OTP-9022: Fixed endode/decode of values of type Counter32.

OTP-9088: [agent] Added support for sending traps to IPv6 targets.

OTP-9119: [agent] To be able to handle multiple engine-id(s) when
	  sending trap(s), the function
	  snmp_community_mib:add_community/6 has been added.

OTP-9162: [manager] The API for snmp requests has been augmented to
	  allow the caller to override some configuration.

OTP-9174: [manager] The old API functions (for get and set
	  requests) are now officially deprecated.

OTP-9183: [agent] Pass extra info through the agent to the net-if
	  process when sending notifications.

OTP-9208: Added type specs for functions that do not return.
	  Kostis Sagonas

Merge branch 'bmk/snmp/snmp420_integration' into dev

1 files changed, 16 insertions, 10 deletions

diff --git a/lib/snmp/src/agent/snmpa_acm.erl b/lib/snmp/src/agent/snmpa_acm.erl
index 6ad4f0b442..30bd34a205 100644
--- a/lib/snmp/src/agent/snmpa_acm.erl
+++ b/lib/snmp/src/agent/snmpa_acm.erl
@@ -62,11 +62,13 @@
 %%       {error, Reason} |
 %%       {discarded, Variable, Reason}
 %% Types: Pdu = #pdu
-%%        ACMData = acm_data() = {community, Community, Address} |
-%%                               {v3, MsgID, SecModel, SecName, SecLevel,
-%%                                    ContextEngineID, ContextName, SecData}
+%%        ACMData = acm_data() = 
+%%             {community, SecModel, Community, TDomain, TAddress} |
+%%             {v3, MsgID, SecModel, SecName, SecLevel,
+%%                  ContextEngineID, ContextName, SecData}
 %%        Community       = string()
-%%        Address         = ip() ++ udp() (list)
+%%        TDomain         = ?transportDomainUdpIpv4 | ?transportDomainUdpIpv6
+%%        TAddress        = ip() ++ udp() (list)
 %%        MsgID           = integer() <not used>
 %%        SecModel        = ?SEC_*  (see snmp_types.hrl)
 %%        SecName         = string()
@@ -114,7 +116,10 @@ error2status(_) -> genErr.
 %% discarded: no error response is sent
 %% authentication_failure: no error response is sent, a trap is generated
 %%-----------------------------------------------------------------
-init_ca(Pdu, {community, SecModel, Community, TAddr}) ->
+init_ca(Pdu, {community, SecModel, Community, TAddress}) ->
+    TDomain = snmp_conf:mk_tdomain(snmp_target_mib:default_domain()),
+    init_ca(Pdu, {community, SecModel, Community, TDomain, TAddress});
+init_ca(Pdu, {community, SecModel, Community, TDomain, TAddress}) ->
     %% This is a v1 or v2c request.   Use SNMP-COMMUNITY-MIB to
     %% map the community to vacm parameters.
     ?vtrace("check access for ~n"
@@ -126,18 +131,18 @@ init_ca(Pdu, {community, SecModel, Community, TAddr}) ->
 		   _ -> read
 	       end,
     ?vtrace("View type: ~p", [ViewType]),
-    CaCacheKey = {Community, SecModel, TAddr, ViewType},
+    CaCacheKey = {Community, SecModel, TDomain, TAddress, ViewType},
     case check_ca_cache(CaCacheKey) of
         false ->
-            case snmp_community_mib:community2vacm(Community,
-                                                   {?snmpUDPDomain,TAddr}) of
+            case snmp_community_mib:community2vacm(Community, 
+						   {TDomain, TAddress}) of
                 {SecName, _ContextEngineId, ContextName} ->
                     %% Maybe we should check that the contextEngineID 
 		    %% matches the local engineID?  
 		    %% It better, since we don't impl. proxy.
                     ?vtrace("get mib view"
                             "~n   Security name: ~p"
-                            "~n   Context name:  ~p",[SecName,ContextName]),
+                            "~n   Context name:  ~p",[SecName, ContextName]),
                     case snmpa_vacm:get_mib_view(ViewType, SecModel, SecName,
                                                  ?'SnmpSecurityLevel_noAuthNoPriv',
                                                  ContextName) of
@@ -153,7 +158,7 @@ init_ca(Pdu, {community, SecModel, Community, TAddr}) ->
                     end;
                 undefined ->
                     {authentication_failure, snmpInBadCommunityNames,
-                     {bad_community_name, TAddr, Community}}
+                     {bad_community_name, TDomain, TAddress, Community}}
             end;
         Res ->
             Res
@@ -219,6 +224,7 @@ upd_ca_cache(KeyVal) ->
 invalidate_ca_cache() ->
     erase(ca_cache).
 
+
 %%-----------------------------------------------------------------
 %% Func: check(Res) -> {ok, MibView} | {discarded, Variable, Reason}
 %% Args: Res = {ok, AccessFunc} |