OTP-9022: Fixed endode/decode of values of type Counter32.

OTP-9088: [agent] Added support for sending traps to IPv6 targets.

OTP-9119: [agent] To be able to handle multiple engine-id(s) when
	  sending trap(s), the function
	  snmp_community_mib:add_community/6 has been added.

OTP-9162: [manager] The API for snmp requests has been augmented to
	  allow the caller to override some configuration.

OTP-9174: [manager] The old API functions (for get and set
	  requests) are now officially deprecated.

OTP-9183: [agent] Pass extra info through the agent to the net-if
	  process when sending notifications.

OTP-9208: Added type specs for functions that do not return.
	  Kostis Sagonas

Merge branch 'bmk/snmp/snmp420_integration' into dev

1 files changed, 24 insertions, 20 deletions

diff --git a/lib/snmp/src/agent/snmpa_mpd.erl b/lib/snmp/src/agent/snmpa_mpd.erl
index fd75b98f84..39a4246d26 100644
--- a/lib/snmp/src/agent/snmpa_mpd.erl
+++ b/lib/snmp/src/agent/snmpa_mpd.erl
@@ -115,8 +115,8 @@ reset() ->
 %% Func: process_packet(Packet, TDomain, TAddress, State, Log) ->
 %%       {ok, SnmpVsn, Pdu, PduMS, ACMData} | {discarded, Reason}
 %% Types: Packet = binary()
-%%        TDomain = snmpUDPDomain | atom()
-%%        TAddress = {Ip, Udp}
+%%        TDomain = snmpUDPDomain | transportDomain()
+%%        TAddress = {Ip, Udp} (*but* depends on TDomain)
 %%        State = #state
 %% Purpose: This is the main Message Dispatching function. (see
 %%          section 4.2.1 in rfc2272)
@@ -182,24 +182,30 @@ discarded_pdu(Variable) -> inc(Variable).
 %%-----------------------------------------------------------------
 %% Handles a Community based message (v1 or v2c).
 %%-----------------------------------------------------------------
-v1_v2c_proc(Vsn, NoteStore, Community, snmpUDPDomain, 
+v1_v2c_proc(Vsn, NoteStore, Community, Domain, 
 	    {Ip, Udp}, LocalEngineID, 
 	    Data, HS, Log, Packet) ->
-    TAddress = tuple_to_list(Ip) ++ [Udp div 256, Udp rem 256],
-    AgentMS = get_engine_max_message_size(LocalEngineID),
-    MgrMS = snmp_community_mib:get_target_addr_ext_mms(?snmpUDPDomain,
-						       TAddress),
-    PduMS = case MgrMS of
-		{ok, MMS} when MMS < AgentMS -> MMS - HS;
-		_ -> AgentMS - HS
-	    end,
+    TDomain  = snmp_conf:mk_tdomain(Domain), 
+    TAddress = snmp_conf:mk_taddress(Domain, Ip, Udp),
+    AgentMS  = get_engine_max_message_size(LocalEngineID),
+    MgrMS    = snmp_community_mib:get_target_addr_ext_mms(TDomain, TAddress),
+    PduMS    = case MgrMS of
+		   {ok, MMS} when MMS < AgentMS -> MMS - HS;
+		   _ -> AgentMS - HS
+	       end,
     case (catch snmp_pdus:dec_pdu(Data)) of
 	Pdu when is_record(Pdu, pdu) ->
 	    Log(Pdu#pdu.type, Packet),
 	    inc_snmp_in_vars(Pdu),
 	    #pdu{request_id = ReqId} = Pdu,
-	    OkRes = {ok, Vsn, Pdu, PduMS,
-		     {community, sec_model(Vsn), Community, TAddress}},
+	    
+	    %% <TDomain>
+	    %% We have added TDomain, what are the consequences?
+	    ACMData = 
+		{community, sec_model(Vsn), Community, TDomain, TAddress}, 
+	    OkRes = {ok, Vsn, Pdu, PduMS, ACMData},
+	    %% </TDomain>
+
 	    %% Make sure that we don't process duplicate SET request
 	    %% twice.  We don't know what could happen in that case.
 	    %% The mgr does, so he has to generate a new SET request.
@@ -216,8 +222,6 @@ v1_v2c_proc(Vsn, NoteStore, Community, snmpUDPDomain,
 			    snmp_note_store:set_note(NoteStore, 
 						     100, Key, true),
 			    %% Uses ACMData that snmpa_acm knows of.
-			    %% snmpUDPDomain is implicit, since that's the only
-			    %% one we handle.
 			    OkRes;
 			true ->
 			    {discarded, duplicate_pdu}
@@ -275,12 +279,12 @@ v3_proc(NoteStore, Packet, LocalEngineID, V3Hdr, Data, Log) ->
 	    "~n   msgSecurityParameters = ~w",
 	    [MsgID, MMS, MsgFlags, MsgSecurityModel, SecParams]),
     %% 7.2.4
-    SecModule = get_security_module(MsgSecurityModel),
+    SecModule    = get_security_module(MsgSecurityModel),
     %% 7.2.5
-    SecLevel = check_sec_level(MsgFlags),
+    SecLevel     = check_sec_level(MsgFlags),
     IsReportable = snmp_misc:is_reportable(MsgFlags),
     %% 7.2.6
-    ?vtrace("v3_proc -> [7.2.6]"
+    ?vtrace("v3_proc -> [7.2.4-7.2.6]"
 	    "~n   SecModule    = ~p"
 	    "~n   SecLevel     = ~p"
 	    "~n   IsReportable = ~p",
@@ -531,7 +535,7 @@ check_sec_module_result(Res, V3Hdr, Data, LocalEngineID, IsReportable, Log) ->
 	    ?vdebug("security module result [7.2.6-b]:"
 		    "~n   Reason: ~p", [Reason]),
 	    throw({discarded, {securityError, Reason}});
-	{error, Reason, ErrorInfo} when IsReportable == true -> % case 7.2.6 a
+	{error, Reason, ErrorInfo} when IsReportable =:= true -> % case 7.2.6 a
 	    ?vdebug("security module result when reportable [7.2.6-a]:"
 		    "~n   Reason:    ~p"
 		    "~n   ErrorInfo: ~p", [Reason, ErrorInfo]),
@@ -574,7 +578,7 @@ generate_response_msg(Vsn, RePdu, Type, ACMData, LocalEngineID, Log) ->
     generate_response_msg(Vsn, RePdu, Type, ACMData, LocalEngineID, Log, 1).
 
 generate_response_msg(Vsn, RePdu, Type, 
-		      {community, _SecModel, Community, _IpUdp},
+		      {community, _SecModel, Community, _TDomain, _TAddress},
 		      LocalEngineID, 
 		      Log, _) ->
 	case catch snmp_pdus:enc_pdu(RePdu) of