snmp: Change to random use crypto. Remove use of erlang:now

9 files changed, 36 insertions, 98 deletions

diff --git a/lib/snmp/src/agent/snmp_shadow_table.erl b/lib/snmp/src/agent/snmp_shadow_table.erl
index 34543d542b..c4704e201b 100644
--- a/lib/snmp/src/agent/snmp_shadow_table.erl
+++ b/lib/snmp/src/agent/snmp_shadow_table.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1996-2009. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -76,7 +76,7 @@ delete_time_stamp_table() ->
     end.
 
 update(Name, UpdateFunc, Interval) ->
-    CurrentTime = get_time(),
+    CurrentTime = snmp_misc:now(ms),
     case mnesia:dirty_read({time_stamp, Name}) of
 	[#time_stamp{data = Expire}] when CurrentTime =< Expire -> ok;
 	_ ->
@@ -117,9 +117,6 @@ table_func(Op, RowIndex, Cols,
     update(Name, UpdateFunc, Interval),
     snmp_generic:table_func(Op, RowIndex, Cols, {Name, mnesia}).
 
-get_time() ->
-    {M,S,U} = erlang:now(),
-    1000000000 * M + 1000 * S + (U div 1000).
 
 %%-----------------------------------------------------------------
 %% Urrk.
@@ -183,5 +180,3 @@ delete_table(Tab) ->
 
 error_msg(F, A) ->
     ?snmpa_error(F, A).
-
-
diff --git a/lib/snmp/src/agent/snmp_standard_mib.erl b/lib/snmp/src/agent/snmp_standard_mib.erl
index aace3fd413..53f733ae4e 100644
--- a/lib/snmp/src/agent/snmp_standard_mib.erl
+++ b/lib/snmp/src/agent/snmp_standard_mib.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1996-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -546,8 +546,9 @@ dummy(_Op) -> ok.
 %%-----------------------------------------------------------------
 snmp_set_serial_no(new) ->
     snmp_generic:variable_func(new, {snmpSetSerialNo, volatile}),
-    {A1,A2,A3} = erlang:now(),
-    random:seed(A1,A2,A3),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     Val = random:uniform(2147483648) - 1,
     snmp_generic:variable_func(set, Val, {snmpSetSerialNo, volatile});
 
diff --git a/lib/snmp/src/agent/snmp_target_mib.erl b/lib/snmp/src/agent/snmp_target_mib.erl
index ef9503cda8..f66c54849f 100644
--- a/lib/snmp/src/agent/snmp_target_mib.erl
+++ b/lib/snmp/src/agent/snmp_target_mib.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1998-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1998-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -346,13 +346,6 @@ check_target_params(X) ->
     error({invalid_target_params, X}).
 
 
-
-%% maybe_create_table(Name) ->
-%%     case snmpa_local_db:table_exists(db(Name)) of
-%% 	true -> ok;
-%% 	_ -> snmpa_local_db:table_create(db(Name))
-%%     end.
-
 init_tabs(Addrs, Params) ->
     ?vdebug("create target address table",[]),
     AddrDB = db(snmpTargetAddrTable),
@@ -679,8 +672,9 @@ snmpTargetSpinLock(print) ->
     
 snmpTargetSpinLock(new) ->
     snmp_generic:variable_func(new, {snmpTargetSpinLock, volatile}),
-    {A1,A2,A3} = erlang:now(),
-    random:seed(A1,A2,A3),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     Val = random:uniform(2147483648) - 1,
     snmp_generic:variable_func(set, Val, {snmpTargetSpinLock, volatile});
 
@@ -1080,5 +1074,3 @@ error(Reason) ->
 
 config_err(F, A) ->
     snmpa_error:config_err("[TARGET-MIB]: " ++ F, A).
-
-
diff --git a/lib/snmp/src/agent/snmp_user_based_sm_mib.erl b/lib/snmp/src/agent/snmp_user_based_sm_mib.erl
index 69dce337ba..ce6dc21435 100644
--- a/lib/snmp/src/agent/snmp_user_based_sm_mib.erl
+++ b/lib/snmp/src/agent/snmp_user_based_sm_mib.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1999-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -439,8 +439,9 @@ usmUserSpinLock(print) ->
     
 usmUserSpinLock(new) ->
     snmp_generic:variable_func(new, {usmUserSpinLock, volatile}),
-    {A1,A2,A3} = erlang:now(),
-    random:seed(A1,A2,A3),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     Val = random:uniform(2147483648) - 1,
     snmp_generic:variable_func(set, Val, {usmUserSpinLock, volatile});
 
@@ -1191,29 +1192,7 @@ extract_new_key(Hash, OldKey, KeyChange) ->
 -define(i8(Int), Int band 255).
 
 mk_random(Len) when Len =< 20 ->
-    %% Use of yield():
-    %% This will either schedule another process, or fail and invoke
-    %% the error_handler (in old versions).  In either case, it is
-    %% safe to assume that now, reductions and garbage_collection have
-    %% changed in a non-deterministically way.
-    {_,_,A} = erlang:now(),
-    catch erlang:yield(),
-    {_,_,B} = erlang:now(),
-    catch erlang:yield(),
-    {_,_,C} = erlang:now(),
-    {D,_}   = erlang:statistics(reductions),
-    {E,_}   = erlang:statistics(runtime),
-    {F,_}   = erlang:statistics(wall_clock),
-    {G,H,_} = erlang:statistics(garbage_collection),
-    catch erlang:yield(),
-    {_,_,C2} = erlang:now(),
-    {D2,_}   = erlang:statistics(reductions),
-    {_,H2,_} = erlang:statistics(garbage_collection),
-    %% X(N) means we can use N bits from variable X:
-    %% A(16) B(16) C(16) D(16) E(8) F(16) G(8) H(16)
-    Rnd20 = [?i16(A),?i16(B),?i16(C),?i16(D),?i8(E),?i16(F),
-	     ?i8(G),?i16(H),?i16(C2),?i16(D2),?i16(H2)],
-    lists:sublist(Rnd20, Len).
+    binary_to_list(crypto:strong_rand_bytes(Len)).
     
 split(0, Rest, FirstRev) ->
     {lists:reverse(FirstRev), Rest};
diff --git a/lib/snmp/src/agent/snmp_view_based_acm_mib.erl b/lib/snmp/src/agent/snmp_view_based_acm_mib.erl
index 722bd7ac5b..28e2bdbb96 100644
--- a/lib/snmp/src/agent/snmp_view_based_acm_mib.erl
+++ b/lib/snmp/src/agent/snmp_view_based_acm_mib.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1999-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -845,8 +845,9 @@ vacmViewSpinLock(print) ->
 
 vacmViewSpinLock(new) ->
     snmp_generic:variable_func(new, volatile_db(vacmViewSpinLock)),
-    {A1,A2,A3} = erlang:now(),
-    random:seed(A1,A2,A3),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     Val = random:uniform(2147483648) - 1,
     snmp_generic:variable_func(set, Val, volatile_db(vacmViewSpinLock));
 
@@ -1133,4 +1134,3 @@ error(Reason) ->
 
 config_err(F, A) ->
     snmpa_error:config_err("[VIEW-BASED-ACM-MIB]: " ++ F, A).
-
diff --git a/lib/snmp/src/agent/snmpa_mpd.erl b/lib/snmp/src/agent/snmpa_mpd.erl
index 642b1f7fc5..24007a4e63 100644
--- a/lib/snmp/src/agent/snmpa_mpd.erl
+++ b/lib/snmp/src/agent/snmpa_mpd.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1997-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1997-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -75,8 +75,9 @@
 init(Vsns) ->
     ?vlog("init -> entry with"
 	"~n   Vsns: ~p", [Vsns]),
-    {A,B,C} = erlang:now(),
-    random:seed(A,B,C),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     ets:insert(snmp_agent_table, {msg_id, random:uniform(2147483647)}),
     ets:insert(snmp_agent_table, {req_id, random:uniform(2147483647)}),
     init_counters(),
@@ -771,21 +772,7 @@ generate_v3_report_msg(MsgID, MsgSecurityModel, Data, LocalEngineID,
 			   ContextEngineID, ContextName, SecData}, 
 			  LocalEngineID, Log).
 
-%% req_id(#scopedPdu{data = #pdu{request_id = ReqId}}) ->
-%%     ?vtrace("Report ReqId: ~p",[ReqId]),
-%%     ReqId;
-%% req_id(_) ->
-%%     0. % RFC2572, 7.1.3.c.4
 
-    
-%% maybe_generate_discovery1_report_msg() ->
-%%     case (catch DiscoveryHandler:handle_discovery1(Ip, Udp, EngineId)) of
-%% 	{ok, Entry} when is_record(Entry, snmp_discovery_data1) ->
-%% 	    ok;
-%% 	ignore ->
-%% 	    ok;
-%% 	{error, Reason} ->
-	    
 %% Response to stage 1 discovery message (terminating, i.e. from the manager)
 generate_discovery1_report_msg(MsgID, MsgSecurityModel, 
 			       SecName, SecLevel, 
diff --git a/lib/snmp/src/agent/snmpa_net_if.erl b/lib/snmp/src/agent/snmpa_net_if.erl
index 840d56d563..c05a85c07a 100644
--- a/lib/snmp/src/agent/snmpa_net_if.erl
+++ b/lib/snmp/src/agent/snmpa_net_if.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 2004-2014. All Rights Reserved.
+%% Copyright Ericsson AB 2004-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -674,7 +674,7 @@ handle_recv(
   #state{mpd_state  = MpdState, note_store = NS, log = Log} = S,
   #transport{socket = Socket} = Transport,
   From, Packet) ->
-    put(n1, erlang:now()),
+    put(n1, erlang:monotonic_time(micro_seconds)),
     LogF =
 	fun(Type, Data) ->
 		log(Log, Type, Data, From)
@@ -1379,15 +1379,7 @@ do_close_log(_) ->
 %%% DEBUG FUNCTIONS
 %%%-----------------------------------------------------------------
 time_in_agent() ->
-    subtr(erlang:now(), get(n1)).
-
-subtr({X1,Y1,Z1}, {X1,Y1,Z2}) ->
-    Z1 - Z2;
-subtr({X1,Y1,Z1}, {X1,Y2,Z2}) ->
-    ((Y1-Y2) * 1000000) + (Z1 - Z2);
-subtr({X1,Y1,Z1}, {X2,Y2,Z2}) ->
-    ((X1 - X2) * 1000000000000) + ((Y1 - Y2) * 1000000) + (Z1 - Z2).
-
+    erlang:monotonic_time(micro_seconds) - get(n1).
 
 %% ----------------------------------------------------------------
 
@@ -1637,10 +1629,3 @@ get_port_info(Id) ->
 
 
 %% ----------------------------------------------------------------
-
-% i(F) ->
-%     i(F, []).
-
-% i(F, A) ->
-%     io:format("~p: " ++ F ++ "~n", [?MODULE|A]).
-
diff --git a/lib/snmp/src/agent/snmpa_usm.erl b/lib/snmp/src/agent/snmpa_usm.erl
index 719ea4e356..c571e50517 100644
--- a/lib/snmp/src/agent/snmpa_usm.erl
+++ b/lib/snmp/src/agent/snmpa_usm.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1999-2013. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -645,8 +645,9 @@ get_des_salt() ->
 		ets:insert(snmp_agent_table, {usm_des_salt, 0}),
 		0;
 	    _ -> % it doesn't exist, initialize
-		{A1,A2,A3} = erlang:now(),
-		random:seed(A1,A2,A3),
+                random:seed(erlang:phash2([node()]),
+                            erlang:monotonic_time(),
+                            erlang:unique_integer()),
 		R = random:uniform(4294967295),
 		ets:insert(snmp_agent_table, {usm_des_salt, R}),
 		R
@@ -677,8 +678,9 @@ get_aes_salt() ->
 		ets:insert(snmp_agent_table, {usm_aes_salt, 0}),
 		0;
 	    _ -> % it doesn't exist, initialize
-		{A1,A2,A3} = erlang:now(),
-		random:seed(A1,A2,A3),
+                random:seed(erlang:phash2([node()]),
+                            erlang:monotonic_time(),
+                            erlang:unique_integer()),
 		R = random:uniform(36893488147419103231),
 		ets:insert(snmp_agent_table, {usm_aes_salt, R}),
 		R
diff --git a/lib/snmp/src/agent/snmpa_vacm.erl b/lib/snmp/src/agent/snmpa_vacm.erl
index dadcf32543..281b2bd34a 100644
--- a/lib/snmp/src/agent/snmpa_vacm.erl
+++ b/lib/snmp/src/agent/snmpa_vacm.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1999-2012. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -305,8 +305,8 @@ dump_table() ->
 %% time dumping the table.
 unique_table_name(Pre) ->
     %% We want something that is guaranteed to be unique, 
-    %% therefor we use erlang:now() instead of os:timestamp()
-    unique_table_name(Pre, erlang:now()).
+    %% therefor we use erlang:timestamp() instead of os:timestamp()
+    unique_table_name(Pre, erlang:timestamp()).
 
 unique_table_name(Pre, {_A, _B, C} = Now) ->
     {Date, Time}     = calendar:now_to_datetime(Now),
@@ -445,6 +445,3 @@ gc_tab(Oid) ->
 
 user_err(F, A) ->
     snmpa_error:user_err(F, A).
-
-% config_err(F, A) ->
-%     snmpa_error:config_err(F, A).