snmp: Change to random use crypto. Remove use of erlang:now

22 files changed, 102 insertions, 624 deletions

diff --git a/lib/snmp/src/agent/snmp_shadow_table.erl b/lib/snmp/src/agent/snmp_shadow_table.erl
index 34543d542b..c4704e201b 100644
--- a/lib/snmp/src/agent/snmp_shadow_table.erl
+++ b/lib/snmp/src/agent/snmp_shadow_table.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1996-2009. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -76,7 +76,7 @@ delete_time_stamp_table() ->
     end.
 
 update(Name, UpdateFunc, Interval) ->
-    CurrentTime = get_time(),
+    CurrentTime = snmp_misc:now(ms),
     case mnesia:dirty_read({time_stamp, Name}) of
 	[#time_stamp{data = Expire}] when CurrentTime =< Expire -> ok;
 	_ ->
@@ -117,9 +117,6 @@ table_func(Op, RowIndex, Cols,
     update(Name, UpdateFunc, Interval),
     snmp_generic:table_func(Op, RowIndex, Cols, {Name, mnesia}).
 
-get_time() ->
-    {M,S,U} = erlang:now(),
-    1000000000 * M + 1000 * S + (U div 1000).
 
 %%-----------------------------------------------------------------
 %% Urrk.
@@ -183,5 +180,3 @@ delete_table(Tab) ->
 
 error_msg(F, A) ->
     ?snmpa_error(F, A).
-
-
diff --git a/lib/snmp/src/agent/snmp_standard_mib.erl b/lib/snmp/src/agent/snmp_standard_mib.erl
index aace3fd413..53f733ae4e 100644
--- a/lib/snmp/src/agent/snmp_standard_mib.erl
+++ b/lib/snmp/src/agent/snmp_standard_mib.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1996-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -546,8 +546,9 @@ dummy(_Op) -> ok.
 %%-----------------------------------------------------------------
 snmp_set_serial_no(new) ->
     snmp_generic:variable_func(new, {snmpSetSerialNo, volatile}),
-    {A1,A2,A3} = erlang:now(),
-    random:seed(A1,A2,A3),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     Val = random:uniform(2147483648) - 1,
     snmp_generic:variable_func(set, Val, {snmpSetSerialNo, volatile});
 
diff --git a/lib/snmp/src/agent/snmp_target_mib.erl b/lib/snmp/src/agent/snmp_target_mib.erl
index ef9503cda8..f66c54849f 100644
--- a/lib/snmp/src/agent/snmp_target_mib.erl
+++ b/lib/snmp/src/agent/snmp_target_mib.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1998-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1998-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -346,13 +346,6 @@ check_target_params(X) ->
     error({invalid_target_params, X}).
 
 
-
-%% maybe_create_table(Name) ->
-%%     case snmpa_local_db:table_exists(db(Name)) of
-%% 	true -> ok;
-%% 	_ -> snmpa_local_db:table_create(db(Name))
-%%     end.
-
 init_tabs(Addrs, Params) ->
     ?vdebug("create target address table",[]),
     AddrDB = db(snmpTargetAddrTable),
@@ -679,8 +672,9 @@ snmpTargetSpinLock(print) ->
     
 snmpTargetSpinLock(new) ->
     snmp_generic:variable_func(new, {snmpTargetSpinLock, volatile}),
-    {A1,A2,A3} = erlang:now(),
-    random:seed(A1,A2,A3),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     Val = random:uniform(2147483648) - 1,
     snmp_generic:variable_func(set, Val, {snmpTargetSpinLock, volatile});
 
@@ -1080,5 +1074,3 @@ error(Reason) ->
 
 config_err(F, A) ->
     snmpa_error:config_err("[TARGET-MIB]: " ++ F, A).
-
-
diff --git a/lib/snmp/src/agent/snmp_user_based_sm_mib.erl b/lib/snmp/src/agent/snmp_user_based_sm_mib.erl
index 69dce337ba..ce6dc21435 100644
--- a/lib/snmp/src/agent/snmp_user_based_sm_mib.erl
+++ b/lib/snmp/src/agent/snmp_user_based_sm_mib.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1999-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -439,8 +439,9 @@ usmUserSpinLock(print) ->
     
 usmUserSpinLock(new) ->
     snmp_generic:variable_func(new, {usmUserSpinLock, volatile}),
-    {A1,A2,A3} = erlang:now(),
-    random:seed(A1,A2,A3),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     Val = random:uniform(2147483648) - 1,
     snmp_generic:variable_func(set, Val, {usmUserSpinLock, volatile});
 
@@ -1191,29 +1192,7 @@ extract_new_key(Hash, OldKey, KeyChange) ->
 -define(i8(Int), Int band 255).
 
 mk_random(Len) when Len =< 20 ->
-    %% Use of yield():
-    %% This will either schedule another process, or fail and invoke
-    %% the error_handler (in old versions).  In either case, it is
-    %% safe to assume that now, reductions and garbage_collection have
-    %% changed in a non-deterministically way.
-    {_,_,A} = erlang:now(),
-    catch erlang:yield(),
-    {_,_,B} = erlang:now(),
-    catch erlang:yield(),
-    {_,_,C} = erlang:now(),
-    {D,_}   = erlang:statistics(reductions),
-    {E,_}   = erlang:statistics(runtime),
-    {F,_}   = erlang:statistics(wall_clock),
-    {G,H,_} = erlang:statistics(garbage_collection),
-    catch erlang:yield(),
-    {_,_,C2} = erlang:now(),
-    {D2,_}   = erlang:statistics(reductions),
-    {_,H2,_} = erlang:statistics(garbage_collection),
-    %% X(N) means we can use N bits from variable X:
-    %% A(16) B(16) C(16) D(16) E(8) F(16) G(8) H(16)
-    Rnd20 = [?i16(A),?i16(B),?i16(C),?i16(D),?i8(E),?i16(F),
-	     ?i8(G),?i16(H),?i16(C2),?i16(D2),?i16(H2)],
-    lists:sublist(Rnd20, Len).
+    binary_to_list(crypto:strong_rand_bytes(Len)).
     
 split(0, Rest, FirstRev) ->
     {lists:reverse(FirstRev), Rest};
diff --git a/lib/snmp/src/agent/snmp_view_based_acm_mib.erl b/lib/snmp/src/agent/snmp_view_based_acm_mib.erl
index 722bd7ac5b..28e2bdbb96 100644
--- a/lib/snmp/src/agent/snmp_view_based_acm_mib.erl
+++ b/lib/snmp/src/agent/snmp_view_based_acm_mib.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1999-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -845,8 +845,9 @@ vacmViewSpinLock(print) ->
 
 vacmViewSpinLock(new) ->
     snmp_generic:variable_func(new, volatile_db(vacmViewSpinLock)),
-    {A1,A2,A3} = erlang:now(),
-    random:seed(A1,A2,A3),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     Val = random:uniform(2147483648) - 1,
     snmp_generic:variable_func(set, Val, volatile_db(vacmViewSpinLock));
 
@@ -1133,4 +1134,3 @@ error(Reason) ->
 
 config_err(F, A) ->
     snmpa_error:config_err("[VIEW-BASED-ACM-MIB]: " ++ F, A).
-
diff --git a/lib/snmp/src/agent/snmpa_mpd.erl b/lib/snmp/src/agent/snmpa_mpd.erl
index 642b1f7fc5..24007a4e63 100644
--- a/lib/snmp/src/agent/snmpa_mpd.erl
+++ b/lib/snmp/src/agent/snmpa_mpd.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1997-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1997-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -75,8 +75,9 @@
 init(Vsns) ->
     ?vlog("init -> entry with"
 	"~n   Vsns: ~p", [Vsns]),
-    {A,B,C} = erlang:now(),
-    random:seed(A,B,C),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     ets:insert(snmp_agent_table, {msg_id, random:uniform(2147483647)}),
     ets:insert(snmp_agent_table, {req_id, random:uniform(2147483647)}),
     init_counters(),
@@ -771,21 +772,7 @@ generate_v3_report_msg(MsgID, MsgSecurityModel, Data, LocalEngineID,
 			   ContextEngineID, ContextName, SecData}, 
 			  LocalEngineID, Log).
 
-%% req_id(#scopedPdu{data = #pdu{request_id = ReqId}}) ->
-%%     ?vtrace("Report ReqId: ~p",[ReqId]),
-%%     ReqId;
-%% req_id(_) ->
-%%     0. % RFC2572, 7.1.3.c.4
 
-    
-%% maybe_generate_discovery1_report_msg() ->
-%%     case (catch DiscoveryHandler:handle_discovery1(Ip, Udp, EngineId)) of
-%% 	{ok, Entry} when is_record(Entry, snmp_discovery_data1) ->
-%% 	    ok;
-%% 	ignore ->
-%% 	    ok;
-%% 	{error, Reason} ->
-	    
 %% Response to stage 1 discovery message (terminating, i.e. from the manager)
 generate_discovery1_report_msg(MsgID, MsgSecurityModel, 
 			       SecName, SecLevel, 
diff --git a/lib/snmp/src/agent/snmpa_net_if.erl b/lib/snmp/src/agent/snmpa_net_if.erl
index 840d56d563..c05a85c07a 100644
--- a/lib/snmp/src/agent/snmpa_net_if.erl
+++ b/lib/snmp/src/agent/snmpa_net_if.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 2004-2014. All Rights Reserved.
+%% Copyright Ericsson AB 2004-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -674,7 +674,7 @@ handle_recv(
   #state{mpd_state  = MpdState, note_store = NS, log = Log} = S,
   #transport{socket = Socket} = Transport,
   From, Packet) ->
-    put(n1, erlang:now()),
+    put(n1, erlang:monotonic_time(micro_seconds)),
     LogF =
 	fun(Type, Data) ->
 		log(Log, Type, Data, From)
@@ -1379,15 +1379,7 @@ do_close_log(_) ->
 %%% DEBUG FUNCTIONS
 %%%-----------------------------------------------------------------
 time_in_agent() ->
-    subtr(erlang:now(), get(n1)).
-
-subtr({X1,Y1,Z1}, {X1,Y1,Z2}) ->
-    Z1 - Z2;
-subtr({X1,Y1,Z1}, {X1,Y2,Z2}) ->
-    ((Y1-Y2) * 1000000) + (Z1 - Z2);
-subtr({X1,Y1,Z1}, {X2,Y2,Z2}) ->
-    ((X1 - X2) * 1000000000000) + ((Y1 - Y2) * 1000000) + (Z1 - Z2).
-
+    erlang:monotonic_time(micro_seconds) - get(n1).
 
 %% ----------------------------------------------------------------
 
@@ -1637,10 +1629,3 @@ get_port_info(Id) ->
 
 
 %% ----------------------------------------------------------------
-
-% i(F) ->
-%     i(F, []).
-
-% i(F, A) ->
-%     io:format("~p: " ++ F ++ "~n", [?MODULE|A]).
-
diff --git a/lib/snmp/src/agent/snmpa_usm.erl b/lib/snmp/src/agent/snmpa_usm.erl
index 719ea4e356..c571e50517 100644
--- a/lib/snmp/src/agent/snmpa_usm.erl
+++ b/lib/snmp/src/agent/snmpa_usm.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1999-2013. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -645,8 +645,9 @@ get_des_salt() ->
 		ets:insert(snmp_agent_table, {usm_des_salt, 0}),
 		0;
 	    _ -> % it doesn't exist, initialize
-		{A1,A2,A3} = erlang:now(),
-		random:seed(A1,A2,A3),
+                random:seed(erlang:phash2([node()]),
+                            erlang:monotonic_time(),
+                            erlang:unique_integer()),
 		R = random:uniform(4294967295),
 		ets:insert(snmp_agent_table, {usm_des_salt, R}),
 		R
@@ -677,8 +678,9 @@ get_aes_salt() ->
 		ets:insert(snmp_agent_table, {usm_aes_salt, 0}),
 		0;
 	    _ -> % it doesn't exist, initialize
-		{A1,A2,A3} = erlang:now(),
-		random:seed(A1,A2,A3),
+                random:seed(erlang:phash2([node()]),
+                            erlang:monotonic_time(),
+                            erlang:unique_integer()),
 		R = random:uniform(36893488147419103231),
 		ets:insert(snmp_agent_table, {usm_aes_salt, R}),
 		R
diff --git a/lib/snmp/src/agent/snmpa_vacm.erl b/lib/snmp/src/agent/snmpa_vacm.erl
index dadcf32543..281b2bd34a 100644
--- a/lib/snmp/src/agent/snmpa_vacm.erl
+++ b/lib/snmp/src/agent/snmpa_vacm.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1999-2012. All Rights Reserved.
+%% Copyright Ericsson AB 1999-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -305,8 +305,8 @@ dump_table() ->
 %% time dumping the table.
 unique_table_name(Pre) ->
     %% We want something that is guaranteed to be unique, 
-    %% therefor we use erlang:now() instead of os:timestamp()
-    unique_table_name(Pre, erlang:now()).
+    %% therefor we use erlang:timestamp() instead of os:timestamp()
+    unique_table_name(Pre, erlang:timestamp()).
 
 unique_table_name(Pre, {_A, _B, C} = Now) ->
     {Date, Time}     = calendar:now_to_datetime(Now),
@@ -445,6 +445,3 @@ gc_tab(Oid) ->
 
 user_err(F, A) ->
     snmpa_error:user_err(F, A).
-
-% config_err(F, A) ->
-%     snmpa_error:config_err(F, A).
diff --git a/lib/snmp/src/manager/snmpm_mpd.erl b/lib/snmp/src/manager/snmpm_mpd.erl
index f8a7441c0a..5fc9d3655c 100644
--- a/lib/snmp/src/manager/snmpm_mpd.erl
+++ b/lib/snmp/src/manager/snmpm_mpd.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2004-2014. All Rights Reserved.
+%% Copyright Ericsson AB 2004-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -67,8 +67,9 @@
 %%%-----------------------------------------------------------------
 init(Vsns) ->
     ?vdebug("init -> entry with ~p", [Vsns]),
-    {A,B,C} = erlang:now(),
-    random:seed(A,B,C),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     snmpm_config:cre_counter(msg_id, random:uniform(2147483647)),
     snmpm_config:cre_counter(req_id, random:uniform(2147483647)),
     init_counters(),
@@ -896,17 +897,6 @@ get_agent_engine_id(Name) ->
 is_known_engine_id(EngineID, {Addr, Port}) ->
     snmpm_config:is_known_engine_id(EngineID, Addr, Port).
 
-%% is_known_engine_id(EngineID, Addr, Port) ->
-%%     snmpm_config:is_known_engine_id(EngineID, Addr, Port).
-
-% get_agent_engine_id(Addr, Port) ->
-%     case snmpm_config:get_agent_engine_id(Addr, Port) of
-% 	{ok, Id} ->
-% 	    Id;
-% 	_Error ->
-% 	    ""
-%     end.
-
 
 %%-----------------------------------------------------------------
 %% Sequence number (msg-id & req-id) functions
diff --git a/lib/snmp/src/manager/snmpm_net_if.erl b/lib/snmp/src/manager/snmpm_net_if.erl
index b4cc165d2e..5186db64ec 100644
--- a/lib/snmp/src/manager/snmpm_net_if.erl
+++ b/lib/snmp/src/manager/snmpm_net_if.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2004-2014. All Rights Reserved.
+%% Copyright Ericsson AB 2004-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -489,11 +489,6 @@ handle_call({verbosity, Verbosity}, _From, State) ->
     put(verbosity, Verbosity),
     {reply, ok, State};
 
-%% handle_call({system_info_updated, What}, _From, State) ->
-%%     ?vlog("received system_info_updated request with What = ~p", [What]),
-%%     {NewState, Reply} = handle_system_info_updated(State, What),
-%%     {reply, Reply, NewState};
-
 handle_call(get_log_type, _From, State) ->
     ?vlog("received get-log-type request", []),
     Reply = (catch handle_get_log_type(State)),
@@ -816,7 +811,7 @@ handle_inform_request(
 	    ok;
 	[] ->
 	    RePdu  = make_response_pdu(Pdu),
-	    Expire = t() + To, 
+	    Expire = snmp_misc:now(ms) + To,
 	    Rec    = {Key, Expire, {Vsn, ACM, RePdu}},
 	    ets:insert(snmpm_inform_request_table, Rec)
     end.
@@ -876,7 +871,7 @@ maybe_send_inform_response(
     
 handle_inform_response_gc(#state{irb = IRB} = State) ->
     ets:safe_fixtable(snmpm_inform_request_table, true),
-    do_irgc(ets:first(snmpm_inform_request_table), t()),
+    do_irgc(ets:first(snmpm_inform_request_table), snmp_misc:now(ms)),
     ets:safe_fixtable(snmpm_inform_request_table, false),
     State#state{irgc = irgc_start(IRB)}.
 
@@ -1023,110 +1018,6 @@ handle_disk_log(_Log, _Info, State) ->
     State.
 
 
-%% mk_discovery_msg('version-3', Pdu, _VsnHdr, UserName) ->
-%%     ScopedPDU = #scopedPdu{contextEngineID = "",
-%% 			   contextName = "",
-%% 			   data = Pdu},
-%%     Bytes = snmp_pdus:enc_scoped_pdu(ScopedPDU),
-%%     MsgID = get(msg_id),
-%%     put(msg_id,MsgID+1),
-%%     UsmSecParams = 
-%% 	#usmSecurityParameters{msgAuthoritativeEngineID = "",
-%% 			       msgAuthoritativeEngineBoots = 0,
-%% 			       msgAuthoritativeEngineTime = 0,
-%% 			       msgUserName = UserName,
-%% 			       msgPrivacyParameters = "",
-%% 			       msgAuthenticationParameters = ""},
-%%     SecBytes = snmp_pdus:enc_usm_security_parameters(UsmSecParams),
-%%     PduType = Pdu#pdu.type,
-%%     Hdr = #v3_hdr{msgID = MsgID, 
-%% 		  msgMaxSize = 1000,
-%% 		  msgFlags = snmp_misc:mk_msg_flags(PduType, 0),
-%% 		  msgSecurityModel = ?SEC_USM,
-%% 		  msgSecurityParameters = SecBytes},
-%%     Msg = #message{version = 'version-3', vsn_hdr = Hdr, data = Bytes},
-%%     case (catch snmp_pdus:enc_message_only(Msg)) of
-%% 	{'EXIT', Reason} ->
-%% 	    error("Encoding error. Pdu: ~w. Reason: ~w",[Pdu, Reason]),
-%% 	    error;
-%% 	L when list(L) ->
-%% 	    {Msg, L}
-%%     end;
-%% mk_discovery_msg(Version, Pdu, {Com, _, _, _, _}, UserName) ->
-%%     Msg = #message{version = Version, vsn_hdr = Com, data = Pdu},
-%%     case catch snmp_pdus:enc_message(Msg) of
-%% 	{'EXIT', Reason} ->
-%% 	    error("Encoding error. Pdu: ~w. Reason: ~w",[Pdu, Reason]),
-%% 	    error;
-%% 	L when list(L) -> 
-%% 	    {Msg, L}
-%%     end.
-
-
-%% mk_msg('version-3', Pdu, {Context, User, EngineID, CtxEngineId, SecLevel}, 
-%%        MsgData) ->
-%%     %% Code copied from snmp_mpd.erl
-%%     {MsgId, SecName, SecData} =
-%% 	if
-%% 	    tuple(MsgData), Pdu#pdu.type == 'get-response' ->
-%% 		MsgData;
-%% 	    true -> 
-%% 		Md = get(msg_id),
-%% 		put(msg_id, Md + 1),
-%% 		{Md, User, []}
-%% 	end,
-%%     ScopedPDU = #scopedPdu{contextEngineID = CtxEngineId,
-%% 			   contextName = Context,
-%% 			   data = Pdu},
-%%     ScopedPDUBytes = snmp_pdus:enc_scoped_pdu(ScopedPDU),
-
-%%     PduType = Pdu#pdu.type,
-%%     V3Hdr = #v3_hdr{msgID      = MsgId,
-%% 		    msgMaxSize = 1000,
-%% 		    msgFlags   = snmp_misc:mk_msg_flags(PduType, SecLevel),
-%% 		    msgSecurityModel = ?SEC_USM},
-%%     Message = #message{version = 'version-3', vsn_hdr = V3Hdr,
-%% 		       data = ScopedPDUBytes},
-%%     SecEngineID = case PduType of
-%% 		      'get-response' -> snmp_framework_mib:get_engine_id();
-%% 		      _ -> EngineID
-%% 		  end,
-%%     case catch snmp_usm:generate_outgoing_msg(Message, SecEngineID,
-%% 					      SecName, SecData, SecLevel) of
-%% 	{'EXIT', Reason} ->
-%% 	    error("Encoding error. Pdu: ~w. Reason: ~w",[Pdu, Reason]),
-%% 	    error;
-%% 	{error, Reason} ->
-%% 	    error("Encoding error. Pdu: ~w. Reason: ~w",[Pdu, Reason]),
-%% 	    error;
-%% 	Packet ->
-%% 	    Packet
-%%     end;
-%% mk_msg(Version, Pdu, {Com, _User, _EngineID, _Ctx, _SecLevel}, _SecData) ->
-%%     Msg = #message{version = Version, vsn_hdr = Com, data = Pdu},
-%%     case catch snmp_pdus:enc_message(Msg) of
-%% 	{'EXIT', Reason} ->
-%% 	    error("Encoding error. Pdu: ~w. Reason: ~w",[Pdu, Reason]),
-%% 	    error;
-%% 	B when list(B) -> 
-%% 	    B
-%%     end.
-
-
-%% handle_system_info_updated(#state{log = {Log, _OldType}} = State, 
-%% 			   audit_trail_log_type = _What) ->
-%%     %% Just to make sure, check that ATL is actually enabled
-%%     case snmpm_config:system_info(audit_trail_log) of
-%% 	{ok, true} ->
-%% 	    {ok, Type} = snmpm_config:system_info(audit_trail_log_type),
-%% 	    NewState = State#state{log = {Log, Type}},
-%% 	    {NewState, ok};
-%% 	_ ->
-%% 	    {State, {error, {adt_not_enabled}}}
-%%     end;
-%% handle_system_info_updated(_State, _What) ->
-%%     ok.
-
 handle_get_log_type(#state{log = {_Log, Value}} = State) ->
     %% Just to make sure, check that ATL is actually enabled
     case snmpm_config:system_info(audit_trail_log) of
@@ -1257,13 +1148,6 @@ maybe_process_extra_info(_ExtraInfo) ->
 
 %% -------------------------------------------------------------------
 
-t() ->
-    {A,B,C} = erlang:now(),
-    A*1000000000+B*1000+(C div 1000).
-
-
-%% -------------------------------------------------------------------
-
 %% info_msg(F, A) ->
 %%     ?snmpm_info("NET-IF server: " ++ F, A).
 
@@ -1301,8 +1185,6 @@ proc_mem(P) when is_pid(P) ->
 	_ ->
 	    undefined
     end.
-%% proc_mem(_) ->
-%%     undefined.
 
 
 get_port_info(Id) ->
@@ -1382,20 +1264,6 @@ counters() ->
 inc(Name)    -> inc(Name, 1).
 inc(Name, N) -> snmpm_config:incr_stats_counter(Name, N).
 
-%% get_counters() ->
-%%     Counters = counters(),
-%%     get_counters(Counters, []).
-
-%% get_counters([], Acc) ->
-%%     lists:reverse(Acc);
-%% get_counters([Counter|Counters], Acc) ->
-%%     case snmpm_config:get_stats_counter(Counter) of
-%%         {ok, CounterVal} ->
-%%             get_counters(Counters, [{Counter, CounterVal}|Acc]);
-%%         _ ->
-%%             get_counters(Counters, Acc)
-%%     end.
-
 
 %% ----------------------------------------------------------------
 
diff --git a/lib/snmp/src/manager/snmpm_server.erl b/lib/snmp/src/manager/snmpm_server.erl
index a75122d0bb..3a37174d9e 100644
--- a/lib/snmp/src/manager/snmpm_server.erl
+++ b/lib/snmp/src/manager/snmpm_server.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2004-2014. All Rights Reserved.
+%% Copyright Ericsson AB 2004-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -467,27 +467,6 @@ cancel_async_request(UserId, ReqId) ->
     call({cancel_async_request, UserId, ReqId}).
 
 
-%% discovery(UserId, BAddr) ->
-%%     discovery(UserId, BAddr, ?SNMP_AGENT_PORT, [], 
-%% 	      ?DEFAULT_ASYNC_EXPIRE, ?EXTRA_INFO).
-
-%% discovery(UserId, BAddr, Config) when is_list(Config) ->
-%%     discovery(UserId, BAddr, ?SNMP_AGENT_PORT, Config, 
-%% 	      ?DEFAULT_ASYNC_EXPIRE, ?EXTRA_INFO);
-
-%% discovery(UserId, BAddr, Expire) when is_integer(Expire) ->
-%%     discovery(UserId, BAddr, ?SNMP_AGENT_PORT, [], Expire, ?EXTRA_INFO).
-
-%% discovery(UserId, BAddr, Config, Expire) ->
-%%     discovery(UserId, BAddr, ?SNMP_AGENT_PORT, Config, Expire, ?EXTRA_INFO).
-
-%% discovery(UserId, BAddr, Port, Config, Expire) ->
-%%     discovery(UserId, BAddr, Port, Config, Expire, ?EXTRA_INFO).
-
-%% discovery(UserId, BAddr, Port, Config, Expire, ExtraInfo) ->
-%%     call({discovery, self(), UserId, BAddr, Port, Config, Expire, ExtraInfo}).
-
-
 verbosity(Verbosity) ->
     case ?vvalidate(Verbosity) of
 	Verbosity ->
@@ -927,14 +906,6 @@ handle_call({cancel_async_request, UserId, ReqId}, _From, State) ->
     {reply, Reply, State};
 
 
-%% handle_call({discovery, Pid, UserId, BAddr, Port, Config, Expire, ExtraInfo}, 
-%% 	    _From, State) ->
-%%     ?vlog("received discovery request", []),
-%%     Reply = (catch handle_discovery(Pid, UserId, BAddr, Port, Config, 
-%% 				    Expire, ExtraInfo, State)),
-%%     {reply, Reply, State};
-
-
 handle_call({load_mib, Mib}, _From, State) ->
     ?vlog("received load_mib request", []),
     case snmpm_config:load_mib(Mib) of
@@ -988,13 +959,6 @@ handle_call(is_started, _From, State) ->
     IsStarted = is_started(State), 
     {reply, IsStarted, State};
 
-%% handle_call({system_info_updated, Target, What}, _From, State) ->
-%%     ?vlog("received system_info_updated request: "
-%% 	  "~n   Target: ~p"
-%% 	  "~n   What:   ~p", [Target, What]),
-%%     Reply = handle_system_info_updated(State, Target, What), 
-%%     {reply, Reply, State};
-
 handle_call(get_log_type, _From, State) ->
     ?vlog("received get_log_type request", []),
     Reply = handle_get_log_type(State), 
@@ -1042,11 +1006,6 @@ handle_info({snmp_error, ReqId, Reason, Domain, Addr}, State) ->
     handle_snmp_error(Domain, Addr, ReqId, Reason, State),
     {noreply, State};
 
-%% handle_info({snmp_error, ReqId, Pdu, Reason, Addr, Port}, State) ->
-%%     ?vlog("received snmp_error message", []),
-%%     handle_snmp_error(Pdu, ReqId, Reason, Addr, Port, State),
-%%     {noreply, State};
-
 
 handle_info({snmp_pdu, Pdu, Domain, Addr}, State) ->
     ?vlog("received snmp_pdu message", []),
@@ -1411,7 +1370,7 @@ handle_async_get(Pid, UserId, TargetName, Oids, SendOpts, State) ->
 			      address  = Addr,
 			      type     = get, 
 			      data     = MsgData, 
-			      expire   = t() + Expire},
+			      expire   = snmp_misc:now(ms) + Expire},
 
 	    ets:insert(snmpm_request_table, Req),
 	    gct_activate(State#state.gct),
@@ -1460,7 +1419,7 @@ handle_async_get_next(Pid, UserId, TargetName, Oids, SendOpts, State) ->
 			      address  = Addr,
 			      type     = get_next, 
 			      data     = MsgData, 
-			      expire   = t() + Expire},
+			      expire   = snmp_misc:now(ms) + Expire},
 
 	    ets:insert(snmpm_request_table, Req),
 	    gct_activate(State#state.gct),
@@ -1516,7 +1475,7 @@ handle_async_get_bulk(Pid,
 			      address  = Addr,
 			      type     = get_bulk, 
 			      data     = MsgData, 
-			      expire   = t() + Expire},
+			      expire   = snmp_misc:now(ms) + Expire},
 	    ets:insert(snmpm_request_table, Req),
 	    gct_activate(State#state.gct),
 	    {ok, ReqId};
@@ -1564,7 +1523,7 @@ handle_async_set(Pid, UserId, TargetName, VarsAndVals, SendOpts, State) ->
 			      address  = Addr,
 			      type     = set, 
 			      data     = MsgData, 
-			      expire   = t() + Expire},
+			      expire   = snmp_misc:now(ms) + Expire},
 
 	    ets:insert(snmpm_request_table, Req),
 	    gct_activate(State#state.gct),
@@ -1600,18 +1559,6 @@ handle_cancel_async_request(UserId, ReqId, _State) ->
 	    ?vlog("handle_cancel_async_request -> not found", []),
 	    {error, not_found}
     end.
-    
-
-%% handle_system_info_updated(#state{net_if = Pid, net_if_mod = Mod} = _State,
-%% 			   net_if = _Target, What) ->
-%%     case (catch Mod:system_info_updated(Pid, What)) of
-%% 	{'EXIT', _} ->
-%% 	    {error, not_supported};
-%% 	Else ->
-%% 	    Else
-%%     end;
-%% handle_system_info_updated(_State, Target, What) ->
-%%     {error, {bad_target, Target, What}}.
 
 handle_get_log_type(#state{net_if = Pid, net_if_mod = Mod}) ->
     case (catch Mod:get_log_type(Pid)) of
@@ -1629,47 +1576,6 @@ handle_set_log_type(#state{net_if = Pid, net_if_mod = Mod}, NewType) ->
 	    Else
     end.
 
-
-%% handle_discovery(Pid, UserId, BAddr, Port, Config, Expire, ExtraInfo, State) ->
-%%     ?vtrace("handle_discovery -> entry with"
-%% 	    "~n   Pid:         ~p"
-%% 	    "~n   UserId:      ~p"
-%% 	    "~n   BAddr:       ~p"
-%% 	    "~n   Port:        ~p"
-%% 	    "~n   Config:      ~p"
-%% 	    "~n   Expire:      ~p",
-%% 	    [Pid, UserId, BAddr, Port, Config, Expire]),
-%%     case agent_data(default, default, "", Config) of
-%% 	{ok, Addr, Port, Vsn, MsgData} ->
-%% 	    ?vtrace("handle_discovery -> send a ~p disco message", [Vsn]),
-%% 	    ReqId  = send_discovery(Vsn, MsgData, BAddr, Port, ExtraInfo, 
-%% 				    State),
-%% 	    ?vdebug("handle_discovery -> ReqId: ~p", [ReqId]),
-%% 	    MonRef = erlang:monitor(process, Pid),
-%% 	    ?vtrace("handle_discovery -> MonRef: ~p", [MonRef]),
-%% 	    Req    = #request{id        = ReqId,
-%% 			      user_id   = UserId, 
-%%			      target    = TargetName, 
-%% 			      addr      = BAddr, 
-%% 			      port      = Port,
-%% 			      type      = get, 
-%% 			      data      = MsgData, 
-%% 			      mon       = MonRef,
-%% 			      discovery = true, 
-%% 			      expire    = t() + Expire},
-%% 	    ets:insert(snmpm_request_table, Req),
-%% 	    gct_activate(State#state.gct),
-%% 	    {ok, ReqId};
-
-%% 	Error ->
-%% 	    ?vinfo("failed retrieving agent data for discovery (get):"
-%% 		   "~n   BAddr: ~p"
-%% 		   "~n   Port:  ~p"
-%% 		   "~n   Error: ~p", [BAddr, Port, Error]),
-%% 	    Error
-%%     end.
-
-
 handle_sync_timeout(ReqId, From, State) ->
     ?vtrace("handle_sync_timeout -> entry with"
 	    "~n   ReqId: ~p"
@@ -1693,7 +1599,7 @@ handle_sync_timeout(ReqId, From, State) ->
 	    Req = Req0#request{ref    = undefined, 
 			       mon    = undefined, 
 			       from   = undefined, 
-			       expire = t()},
+			       expire = snmp_misc:now(ms)},
 	    ets:insert(snmpm_request_table, Req),
 	    gct_activate(State#state.gct),
 	    ok;
@@ -3024,7 +2930,7 @@ cancel_timer(Ref) ->
 
 handle_gc(GCT) ->
     ets:safe_fixtable(snmpm_request_table, true),
-    case do_gc(ets:first(snmpm_request_table), t()) of
+    case do_gc(ets:first(snmpm_request_table), snmp_misc:now(ms)) of
 	0 ->
 	    gct_deactivate(GCT);
 	_ ->
@@ -3098,23 +3004,11 @@ send_set_request(VarsAndVals, Vsn, MsgData, Domain, Addr, ExtraInfo,
     Mod:send_pdu(NetIf, Pdu, Vsn, MsgData, Domain, Addr, ExtraInfo),
     Pdu#pdu.request_id.
 
-%% send_discovery(Vsn, MsgData, Addr, Port, ExtraInfo, 
-%% 	       #state{net_if     = NetIf, 
-%% 		      net_if_mod = Mod}) ->
-%%     Pdu = make_discovery_pdu(),
-%%     Mod:send_pdu(NetIf, Pdu, Vsn, MsgData, Addr, Port, ExtraInfo),
-%%     Pdu#pdu.request_id.
-							  
-
 
 %%----------------------------------------------------------------------
 %% 
 %%----------------------------------------------------------------------
 
-%% make_discovery_pdu() ->
-%%     Oids = [?sysObjectID_instance, ?sysDescr_instance, ?sysUpTime_instance],
-%%     make_pdu_impl(get, Oids).
-
 make_pdu(set, VarsAndVals, MiniMIB) ->
     VBs = [var_and_value_to_varbind(VAV, MiniMIB) || VAV <- VarsAndVals],
     make_pdu_impl(set, VBs);
@@ -3397,7 +3291,7 @@ gct_init(#gct{parent = Parent, timeout = Timeout} = State) ->
     gct(State, Timeout).
 
 gct(#gct{parent = Parent, state = active} = State, Timeout) ->
-    T = t(),
+    T = snmp_misc:now(ms),
     receive
 	{stop, Parent} ->
 	    ok;
@@ -3455,7 +3349,7 @@ gct(#gct{parent = Parent, state = idle} = State, Timeout) ->
     end.
 
 new_timeout(T1, T2) ->
-    case T1 - (t() - T2) of
+    case T1 - (snmp_misc:now(ms) - T2) of
 	T when (T > 0) ->
 	    T;
 	_ ->
@@ -3475,11 +3369,6 @@ maybe_demonitor(undefined) ->
 maybe_demonitor(MonRef) ->
     erlang:demonitor(MonRef).
 
-%% Time in milli seconds
-t() ->
-    {A,B,C} = erlang:now(),
-    A*1000000000+B*1000+(C div 1000).
-
 mk_target_name(Domain, Addr, Config) ->
     snmpm_config:mk_target_name(Domain, Addr, Config).
 
@@ -3518,12 +3407,6 @@ call(Req) ->
 call(Req, To) ->
     gen_server:call(?SERVER, Req, To).
 
-%% cast(Msg) ->
-%%     gen_server:cast(?SERVER, Msg).
-
-%% info_msg(F, A) ->
-%%     ?snmpm_info("Server: " ++ F, A).
-
 warning_msg(F, A) ->
     ?snmpm_warning("Server: " ++ F, A).
 
@@ -3599,20 +3482,3 @@ note_store_info(Pid) ->
 
 
 %%----------------------------------------------------------------------
-
-
-%%----------------------------------------------------------------------
-%% Debug
-%%----------------------------------------------------------------------
-
-% sz(L) when is_list(L) ->
-%     length(lists:flatten(L));
-% sz(B) when is_binary(B) ->
-%     size(B).
-
-%% p(F) ->
-%%     p(F, []).
-
-%% p(F, A) ->
-%%     io:format("~w:" ++ F ++ "~n", [?MODULE | A]).
-
diff --git a/lib/snmp/src/misc/snmp_misc.erl b/lib/snmp/src/misc/snmp_misc.erl
index c36cee2a53..cc438977c9 100644
--- a/lib/snmp/src/misc/snmp_misc.erl
+++ b/lib/snmp/src/misc/snmp_misc.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 1996-2013. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -101,21 +101,14 @@ sleep(Time) ->
 %% Returns time in ms = sec/1000
 % now() -> now(ms).
 now(ms) ->
-    Now = erlang:now(),
-    element(1,Now)*1000000000+
-	element(2,Now)*1000+
-	(element(3,Now) div 1000);
+    erlang:monotonic_time(milli_seconds);
+
 %% Returns time in cs = sec/100
 now(cs) ->
-    Now = erlang:now(),
-    element(1,Now)*100000000+
-        element(2,Now)*100+
-	(element(3,Now) div 10000);
+    erlang:monotonic_time(100);
+
 now(sec) ->
-    Now = erlang:now(),
-    element(1,Now)*1000000+
-        element(2,Now)+
-	(element(3,Now) div 1000000).
+    erlang:monotonic_time(seconds).
     
 
 is_crypto_supported(Alg) ->
@@ -479,7 +472,3 @@ format_val('OBJECT IDENTIFIER', _, Val, MiniMib) ->
     io_lib:format("~w", [NVal]);
 format_val(_, _, Val, _MiniMib) ->
     io_lib:format("~p", [Val]).
-    
-
-
-
diff --git a/lib/snmp/test/snmp_agent_test.erl b/lib/snmp/test/snmp_agent_test.erl
index b4770ad0a9..a28cdf6aca 100644
--- a/lib/snmp/test/snmp_agent_test.erl
+++ b/lib/snmp/test/snmp_agent_test.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2003-2014. All Rights Reserved.
+%% Copyright Ericsson AB 2003-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -426,10 +426,6 @@
 -include_lib("snmp/include/snmp_types.hrl").
 -include_lib("snmp/src/agent/snmpa_atl.hrl").
 
-%% -include_lib("snmp/include/SNMP-COMMUNITY-MIB.hrl").
-%% -include_lib("snmp/include/SNMP-VIEW-BASED-ACM-MIB.hrl").
-%% -include_lib("snmp/include/SNMP-USER-BASED-SM-MIB.hrl").
-
 
 -define(klas1, [1,3,6,1,2,1,7]).
 -define(klas2, [1,3,6,1,2,1,9]).
@@ -1612,7 +1608,8 @@ app_dir(App) ->
 create_local_db_dir(Config) when is_list(Config) ->
     ?P(create_local_db_dir),
     DataDir = snmp_test_lib:lookup(data_dir, Config),
-    T = erlang:now(),
+    UName = erlang:unique_integer([positive]),
+    T = {UName, UName, UName},
     [As,Bs,Cs] = [integer_to_list(I) || I <- tuple_to_list(T)],
     DbDir = filename:join([DataDir, As, Bs, Cs]),
     ok = del_dir(DbDir, 3),
@@ -2448,10 +2445,6 @@ mul_cases() ->
     ].
 
 
-%% multiple_reqs_3(_X) -> 
-%%     {req, [], {conf, init_mul, mul_cases_3(), finish_mul}}.
-
-
 mul_cases_2() -> 
     [
      mul_get_2, 
@@ -3200,19 +3193,18 @@ v1_get_next_p() ->
     %% 4.1.3:2
     gn([[tTooBig]]),
     io:format("We currently don't handle tooBig correct!!!\n"),
-%    ?line ?expect3(tooBig, 0, [{[tTooBig], 'NULL'}]),
+
     ?line ?expect3(tooBig, 0, any),
 
     %% 4.1.3:3
     gn([[tGenErr1]]),
-%    ?line expect(40, genErr, 1, [{[tGenErr1], 'NULL'}]),
+
     ?line ?expect3(genErr, 1, any),
     gn([[tGenErr2]]),
-%    ?line ?expect3(genErr, 1, [{[tGenErr2], 'NULL'}]),
+
     ?line ?expect3(genErr, 1, any),
     gn([[sysDescr], [tGenErr3]]),
-%    ?line ?expect3(genErr, 2, [{[sysDescr], 'NULL'},
-%				 {[tGenErr3], 'NULL'}]).
+
     ?line ?expect3(genErr, 2, any).
     
 v1_set_p() ->
@@ -3451,8 +3443,7 @@ v2_set_p() ->
 %% Req. OLD-SNMPEA-MIB
 table_test() ->
     io:format("Testing simple get, next and set on communityTable...~n"),
-%% {[147,214,36,45], "public", 2, readWrite}.
-%% {[147,214,36,45], "standard trap", 2, read}.
+
     Key1c3 = [intCommunityViewIndex,get(mip),is("public")],
     Key2c3 = [intCommunityViewIndex,get(mip),is("standard trap")],
     Key1c4 = [intCommunityAccess,get(mip),is("public")],
@@ -3620,8 +3611,6 @@ notify(Pid, What) ->
 
 %% Req: system group, OLD-SNMPEA-MIB, Klas1
 big_test() ->
-    %% put(sname, {?MODULE, big_test}),
-    %% put(verbosity, trace),
 
     ?DBG("big_test -> testing simple next/get/set @ master agent...",[]),
     simple_standard_test(),
@@ -5691,8 +5680,7 @@ loop_mib_1(suite) -> [];
 loop_mib_1(Config) when is_list(Config) ->
     ?P(loop_mib_1),
     ?LOG("loop_mib_1 -> initiate case",[]),
-    %% snmpa:verbosity(master_agent,debug),
-    %% snmpa:verbosity(mib_server,info),
+
     {_SaNode, _MgrNode, _MibDir} = init_case(Config),
     ?DBG("loop_mib_1 -> ~n"
 	   "\tSaNode:  ~p~n"
@@ -6643,7 +6631,6 @@ otp8395({init, Config}) when is_list(Config) ->
     %% 
 
     {ok, AgentNode}    = start_node(agent),
-    %% {ok, SubAgentNode} = start_node(sub_agent),
     {ok, ManagerNode}  = start_node(manager),
 
     %% -- 
@@ -6654,16 +6641,9 @@ otp8395({init, Config}) when is_list(Config) ->
     AgentMnesiaDir = join([AgentDbDir, "mnesia"]),
     mnesia_init(AgentNode, AgentMnesiaDir),
 
-    %% SubAgentDir = ?config(sub_agent_dir, Config),
-    %% SubAgentMnesiaDir = join([SubAgentDir, "mnesia"]),
-    %% mnesia_init(SubAgentNode, SubAgentMnesiaDir),
-
-    %% ok = mnesia_create_schema(AgentNode, [AgentNode, SubAgentNode]), 
-    %% ok = mnesia:create_schema([AgentNode, SubAgentNode]),
     mnesia_create_schema(AgentNode, [AgentNode]),
 
     mnesia_start(AgentNode),
-    %% mnesia_start(SubAgentNode),
 
     %% --
     %% Host & IP
@@ -6749,11 +6729,6 @@ otp8395({fin, Config}) when is_list(Config) ->
     ?DBG("otp8395(fin) -> stop agent node", []),
     stop_node(AgentNode),
 
-
-    %% SubAgentNode = ?config(sub_agent_node, Config),
-    %% stop_node(SubAgentNode),
-
-
     %% - 
     %% Stop the manager node
     %% 
@@ -6970,20 +6945,6 @@ process_options(Defaults, _Opts) ->
     %% process_options(Defaults, Opts, []).
     Defaults.
 
-%% process_options([], _Opts, Acc) ->
-%%     lists:reverse(Acc);
-%% process_options([{Key, DefaultValue}|Defaults], Opts, Acc) ->
-%%     case lists:keysearch(Key, 1, Opts) of
-%% 	{value, {Key, Value}} when is_list->
-	    
-
-%% snmp_app_env_init(Node, Entity, Conf) ->
-%%     rpc:call(Node, snmp_app_env_init, [Entity, Conf]).
-
-%% snmp_app_env_init(Entity, Conf) ->
-%%     application:unload(snmp),
-%%     application:load(snmp),
-%%     application:set_env(snmp, Entity, Conf).
 
 start_stdalone_agent(Node, Config)  ->
     rpc:call(Node, ?MODULE, start_stdalone_agent, [Config]).
@@ -7063,9 +7024,6 @@ do_info(MaNode) ->
 			  tree_size_bytes, 
 			  db_memory]}], 
     verify_info(Info, Keys),
-    %% OldInfo = snmpa:old_info_format(Info),
-    %% ?DBG("info_test1 -> OldInfo: ~n~p", [OldInfo]),
-    %% verify_old_info(OldInfo),
     ok.
 
 verify_info([], []) ->
@@ -7107,21 +7065,6 @@ verify_subinfo(Info0, [Key|Keys]) ->
 	Info ->
 	    verify_subinfo(Info, Keys)
     end.
-
-%% verify_old_info(Info) ->
-%%     Keys = [vsns, subagents, loaded_mibs, 
-%% 	    tree_size_bytes, process_memory, db_memory],
-%%     verify_old_info(Keys, Info).
-
-%% verify_old_info([], _) ->
-%%     ok;
-%% verify_old_info([Key|Keys], Info) ->
-%%     case lists:keymember(Key, 1, Info) of
-%% 	true ->
-%% 	    verify_old_info(Keys, Info);
-%% 	false ->
-%% 	    ?FAIL({missing_old_info, Key})
-%%     end.
    
 %% Index String - string used in index
 is(S) -> [length(S) | S].
@@ -7184,8 +7127,6 @@ rewrite_usm_mgr(Dir, ShaKey, DesKey) ->
 reset_usm_mgr(Dir) ->
     snmp_agent_test_lib:reset_usm_mgr(Dir).
 
-%% update_community(Vsns, Dir) ->
-%%     snmp_agent_test_lib:update_community(Vsns, Dir).
 
 update_vacm(Vsn, Dir) ->
     snmp_agent_test_lib:update_vacm(Vsn, Dir).
@@ -7196,8 +7137,6 @@ write_community_conf(Dir, Conf) ->
 write_target_addr_conf(Dir, Conf) ->
     snmp_agent_test_lib:write_target_addr_conf(Dir, Conf).
 
-%% write_target_addr_conf(Dir, ManagerIp, UDP, Vsns) -> 
-%%     snmp_agent_test_lib:write_target_addr_conf(Dir, ManagerIp, UDP, Vsns).
 
 rewrite_target_addr_conf(Dir, NewPort) ->
     snmp_agent_test_lib:rewrite_target_addr_conf(Dir, NewPort).
@@ -7218,10 +7157,6 @@ reset_target_params_conf(Dir) ->
 write_notify_conf(Dir) -> 
     snmp_agent_test_lib:write_notify_conf(Dir).
 
-%% write_view_conf(Dir) -> 
-%%     snmp_agent_test_lib:write_view_conf(Dir).
-
-
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
 copy_file(From, To) ->
@@ -7381,9 +7316,6 @@ lists_key1search(Key, List) when is_atom(Key) ->
     end.
 
 
-%% regs() ->
-%%     lists:sort(registered()).
-
 %% ------
 
 join(Parts) ->
diff --git a/lib/snmp/test/snmp_app_test.erl b/lib/snmp/test/snmp_app_test.erl
index 9b13e7cf1a..1e68b4e2c8 100644
--- a/lib/snmp/test/snmp_app_test.erl
+++ b/lib/snmp/test/snmp_app_test.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 2003-2012. All Rights Reserved.
+%% Copyright Ericsson AB 2003-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -32,8 +32,6 @@
 	 modules/1,
 	 exportall/1,
 	 app_depend/1,
-	 undef_funcs/1,
-
 	
 	 start_and_stop_empty/1, 
 	 start_and_stop_with_agent/1, 
@@ -59,7 +57,6 @@ all() ->
 	 modules, 
 	 exportall, 
 	 app_depend,
-	 undef_funcs, 
 	 {group, start_and_stop}
 	],
     Cases.
@@ -131,9 +128,6 @@ end_per_suite(Config) when is_list(Config) ->
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
 %% Test server callbacks
-init_per_testcase(undef_funcs, Config) ->
-    Config2 = lists:keydelete(watchdog, 1, Config),
-    [{watchdog, ?WD_START(?MINS(10))} | Config2];
 init_per_testcase(_Case, Config) ->
     Config.
 
@@ -293,88 +287,6 @@ check_apps([App|Apps]) ->
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
-undef_funcs(suite) ->
-    [];
-undef_funcs(doc) ->
-    [];
-undef_funcs(Config) when is_list(Config) ->
-    App            = snmp,
-    AppFile        = key1search(app_file, Config),
-    Mods           = key1search(modules, AppFile),
-    Root           = code:root_dir(),
-    LibDir         = code:lib_dir(App),
-    EbinDir        = filename:join([LibDir,"ebin"]),
-    XRefTestName   = undef_funcs_make_name(App, xref_test_name),
-    {ok, XRef}     = xref:start(XRefTestName),
-    ok             = xref:set_default(XRef,
-                                      [{verbose,false},{warnings,false}]),
-    XRefName       = undef_funcs_make_name(App, xref_name),
-    {ok, XRefName} = xref:add_release(XRef, Root, {name,XRefName}),
-    {ok, App}      = xref:replace_application(XRef, App, EbinDir),
-    {ok, Undefs}   = xref:analyze(XRef, undefined_function_calls),
-    xref:stop(XRef),
-    analyze_undefined_function_calls(Undefs, Mods, []).
-
-valid_undef(crypto = CalledMod) ->
-    case (catch CalledMod:version()) of
-        Version when is_list(Version) ->
-	    %% The called module was crypto and the version 
-	    %% function returns a valid value. 
-	    %% This means that the function is
-	    %% actually undefined...
-	    true;
-	_ ->
-	    %% The called module was crypto but the version 
-	    %% function does *not* return a valid value.
-	    %% This means the crypto was not actually not
-	    %% build, which is an case snmp handles.
-	    false
-    end;
-valid_undef(_) ->
-    true.
-
-    
-analyze_undefined_function_calls([], _, []) ->
-    ok;
-analyze_undefined_function_calls([], _, AppUndefs) ->
-    exit({suite_failed, {undefined_function_calls, AppUndefs}});
-analyze_undefined_function_calls([{{Mod, _F, _A}, _C} = AppUndef|Undefs],
-                                 AppModules, AppUndefs) ->
-    %% Check that this module is our's
-    case lists:member(Mod,AppModules) of
-        true ->
-            {Calling,Called} = AppUndef,
-            {Mod1,Func1,Ar1} = Calling,
-            {Mod2,Func2,Ar2} = Called,
-	    %% If the called module is crypto, then we will *not*
-	    %% fail if crypto is not built (since crypto is actually 
-	    %% not built for all platforms)
-	    case valid_undef(Mod2) of
-		true ->
-		    io:format("undefined function call: "
-			      "~n   ~w:~w/~w calls ~w:~w/~w~n",
-			      [Mod1,Func1,Ar1,Mod2,Func2,Ar2]),
-		    analyze_undefined_function_calls(
-		      Undefs, AppModules, [AppUndef|AppUndefs]);
-		false ->
-		    io:format("skipping ~p (calling ~w:~w/~w)~n", 
-			      [Mod, Mod2, Func2, Ar2]),
-		    analyze_undefined_function_calls(Undefs, 
-						     AppModules, AppUndefs)
-	    end;
-        false ->
-	    io:format("dropping ~p~n", [Mod]),
-	    analyze_undefined_function_calls(Undefs, AppModules, AppUndefs)
-    end.
-
-%% This function is used simply to avoid cut-and-paste errors later...
-undef_funcs_make_name(App, PostFix) ->
-    list_to_atom(atom_to_list(App) ++ "_" ++ atom_to_list(PostFix)).
-
-
-%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
-
-
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
diff --git a/lib/snmp/test/snmp_appup_mgr.erl b/lib/snmp/test/snmp_appup_mgr.erl
index 6648ce9dbe..b07f8b3c72 100644
--- a/lib/snmp/test/snmp_appup_mgr.erl
+++ b/lib/snmp/test/snmp_appup_mgr.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 2003-2010. All Rights Reserved.
+%% Copyright Ericsson AB 2003-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -140,7 +140,7 @@ handle_req(#agent{host = Host, port = Port}, Reqs) ->
     {ok, ReqId} = snmpm:ag(?USER_ID, Host, Port, Oids),
     p("issued get-request (~w) for: ~s", [ReqId, oid_descs(Descs)]),
     ReqTimer = erlang:send_after(?REQ_TIMEOUT, self(), {req_timeout, ReqId}),
-    {ReqId, erlang:now(), ReqTimer}.
+    {ReqId, erlang:monotonic_time(micro_seconds), ReqTimer}.
 
 oid_descs([]) ->
     [];
@@ -163,7 +163,7 @@ handle_req_timeout(#state{ids = IDs0} = State, ReqId) ->
 handle_snmp(#state{ids = IDs0} = S, {error, ReqId, Reason}) ->
     case lists:keysearch(ReqId, 1, IDs0) of
 	{value, {ReqId, T, Ref}} ->
-	    Diff = timer:now_diff(erlang:now(), T),
+	    Diff = erlang:monotonic_time(micro_seconds) - T,
 	    p("SNMP error regarding outstanding request after ~w microsec:"
 	      "~n   ReqId:  ~w"
 	      "~n   Reason: ~w", [Diff, ReqId, Reason]),
@@ -187,7 +187,7 @@ handle_snmp(State, {agent, Addr, Port, SnmpInfo}) ->
 handle_snmp(#state{ids = IDs0} = S, {pdu, Addr, Port, ReqId, SnmpResponse}) ->
     case lists:keysearch(ReqId, 1, IDs0) of
 	{value, {ReqId, T, Ref}} ->
-	    Diff = timer:now_diff(erlang:now(), T),
+	    Diff = erlang:monotonic_time(micro_seconds) - T,
 	    p("SNMP pdu regarding outstanding request after ~w microsec:"
 	      "~n   ReqId:        ~w"
 	      "~n   Addr:         ~w"
diff --git a/lib/snmp/test/snmp_conf_test.erl b/lib/snmp/test/snmp_conf_test.erl
index 7f5d11c0e7..dacedf0847 100644
--- a/lib/snmp/test/snmp_conf_test.erl
+++ b/lib/snmp/test/snmp_conf_test.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %% 
-%% Copyright Ericsson AB 2003-2014. All Rights Reserved.
+%% Copyright Ericsson AB 2003-2015. All Rights Reserved.
 %% 
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -117,7 +117,7 @@ check_mandatory(Config) when is_list(Config) ->
 	  {b, mandatory}, 
 	  {d, {value, 20202}}, 
 	  {e, {value, "kalle"}}],
-    ?line {ok, L1} = verify_mandatory(A1, B1),
+    ?line {ok, _L1} = verify_mandatory(A1, B1),
     ?DBG("check_mandatory -> L1: ~p", [L1]),
     A2 = [{a, hej}, {c, 10}, {d, 10101}, {f, 10.88}],
     B2 = [{a, {value, hejsan}}, 
diff --git a/lib/snmp/test/snmp_log_test.erl b/lib/snmp/test/snmp_log_test.erl
index fb7285110f..ed71dba23f 100644
--- a/lib/snmp/test/snmp_log_test.erl
+++ b/lib/snmp/test/snmp_log_test.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2003-2013. All Rights Reserved.
+%% Copyright Ericsson AB 2003-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -633,11 +633,11 @@ log_to_txt3(Config) when is_list(Config) ->
 	log_reader_log_to(Reader, 
 			  fun() -> 
 				  I = disk_log:info(Log),
-				  T1 = t(), 
+				  T1 = snmp_misc:now(ms),
 				  R = snmp_log:log_to_txt(Log, LogFile, Dir, 
 							  Mibs, TxtFile),
-				  T2 = t(), 
-				  io:format(user, 
+				  T2 = snmp_misc:now(ms),
+				  io:format(user,
 					    "Time converting file: ~w ms~n",
 					    [T2 - T1]),
 				  {R, I}
@@ -704,10 +704,10 @@ log_writer_start(Name, File, Size, Repair) ->
 
 log_writer_stop(Pid) ->
     Pid ! {stop, self()},
-    _T1 = t(),
+    _T1 = snmp_misc:now(ms),
     receive
 	{'EXIT', Pid, normal} ->
-	    _T2 = t(),
+	    _T2 = snmp_misc:now(ms),
 	    ?DBG("it took ~w ms to stop the writer", [_T2 - _T1]),
 	    ok
     after 60000 ->
@@ -721,10 +721,10 @@ log_writer_info(Pid) ->
 
 log_writer_sleep(Pid, Time) ->
     Pid ! {sleep, Time, self()},
-    _T1 = t(),
+    _T1 = snmp_misc:now(ms),
     receive 
 	{sleeping, Pid} ->
-	    _T2 = t(),
+	    _T2 = snmp_misc:now(ms),
 	    ?DBG("it took ~w ms to put the writer to sleep", [_T2 - _T1]),
 	    ok;
 	{'EXIT', Pid, Reason} ->
@@ -793,10 +793,10 @@ lp(F, A) ->
 
 log_reader_start() ->
     Pid = spawn_link(?MODULE, log_reader_main, [self()]),
-    _T1 = t(),
+    _T1 = snmp_misc:now(ms),
     receive 
 	{started, Pid} ->
-	    _T2 = t(),
+	    _T2 = snmp_misc:now(ms),
 	    ?DBG("it took ~w ms to start the reader", [_T2 - _T1]),
 	    {ok, Pid};
 	{'EXIT', Pid, Reason} ->
@@ -807,10 +807,10 @@ log_reader_start() ->
 
 log_reader_stop(Pid) ->
     Pid ! {stop, self()},
-    _T1 = t(),
+    _T1 = snmp_misc:now(ms),
     receive
 	{'EXIT', Pid, normal} ->
-	    _T2 = t(),
+	    _T2 = snmp_misc:now(ms),
 	    ?DBG("it took ~w ms to put the reader to eleep", [_T2 - _T1]),
 	    ok
     after 1000 ->
@@ -1124,8 +1124,3 @@ join(D, F) ->
 
 p(Case) ->
     io:format(user, "test case: ~w~n", [Case]).
-
-%% Time in milli sec
-t() ->
-    {A,B,C} = erlang:now(),
-    A*1000000000+B*1000+(C div 1000).
diff --git a/lib/snmp/test/snmp_manager_config_test.erl b/lib/snmp/test/snmp_manager_config_test.erl
index f37e957dae..ba674edce3 100644
--- a/lib/snmp/test/snmp_manager_config_test.erl
+++ b/lib/snmp/test/snmp_manager_config_test.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2004-2014. All Rights Reserved.
+%% Copyright Ericsson AB 2004-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -2169,7 +2169,6 @@ register_usm_user_using_function(Conf) when is_list(Conf) ->
     %% --
     p("done"),
     ok.
-%%    ?SKIP(not_yet_implemented).
 
 
 %% 
@@ -2259,8 +2258,9 @@ create_and_increment(Conf) when is_list(Conf) ->
     ?line {ok, _Pid} = snmpm_config:start_link(Opts),
 
     %% Random init
-    {A,B,C} = erlang:now(),
-    random:seed(A,B,C),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
 
     StartVal = random:uniform(2147483647),
     IncVal   = 42, 
diff --git a/lib/snmp/test/snmp_test_lib.erl b/lib/snmp/test/snmp_test_lib.erl
index 5e611340a3..72c7452ec4 100644
--- a/lib/snmp/test/snmp_test_lib.erl
+++ b/lib/snmp/test/snmp_test_lib.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 2002-2014. All Rights Reserved.
+%% Copyright Ericsson AB 2002-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -30,7 +30,7 @@
 	 lookup/2, 
 	 replace_config/3, set_config/3, get_config/2, get_config/3]).
 -export([fail/3, skip/3]).
--export([millis/0, millis_diff/2, hours/1, minutes/1, seconds/1, sleep/1]).
+-export([hours/1, minutes/1, seconds/1, sleep/1]).
 -export([flush_mqueue/0, trap_exit/0, trap_exit/1]).
 -export([ping/1, local_nodes/0, nodes_on/1]).
 -export([start_node/2]).
@@ -334,14 +334,6 @@ skip(Reason, Module, Line) ->
 %% Time related function
 %% 
 
-millis() ->
-    erlang:now().
-
-millis_diff(A,B) ->
-    T1 = (element(1,A)*1000000) + element(2,A) + (element(3,A)/1000000),
-    T2 = (element(1,B)*1000000) + element(2,B) + (element(3,B)/1000000),
-    T1 - T2.
-
 hours(N)   -> trunc(N * 1000 * 60 * 60).
 minutes(N) -> trunc(N * 1000 * 60).
 seconds(N) -> trunc(N * 1000).
@@ -628,4 +620,3 @@ format_timestamp({_N1, _N2, N3} = Now) ->
         io_lib:format("~.4w:~.2.0w:~.2.0w ~.2.0w:~.2.0w:~.2.0w ~w",
                       [YYYY,MM,DD,Hour,Min,Sec,round(N3/1000)]),
     lists:flatten(FormatDate).
-
diff --git a/lib/snmp/test/snmp_test_lib.hrl b/lib/snmp/test/snmp_test_lib.hrl
index 9b7609b831..fd584880da 100644
--- a/lib/snmp/test/snmp_test_lib.hrl
+++ b/lib/snmp/test/snmp_test_lib.hrl
@@ -1,8 +1,8 @@
-%%<copyright>
-%% <year>2002-2014</year>
-%% <holder>Ericsson AB, All Rights Reserved</holder>
-%%</copyright>
-%%<legalnotice>
+%%
+%% %CopyrightBegin%
+%%
+%% Copyright Ericsson AB 2002-2015. All Rights Reserved.
+%%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
 %% compliance with the License. You should have received a copy of the
@@ -15,7 +15,7 @@
 %% under the License.
 %%
 %% The Initial Developer of the Original Code is Ericsson AB.
-%%</legalnotice>
+%% %CopyrightEnd%
 %%
 %%----------------------------------------------------------------------
 %% Purpose: Define common macros for testing
@@ -73,8 +73,6 @@
 -endif.
 
 -define(SLEEP(MSEC),    snmp_test_lib:sleep(MSEC)).
--define(M(),            snmp_test_lib:millis()).
--define(MDIFF(A,B),     snmp_test_lib:millis_diff(A,B)).
 
 %% - Process utility macros - 
 
@@ -149,4 +147,3 @@
 
 -define(PRINT(P,F,A),
 	snmp_test_lib:print(P,?MODULE,?LINE,F,A)).
-
diff --git a/lib/snmp/test/snmp_test_mgr.erl b/lib/snmp/test/snmp_test_mgr.erl
index 8cb6ec588e..1bf7efc695 100644
--- a/lib/snmp/test/snmp_test_mgr.erl
+++ b/lib/snmp/test/snmp_test_mgr.erl
@@ -1,7 +1,7 @@
 %% 
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1996-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1996-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -188,8 +188,9 @@ receive_trap(Timeout) ->
 init({Options, CallerPid}) ->
     put(sname,     mgr),
     put(verbosity, debug), 
-    {A1,A2,A3} = erlang:now(),
-    random:seed(A1,A2,A3),
+    random:seed(erlang:phash2([node()]),
+                erlang:monotonic_time(),
+                erlang:unique_integer()),
     case (catch is_options_ok(Options)) of
 	true ->
 	    put(debug, get_value(debug, Options, false)),
@@ -1135,4 +1136,3 @@ d(_,_F,_A) ->
 
 formated_timestamp() ->
     snmp_test_lib:formated_timestamp().
-