diff options
author | Micael Karlberg <[email protected]> | 2019-05-29 12:12:25 +0200 |
---|---|---|
committer | Micael Karlberg <[email protected]> | 2019-05-29 12:21:13 +0200 |
commit | 9e0dbd341d738e0c8a268752f131fa6ab6195ad3 (patch) | |
tree | 7ceb4b780211993406ac96584f7f81cf848b21ad /lib/snmp | |
parent | e628d2cdf8953b8692e6b9ac0265c20bfce4b21d (diff) | |
download | otp-9e0dbd341d738e0c8a268752f131fa6ab6195ad3.tar.gz otp-9e0dbd341d738e0c8a268752f131fa6ab6195ad3.tar.bz2 otp-9e0dbd341d738e0c8a268752f131fa6ab6195ad3.zip |
[snmp] Add verbosity printouts to the set handling
Add verbosity printouts after a set operation. Both
for a successful and a failed set.
On one of our test hosts (a VM running an old gento),
it looked like an ets or dets insert hangs. But since
we only have a printout directly before, we can't
tell for sure what happens.
OTP-15764
Diffstat (limited to 'lib/snmp')
-rw-r--r-- | lib/snmp/src/agent/snmpa_set.erl | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/lib/snmp/src/agent/snmpa_set.erl b/lib/snmp/src/agent/snmpa_set.erl index 9833d6fdcc..b3a3bf0ab0 100644 --- a/lib/snmp/src/agent/snmpa_set.erl +++ b/lib/snmp/src/agent/snmpa_set.erl @@ -163,10 +163,14 @@ set_phase_two(MyVarbinds, SubagentVarbinds) -> [MyVarbinds, SubagentVarbinds]), case snmpa_set_lib:try_set(MyVarbinds) of {noError, 0} -> + ?vtrace("set phase two: (local) varbinds set ok", []), set_phase_two_subagents(SubagentVarbinds); - {ErrorStatus, Index} -> + {ErrorStatus, ErrorIndex} -> + ?vlog("set phase two: (local) varbinds set failed" + "~n ErrorStatus: ~p" + "~n ErrorIndex: ~p", [ErrorStatus, ErrorIndex]), set_phase_two_undo_subagents(SubagentVarbinds), - {ErrorStatus, Index} + {ErrorStatus, ErrorIndex} end. %%----------------------------------------------------------------- @@ -188,6 +192,7 @@ set_phase_two_subagents([{SubAgentPid, SAVbs} | SubagentVarbinds]) -> {_SAOids, Vbs} = sa_split(SAVbs), case catch snmpa_agent:subagent_set(SubAgentPid, [phase_two, set, Vbs]) of {noError, 0} -> + ?vtrace("set phase two: subagent ~p varbinds set ok", [SubAgentPid]), set_phase_two_subagents(SubagentVarbinds); {'EXIT', Reason} -> user_err("Lost contact with subagent (set)~n~w. Using genErr", @@ -195,10 +200,14 @@ set_phase_two_subagents([{SubAgentPid, SAVbs} | SubagentVarbinds]) -> set_phase_two_undo_subagents(SubagentVarbinds), {genErr, 0}; {ErrorStatus, ErrorIndex} -> + ?vlog("set phase two: subagent ~p varbinds set failed" + "~n ErrorStatus: ~p" + "~n ErrorIndex: ~p", [SubAgentPid, ErrorStatus, ErrorIndex]), set_phase_two_undo_subagents(SubagentVarbinds), {ErrorStatus, ErrorIndex} end; set_phase_two_subagents([]) -> + ?vtrace("set phase two: subagent(s) set ok", []), {noError, 0}. %%----------------------------------------------------------------- |