ssh: Merge connection_manager and connection_handler processes

Also start adding dialyzer specs and removing dead code

1 files changed, 256 insertions, 328 deletions

diff --git a/lib/ssh/src/ssh_connection.erl b/lib/ssh/src/ssh_connection.erl
index ec3022e7c1..d3760f8295 100644
--- a/lib/ssh/src/ssh_connection.erl
+++ b/lib/ssh/src/ssh_connection.erl
@@ -29,232 +29,205 @@
 -include("ssh_connect.hrl").
 -include("ssh_transport.hrl").
 
+%% API
 -export([session_channel/2, session_channel/4,
 	 exec/4, shell/2, subsystem/4, send/3, send/4, send/5, 
-	 send_eof/2, adjust_window/3, open_pty/3, open_pty/7,
-	 open_pty/9, setenv/5, window_change/4, window_change/6,
+	 send_eof/2, adjust_window/3, setenv/5, close/2, reply_request/4]).
+
+%% Potential API currently unsupported and not tested
+-export([open_pty/3, open_pty/7,
+	 open_pty/9, window_change/4, window_change/6,
 	 direct_tcpip/6, direct_tcpip/8, tcpip_forward/3,
-	 cancel_tcpip_forward/3, signal/3, exit_status/3, encode_ip/1, close/2,
-	 reply_request/4]).
+	 cancel_tcpip_forward/3, signal/3, exit_status/3]).
 
--export([channel_data/6, handle_msg/4, channel_eof_msg/1,
+%% Internal application API
+-export([channel_data/5, handle_msg/3, channel_eof_msg/1,
 	 channel_close_msg/1, channel_success_msg/1, channel_failure_msg/1, 
+	 channel_status_msg/1,
 	 channel_adjust_window_msg/2, channel_data_msg/3,
 	 channel_open_msg/5, channel_open_confirmation_msg/4,
 	 channel_open_failure_msg/4, channel_request_msg/4,
 	 global_request_msg/3, request_failure_msg/0, 
 	 request_success_msg/1, bind/4, unbind/3, unbind_channel/2, 
-	 bound_channel/3]).
+	 bound_channel/3, encode_ip/1]).
 
 %%--------------------------------------------------------------------
-%%% Internal application API
+%%% API
 %%--------------------------------------------------------------------
 
 %%--------------------------------------------------------------------
-%% Function: session_channel(ConnectionManager 
-%%                           [, InitialWindowSize, MaxPacketSize], 
-%%                           Timeout) -> {ok, }
-%%   ConnectionManager = pid() 
-%%   InitialWindowSize = integer()
-%%   MaxPacketSize = integer() 
-%%
+-spec session_channel(pid(), timeout()) -> {ok, channel_id()} | {error, term()}.
+-spec session_channel(pid(), integer(), integer(), timeout()) -> {ok, channel_id()} | {error, term()}.
+
 %% Description: Opens a channel for a ssh session. A session is a
 %% remote execution of a program. The program may be a shell, an
 %% application, a system command, or some built-in subsystem.
 %% --------------------------------------------------------------------
-session_channel(ConnectionManager, Timeout) ->
-    session_channel(ConnectionManager, 
+
+session_channel(ConnectionHandler, Timeout) ->
+    session_channel(ConnectionHandler,
  		    ?DEFAULT_WINDOW_SIZE, ?DEFAULT_PACKET_SIZE,
  		    Timeout).
-session_channel(ConnectionManager, InitialWindowSize, 
+
+session_channel(ConnectionHandler, InitialWindowSize,
  		MaxPacketSize, Timeout) ->
-    ssh_connection_manager:open_channel(ConnectionManager, "session", <<>>,
+    case ssh_connection_handler:open_channel(ConnectionHandler, "session", <<>>,
 					InitialWindowSize,
- 					MaxPacketSize, Timeout).
+					MaxPacketSize, Timeout) of
+	{open, Channel} ->
+	    {ok, Channel};
+	Error ->
+	    Error
+    end.
+
 %%--------------------------------------------------------------------
-%% Function: exec(ConnectionManager, ChannelId, Command, Timeout) -> 
-%%
-%%   ConnectionManager = pid() 
-%%   ChannelId = integer()
-%%   Cmd = string()
-%%   Timeout = integer() 
-%%
+-spec exec(pid(), channel_id(), string(), timeout()) -> success | failure.
+
 %% Description: Will request that the server start the
 %% execution of the given command. 
 %%--------------------------------------------------------------------
-exec(ConnectionManager, ChannelId, Command, TimeOut) ->
-    ssh_connection_manager:request(ConnectionManager, self(), ChannelId, "exec", 
- 				   true, [?string(Command)], TimeOut).
+exec(ConnectionHandler, ChannelId, Command, TimeOut) ->
+    ssh_connection_handler:request(ConnectionHandler, self(), ChannelId, "exec",
+				   true, [?string(Command)], TimeOut).
+
 %%--------------------------------------------------------------------
-%% Function: shell(ConnectionManager, ChannelId) -> 
-%%
-%%   ConnectionManager = pid() 
-%%   ChannelId = integer()
-%%
+-spec shell(pid(), channel_id()) -> _.
+
 %% Description: Will request that the user's default shell (typically
 %% defined in /etc/passwd in UNIX systems) be started at the other
 %% end.
 %%--------------------------------------------------------------------
-shell(ConnectionManager, ChannelId) ->
-    ssh_connection_manager:request(ConnectionManager, self(), ChannelId, 
+shell(ConnectionHandler, ChannelId) ->
+    ssh_connection_handler:request(ConnectionHandler, self(), ChannelId,
  				   "shell", false, <<>>, 0).
 %%--------------------------------------------------------------------
-%% Function: subsystem(ConnectionManager, ChannelId, SubSystem, TimeOut) -> 
-%%
-%% ConnectionManager = pid() 
-%% ChannelId = integer()
-%% SubSystem = string()
-%% TimeOut = integer() 
-%%
+-spec subsystem(pid(), channel_id(), string(), timeout()) ->
+		       success | failure | {error, timeout}.
 %%
 %% Description: Executes a predefined subsystem.
 %%--------------------------------------------------------------------
-subsystem(ConnectionManager, ChannelId, SubSystem, TimeOut) ->
-     ssh_connection_manager:request(ConnectionManager, self(),
+subsystem(ConnectionHandler, ChannelId, SubSystem, TimeOut) ->
+     ssh_connection_handler:request(ConnectionHandler, self(),
 				    ChannelId, "subsystem", 
 				    true, [?string(SubSystem)], TimeOut).
 %%--------------------------------------------------------------------
-%% Function: send(ConnectionManager, ChannelId, Type, Data, [TimeOut]) ->
+-spec send(pid(), channel_id(), iodata()) ->
+		  ok | {error, closed}.
+-spec send(pid(), channel_id(), integer()| iodata(), timeout() | iodata()) ->
+		  ok | {error, timeout} | {error, closed}.
+-spec send(pid(), channel_id(), integer(), iodata(), timeout()) ->
+		  ok | {error, timeout} | {error, closed}.
 %%
 %%
 %% Description: Sends channel data.
 %%--------------------------------------------------------------------
-send(ConnectionManager, ChannelId, Data) ->
-    send(ConnectionManager, ChannelId, 0, Data, infinity).
-send(ConnectionManager, ChannelId, Data, TimeOut) when is_integer(TimeOut) ->
-    send(ConnectionManager, ChannelId, 0, Data, TimeOut);
-send(ConnectionManager, ChannelId, Data, infinity) ->
-    send(ConnectionManager, ChannelId, 0, Data, infinity);
-send(ConnectionManager, ChannelId, Type, Data) ->
-    send(ConnectionManager, ChannelId, Type, Data, infinity).
-send(ConnectionManager, ChannelId, Type, Data, TimeOut) ->
-    ssh_connection_manager:send(ConnectionManager, ChannelId, 
+send(ConnectionHandler, ChannelId, Data) ->
+    send(ConnectionHandler, ChannelId, 0, Data, infinity).
+send(ConnectionHandler, ChannelId, Data, TimeOut) when is_integer(TimeOut) ->
+    send(ConnectionHandler, ChannelId, 0, Data, TimeOut);
+send(ConnectionHandler, ChannelId, Data, infinity) ->
+    send(ConnectionHandler, ChannelId, 0, Data, infinity);
+send(ConnectionHandler, ChannelId, Type, Data) ->
+    send(ConnectionHandler, ChannelId, Type, Data, infinity).
+send(ConnectionHandler, ChannelId, Type, Data, TimeOut) ->
+    ssh_connection_handler:send(ConnectionHandler, ChannelId,
 				Type, Data, TimeOut).
 %%--------------------------------------------------------------------
-%% Function: send_eof(ConnectionManager, ChannelId) ->
+-spec send_eof(pid(), channel_id()) -> ok | {error, closed}.
 %%
 %%
 %% Description: Sends eof on the channel <ChannelId>.
 %%--------------------------------------------------------------------
-send_eof(ConnectionManager, Channel) ->
-    ssh_connection_manager:send_eof(ConnectionManager, Channel).
+send_eof(ConnectionHandler, Channel) ->
+    ssh_connection_handler:send_eof(ConnectionHandler, Channel).
 
 %%--------------------------------------------------------------------
-%% Function: adjust_window(ConnectionManager, Channel, Bytes) -> 
+-spec adjust_window(pid(), channel_id(), integer()) -> ok.
 %%
 %%
 %% Description: Adjusts the ssh flowcontrol window.
 %%--------------------------------------------------------------------
-adjust_window(ConnectionManager, Channel, Bytes) ->
-    ssh_connection_manager:adjust_window(ConnectionManager, Channel, Bytes).
+adjust_window(ConnectionHandler, Channel, Bytes) ->
+    ssh_connection_handler:adjust_window(ConnectionHandler, Channel, Bytes).
 
 %%--------------------------------------------------------------------
-%% Function: setenv(ConnectionManager, ChannelId, Var, Value, TimeOut) ->
+-spec setenv(pid(), channel_id(), string(), string(), timeout()) ->  success | failure.
 %%
 %%
 %% Description: Environment variables may be passed to the shell/command to be
 %% started later.
 %%--------------------------------------------------------------------
-setenv(ConnectionManager, ChannelId, Var, Value, TimeOut) ->
-    ssh_connection_manager:request(ConnectionManager, ChannelId, 
+setenv(ConnectionHandler, ChannelId, Var, Value, TimeOut) ->
+    ssh_connection_handler:request(ConnectionHandler, ChannelId,
 	    "env", true, [?string(Var), ?string(Value)], TimeOut).
 
 
 %%--------------------------------------------------------------------
-%% Function: close(ConnectionManager, ChannelId) ->
+-spec close(pid(), channel_id()) -> ok.
 %%
 %%
 %% Description: Sends a close message on the channel <ChannelId>.
 %%--------------------------------------------------------------------
-close(ConnectionManager, ChannelId) ->
-    ssh_connection_manager:close(ConnectionManager, ChannelId).
-
+close(ConnectionHandler, ChannelId) ->
+    ssh_connection_handler:close(ConnectionHandler, ChannelId).
 
 %%--------------------------------------------------------------------
-%% Function: reply_request(ConnectionManager, WantReply, Status, CannelId) ->_
+-spec reply_request(pid(), boolean(), success | failure, channel_id()) -> ok.
 %%
 %%
 %% Description: Send status replies to requests that want such replies.
 %%--------------------------------------------------------------------
-reply_request(ConnectionManager, true, Status, ChannelId) ->
-    ssh_connection_manager:reply_request(ConnectionManager, Status, ChannelId),
-    ok;
+reply_request(ConnectionHandler, true, Status, ChannelId) ->
+    ssh_connection_handler:reply_request(ConnectionHandler, Status, ChannelId);
 reply_request(_,false, _, _) ->
     ok.
 
-
 %%--------------------------------------------------------------------
-%% Function: window_change(ConnectionManager, Channel, Width, Height) ->
-%%
-%%
-%% Description: Not yet officialy supported.
+%% Not yet officialy supported! The following functions are part of the
+%% initial contributed ssh application. They are untested. Do we want them?
+%% Should they be documented and tested?
 %%--------------------------------------------------------------------
-window_change(ConnectionManager, Channel, Width, Height) ->
-    window_change(ConnectionManager, Channel, Width, Height, 0, 0).
-window_change(ConnectionManager, Channel, Width, Height, 
+window_change(ConnectionHandler, Channel, Width, Height) ->
+    window_change(ConnectionHandler, Channel, Width, Height, 0, 0).
+window_change(ConnectionHandler, Channel, Width, Height,
 	      PixWidth, PixHeight) ->
-    ssh_connection_manager:request(ConnectionManager, Channel, 
+    ssh_connection_handler:request(ConnectionHandler, Channel,
 				   "window-change", false, 
 				   [?uint32(Width), ?uint32(Height),
 				    ?uint32(PixWidth), ?uint32(PixHeight)], 0).
-%%--------------------------------------------------------------------
-%% Function: signal(ConnectionManager, Channel, Sig) ->
-%%
-%%
-%% Description:  Not yet officialy supported.
-%%--------------------------------------------------------------------
-signal(ConnectionManager, Channel, Sig) ->
-    ssh_connection_manager:request(ConnectionManager, Channel, 
+
+signal(ConnectionHandler, Channel, Sig) ->
+    ssh_connection_handler:request(ConnectionHandler, Channel,
 				   "signal", false, [?string(Sig)], 0).
 
-%%--------------------------------------------------------------------
-%% Function: signal(ConnectionManager, Channel, Status) ->
-%%
-%%
-%% Description:  Not yet officialy supported.
-%%--------------------------------------------------------------------
-exit_status(ConnectionManager, Channel, Status) ->
-    ssh_connection_manager:request(ConnectionManager, Channel, 
-				   "exit-status", false, [?uint32(Status)], 0).
 
+exit_status(ConnectionHandler, Channel, Status) ->
+    ssh_connection_handler:request(ConnectionHandler, Channel,
+				   "exit-status", false, [?uint32(Status)], 0).
 
-%%--------------------------------------------------------------------
-%% Function: open_pty(ConnectionManager, Channel, TimeOut) ->
-%%
-%%
-%% Description:  Not yet officialy supported.
-%%--------------------------------------------------------------------
-open_pty(ConnectionManager, Channel, TimeOut) ->
-    open_pty(ConnectionManager, Channel, 
+open_pty(ConnectionHandler, Channel, TimeOut) ->
+    open_pty(ConnectionHandler, Channel,
 	     os:getenv("TERM"), 80, 24, [], TimeOut).
 
-open_pty(ConnectionManager, Channel, Term, Width, Height, PtyOpts, TimeOut) ->
-    open_pty(ConnectionManager, Channel, Term, Width, 
+open_pty(ConnectionHandler, Channel, Term, Width, Height, PtyOpts, TimeOut) ->
+    open_pty(ConnectionHandler, Channel, Term, Width,
 	     Height, 0, 0, PtyOpts, TimeOut).
 
-open_pty(ConnectionManager, Channel, Term, Width, Height, 
+open_pty(ConnectionHandler, Channel, Term, Width, Height,
 	 PixWidth, PixHeight, PtyOpts, TimeOut) ->
-    ssh_connection_manager:request(ConnectionManager, 
+    ssh_connection_handler:request(ConnectionHandler,
 				   Channel, "pty-req", true, 
 				   [?string(Term),
 				    ?uint32(Width), ?uint32(Height),
 				    ?uint32(PixWidth),?uint32(PixHeight),
 				    encode_pty_opts(PtyOpts)], TimeOut).
 
-
-%%--------------------------------------------------------------------
-%% Function: direct_tcpip(ConnectionManager, RemoteHost,  
-%%                        RemotePort, OrigIP, OrigPort, Timeout) ->
-%%
-%%
-%% Description: Not yet officialy supported.
-%%--------------------------------------------------------------------
-direct_tcpip(ConnectionManager, RemoteHost, 
+direct_tcpip(ConnectionHandler, RemoteHost,
 	     RemotePort, OrigIP, OrigPort, Timeout) ->
-    direct_tcpip(ConnectionManager, RemoteHost, RemotePort, OrigIP, OrigPort,
+    direct_tcpip(ConnectionHandler, RemoteHost, RemotePort, OrigIP, OrigPort,
 		 ?DEFAULT_WINDOW_SIZE, ?DEFAULT_PACKET_SIZE, Timeout).
 
-direct_tcpip(ConnectionManager, RemoteIP, RemotePort, OrigIP, OrigPort,
+direct_tcpip(ConnectionHandler, RemoteIP, RemotePort, OrigIP, OrigPort,
 	     InitialWindowSize, MaxPacketSize, Timeout) ->
     case {encode_ip(RemoteIP), encode_ip(OrigIP)} of
 	{false, _} -> 
@@ -262,7 +235,7 @@ direct_tcpip(ConnectionManager, RemoteIP, RemotePort, OrigIP, OrigPort,
 	{_, false} -> 
 	    {error, einval};
 	{RIP, OIP} ->
-	    ssh_connection_manager:open_channel(ConnectionManager,
+	    ssh_connection_handler:open_channel(ConnectionHandler,
 						"direct-tcpip",
 						[?string(RIP), 
 						 ?uint32(RemotePort),
@@ -272,34 +245,24 @@ direct_tcpip(ConnectionManager, RemoteIP, RemotePort, OrigIP, OrigPort,
 						MaxPacketSize,
 						Timeout)
     end.
-%%--------------------------------------------------------------------
-%% Function: tcpip_forward(ConnectionManager, BindIP, BindPort) ->
-%%
-%%
-%% Description: Not yet officialy supported.
-%%--------------------------------------------------------------------
-tcpip_forward(ConnectionManager, BindIP, BindPort) ->
+
+tcpip_forward(ConnectionHandler, BindIP, BindPort) ->
     case encode_ip(BindIP) of
 	false -> 
 	    {error, einval};
 	IPStr ->
-	    ssh_connection_manager:global_request(ConnectionManager, 
+	    ssh_connection_handler:global_request(ConnectionHandler,
 						  "tcpip-forward", true,
 						  [?string(IPStr),
 						   ?uint32(BindPort)])
     end.
-%%--------------------------------------------------------------------
-%% Function: cancel_tcpip_forward(ConnectionManager, BindIP, Port) ->
-%%
-%%
-%% Description: Not yet officialy supported.
-%%--------------------------------------------------------------------
-cancel_tcpip_forward(ConnectionManager, BindIP, Port) ->
+
+cancel_tcpip_forward(ConnectionHandler, BindIP, Port) ->
     case encode_ip(BindIP) of
 	false -> 
 	    {error, einval};
 	IPStr ->
-	    ssh_connection_manager:global_request(ConnectionManager, 
+	    ssh_connection_handler:global_request(ConnectionHandler,
 						  "cancel-tcpip-forward", true,
 						  [?string(IPStr),
 						   ?uint32(Port)])
@@ -308,22 +271,23 @@ cancel_tcpip_forward(ConnectionManager, BindIP, Port) ->
 %%--------------------------------------------------------------------
 %%% Internal API
 %%--------------------------------------------------------------------
-channel_data(ChannelId, DataType, Data, Connection, ConnectionPid, From) 
+channel_data(ChannelId, DataType, Data, Connection, From)
   when is_list(Data)->
     channel_data(ChannelId, DataType, 
-		 list_to_binary(Data), Connection, ConnectionPid, From);
+		 list_to_binary(Data), Connection, From);
 
 channel_data(ChannelId, DataType, Data, 
-	     #connection{channel_cache = Cache} = Connection, ConnectionPid,
+	     #connection{channel_cache = Cache} = Connection,
 	     From) ->
     
     case ssh_channel:cache_lookup(Cache, ChannelId) of
 	#channel{remote_id = Id, sent_close = false} = Channel0 ->
-	    {SendList, Channel} = update_send_window(Channel0#channel{flow_control = From}, DataType,
-						     Data, Connection),
+	    {SendList, Channel} =
+		update_send_window(Channel0#channel{flow_control = From}, DataType,
+				   Data, Connection),
 	    Replies = 
 		lists:map(fun({SendDataType, SendData}) -> 
-				  {connection_reply, ConnectionPid,
+				  {connection_reply,
 				   channel_data_msg(Id,
 						    SendDataType,
 						    SendData)}
@@ -333,7 +297,7 @@ channel_data(ChannelId, DataType, Data,
 					Cache),
 	    {{replies, Replies ++ FlowCtrlMsgs}, Connection};
 	_ ->
-	    gen_server:reply(From, {error, closed}),
+	    gen_fsm:reply(From, {error, closed}),
 	    {noreply, Connection}
     end.
 
@@ -341,7 +305,7 @@ handle_msg(#ssh_msg_channel_open_confirmation{recipient_channel = ChannelId,
 					      sender_channel = RemoteId,
 					      initial_window_size = WindowSz,
 					      maximum_packet_size = PacketSz}, 
-	   #connection{channel_cache = Cache} = Connection0, _, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
     
     #channel{remote_id = undefined} = Channel =
 	ssh_channel:cache_lookup(Cache, ChannelId), 
@@ -357,7 +321,7 @@ handle_msg(#ssh_msg_channel_open_failure{recipient_channel = ChannelId,
 					 reason = Reason,
 					 description = Descr,
 					 lang = Lang},  
-	   #connection{channel_cache = Cache} = Connection0, _, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
     ssh_channel:cache_delete(Cache, ChannelId),
     {Reply, Connection} = 
@@ -365,51 +329,59 @@ handle_msg(#ssh_msg_channel_open_failure{recipient_channel = ChannelId,
     {{replies, [Reply]}, Connection};
 
 handle_msg(#ssh_msg_channel_success{recipient_channel = ChannelId},
-	   #connection{channel_cache = Cache} = Connection0, _, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
-    {Reply, Connection} = reply_msg(Channel, Connection0, success),
-    {{replies, [Reply]}, Connection};
+    case reply_msg(Channel, Connection0, success) of
+	{[], Connection} ->
+	    {noreply, Connection};
+	{Reply, Connection} ->
+	    {{replies, [Reply]}, Connection}
+    end;
 
 handle_msg(#ssh_msg_channel_failure{recipient_channel = ChannelId},
-	   #connection{channel_cache = Cache} = Connection0, _, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
-    {Reply, Connection} = reply_msg(Channel, Connection0, failure),
-    {{replies, [Reply]}, Connection};
+    case reply_msg(Channel, Connection0, failure) of
+	{[], Connection} ->
+	    {noreply, Connection};
+	{Reply, Connection} ->
+	    {{replies, [Reply]}, Connection}
+    end;
+
 
 handle_msg(#ssh_msg_channel_eof{recipient_channel = ChannelId}, 
-	    #connection{channel_cache = Cache} = Connection0, _, _) ->
+	    #connection{channel_cache = Cache} = Connection0, _) ->
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
     {Reply, Connection} = reply_msg(Channel, Connection0, {eof, ChannelId}),
     {{replies, [Reply]}, Connection};
    
 handle_msg(#ssh_msg_channel_close{recipient_channel = ChannelId},   
-	   #connection{channel_cache = Cache} = Connection0, 
-	   ConnectionPid, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
 
 	case ssh_channel:cache_lookup(Cache, ChannelId) of
-		#channel{sent_close = Closed, remote_id = RemoteId, flow_control = FlowControl} = Channel ->
+		#channel{sent_close = Closed, remote_id = RemoteId,
+			 flow_control = FlowControl} = Channel ->
 		ssh_channel:cache_delete(Cache, ChannelId),
 		{CloseMsg, Connection} = 
 		    reply_msg(Channel, Connection0, {closed, ChannelId}),
-
-			ConnReplyMsgs =
-		case Closed of
-					true -> [];
-		    false ->
-			RemoteCloseMsg = channel_close_msg(RemoteId),
-						[{connection_reply, ConnectionPid, RemoteCloseMsg}]
-				end,
-
-			%% if there was a send() in progress, make it fail
-			SendReplyMsgs =
-				case FlowControl of
-					undefined -> [];
-					From ->
-						[{flow_control, From, {error, closed}}]
-				end,
-
-			Replies = ConnReplyMsgs ++ [CloseMsg] ++ SendReplyMsgs,
-			{{replies, Replies}, Connection};
+		ConnReplyMsgs =
+		    case Closed of
+			true -> [];
+			false ->
+			    RemoteCloseMsg = channel_close_msg(RemoteId),
+			    [{connection_reply, RemoteCloseMsg}]
+		    end,
+
+		%% if there was a send() in progress, make it fail
+		SendReplyMsgs =
+		    case FlowControl of
+			undefined -> [];
+			From ->
+			    [{flow_control, From, {error, closed}}]
+		    end,
+
+		Replies = ConnReplyMsgs ++ [CloseMsg] ++ SendReplyMsgs,
+		{{replies, Replies}, Connection};
 
 	    undefined ->
 		{{replies, []}, Connection0}
@@ -417,21 +389,24 @@ handle_msg(#ssh_msg_channel_close{recipient_channel = ChannelId},
 
 handle_msg(#ssh_msg_channel_data{recipient_channel = ChannelId,
 				 data = Data}, 
-	   #connection{channel_cache = Cache} = Connection0, _, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
     
-    #channel{recv_window_size = Size} = Channel =
-	ssh_channel:cache_lookup(Cache, ChannelId), 
-    WantedSize = Size - size(Data),
-    ssh_channel:cache_update(Cache, Channel#channel{
-				      recv_window_size = WantedSize}),
-    {Replies, Connection} = 
-	channel_data_reply(Cache, Channel, Connection0, 0, Data),
-    {{replies, Replies}, Connection};
+    case ssh_channel:cache_lookup(Cache, ChannelId) of
+	#channel{recv_window_size = Size} = Channel ->
+	    WantedSize = Size - size(Data),
+	    ssh_channel:cache_update(Cache, Channel#channel{
+					      recv_window_size = WantedSize}),
+	    {Replies, Connection} =
+		channel_data_reply(Cache, Channel, Connection0, 0, Data),
+	    {{replies, Replies}, Connection};
+	undefined ->
+	    {noreply, Connection0}
+    end;
 
 handle_msg(#ssh_msg_channel_extended_data{recipient_channel = ChannelId,
 					  data_type_code = DataType,
 					  data = Data}, 
-	   #connection{channel_cache = Cache} = Connection0, _, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
     
     #channel{recv_window_size = Size} = Channel =
 	ssh_channel:cache_lookup(Cache, ChannelId), 
@@ -444,9 +419,7 @@ handle_msg(#ssh_msg_channel_extended_data{recipient_channel = ChannelId,
 
 handle_msg(#ssh_msg_channel_window_adjust{recipient_channel = ChannelId,
 					  bytes_to_add = Add}, 
-	   #connection{channel_cache = Cache} = Connection, 
-	   ConnectionPid, _) ->
-    
+	   #connection{channel_cache = Cache} = Connection, _) ->
     #channel{send_window_size = Size, remote_id = RemoteId} = 
 	Channel0 = ssh_channel:cache_lookup(Cache, ChannelId), 
     
@@ -455,8 +428,7 @@ handle_msg(#ssh_msg_channel_window_adjust{recipient_channel = ChannelId,
 			   0, undefined, Connection),
     
     Replies = lists:map(fun({Type, Data}) -> 
-				{connection_reply, ConnectionPid,
-				 channel_data_msg(RemoteId, Type, Data)}
+				{connection_reply, channel_data_msg(RemoteId, Type, Data)}
 			end, SendList),
     FlowCtrlMsgs = flow_control(Channel, Cache),
     {{replies, Replies ++ FlowCtrlMsgs}, Connection};
@@ -464,10 +436,9 @@ handle_msg(#ssh_msg_channel_window_adjust{recipient_channel = ChannelId,
 handle_msg(#ssh_msg_channel_open{channel_type = "session" = Type,
 				 sender_channel = RemoteId,
 				 initial_window_size = WindowSz,
-				 maximum_packet_size = PacketSz}, Connection0, 
-	   ConnectionPid, server) ->
+				 maximum_packet_size = PacketSz}, Connection0, server) ->
    
-    try setup_session(Connection0, ConnectionPid, RemoteId,
+    try setup_session(Connection0, RemoteId,
 		     Type, WindowSz, PacketSz) of
 	Result ->
 	    Result
@@ -475,20 +446,20 @@ handle_msg(#ssh_msg_channel_open{channel_type = "session" = Type,
 	    FailMsg = channel_open_failure_msg(RemoteId, 
 					       ?SSH_OPEN_CONNECT_FAILED,
 					       "Connection refused", "en"),
-	    {{replies, [{connection_reply, ConnectionPid, FailMsg}]}, 
+	    {{replies, [{connection_reply, FailMsg}]},
 	     Connection0}
     end;
 
 handle_msg(#ssh_msg_channel_open{channel_type = "session",
 				 sender_channel = RemoteId}, 
-	   Connection, ConnectionPid, client) ->
+	   Connection, client) ->
     %% Client implementations SHOULD reject any session channel open
     %% requests to make it more difficult for a corrupt server to attack the
     %% client. See See RFC 4254 6.1.
     FailMsg = channel_open_failure_msg(RemoteId, 
 				       ?SSH_OPEN_CONNECT_FAILED,
 				       "Connection refused", "en"),
-    {{replies, [{connection_reply, ConnectionPid, FailMsg}]}, 
+    {{replies, [{connection_reply, FailMsg}]},
      Connection};
 
 handle_msg(#ssh_msg_channel_open{channel_type = "forwarded-tcpip" = Type,
@@ -496,8 +467,7 @@ handle_msg(#ssh_msg_channel_open{channel_type = "forwarded-tcpip" = Type,
 				 initial_window_size = RWindowSz,
 				 maximum_packet_size = RPacketSz,
 				 data = Data}, 
-	   #connection{channel_cache = Cache} = Connection0, 
-	   ConnectionPid, server) ->
+	   #connection{channel_cache = Cache} = Connection0, server) ->
     <<?UINT32(ALen), Address:ALen/binary, ?UINT32(Port),
      ?UINT32(OLen), Orig:OLen/binary, ?UINT32(OrigPort)>> = Data,
     
@@ -507,7 +477,7 @@ handle_msg(#ssh_msg_channel_open{channel_type = "forwarded-tcpip" = Type,
 					       ?SSH_OPEN_CONNECT_FAILED,
 					       "Connection refused", "en"),
 	    {{replies, 
-	      [{connection_reply, ConnectionPid, FailMsg}]}, Connection0};
+	      [{connection_reply, FailMsg}]}, Connection0};
 	ChannelPid ->
 	    {ChannelId, Connection1} = new_channel_id(Connection0),
 	    LWindowSz = ?DEFAULT_WINDOW_SIZE,
@@ -528,32 +498,31 @@ handle_msg(#ssh_msg_channel_open{channel_type = "forwarded-tcpip" = Type,
 			  {open,  Channel, {forwarded_tcpip,
 					    decode_ip(Address), Port,
 					    decode_ip(Orig), OrigPort}}),
-	    {{replies, [{connection_reply, ConnectionPid, OpenConfMsg},
+	    {{replies, [{connection_reply, OpenConfMsg},
 			OpenMsg]}, Connection}
     end;
 
 handle_msg(#ssh_msg_channel_open{channel_type = "forwarded-tcpip",
 				 sender_channel = RemoteId}, 
-	   Connection, ConnectionPid, client) ->
+	   Connection, client) ->
     %% Client implementations SHOULD reject direct TCP/IP open requests for
     %% security reasons. See RFC 4254 7.2.
     FailMsg = channel_open_failure_msg(RemoteId, 
 				       ?SSH_OPEN_CONNECT_FAILED,
 				       "Connection refused", "en"),
-    {{replies, [{connection_reply, ConnectionPid, FailMsg}]}, Connection};
+    {{replies, [{connection_reply, FailMsg}]}, Connection};
 
 
-handle_msg(#ssh_msg_channel_open{sender_channel = RemoteId}, Connection, 
-	   ConnectionPid, _) ->
+handle_msg(#ssh_msg_channel_open{sender_channel = RemoteId}, Connection, _) ->
     FailMsg = channel_open_failure_msg(RemoteId, 
 				       ?SSH_OPEN_ADMINISTRATIVELY_PROHIBITED,
 				       "Not allowed", "en"),
-    {{replies, [{connection_reply, ConnectionPid, FailMsg}]}, Connection};
+    {{replies, [{connection_reply, FailMsg}]}, Connection};
 
 handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				    request_type = "exit-status",
 				    data = Data},
-	   #connection{channel_cache = Cache} = Connection, _, _) ->
+	   #connection{channel_cache = Cache} = Connection, _) ->
     <<?UINT32(Status)>> = Data,
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
     {Reply, Connection} = 
@@ -564,8 +533,7 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				    request_type = "exit-signal",
 				    want_reply = false,
 				    data = Data},  
-	   #connection{channel_cache = Cache} = Connection0, 
-	   ConnectionPid, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
     <<?UINT32(SigLen), SigName:SigLen/binary,
      ?BOOLEAN(_Core), 
      ?UINT32(ErrLen), Err:ErrLen/binary,
@@ -578,14 +546,14 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				      binary_to_list(Err),
 				      binary_to_list(Lang)}),
     CloseMsg = channel_close_msg(RemoteId),
-    {{replies, [{connection_reply, ConnectionPid, CloseMsg}, Reply]},
+    {{replies, [{connection_reply, CloseMsg}, Reply]},
      Connection};
 
 handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				    request_type = "xon-xoff",
 				    want_reply = false,
 				    data = Data},
-	   #connection{channel_cache = Cache} = Connection, _, _) ->
+	   #connection{channel_cache = Cache} = Connection, _) ->
     <<?BOOLEAN(CDo)>> = Data,
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
     {Reply, Connection} = 
@@ -596,7 +564,7 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				    request_type = "window-change",
 				    want_reply = false,
 				    data = Data}, 
-	   #connection{channel_cache = Cache} = Connection0, _, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
     <<?UINT32(Width),?UINT32(Height),
      ?UINT32(PixWidth), ?UINT32(PixHeight)>> = Data,
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
@@ -609,7 +577,7 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				    request_type = "signal",
 				    data = Data}, 
-	   #connection{channel_cache = Cache} = Connection0, _, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
     <<?UINT32(SigLen), SigName:SigLen/binary>> = Data,
     
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
@@ -622,8 +590,7 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				    request_type = "subsystem",
 				    want_reply = WantReply,
 				    data = Data},
-	   #connection{channel_cache = Cache} = Connection, 
-	   ConnectionPid, server) ->
+	   #connection{channel_cache = Cache} = Connection, server) ->
     <<?UINT32(SsLen), SsName:SsLen/binary>> = Data,
     
     #channel{remote_id = RemoteId} = Channel0 = 
@@ -631,22 +598,23 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
     
     ReplyMsg =  {subsystem, ChannelId, WantReply, binary_to_list(SsName)},
     
-    try start_subsytem(SsName, Connection, Channel0, ReplyMsg) of
-	{ok, Pid} -> 
-	    erlang:monitor(process, Pid),
-	    Channel = Channel0#channel{user = Pid},
-	    ssh_channel:cache_update(Cache, Channel),
-	    Reply = {connection_reply, ConnectionPid, 
-		     channel_success_msg(RemoteId)}, 
-	    {{replies, [Reply]}, Connection}
-    catch _:_ ->
-	    Reply = {connection_reply, ConnectionPid, 
-		     channel_failure_msg(RemoteId)}, 
-	    {{replies, [Reply]}, Connection}
+    try
+	{ok, Pid} = start_subsytem(SsName, Connection, Channel0, ReplyMsg),
+	erlang:monitor(process, Pid),
+	Channel = Channel0#channel{user = Pid},
+	ssh_channel:cache_update(Cache, Channel),
+	Reply = {connection_reply,
+		 channel_success_msg(RemoteId)},
+	{{replies, [Reply]}, Connection}
+    catch
+	_:_ ->
+	    ErrorReply = {connection_reply,
+			  channel_failure_msg(RemoteId)},
+	    {{replies, [ErrorReply]}, Connection}
     end;	
 
 handle_msg(#ssh_msg_channel_request{request_type = "subsystem"},
-	   Connection, _, client) ->
+	   Connection, client) ->
     %% The client SHOULD ignore subsystem requests. See RFC 4254 6.5.
     {{replies, []}, Connection};
 
@@ -654,8 +622,7 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				    request_type = "pty-req",
 				    want_reply = WantReply,
 				    data = Data},
-	   #connection{channel_cache = Cache} = Connection, 
-	   ConnectionPid, server) ->
+	   #connection{channel_cache = Cache} = Connection, server) ->
     <<?UINT32(TermLen), BTermName:TermLen/binary,
      ?UINT32(Width),?UINT32(Height),
      ?UINT32(PixWidth), ?UINT32(PixHeight),
@@ -667,27 +634,26 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
     
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
     
-    handle_cli_msg(Connection, ConnectionPid, Channel, 
+    handle_cli_msg(Connection, Channel,
 		   {pty, ChannelId, WantReply, PtyRequest});
 
 handle_msg(#ssh_msg_channel_request{request_type = "pty-req"},
-	   Connection, _, client) ->
+	   Connection, client) ->
     %% The client SHOULD ignore pty requests. See RFC 4254 6.2.
     {{replies, []}, Connection};
 
 handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				    request_type = "shell",
 				    want_reply = WantReply},
-	   #connection{channel_cache = Cache} = Connection, 
-	   ConnectionPid, server) ->
+	   #connection{channel_cache = Cache} = Connection, server) ->
       
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
     
-    handle_cli_msg(Connection, ConnectionPid, Channel, 
+    handle_cli_msg(Connection, Channel,
 		   {shell, ChannelId, WantReply});
  
 handle_msg(#ssh_msg_channel_request{request_type = "shell"},
-	   Connection, _, client) ->
+	   Connection, client) ->
     %% The client SHOULD ignore shell requests. See RFC 4254 6.5.
     {{replies, []}, Connection};
 
@@ -695,17 +661,16 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				    request_type = "exec",
 				    want_reply = WantReply,
 				    data = Data},
-	   #connection{channel_cache = Cache} = Connection, 
-	   ConnectionPid, server) ->
+	   #connection{channel_cache = Cache} = Connection, server) ->
     <<?UINT32(Len), Command:Len/binary>> = Data,
      
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
     
-    handle_cli_msg(Connection, ConnectionPid, Channel, 
+    handle_cli_msg(Connection, Channel,
 		   {exec, ChannelId, WantReply, binary_to_list(Command)});
 	
 handle_msg(#ssh_msg_channel_request{request_type = "exec"},
-	   Connection, _, client) ->
+	   Connection, client) ->
     %% The client SHOULD ignore exec requests. See RFC 4254 6.5.
     {{replies, []}, Connection};
 
@@ -713,31 +678,30 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
   				    request_type = "env",
   				    want_reply = WantReply,
   				    data = Data}, 
-  	   #connection{channel_cache = Cache} = Connection, 
-  	   ConnectionPid, server) ->
+	   #connection{channel_cache = Cache} = Connection, server) ->
     
     <<?UINT32(VarLen), 
      Var:VarLen/binary, ?UINT32(ValueLen), Value:ValueLen/binary>> = Data,
     
     Channel = ssh_channel:cache_lookup(Cache, ChannelId), 
     
-    handle_cli_msg(Connection, ConnectionPid, Channel,
+    handle_cli_msg(Connection, Channel,
  		   {env, ChannelId, WantReply, Var, Value});
 
 handle_msg(#ssh_msg_channel_request{request_type = "env"},
-	   Connection, _, client) ->
+	   Connection, client) ->
     %% The client SHOULD ignore env requests. 
     {{replies, []}, Connection};
 
 handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 				    request_type = _Other,
-				    want_reply = WantReply},  #connection{channel_cache = Cache} = Connection,
-	   ConnectionPid, _) ->
+				    want_reply = WantReply},
+	   #connection{channel_cache = Cache} = Connection, _) ->
     if WantReply == true ->
 		case ssh_channel:cache_lookup(Cache, ChannelId) of
 		    #channel{remote_id = RemoteId}  -> 
 			FailMsg = channel_failure_msg(RemoteId),
-			{{replies, [{connection_reply, ConnectionPid, FailMsg}]}, 
+			{{replies, [{connection_reply, FailMsg}]},
 			 Connection};
 		    undefined -> %% Chanel has been closed
 			{noreply, Connection}
@@ -748,61 +712,75 @@ handle_msg(#ssh_msg_channel_request{recipient_channel = ChannelId,
 
 handle_msg(#ssh_msg_global_request{name = _Type,
 				   want_reply = WantReply,
-				   data = _Data}, Connection,
-	   ConnectionPid, _) ->
+				   data = _Data}, Connection, _) ->
     if WantReply == true ->
 	    FailMsg = request_failure_msg(),
-	    {{replies, [{connection_reply, ConnectionPid, FailMsg}]}, 
+	    {{replies, [{connection_reply, FailMsg}]},
 	     Connection};
        true ->
 	    {noreply, Connection}  
     end;
 
+handle_msg(#ssh_msg_request_failure{},
+	   #connection{requests = [{_, From} | Rest]} = Connection, _) ->
+    {{replies, [{channel_requst_reply, From, {failure, <<>>}}]},
+     Connection#connection{requests = Rest}};
+handle_msg(#ssh_msg_request_success{data = Data},
+	   #connection{requests = [{_, From} | Rest]} = Connection, _) ->
+    {{replies, [{channel_requst_reply, From, {success, Data}}]},
+     Connection#connection{requests = Rest}};
+
 %%% This transport message will also be handled at the connection level
 handle_msg(#ssh_msg_disconnect{code = Code,
 			       description = Description,
 			       language = _Lang },
-	   #connection{channel_cache = Cache} = Connection0, _, _) ->
+	   #connection{channel_cache = Cache} = Connection0, _) ->
     {Connection, Replies} = 
 	ssh_channel:cache_foldl(fun(Channel, {Connection1, Acc}) ->
 					{Reply, Connection2} =  
 					    reply_msg(Channel,
-						      Connection1, {closed, Channel#channel.local_id}),
+						      Connection1,
+						      {closed, Channel#channel.local_id}),
 					{Connection2, [Reply | Acc]}
 				end, {Connection0, []}, Cache),
     
     ssh_channel:cache_delete(Cache),
     {disconnect, {Code, Description}, {{replies, Replies}, Connection}}.
 
-handle_cli_msg(#connection{channel_cache = Cache} = Connection0,
-	       ConnectionPid, 
+handle_cli_msg(#connection{channel_cache = Cache} = Connection,
 	       #channel{user = undefined, 
+			remote_id = RemoteId,
 			local_id = ChannelId} = Channel0, Reply0) -> 
     
-    case (catch start_cli(Connection0, ChannelId)) of
+    case (catch start_cli(Connection, ChannelId)) of
 	{ok, Pid} ->
 	    erlang:monitor(process, Pid),
 	    Channel = Channel0#channel{user = Pid},
 	    ssh_channel:cache_update(Cache, Channel),
-	    {Reply, Connection} = reply_msg(Channel, Connection0, Reply0),
-	    {{replies, [Reply]}, Connection};
-	_ ->
-	    Reply = {connection_reply, ConnectionPid, 
-		     request_failure_msg()}, 
-	    {{replies, [Reply]}, Connection0}
+	    Reply = {connection_reply,
+		     channel_success_msg(RemoteId)},
+	    {{replies, [{channel_data, Pid, Reply0}, Reply]}, Connection};
+	_Other ->
+	    Reply = {connection_reply,
+		     channel_failure_msg(RemoteId)},
+	    {{replies, [Reply]}, Connection}
     end;
 
-handle_cli_msg(Connection0, _, Channel, Reply0) -> 
+handle_cli_msg(Connection0, Channel, Reply0) ->
     {Reply, Connection} =  reply_msg(Channel, Connection0, Reply0),
     {{replies, [Reply]}, Connection}.
 
-
 channel_eof_msg(ChannelId) ->
     #ssh_msg_channel_eof{recipient_channel = ChannelId}.
 
 channel_close_msg(ChannelId) ->
     #ssh_msg_channel_close {recipient_channel = ChannelId}.
 
+channel_status_msg({success, ChannelId}) ->
+    channel_success_msg(ChannelId);
+channel_status_msg({failure, ChannelId}) ->
+    channel_failure_msg(ChannelId).
+
 channel_success_msg(ChannelId) ->
     #ssh_msg_channel_success{recipient_channel = ChannelId}.
 
@@ -901,14 +879,14 @@ start_channel(Cb, Id, Args, SubSysSup) ->
 
 start_channel(Cb, Id, Args, SubSysSup, Exec) ->
     ChildSpec = child_spec(Cb, Id, Args, Exec),
-    ChannelSup =ssh_subsystem_sup:channel_supervisor(SubSysSup),
+    ChannelSup = ssh_subsystem_sup:channel_supervisor(SubSysSup),
     ssh_channel_sup:start_child(ChannelSup, ChildSpec).
     
 %%--------------------------------------------------------------------
 %%% Internal functions
 %%--------------------------------------------------------------------
 setup_session(#connection{channel_cache = Cache} = Connection0, 
-	      ConnectionPid, RemoteId,
+	      RemoteId,
 	      Type, WindowSize, PacketSize) ->
     {ChannelId, Connection} = new_channel_id(Connection0),
 
@@ -926,7 +904,7 @@ setup_session(#connection{channel_cache = Cache} = Connection0,
 						?DEFAULT_WINDOW_SIZE, 
 						?DEFAULT_PACKET_SIZE),
 
-    {{replies, [{connection_reply, ConnectionPid, OpenConfMsg}]}, Connection}.
+    {{replies, [{connection_reply, OpenConfMsg}]}, Connection}.
 
 
 check_subsystem("sftp"= SsName, Options) ->
@@ -955,35 +933,19 @@ child_spec(Callback, Id, Args, Exec) ->
     Type = worker,
     {Name, StartFunc, Restart, Shutdown, Type, [ssh_channel]}.
 
-%% Backwards compatibility
-start_cli(#connection{address = Address, port = Port, cli_spec = {Fun, [Shell]},
-		      options = Options}, 
-	  _ChannelId) when is_function(Fun) ->
-    case Fun(Shell, Address, Port, Options) of
-	NewFun when is_function(NewFun) ->
-	    {ok, NewFun()};
-	Pid when is_pid(Pid) ->
-	    {ok, Pid}
-    end;
-
 start_cli(#connection{cli_spec = {CbModule, Args}, exec = Exec,
 		      sub_system_supervisor = SubSysSup}, ChannelId) ->
     start_channel(CbModule, ChannelId, Args, SubSysSup, Exec).
 
-start_subsytem(BinName, #connection{address = Address, port = Port, 
-				    options = Options, 
+start_subsytem(BinName, #connection{options = Options,
 				    sub_system_supervisor = SubSysSup},
-	       #channel{local_id = ChannelId, remote_id = RemoteChannelId},
-	       ReplyMsg) ->
+	       #channel{local_id = ChannelId}, _ReplyMsg) ->
     Name = binary_to_list(BinName),
     case check_subsystem(Name, Options) of
 	{Callback, Opts} when is_atom(Callback), Callback =/= none ->
 	    start_channel(Callback, ChannelId, Opts, SubSysSup);
 	{Other, _} when Other =/= none ->
-	    handle_backwards_compatibility(Other, self(), 
-					   ChannelId, RemoteChannelId,
-					   Options, Address, Port, 
-					   {ssh_cm, self(), ReplyMsg})
+	    {error, legacy_option_not_supported}
     end.
 
 channel_data_reply(_, #channel{local_id = ChannelId} = Channel, 
@@ -1006,9 +968,12 @@ reply_msg(Channel, Connection, failure = Reply) ->
     request_reply_or_data(Channel, Connection, Reply);
 reply_msg(Channel, Connection, {closed, _} = Reply) ->
     request_reply_or_data(Channel, Connection, Reply);
+reply_msg(undefined, Connection, _Reply) ->
+    {noreply, Connection};
 reply_msg(#channel{user = ChannelPid}, Connection, Reply) ->
     {{channel_data, ChannelPid, Reply}, Connection}.
 
+
 request_reply_or_data(#channel{local_id = ChannelId, user = ChannelPid}, 
 		      #connection{requests = Requests} = 
 		      Connection, Reply) -> 
@@ -1016,10 +981,13 @@ request_reply_or_data(#channel{local_id = ChannelId, user = ChannelPid},
 	{value, {ChannelId, From}} ->
 	    {{channel_requst_reply, From, Reply}, 
 	     Connection#connection{requests = 
-				   lists:keydelete(ChannelId, 1, Requests)}};
+				       lists:keydelete(ChannelId, 1, Requests)}};
+	false when (Reply == success) or (Reply == failure) ->
+	    {[], Connection};
 	false ->
 	    {{channel_data, ChannelPid, Reply}, Connection}
     end.
+
 update_send_window(Channel, _, undefined,
 		   #connection{channel_cache = Cache}) ->
     do_update_send_window(Channel,  Channel#channel.send_buf, Cache);
@@ -1075,7 +1043,7 @@ flow_control([], Channel, Cache) ->
     [];
 
 flow_control([_|_], #channel{flow_control = From,
-							 send_buf = []} = Channel, Cache) when From =/= undefined ->
+			     send_buf = []} = Channel, Cache) when From =/= undefined ->
 	[{flow_control, Cache, Channel, From, ok}];
 flow_control(_,_,_) ->
 	[].
@@ -1277,43 +1245,3 @@ decode_ip(Addr) when is_binary(Addr) ->
 	{ok,A}    -> A
     end.
 
-%% This is really awful and that is why it is beeing phased out. 
-handle_backwards_compatibility({_,_,_,_,_,_} = ChildSpec, _, _, _, _,
-			       Address, Port, _) ->
-    SystemSup = ssh_system_sup:system_supervisor(Address, Port),
-    ChannelSup = ssh_system_sup:channel_supervisor(SystemSup),
-    ssh_channel_sup:start_child(ChannelSup, ChildSpec);
-
-handle_backwards_compatibility(Module, ConnectionManager, ChannelId,
-			       RemoteChannelId, Opts,
-			       _, _, Msg) when is_atom(Module) ->
-    {ok, SubSystemPid} = gen_server:start_link(Module, [Opts], []),
-    SubSystemPid !
-	{ssh_cm, ConnectionManager, 
-	 {open, ChannelId, RemoteChannelId, {session}}},
-    SubSystemPid ! Msg,
-    {ok, SubSystemPid}; 
-
-handle_backwards_compatibility(Fun, ConnectionManager, ChannelId, 
-			       RemoteChannelId, 
-			       _, _, _, Msg) when is_function(Fun) ->
-    SubSystemPid = Fun(),
-    SubSystemPid ! 
-	{ssh_cm, ConnectionManager, 
-	 {open, ChannelId, RemoteChannelId, {session}}},
-    SubSystemPid ! Msg,
-    {ok, SubSystemPid};
-
-handle_backwards_compatibility(ChildSpec, 
-			       ConnectionManager, 
-			       ChannelId, RemoteChannelId, _, 
-			       Address, Port, Msg) ->
-    SystemSup = ssh_system_sup:system_supervisor(Address, Port),
-    ChannelSup = ssh_system_sup:channel_supervisor(SystemSup),
-    {ok, SubSystemPid} 
-	= ssh_channel_sup:start_child(ChannelSup, ChildSpec),
-    SubSystemPid ! 
-	{ssh_cm, ConnectionManager, 
-	 {open, ChannelId, RemoteChannelId, {session}}},
-    SubSystemPid ! Msg,
-    {ok, SubSystemPid}.