aboutsummaryrefslogtreecommitdiffstats
path: root/lib/ssh/src/ssh_connection_handler.erl
diff options
context:
space:
mode:
authorErlang/OTP <[email protected]>2010-10-21 14:11:17 +0200
committerErlang/OTP <[email protected]>2010-10-21 14:11:17 +0200
commitc219fb35d73ad393d983fd8b47a127d03cbc41c5 (patch)
treee6f81aec5308dfceefdc6d920434928f38c41981 /lib/ssh/src/ssh_connection_handler.erl
parent0f727bd7b72b009eac169c2e9ef925d3c2ffa409 (diff)
parent24c67e110e2219c269454566126ad0885ee57bdc (diff)
downloadotp-c219fb35d73ad393d983fd8b47a127d03cbc41c5.tar.gz
otp-c219fb35d73ad393d983fd8b47a127d03cbc41c5.tar.bz2
otp-c219fb35d73ad393d983fd8b47a127d03cbc41c5.zip
Merge branch 'nick/ssh/crash_report/OTP-8881' into maint-r13
* nick/ssh/crash_report/OTP-8881: In some cases a crash report was generated when a connection was closing down. This was caused by a race condition between two processes.
Diffstat (limited to 'lib/ssh/src/ssh_connection_handler.erl')
-rw-r--r--lib/ssh/src/ssh_connection_handler.erl16
1 files changed, 12 insertions, 4 deletions
diff --git a/lib/ssh/src/ssh_connection_handler.erl b/lib/ssh/src/ssh_connection_handler.erl
index 822ef8f8f9..926d4fddce 100644
--- a/lib/ssh/src/ssh_connection_handler.erl
+++ b/lib/ssh/src/ssh_connection_handler.erl
@@ -705,11 +705,19 @@ generate_event(<<?BYTE(Byte), _/binary>> = Msg, StateName,
Byte == ?SSH_MSG_CHANNEL_REQUEST;
Byte == ?SSH_MSG_CHANNEL_SUCCESS;
Byte == ?SSH_MSG_CHANNEL_FAILURE ->
- ssh_connection_manager:event(Pid, Msg),
- State = generate_event_new_state(State0, EncData),
- next_packet(State),
- {next_state, StateName, State};
+ try
+ ssh_connection_manager:event(Pid, Msg),
+ State = generate_event_new_state(State0, EncData),
+ next_packet(State),
+ {next_state, StateName, State}
+ catch
+ exit:{noproc, _Reason} ->
+ Report = io_lib:format("~p Connection Handler terminated: ~p~n",
+ [self(), Pid]),
+ error_logger:info_report(Report),
+ {stop, normal, State0}
+ end;
generate_event(Msg, StateName, State0, EncData) ->
Event = ssh_bits:decode(Msg),
State = generate_event_new_state(State0, EncData),