diff options
| author | nick <[email protected]> | 2010-09-03 12:52:02 +0200 |
|---|---|---|
| committer | nick <[email protected]> | 2010-09-03 12:52:02 +0200 |
| commit | 8f67f51105560f1c0e721117100cf20d0c6061c0 (patch) | |
| tree | d1c69b96672df5bf985914d9e3799168c41fdf82 /lib/ssh/src/ssh_connection_manager.erl | |
| parent | f0c4e27ef0a5a365cab7b1dc69dbecf7856c3f3f (diff) | |
| parent | fddc1ed0341d13df8373509fa063d889fab8d219 (diff) | |
| download | otp-8f67f51105560f1c0e721117100cf20d0c6061c0.tar.gz otp-8f67f51105560f1c0e721117100cf20d0c6061c0.tar.bz2 otp-8f67f51105560f1c0e721117100cf20d0c6061c0.zip | |
Merge branch 'nick/ssh/fix-process-leak/OTP-8807' into dev
* nick/ssh/fix-process-leak/OTP-8807:
Fix race condition when terminating a connection.
fix process leak in ssh_system_sup (dynamicaly created childs where not cleaned up)
Diffstat (limited to 'lib/ssh/src/ssh_connection_manager.erl')
| -rw-r--r-- | lib/ssh/src/ssh_connection_manager.erl | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/lib/ssh/src/ssh_connection_manager.erl b/lib/ssh/src/ssh_connection_manager.erl index 9e55312e5f..6bf89224cf 100644 --- a/lib/ssh/src/ssh_connection_manager.erl +++ b/lib/ssh/src/ssh_connection_manager.erl @@ -560,13 +560,18 @@ handle_info({'EXIT', _, _}, State) -> %% The return value is ignored. %%-------------------------------------------------------------------- terminate(Reason, #state{connection_state = - #connection{requests = Requests}, + #connection{requests = Requests, + sub_system_supervisor = SubSysSup}, opts = Opts}) -> SSHOpts = proplists:get_value(ssh_opts, Opts), disconnect_fun(Reason, SSHOpts), (catch lists:foreach(fun({_, From}) -> gen_server:reply(From, {error, connection_closed}) end, Requests)), + Address = proplists:get_value(address, Opts), + Port = proplists:get_value(port, Opts), + SystemSup = ssh_system_sup:system_supervisor(Address, Port), + ssh_system_sup:stop_subsystem(SystemSup, SubSysSup), ok. %%-------------------------------------------------------------------- |