Merge branch 'master' into sverk/hipe-line-table-bug/master/OTP-13282

1 files changed, 278 insertions, 121 deletions

diff --git a/lib/ssh/test/ssh_sftp_SUITE.erl b/lib/ssh/test/ssh_sftp_SUITE.erl
index c19ede296f..698af259c8 100644
--- a/lib/ssh/test/ssh_sftp_SUITE.erl
+++ b/lib/ssh/test/ssh_sftp_SUITE.erl
@@ -27,14 +27,9 @@
 -include_lib("common_test/include/ct.hrl").
 -include_lib("kernel/include/file.hrl").
 
-% Default timetrap timeout
+						% Default timetrap timeout
 -define(default_timeout, ?t:minutes(1)).
 
--define(USER, "Alladin").
--define(PASSWD, "Sesame").
-
--define(tar_file_name, "sftp_tar_test.tar").
-
 %%--------------------------------------------------------------------
 %% Common Test interface functions -----------------------------------
 %%--------------------------------------------------------------------
@@ -43,9 +38,8 @@ suite() ->
     [{ct_hooks,[ts_install_cth]}].
 
 all() -> 
-    [{group, erlang_server},
-     {group, openssh_server},
-     sftp_nonexistent_subsystem
+    [{group, not_unicode},
+     {group, unicode}
     ].
 
 
@@ -53,6 +47,8 @@ init_per_suite(Config) ->
     catch crypto:stop(),
     case (catch crypto:start()) of
 	ok ->
+	    ct:log("file:native_name_encoding() = ~p,~nio:getopts() = ~p",
+		   [file:native_name_encoding(),io:getopts()]),
 	    ssh:start(),
 	    Config;
 	_ ->
@@ -66,61 +62,137 @@ end_per_suite(Config) ->
 
 %%--------------------------------------------------------------------
 groups() -> 
-    [{erlang_server, [], [open_close_file, open_close_dir, read_file, read_dir,
-			  write_file, write_big_file, sftp_read_big_file,
-			  rename_file, mk_rm_dir, remove_file, links,
-			  retrieve_attributes, set_attributes, async_read,
-			  async_write, position, pos_read, pos_write, version_option,
+    [{not_unicode, [], [{group,erlang_server},
+			{group,openssh_server},
+			sftp_nonexistent_subsystem]},
+
+     {unicode, [], [{group,erlang_server},
+		    {group,openssh_server},
+		    sftp_nonexistent_subsystem]},
+
+     {erlang_server, [], [{group,write_read_tests},
+			  version_option,
 			  {group,remote_tar}]},
 
-     {openssh_server, [], [open_close_file, open_close_dir, read_file, read_dir,
-			   write_file, write_big_file, sftp_read_big_file,
-			   rename_file, mk_rm_dir, remove_file, links,
-			   retrieve_attributes, set_attributes, async_read,
-			   async_write, position, pos_read, pos_write,
+     {openssh_server, [], [{group,write_read_tests},
 			   {group,remote_tar}]},
 
-     {remote_tar, [], [create_empty_tar, files_to_tar, big_file_to_tar, files_chunked_to_tar,
+     {remote_tar, [], [create_empty_tar, 
+		       ascii_filename_ascii_contents_to_tar,
+		       ascii_filename_unicode_contents_to_tar,
+		       unicode_filename_ascii_contents_to_tar,
+		       files_to_tar,
+		       big_file_to_tar, files_chunked_to_tar,
 		       directory_to_tar, binaries_to_tar, null_crypto_tar, 
 		       simple_crypto_tar_small, simple_crypto_tar_big,
 		       read_tar, read_null_crypto_tar, read_crypto_tar, 
 		       aes_cbc256_crypto_tar, aes_ctr_stream_crypto_tar
-		      ]}
+		      ]},
+
+     {write_read_tests, [], [open_close_file, open_close_dir, read_file, read_dir,
+			     write_file, write_file_iolist, write_big_file, sftp_read_big_file,
+			     rename_file, mk_rm_dir, remove_file, links,
+			     retrieve_attributes, set_attributes, async_read,
+			     async_write, position, pos_read, pos_write
+			    ]}
     ].
-     
+
+init_per_group(not_unicode, Config) ->
+    ct:comment("Begin ~p",[grps(Config)]),
+    DataDir = ?config(data_dir, Config),
+    PrivDir = ?config(priv_dir, Config),
+    [{user, "Alladin"},
+     {passwd, "Sesame"},
+     {data, <<"Hello world!">>},
+     {filename, filename:join(PrivDir, "sftp.txt")},
+     {testfile, filename:join(PrivDir, "test.txt")},
+     {linktest, filename:join(PrivDir, "link_test.txt")},
+     {tar_filename, filename:join(PrivDir,  "sftp_tar_test.tar")},
+     {tar_F1_txt, "f1.txt"},
+     {datadir_tar, filename:join(DataDir,"sftp_tar_test_data")}
+     | Config];
+
+init_per_group(unicode, Config) ->
+    case file:native_name_encoding() of
+	utf8 ->
+	    ct:comment("Begin ~p",[grps(Config)]),
+	    DataDir = ?config(data_dir, Config),
+	    PrivDir = ?config(priv_dir, Config),
+	    NewConfig =
+		[{user, "åke高兴"},
+		 {passwd, "ärlig日本じん"},
+		 {data, <<"foobar å 一二三四いちにさんち">>},
+		 {filename, filename:join(PrivDir, "sftp瑞点.txt")},
+		 {testfile, filename:join(PrivDir, "testハンス.txt")},
+		 {linktest, filename:join(PrivDir, "link_test語.txt")},
+		 {tar_filename, filename:join(PrivDir,  "sftp_tar_test一二三.tar")},
+		 {tar_F1_txt, "F一.txt"},
+		 {tar_F3_txt, "f3.txt"},
+		 {tar_F4_txt, "g四.txt"},
+		 {datadir_tar, filename:join(DataDir,"sftp_tar_test_data_高兴")}
+		 | lists:foldl(fun(K,Cf) -> lists:keydelete(K,1,Cf) end, 
+			       Config,
+			       [user, passwd, data,
+				filename, testfile, linktest,
+				tar_filename, tar_F1_txt, datadir_tar
+			       ]
+			      )
+		],
+	    FN = fn(?config(tar_F1_txt,NewConfig), NewConfig),
+	    case catch file:read_file(FN) of
+		{ok,FN_contents} ->
+		    ct:log("Readable file:read_file(~tp) ->~n~tp",[FN,FN_contents]),
+		    NewConfig;
+		Other ->
+		    ct:log("Unreadable file:read_file(~tp) ->~n~p",[FN,Other]),
+		    {skip, "Not unicode file reading"}
+	    end;
+
+	_ ->
+	    {skip, "Not unicode file encoding"}
+    end;
 
 init_per_group(erlang_server, Config) ->
+    ct:comment("Begin ~p",[grps(Config)]),
     PrivDir = ?config(priv_dir, Config),
     SysDir =  ?config(data_dir, Config),
+    User = ?config(user, Config),
+    Passwd = ?config(passwd, Config),
     Sftpd = {_, HostX, PortX} =
 	ssh_test_lib:daemon([{system_dir, SysDir},
 			     {user_dir, PrivDir},
 			     {user_passwords,
-			      [{?USER, ?PASSWD}]}]),
+			      [{User, Passwd}]}]),
     [{peer, {fmt_host(HostX),PortX}}, {group, erlang_server}, {sftpd, Sftpd} | Config];
 
 init_per_group(openssh_server, Config) ->
+    ct:comment("Begin ~p",[grps(Config)]),
     Host = ssh_test_lib:hostname(),
-    case (catch ssh_sftp:start_channel(Host,					      
+    case (catch ssh_sftp:start_channel(Host,
 				       [{user_interaction, false},
 					{silently_accept_hosts, true}])) of
 	{ok, _ChannelPid, Connection} ->
 	    [{peer, {_HostName,{IPx,Portx}}}] = ssh:connection_info(Connection,[peer]),
 	    ssh:close(Connection),
 	    [{peer, {fmt_host(IPx),Portx}}, {group, openssh_server} | Config];
+	{error,"Key exchange failed"} ->
+	    {skip, "openssh server doesn't support the tested kex algorithm"};
 	_ ->
 	    {skip, "No openssh server"} 
     end;
 
 init_per_group(remote_tar, Config) ->
+    ct:comment("Begin ~p",[grps(Config)]),
     {Host,Port} =  ?config(peer, Config),
     ct:log("Server (~p) at ~p:~p",[?config(group,Config),Host,Port]),
+    User = ?config(user, Config),
+    Passwd = ?config(passwd, Config),
     {ok, Connection} =
 	case ?config(group, Config) of
 	    erlang_server ->
 		ssh:connect(Host, Port,
-			    [{user, ?USER},
-			     {password, ?PASSWD},
+			    [{user, User},
+			     {password, Passwd},
 			     {user_interaction, false},
 			     {silently_accept_hosts, true}]);
 	    openssh_server ->
@@ -129,11 +201,23 @@ init_per_group(remote_tar, Config) ->
 			     {silently_accept_hosts, true}])
 	end,
     [{remote_tar, true}, 
-     {connection, Connection} | Config].
+     {connection, Connection} | Config];
+
+init_per_group(write_read_tests, Config) ->
+    ct:comment("Begin ~p",[grps(Config)]),
+    Config.
+
+grps(Config) ->
+    proplists:get_all_values(
+      name, 
+      lists:flatten([proplists:get_value(tc_group_properties,Config,[]),
+		     proplists:get_value(tc_group_path,Config,[])])).
 
 end_per_group(erlang_server, Config) ->
+    ct:comment("End ~p",[grps(Config)]),
     Config;
 end_per_group(_, Config) ->
+    ct:comment("End ~p",[grps(Config)]),
     Config.
 
 %%--------------------------------------------------------------------
@@ -141,11 +225,13 @@ end_per_group(_, Config) ->
 init_per_testcase(sftp_nonexistent_subsystem, Config) ->
     PrivDir = ?config(priv_dir, Config),
     SysDir =  ?config(data_dir, Config),
+    User = ?config(user, Config),
+    Passwd = ?config(passwd, Config),
     Sftpd = ssh_test_lib:daemon([{system_dir, SysDir},
 				 {user_dir, PrivDir},
 				 {subsystems, []},
 				 {user_passwords,
-				  [{?USER, ?PASSWD}]}
+				  [{User, Passwd}]}
 				]),
     [{sftpd, Sftpd} | Config];
 
@@ -155,11 +241,13 @@ init_per_testcase(version_option, Config) ->
     TmpConfig = lists:keydelete(sftp, 1, TmpConfig0),
     Dog = ct:timetrap(?default_timeout),
     {_,Host, Port} =  ?config(sftpd, Config),
+    User = ?config(user, Config),
+    Passwd = ?config(passwd, Config),
     {ok, ChannelPid, Connection}  = 
 	ssh_sftp:start_channel(Host, Port,
 			       [{sftp_vsn, 3},
-				{user, ?USER},
-				{password, ?PASSWD},
+				{user, User},
+				{password, Passwd},
 				{user_interaction, false},
 				{silently_accept_hosts, true}]),
     Sftp = {ChannelPid, Connection},
@@ -169,7 +257,9 @@ init_per_testcase(Case, Config0) ->
     prep(Config0),
     Config1 = lists:keydelete(watchdog, 1, Config0),
     Config2 = lists:keydelete(sftp, 1, Config1),
-    Dog = ct:timetrap(?default_timeout),
+    Dog = ct:timetrap(2 * ?default_timeout),
+    User = ?config(user, Config0),
+    Passwd = ?config(passwd, Config0),
 
     Config =
 	case ?config(group,Config2) of
@@ -177,10 +267,11 @@ init_per_testcase(Case, Config0) ->
 		{_,Host, Port} =  ?config(sftpd, Config2),
 		{ok, ChannelPid, Connection}  = 
 		    ssh_sftp:start_channel(Host, Port,
-					   [{user, ?USER},
-					    {password, ?PASSWD},
+					   [{user, User},
+					    {password, Passwd},
 					    {user_interaction, false},
-					    {silently_accept_hosts, true}]),
+					    {silently_accept_hosts, true}]
+					  ),
 		Sftp = {ChannelPid, Connection},
 		[{sftp, Sftp}, {watchdog, Dog} | Config2];
 	    openssh_server when Case == links ->
@@ -208,8 +299,7 @@ init_per_testcase(Case, Config0) ->
 end_per_testcase(sftp_nonexistent_subsystem, Config) ->
     Config;
 end_per_testcase(rename_file, Config) ->
-    PrivDir = ?config(priv_dir, Config),
-    NewFileName = filename:join(PrivDir, "test.txt"),
+    NewFileName = ?config(testfile, Config),
     file:delete(NewFileName),  
     end_per_testcase(Config);
 end_per_testcase(_, Config) ->
@@ -227,8 +317,7 @@ end_per_testcase(Config) ->
 open_close_file() ->
     [{doc, "Test API functions open/3 and close/2"}].
 open_close_file(Config) when is_list(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "sftp.txt"),
+    FileName = ?config(filename, Config),
 
     {Sftp, _} = ?config(sftp, Config),
 
@@ -249,7 +338,7 @@ open_close_dir() ->
 open_close_dir(Config) when is_list(Config) ->
     PrivDir = ?config(priv_dir, Config),
     {Sftp, _} = ?config(sftp, Config),
-    FileName = filename:join(PrivDir, "sftp.txt"),
+    FileName = ?config(filename, Config),
 
     {ok, Handle} = ssh_sftp:opendir(Sftp, PrivDir),
     ok = ssh_sftp:close(Sftp, Handle),
@@ -259,8 +348,7 @@ open_close_dir(Config) when is_list(Config) ->
 read_file() ->
     [{doc, "Test API funtion read_file/2"}].
 read_file(Config) when is_list(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "sftp.txt"),
+    FileName = ?config(filename, Config),
     {Sftp, _} = ?config(sftp, Config),
     {ok, Data} = ssh_sftp:read_file(Sftp, FileName),
     {ok, Data} = ssh_sftp:read_file(Sftp, FileName),
@@ -273,14 +361,13 @@ read_dir(Config) when is_list(Config) ->
     PrivDir = ?config(priv_dir, Config),
     {Sftp, _} = ?config(sftp, Config),
     {ok, Files} = ssh_sftp:list_dir(Sftp, PrivDir),
-    ct:pal("sftp list dir: ~p~n", [Files]).
+    ct:log("sftp list dir: ~p~n", [Files]).
 
 %%--------------------------------------------------------------------
 write_file() ->
     [{doc, "Test API function write_file/2"}].
 write_file(Config) when is_list(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "sftp.txt"),
+    FileName = ?config(filename, Config),
     {Sftp, _} = ?config(sftp, Config),
 
     Data = list_to_binary("Hej hopp!"),
@@ -288,11 +375,31 @@ write_file(Config) when is_list(Config) ->
     {ok, Data} = file:read_file(FileName).
 
 %%--------------------------------------------------------------------
+write_file_iolist() ->
+    [{doc, "Test API function write_file/2 with iolists"}].
+write_file_iolist(Config) when is_list(Config) ->
+    FileName = ?config(filename, Config),
+    {Sftp, _} = ?config(sftp, Config),
+
+    Data = list_to_binary("Hej hopp!"),
+    lists:foreach(
+      fun(D) ->
+	      ssh_sftp:write_file(Sftp, FileName, [D]),
+	      Expected = if is_binary(D) -> D;
+			    is_list(D) -> list_to_binary(D)
+			 end,
+	      {ok, Expected} = file:read_file(FileName)
+      end,
+      [Data, [Data,Data], [[Data],[Data]], [[[Data]],[[[[Data]],Data]]],
+       [[[[Data]],Data],binary_to_list(Data)],
+       [[[[Data]],Data],[[binary_to_list(Data)],[[binary_to_list(Data)]]]]
+      ]).
+
+%%--------------------------------------------------------------------
 write_big_file() ->
     [{doc, "Test API function write_file/2 with big data"}].
 write_big_file(Config) when is_list(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "sftp.txt"),
+    FileName = ?config(filename, Config),
     {Sftp, _} = ?config(sftp, Config),
 
     Data = list_to_binary(lists:duplicate(750000,"a")),
@@ -303,8 +410,7 @@ write_big_file(Config) when is_list(Config) ->
 sftp_read_big_file() ->
     [{doc, "Test API function read_file/2 with big data"}].
 sftp_read_big_file(Config) when is_list(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "sftp.txt"),
+    FileName = ?config(filename, Config),
     {Sftp, _} = ?config(sftp, Config),
 
     Data = list_to_binary(lists:duplicate(750000,"a")),
@@ -317,7 +423,7 @@ remove_file() ->
     [{doc,"Test API function delete/2"}].
 remove_file(Config) when is_list(Config) ->
     PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "sftp.txt"),
+    FileName = ?config(filename, Config),
     {Sftp, _} = ?config(sftp, Config),
 
     {ok, Files} = ssh_sftp:list_dir(Sftp, PrivDir),
@@ -331,17 +437,17 @@ rename_file() ->
     [{doc, "Test API function rename_file/2"}].
 rename_file(Config) when is_list(Config) ->
     PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "sftp.txt"),
-    NewFileName = filename:join(PrivDir, "test.txt"),
+    FileName = ?config(filename, Config),
+    NewFileName = ?config(testfile, Config),
 
     {Sftp, _} = ?config(sftp, Config),
     {ok, Files} = ssh_sftp:list_dir(Sftp, PrivDir),
-    ct:pal("FileName: ~p, Files: ~p~n", [FileName, Files]),
+    ct:log("FileName: ~p, Files: ~p~n", [FileName, Files]),
     true = lists:member(filename:basename(FileName), Files),
     false = lists:member(filename:basename(NewFileName), Files),
     ok = ssh_sftp:rename(Sftp, FileName, NewFileName),
     {ok, NewFiles} = ssh_sftp:list_dir(Sftp, PrivDir),
-    ct:pal("FileName: ~p, Files: ~p~n", [FileName, NewFiles]),
+    ct:log("FileName: ~p, Files: ~p~n", [FileName, NewFiles]),
 
     false = lists:member(filename:basename(FileName), NewFiles),
     true = lists:member(filename:basename(NewFileName), NewFiles).
@@ -352,7 +458,7 @@ mk_rm_dir() ->
 mk_rm_dir(Config) when is_list(Config) ->
     PrivDir = ?config(priv_dir, Config),
     {Sftp, _} = ?config(sftp, Config),
- 
+
     DirName = filename:join(PrivDir, "test"),
     ok = ssh_sftp:make_dir(Sftp, DirName),
     ok = ssh_sftp:del_dir(Sftp, DirName),
@@ -369,9 +475,8 @@ links(Config) when is_list(Config) ->
 	    {skip, "Links are not fully supported by windows"};
 	_ ->
 	    {Sftp, _} = ?config(sftp, Config),
-	    PrivDir =  ?config(priv_dir, Config),
-	    FileName = filename:join(PrivDir, "sftp.txt"),
-	    LinkFileName = filename:join(PrivDir, "link_test.txt"),
+	    FileName = ?config(filename, Config),
+	    LinkFileName = ?config(linktest, Config),
 
 	    ok = ssh_sftp:make_symlink(Sftp, LinkFileName, FileName),
 	    {ok, FileName} = ssh_sftp:read_link(Sftp, LinkFileName)
@@ -381,22 +486,20 @@ links(Config) when is_list(Config) ->
 retrieve_attributes() ->
     [{doc, "Test API function read_file_info/3"}].
 retrieve_attributes(Config) when is_list(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "sftp.txt"),
+    FileName = ?config(filename, Config),
 
     {Sftp, _} = ?config(sftp, Config),
     {ok, FileInfo} = ssh_sftp:read_file_info(Sftp, FileName),
     {ok, NewFileInfo} = file:read_file_info(FileName),
 
     %% TODO comparison. There are some differences now is that ok?
-    ct:pal("SFTP: ~p   FILE: ~p~n", [FileInfo, NewFileInfo]).
+    ct:log("SFTP: ~p   FILE: ~p~n", [FileInfo, NewFileInfo]).
 
 %%--------------------------------------------------------------------
 set_attributes() ->
     [{doc,"Test API function write_file_info/3"}].
 set_attributes(Config) when is_list(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "test.txt"),
+    FileName = ?config(testfile, Config),
 
     {Sftp, _} = ?config(sftp, Config),
     {ok,Fd} = file:open(FileName, write),
@@ -412,26 +515,26 @@ async_read() ->
     [{doc,"Test API aread/3"}].
 async_read(Config) when is_list(Config) ->
     {Sftp, _} = ?config(sftp, Config),
-    PrivDir =  ?config(priv_dir, Config),
 
-    FileName = filename:join(PrivDir, "sftp.txt"),
+    FileName = ?config(filename, Config),
     {ok, Handle} = ssh_sftp:open(Sftp, FileName, [read]),
     {async, Ref} = ssh_sftp:aread(Sftp, Handle, 20),
 
     receive
 	{async_reply, Ref, {ok, Data}} ->
-	    ct:pal("Data: ~p~n", [Data]),
+	    ct:log("Data: ~p~n", [Data]),
 	    ok;
 	Msg ->
 	    ct:fail(Msg)
+    after 
+	30000 -> ct:fail("timeout ~p:~p",[?MODULE,?LINE])
     end.
 %%--------------------------------------------------------------------
 async_write() ->
     [{doc,"Test API awrite/3"}].
 async_write(Config) when is_list(Config) ->
     {Sftp, _} = ?config(sftp, Config),
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "test.txt"),
+    FileName = ?config(testfile, Config),
     {ok, Handle} = ssh_sftp:open(Sftp, FileName, [write]),
     Data = list_to_binary("foobar"),
     {async, Ref} = ssh_sftp:awrite(Sftp, Handle, Data),
@@ -448,8 +551,7 @@ async_write(Config) when is_list(Config) ->
 position() ->
     [{doc, "Test API functions position/3"}].
 position(Config) when is_list(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "test.txt"),
+    FileName = ?config(testfile, Config),
     {Sftp, _} = ?config(sftp, Config),
 
     Data = list_to_binary("1234567890"),
@@ -478,8 +580,7 @@ position(Config) when is_list(Config) ->
 pos_read() ->
     [{doc,"Test API functions pread/3 and apread/3"}].
 pos_read(Config) when is_list(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "test.txt"),
+    FileName = ?config(testfile, Config),
     {Sftp, _} = ?config(sftp, Config),
     Data = list_to_binary("Hej hopp!"),
     ssh_sftp:write_file(Sftp, FileName, [Data]),
@@ -494,6 +595,8 @@ pos_read(Config) when is_list(Config) ->
 	    ok;
 	Msg ->
 	    ct:fail(Msg)
+    after 
+	30000 -> ct:fail("timeout ~p:~p",[?MODULE,?LINE])
     end,
 
     NewData1  = "hopp",
@@ -504,8 +607,7 @@ pos_read(Config) when is_list(Config) ->
 pos_write() ->
     [{doc,"Test API functions pwrite/4 and apwrite/4"}].
 pos_write(Config) when is_list(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    FileName = filename:join(PrivDir, "test.txt"),
+    FileName = ?config(testfile, Config),
     {Sftp, _} = ?config(sftp, Config),
 
     {ok, Handle} = ssh_sftp:open(Sftp, FileName, [write]),
@@ -520,6 +622,8 @@ pos_write(Config) when is_list(Config) ->
 	    ok;
 	Msg ->
 	    ct:fail(Msg)
+    after 
+	30000 -> ct:fail("timeout ~p:~p",[?MODULE,?LINE])
     end,
 
     ok = ssh_sftp:pwrite(Sftp, Handle, eof, list_to_binary("!")),
@@ -532,10 +636,13 @@ sftp_nonexistent_subsystem() ->
     [{doc, "Try to execute sftp subsystem on a server that does not support it"}].
 sftp_nonexistent_subsystem(Config) when is_list(Config) ->
     {_,Host, Port} =  ?config(sftpd, Config),
+    User = ?config(user, Config),
+    Passwd = ?config(passwd, Config),
     {error,"server failed to start sftp subsystem"} =
 	ssh_sftp:start_channel(Host, Port,
 			       [{user_interaction, false},
-				{user, ?USER}, {password, ?PASSWD},
+				{user, User},
+				{password, Passwd},
 				{silently_accept_hosts, true}]).
 
 %%--------------------------------------------------------------------
@@ -547,25 +654,66 @@ version_option(Config) when is_list(Config) ->
 %%--------------------------------------------------------------------
 create_empty_tar(Config) ->
     ChPid2 = ?config(channel_pid2, Config),
-    {ok,Handle} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write]),
     erl_tar:close(Handle),
     {ChPid,_} = ?config(sftp,Config),
     {ok, #file_info{type=regular}} =
-	ssh_sftp:read_file_info(ChPid,fnp(?tar_file_name,Config)).
+	ssh_sftp:read_file_info(ChPid, TarFileName).
 
 %%--------------------------------------------------------------------
 files_to_tar(Config) ->
     ChPid2 = ?config(channel_pid2, Config),
-    {ok,Handle} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write]),
-    ok = erl_tar:add(Handle, fn("f1.txt",Config), "f1.txt", [verbose]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write]),
+    F1 = ?config(tar_F1_txt, Config),
+    ok = erl_tar:add(Handle, fn(F1,Config), F1, [verbose]),
+    ok = erl_tar:add(Handle, fn("f2.txt",Config), "f2.txt", [verbose]),
+    ok = erl_tar:close(Handle),
+    chk_tar([F1, "f2.txt"], Config).
+
+%%--------------------------------------------------------------------
+ascii_filename_ascii_contents_to_tar(Config) ->
+    ChPid2 = ?config(channel_pid2, Config),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write]),
     ok = erl_tar:add(Handle, fn("f2.txt",Config), "f2.txt", [verbose]),
     ok = erl_tar:close(Handle),
-    chk_tar(["f1.txt", "f2.txt"], Config).
+    chk_tar(["f2.txt"], Config).
+
+%%--------------------------------------------------------------------
+ascii_filename_unicode_contents_to_tar(Config) ->
+    case ?config(tar_F3_txt, Config) of
+	undefined ->
+	    {skip, "Unicode test"};
+	Fn ->
+	    ChPid2 = ?config(channel_pid2, Config),
+	    TarFileName = ?config(tar_filename, Config),
+	    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write]),
+	    ok = erl_tar:add(Handle, fn(Fn,Config), Fn, [verbose]),
+	    ok = erl_tar:close(Handle),
+	    chk_tar([Fn], Config)
+    end.
+
+%%--------------------------------------------------------------------
+unicode_filename_ascii_contents_to_tar(Config) ->
+    case ?config(tar_F4_txt, Config) of
+	undefined ->
+	    {skip, "Unicode test"};
+	Fn ->
+	    ChPid2 = ?config(channel_pid2, Config),
+	    TarFileName = ?config(tar_filename, Config),
+	    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write]),
+	    ok = erl_tar:add(Handle, fn(Fn,Config), Fn, [verbose]),
+	    ok = erl_tar:close(Handle),
+	    chk_tar([Fn], Config)
+    end.
 
 %%--------------------------------------------------------------------
 big_file_to_tar(Config) ->
     ChPid2 = ?config(channel_pid2, Config),
-    {ok,Handle} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write]), 
+    TarFileName = ?config(tar_filename, Config),
+    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write]), 
     ok = erl_tar:add(Handle, fn("big.txt",Config), "big.txt", [verbose]),
     ok = erl_tar:close(Handle),
     chk_tar(["big.txt"], Config).
@@ -574,23 +722,27 @@ big_file_to_tar(Config) ->
 %%--------------------------------------------------------------------
 files_chunked_to_tar(Config) ->
     ChPid2 = ?config(channel_pid2, Config),
-    {ok,Handle} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write]),
-    ok = erl_tar:add(Handle, fn("f1.txt",Config), "f1.txt", [verbose,{chunks,2}]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write]),
+    F1 = ?config(tar_F1_txt, Config),
+    ok = erl_tar:add(Handle, fn(F1,Config), F1, [verbose,{chunks,2}]),
     ok = erl_tar:close(Handle),
-    chk_tar(["f1.txt"], Config).
+    chk_tar([F1], Config).
 
 %%--------------------------------------------------------------------
 directory_to_tar(Config) ->
     ChPid2 = ?config(channel_pid2, Config),
-    {ok,Handle} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write]),
     ok = erl_tar:add(Handle, fn("d1",Config), "d1", [verbose]),
     ok = erl_tar:close(Handle),
     chk_tar(["d1"], Config).
-    
+
 %%--------------------------------------------------------------------
 binaries_to_tar(Config) ->
     ChPid2 = ?config(channel_pid2, Config),
-    {ok,Handle} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write]),
     Bin = <<"A binary">>,
     ok = erl_tar:add(Handle, Bin, "b1", [verbose]),
     ok = erl_tar:close(Handle),
@@ -603,13 +755,15 @@ null_crypto_tar(Config) ->
     Cenc = fun(Bin,CState) -> {ok,Bin,CState,_SendSize=5} end,
     Cend = fun(Bin,_CState) -> {ok,Bin} end,
     C = {Cinit,Cenc,Cend},
-    {ok,Handle} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write,{crypto,C}]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write,{crypto,C}]),
     Bin = <<"A binary">>,
+    F1 = ?config(tar_F1_txt, Config),
     ok = erl_tar:add(Handle, Bin, "b1", [verbose]),
-    ok = erl_tar:add(Handle, fn("f1.txt",Config), "f1.txt", [verbose,{chunks,2}]),
+    ok = erl_tar:add(Handle, fn(F1,Config), F1, [verbose,{chunks,2}]),
     ok = erl_tar:add(Handle, fn("big.txt",Config), "big.txt", [verbose,{chunks,15000}]),
     ok = erl_tar:close(Handle),
-    chk_tar([{"b1",Bin}, "f1.txt", "big.txt"], Config).
+    chk_tar([{"b1",Bin}, F1, "big.txt"], Config).
 
 %%--------------------------------------------------------------------
 simple_crypto_tar_small(Config) ->
@@ -619,12 +773,14 @@ simple_crypto_tar_small(Config) ->
     Cdec = fun(Bin,CState) -> {ok,unstuff(Bin),CState,_Size=4} end,
     Cend = fun(Bin,_CState) -> {ok,stuff(Bin)} end,
     C = {Cinit,Cenc,Cend},
-    {ok,Handle} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write,{crypto,C}]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write,{crypto,C}]),
     Bin = <<"A binary">>,
+    F1 = ?config(tar_F1_txt, Config),
     ok = erl_tar:add(Handle, Bin, "b1", [verbose]),
-    ok = erl_tar:add(Handle, fn("f1.txt",Config), "f1.txt", [verbose,{chunks,2}]),
+    ok = erl_tar:add(Handle, fn(F1,Config), F1, [verbose,{chunks,2}]),
     ok = erl_tar:close(Handle),
-    chk_tar([{"b1",Bin}, "f1.txt"], Config, [{crypto,{Cinit,Cdec}}]).
+    chk_tar([{"b1",Bin}, F1], Config, [{crypto,{Cinit,Cdec}}]).
 
 %%--------------------------------------------------------------------
 simple_crypto_tar_big(Config) ->
@@ -634,18 +790,20 @@ simple_crypto_tar_big(Config) ->
     Cdec = fun(Bin,CState) -> {ok,unstuff(Bin),CState,_SendSize=4} end,
     Cend = fun(Bin,_CState) -> {ok,stuff(Bin)} end,
     C = {Cinit,Cenc,Cend},
-    {ok,Handle} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write,{crypto,C}]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,Handle} = ssh_sftp:open_tar(ChPid2, TarFileName, [write,{crypto,C}]),
     Bin = <<"A binary">>,
+    F1 = ?config(tar_F1_txt, Config),
     ok = erl_tar:add(Handle, Bin, "b1", [verbose]),
-    ok = erl_tar:add(Handle, fn("f1.txt",Config), "f1.txt", [verbose,{chunks,2}]),
+    ok = erl_tar:add(Handle, fn(F1,Config), F1, [verbose,{chunks,2}]),
     ok = erl_tar:add(Handle, fn("big.txt",Config), "big.txt", [verbose,{chunks,15000}]),
     ok = erl_tar:close(Handle),
-    chk_tar([{"b1",Bin}, "f1.txt", "big.txt"], Config, [{crypto,{Cinit,Cdec}}]).
+    chk_tar([{"b1",Bin}, F1, "big.txt"], Config, [{crypto,{Cinit,Cdec}}]).
 
 stuff(Bin) -> << <<C,C>> || <<C>> <= Bin >>.
-    
+
 unstuff(Bin) -> << <<C>> || <<C,C>> <= Bin >>.
-     
+
 %%--------------------------------------------------------------------
 read_tar(Config) ->
     ChPid2 = ?config(channel_pid2, Config),
@@ -653,7 +811,8 @@ read_tar(Config) ->
 		 [{"b1",<<"A binary">>},
 		  {"b2",list_to_binary(lists:duplicate(750000,"a"))}
 		 ]),
-    {ok,HandleWrite} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,HandleWrite} = ssh_sftp:open_tar(ChPid2, TarFileName, [write]),
     [ok = erl_tar:add(HandleWrite, Bin, Name, [verbose])
      ||	{Name,Bin} <- NameBins],
     ok = erl_tar:close(HandleWrite),
@@ -675,7 +834,8 @@ read_null_crypto_tar(Config) ->
     Cw = {Cinitw,Cenc,Cendw},
     Cr = {Cinitr,Cdec},
 
-    {ok,HandleWrite} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write,{crypto,Cw}]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,HandleWrite} = ssh_sftp:open_tar(ChPid2, TarFileName, [write,{crypto,Cw}]),
     [ok = erl_tar:add(HandleWrite, Bin, Name, [verbose])
      ||	{Name,Bin} <- NameBins],
     ok = erl_tar:close(HandleWrite),
@@ -698,7 +858,8 @@ read_crypto_tar(Config) ->
     Cw = {Cinitw,Cenc,Cendw},
     Cr = {Cinitr,Cdec},
 
-    {ok,HandleWrite} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write,{crypto,Cw}]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,HandleWrite} = ssh_sftp:open_tar(ChPid2, TarFileName, [write,{crypto,Cw}]),
     [ok = erl_tar:add(HandleWrite, Bin, Name, [verbose])
      ||	{Name,Bin} <- NameBins],
     ok = erl_tar:close(HandleWrite),
@@ -737,7 +898,8 @@ aes_cbc256_crypto_tar(Config) ->
 	    end,
 
     Cw = {Cinitw,Cenc,Cendw},
-    {ok,HandleWrite} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write,{crypto,Cw}]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,HandleWrite} = ssh_sftp:open_tar(ChPid2, TarFileName, [write,{crypto,Cw}]),
     [ok = erl_tar:add(HandleWrite, Bin, Name, [verbose]) || {Name,Bin} <- NameBins],
     ok = erl_tar:close(HandleWrite),
 
@@ -779,7 +941,8 @@ aes_ctr_stream_crypto_tar(Config) ->
 	    end,
 
     Cw = {Cinitw,Cenc,Cendw},
-    {ok,HandleWrite} = ssh_sftp:open_tar(ChPid2, fnp(?tar_file_name,Config), [write,{crypto,Cw}]),
+    TarFileName = ?config(tar_filename, Config),
+    {ok,HandleWrite} = ssh_sftp:open_tar(ChPid2, TarFileName, [write,{crypto,Cw}]),
     [ok = erl_tar:add(HandleWrite, Bin, Name, [verbose]) || {Name,Bin} <- NameBins],
     ok = erl_tar:close(HandleWrite),
 
@@ -790,18 +953,18 @@ aes_ctr_stream_crypto_tar(Config) ->
 %% Internal functions ------------------------------------------------
 %%--------------------------------------------------------------------
 prep(Config) ->
-    PrivDir =  ?config(priv_dir, Config),
-    TestFile = filename:join(PrivDir, "sftp.txt"),
-    TestFile1 = filename:join(PrivDir, "test.txt"),
-    TestLink = filename:join(PrivDir, "link_test.txt"),
+    DataDir =  ?config(data_dir, Config),
+    TestFile = ?config(filename, Config),
+    TestFile1 = ?config(testfile, Config),
+    TestLink = ?config(linktest, Config),
+    TarFileName = ?config(tar_filename, Config),
 
     file:delete(TestFile),
     file:delete(TestFile1),
     file:delete(TestLink),
-    file:delete(fnp(?tar_file_name,Config)),
+    file:delete(TarFileName),
 
     %% Initial config
-    DataDir = ?config(data_dir, Config),
     FileName = filename:join(DataDir, "sftp.txt"),
     file:copy(FileName, TestFile),
     Mode = 8#00400 bor 8#00200 bor 8#00040, % read & write owner, read group
@@ -809,13 +972,12 @@ prep(Config) ->
     ok = file:write_file_info(TestFile,
 			      FileInfo#file_info{mode = Mode}).
 
-
-
 chk_tar(Items, Config) ->
     chk_tar(Items, Config, []).
 
 chk_tar(Items, Config, Opts) ->
-    chk_tar(Items, fnp(?tar_file_name,Config), Config, Opts).
+    TarFileName = ?config(tar_filename, Config),
+    chk_tar(Items, TarFileName, Config, Opts).
 
 chk_tar(Items, TarFileName, Config, Opts)  when is_list(Opts) ->
     tar_size(TarFileName, Config),
@@ -846,7 +1008,7 @@ analyze_report([E={NameE,BinE}|Es], [A={NameA,BinA}|As]) ->
 	NameE < NameA ->
 	    [["Component ",NameE," is missing.\n\n"]
 	     | analyze_report(Es,[A|As])];
-	
+
 	NameE > NameA ->
 	    [["Component ",NameA," is not expected.\n\n"]
 	     | analyze_report([E|Es],As)];
@@ -859,7 +1021,7 @@ analyze_report([], [{NameA,_BinA}|As]) ->
     [["Component ",NameA," not expected.\n\n"] | analyze_report([],As)];
 analyze_report([], []) ->
     "".
-	
+
 tar_size(TarFileName, Config) ->
     {ChPid,_} = ?config(sftp,Config),
     {ok,Data} = ssh_sftp:read_file(ChPid, TarFileName),
@@ -888,14 +1050,9 @@ read_item_contents(ItemName, FileName) ->
     end.
 
 fn(Name, Config) ->
-    Dir = ?config(data_dir, Config),
-    filename:join([Dir,"sftp_tar_test_data",Name]).
-
-fnp(Name, Config) ->
-    Dir = ?config(priv_dir, Config),
-    filename:join([Dir,Name]).
-
+    Dir = ?config(datadir_tar, Config),
+    filename:join(Dir,Name).
 
 fmt_host({A,B,C,D}) -> lists:concat([A,".",B,".",C,".",D]);
 fmt_host(S) -> S.
-    
+