diff options
author | Hans Nilsson <[email protected]> | 2016-05-02 13:10:11 +0200 |
---|---|---|
committer | Hans Nilsson <[email protected]> | 2016-05-02 13:10:11 +0200 |
commit | 857a1d4b17508608241e10315f17988cf2d22ecc (patch) | |
tree | 3542e6dee0f802baae8bcb0ed7100c89b3b331b0 /lib/ssh/test | |
parent | 7cc731c30c4701251fec17d93a88ce2a8739b5b1 (diff) | |
parent | 6282a81eca93e015445e04d09be9ac7854bb96d6 (diff) | |
download | otp-857a1d4b17508608241e10315f17988cf2d22ecc.tar.gz otp-857a1d4b17508608241e10315f17988cf2d22ecc.tar.bz2 otp-857a1d4b17508608241e10315f17988cf2d22ecc.zip |
Merge branch 'hans/ssh/daemon_port_0/OTP-13527'
Conflicts:
lib/ssh/test/ssh_test_lib.erl
Diffstat (limited to 'lib/ssh/test')
-rw-r--r-- | lib/ssh/test/ssh_sftpd_SUITE.erl | 7 | ||||
-rw-r--r-- | lib/ssh/test/ssh_test_lib.erl | 14 |
2 files changed, 14 insertions, 7 deletions
diff --git a/lib/ssh/test/ssh_sftpd_SUITE.erl b/lib/ssh/test/ssh_sftpd_SUITE.erl index fb1a9687af..9385bd127d 100644 --- a/lib/ssh/test/ssh_sftpd_SUITE.erl +++ b/lib/ssh/test/ssh_sftpd_SUITE.erl @@ -105,7 +105,6 @@ init_per_testcase(TestCase, Config) -> ClientUserDir = filename:join(PrivDir, nopubkey), SystemDir = filename:join(?config(priv_dir, Config), system), - Port = ssh_test_lib:inet_port(node()), Options = [{system_dir, SystemDir}, {user_dir, PrivDir}, {user_passwords,[{?USER, ?PASSWD}]}, @@ -113,11 +112,13 @@ init_per_testcase(TestCase, Config) -> {ok, Sftpd} = case TestCase of ver6_basic -> SubSystems = [ssh_sftpd:subsystem_spec([{sftpd_vsn, 6}])], - ssh:daemon(Port, [{subsystems, SubSystems}|Options]); + ssh:daemon(0, [{subsystems, SubSystems}|Options]); _ -> SubSystems = [ssh_sftpd:subsystem_spec([])], - ssh:daemon(Port, [{subsystems, SubSystems}|Options]) + ssh:daemon(0, [{subsystems, SubSystems}|Options]) end, + {ok,Dinf} = ssh:daemon_info(Sftpd), + Port = proplists:get_value(port, Dinf), Cm = ssh_test_lib:connect(Port, [{user_dir, ClientUserDir}, diff --git a/lib/ssh/test/ssh_test_lib.erl b/lib/ssh/test/ssh_test_lib.erl index 5cf2925671..c6541461a1 100644 --- a/lib/ssh/test/ssh_test_lib.erl +++ b/lib/ssh/test/ssh_test_lib.erl @@ -42,27 +42,33 @@ connect(Host, Port, Options) -> ConnectionRef. daemon(Options) -> - daemon(any, inet_port(), Options). + daemon(any, 0, Options). daemon(Port, Options) when is_integer(Port) -> daemon(any, Port, Options); daemon(Host, Options) -> - daemon(Host, inet_port(), Options). + daemon(Host, 0, Options). + daemon(Host, Port, Options) -> ct:log("~p:~p Calling ssh:daemon(~p, ~p, ~p)",[?MODULE,?LINE,Host,Port,Options]), case ssh:daemon(Host, Port, Options) of {ok, Pid} when Host == any -> ct:log("ssh:daemon ok (1)",[]), - {Pid, hostname(), Port}; + {Pid, hostname(), daemon_port(Port,Pid)}; {ok, Pid} -> ct:log("ssh:daemon ok (2)",[]), - {Pid, Host, Port}; + {Pid, Host, daemon_port(Port,Pid)}; Error -> ct:log("ssh:daemon error ~p",[Error]), Error end. +daemon_port(0, Pid) -> {ok,Dinf} = ssh:daemon_info(Pid), + proplists:get_value(port, Dinf); +daemon_port(Port, _) -> Port. + + std_daemon(Config, ExtraOpts) -> PrivDir = ?config(priv_dir, Config), |