aboutsummaryrefslogtreecommitdiffstats
path: root/lib/ssh/test
diff options
context:
space:
mode:
authorHans Nilsson <[email protected]>2016-08-31 10:06:18 +0200
committerHans Nilsson <[email protected]>2016-08-31 10:06:18 +0200
commitc4ad47cbd88a3570116b3f60210d6cae2c62f7b5 (patch)
tree5b1a82794fca17133bfb90ea345d83cfd01ef44f /lib/ssh/test
parent88a20d25f8a9584a78cc8fce1c8f624a15dd2bb3 (diff)
parent3430829486d4c2a2af32214107ba39f9028d7aa8 (diff)
downloadotp-c4ad47cbd88a3570116b3f60210d6cae2c62f7b5.tar.gz
otp-c4ad47cbd88a3570116b3f60210d6cae2c62f7b5.tar.bz2
otp-c4ad47cbd88a3570116b3f60210d6cae2c62f7b5.zip
Merge branch 'hans/ssh/test_fixes/OTP-13854' into maint
Fixes problems found by test suites as well as by Codenomicon/Defensics: - reduce max random padding to 15 bytes (Codenomicon/Defensics) - inclomplete pdu handling (Codenomicon/Defensics) - badmatch - non-blocking send fixes deadlock in ssh_connection_SUITE:interrupted_send
Diffstat (limited to 'lib/ssh/test')
-rw-r--r--lib/ssh/test/ssh_algorithms_SUITE.erl18
1 files changed, 8 insertions, 10 deletions
diff --git a/lib/ssh/test/ssh_algorithms_SUITE.erl b/lib/ssh/test/ssh_algorithms_SUITE.erl
index 0f68130a05..8b2db0e1a8 100644
--- a/lib/ssh/test/ssh_algorithms_SUITE.erl
+++ b/lib/ssh/test/ssh_algorithms_SUITE.erl
@@ -180,21 +180,19 @@ simple_exec(Config) ->
%%--------------------------------------------------------------------
%% Testing if no group matches
simple_exec_groups_no_match_too_small(Config) ->
- try simple_exec_group({400,500,600}, Config)
- of
- _ -> ct:fail("Exec though no group available")
- catch
- error:{badmatch,{error,"No possible diffie-hellman-group-exchange group found"}} ->
- ok
- end.
+ try_exec_simple_group({400,500,600}, Config).
simple_exec_groups_no_match_too_large(Config) ->
- try simple_exec_group({9200,9500,9700}, Config)
+ try_exec_simple_group({9200,9500,9700}, Config).
+
+
+try_exec_simple_group(Group, Config) ->
+ try simple_exec_group(Group, Config)
of
_ -> ct:fail("Exec though no group available")
catch
- error:{badmatch,{error,"No possible diffie-hellman-group-exchange group found"}} ->
- ok
+ error:{badmatch,{error,"No possible diffie-hellman-group-exchange group found"}} -> ok;
+ error:{badmatch,{error,"Connection closed"}} -> ok
end.
%%--------------------------------------------------------------------