Merge remote branch 'upstream/maint'

* upstream/maint:
  ssh: Prepare for release
  ssh: Correct error handling of ssh connect
  ssh: Use the correct channel id when adjusting the channel window

5 files changed, 35 insertions, 46 deletions

diff --git a/lib/ssh/src/ssh.appup.src b/lib/ssh/src/ssh.appup.src
index 0542054596..6967a0f464 100644
--- a/lib/ssh/src/ssh.appup.src
+++ b/lib/ssh/src/ssh.appup.src
@@ -18,12 +18,24 @@
 %%
 
 {"%VSN%",	
- [			
- {<<"2\\.*">>, [{restart_application, ssh}]},
- {<<"1\\.*">>, [{restart_application, ssh}]}	
+ [
+ {<<"2.1">>, [{load_module, ssh_sftpd_file_api, soft_purge, soft_purge, []},
+	      {load_module, ssh_connection, soft_purge, soft_purge, []},
+	      {load_module, ssh_connection_manager, soft_purge, soft_purge, []},
+	      {load_module, ssh_auth, soft_purge, soft_purge, []},
+	      {load_module, ssh_channel, soft_purge, soft_purge, []},
+	      {load_module, ssh, soft_purge, soft_purge, []}]},
+  {<<"2.0\\.*">>, [{restart_application, ssh}]},
+  {<<"1\\.*">>, [{restart_application, ssh}]}
  ],
  [
- {<<"2\\.*">>, [{restart_application, ssh}]},
- {<<"1\\.*">>, [{restart_application, ssh}]}			   
+  {<<"2.1">>,[{load_module, ssh_sftpd_file_api, soft_purge, soft_purge, []},
+	      {load_module, ssh_connection, soft_purge, soft_purge, []},
+	      {load_module, ssh_connection_manager, soft_purge, soft_purge, []},
+	      {load_module, ssh_auth, soft_purge, soft_purge, []},
+	      {load_module, ssh_channel, soft_purge, soft_purge, []},
+	      {load_module, ssh, soft_purge, soft_purge, []}]},
+  {<<"2.0\\.*">>, [{restart_application, ssh}]},
+  {<<"1\\.*">>, [{restart_application, ssh}]}
  ]
 }.
diff --git a/lib/ssh/src/ssh.erl b/lib/ssh/src/ssh.erl
index 85f5f680e6..3395f73884 100644
--- a/lib/ssh/src/ssh.erl
+++ b/lib/ssh/src/ssh.erl
@@ -91,10 +91,8 @@ do_connect(Host, Port, SocketOptions, SshOptions, Timeout, DisableIpv6) ->
  	{ok, ConnectionSup} ->
 	    {ok, Manager} = 
 		ssh_connection_sup:connection_manager(ConnectionSup),
-	    MRef = erlang:monitor(process, Manager),
 	    receive 
 		{Manager, is_connected} ->
-		    do_demonitor(MRef, Manager),
 		    {ok, Manager};
 		%% When the connection fails 
 		%% ssh_connection_sup:connection_manager
@@ -102,30 +100,13 @@ do_connect(Host, Port, SocketOptions, SshOptions, Timeout, DisableIpv6) ->
 		%% could allready have terminated, so we will not
 		%% match the Manager in this case
 		{_, not_connected, {error, econnrefused}} when DisableIpv6 == false ->
-		    do_demonitor(MRef, Manager),
 		    do_connect(Host, Port, proplists:delete(inet6, SocketOptions), 
 			    SshOptions, Timeout, true);
 		{_, not_connected, {error, Reason}} ->
-		    do_demonitor(MRef, Manager),
 		    {error, Reason};
 		{_, not_connected, Other} ->
-		    do_demonitor(MRef, Manager),
-		    {error, Other};
-		{'DOWN', MRef, _, Manager, Reason} when is_pid(Manager) ->
-		    error_logger:warning_report([{ssh, connect},
-						 {diagnose,
-						  "Connection was closed before properly set up."},
-						 {host, Host},
-						 {port, Port},
-						 {reason, Reason}]),
-		    receive %% Clear EXIT message from queue
-			{'EXIT', Manager, _What} -> 
-			    {error, channel_closed}
-		    after 0 ->
-			    {error, channel_closed}
-		    end
+		    {error, Other}
 	    after Timeout  ->
-		    do_demonitor(MRef, Manager),
 		    ssh_connection_manager:stop(Manager),
 		    {error, timeout}
 	    end
@@ -134,16 +115,6 @@ do_connect(Host, Port, SocketOptions, SshOptions, Timeout, DisableIpv6) ->
  	    {error, ssh_not_started}
     end.
 
-do_demonitor(MRef, Manager) ->
-    erlang:demonitor(MRef),
-    receive 
-	{'DOWN', MRef, _, Manager, _} -> 
-	    ok
-    after 0 -> 
-	    ok
-    end.
-
-
 %%--------------------------------------------------------------------
 %% Function: close(ConnectionRef) -> ok
 %%
diff --git a/lib/ssh/src/ssh_connection.erl b/lib/ssh/src/ssh_connection.erl
index c46f799b6d..c2a7c63cbe 100644
--- a/lib/ssh/src/ssh_connection.erl
+++ b/lib/ssh/src/ssh_connection.erl
@@ -436,32 +436,32 @@ handle_msg(#ssh_msg_channel_window_adjust{recipient_channel = ChannelId,
 	   #connection{channel_cache = Cache} = Connection, 
 	   ConnectionPid, _) ->
     
-    #channel{send_window_size = Size} = 
+    #channel{send_window_size = Size, remote_id = RemoteId} = 
 	Channel0 = ssh_channel:cache_lookup(Cache, ChannelId), 
-
+    
     {SendList, Channel} =  %% TODO: Datatype 0 ?
 	update_send_window(Channel0#channel{send_window_size = Size + Add},
 			   0, <<>>, Connection),
     
     Replies = lists:map(fun({Type, Data}) -> 
 				{connection_reply, ConnectionPid,
-				 channel_data_msg(ChannelId, Type, Data)}
+				 channel_data_msg(RemoteId, Type, Data)}
 			end, SendList),
     FlowCtrlMsgs = flow_control(Channel, Cache),
     {{replies, Replies ++ FlowCtrlMsgs}, Connection};
 
 handle_msg(#ssh_msg_channel_open{channel_type = "session" = Type,
-				 sender_channel = ChannelId,
+				 sender_channel = RemoteId,
 				 initial_window_size = WindowSz,
 				 maximum_packet_size = PacketSz}, Connection0, 
 	   ConnectionPid, server) ->
    
-    try setup_session(Connection0, ConnectionPid, ChannelId,
+    try setup_session(Connection0, ConnectionPid, RemoteId,
 		     Type, WindowSz, PacketSz) of
 	Result ->
 	    Result
     catch _:_ ->
-	    FailMsg = channel_open_failure_msg(ChannelId, 
+	    FailMsg = channel_open_failure_msg(RemoteId, 
 					       ?SSH_OPEN_CONNECT_FAILED,
 					       "Connection refused", "en"),
 	    {{replies, [{connection_reply, ConnectionPid, FailMsg}]}, 
@@ -532,9 +532,9 @@ handle_msg(#ssh_msg_channel_open{channel_type = "forwarded-tcpip",
     {{replies, [{connection_reply, ConnectionPid, FailMsg}]}, Connection};
 
 
-handle_msg(#ssh_msg_channel_open{sender_channel = ChannelId}, Connection, 
+handle_msg(#ssh_msg_channel_open{sender_channel = RemoteId}, Connection, 
 	   ConnectionPid, _) ->
-    FailMsg = channel_open_failure_msg(ChannelId, 
+    FailMsg = channel_open_failure_msg(RemoteId, 
 				       ?SSH_OPEN_ADMINISTRATIVELY_PROHIBITED,
 				       "Not allowed", "en"),
     {{replies, [{connection_reply, ConnectionPid, FailMsg}]}, Connection};
diff --git a/lib/ssh/src/ssh_connection_sup.erl b/lib/ssh/src/ssh_connection_sup.erl
index e3544af1c6..b620056310 100644
--- a/lib/ssh/src/ssh_connection_sup.erl
+++ b/lib/ssh/src/ssh_connection_sup.erl
@@ -48,8 +48,12 @@ start_manager_child(Sup, Args) ->
     supervisor:start_child(Sup, Spec).
 
 connection_manager(SupPid) -> 
-    Children = supervisor:which_children(SupPid),
-    {ok, ssh_connection_manager(Children)}.
+    try supervisor:which_children(SupPid) of
+	Children ->
+	    {ok, ssh_connection_manager(Children)}
+    catch exit:{noproc,_} ->
+	    {ok, undefined}
+    end.
 
 %%%=========================================================================
 %%%  Supervisor callback
@@ -107,6 +111,8 @@ handler_spec([Role, Socket, Opts]) ->
     Type = worker,
     {Name, StartFunc, Restart, Shutdown, Type, Modules}.
 
+ssh_connection_manager([]) ->
+    undefined;
 ssh_connection_manager([{_, Child, _, [ssh_connection_manager]} | _]) ->
     Child;
 ssh_connection_manager([_ | Rest]) ->
diff --git a/lib/ssh/vsn.mk b/lib/ssh/vsn.mk
index bff73a1b40..defa47f824 100644
--- a/lib/ssh/vsn.mk
+++ b/lib/ssh/vsn.mk
@@ -1,5 +1,5 @@
 #-*-makefile-*-   ; force emacs to enter makefile-mode
 
-SSH_VSN = 2.1
+SSH_VSN = 2.1.1
 APP_VSN    = "ssh-$(SSH_VSN)"