aboutsummaryrefslogtreecommitdiffstats
path: root/lib/stdlib/src
diff options
context:
space:
mode:
authorBjörn Gustavsson <[email protected]>2012-01-18 15:07:13 +0100
committerBjörn Gustavsson <[email protected]>2012-01-18 15:07:13 +0100
commit878194c3b0ccb5d606ad5c9992dd703b97e38321 (patch)
tree7543e0e944106972351f4fe227d8e26d5826aae3 /lib/stdlib/src
parent57ff4117e17dd31202acd99bff87570405cd66f4 (diff)
parent11d255627033bb96e7c737d35badbacae32a8631 (diff)
downloadotp-878194c3b0ccb5d606ad5c9992dd703b97e38321.tar.gz
otp-878194c3b0ccb5d606ad5c9992dd703b97e38321.tar.bz2
otp-878194c3b0ccb5d606ad5c9992dd703b97e38321.zip
Merge branch 'maint'
* maint: Update primary bootstrap erl_lint: Consistently reject local calls from guards
Diffstat (limited to 'lib/stdlib/src')
-rw-r--r--lib/stdlib/src/erl_lint.erl13
1 files changed, 10 insertions, 3 deletions
diff --git a/lib/stdlib/src/erl_lint.erl b/lib/stdlib/src/erl_lint.erl
index e5adb84932..2f29954dc9 100644
--- a/lib/stdlib/src/erl_lint.erl
+++ b/lib/stdlib/src/erl_lint.erl
@@ -1804,12 +1804,19 @@ guard_test(G, Vt, St0) ->
%% Specially handle record type test here.
guard_test2({call,Line,{atom,Lr,record},[E,A]}, Vt, St0) ->
gexpr({call,Line,{atom,Lr,is_record},[E,A]}, Vt, St0);
-guard_test2({call,_Line,{atom,_La,F},As}=G, Vt, St0) ->
+guard_test2({call,Line,{atom,_La,F},As}=G, Vt, St0) ->
{Asvt,St1} = gexpr_list(As, Vt, St0), %Always check this.
A = length(As),
case erl_internal:type_test(F, A) of
- true when F =/= is_record -> {Asvt,St1};
- _ -> gexpr(G, Vt, St0)
+ true when F =/= is_record ->
+ case no_guard_bif_clash(St1, {F,A}) of
+ false ->
+ {Asvt,add_error(Line, {illegal_guard_local_call,{F,A}}, St1)};
+ true ->
+ {Asvt,St1}
+ end;
+ _ ->
+ gexpr(G, Vt, St0)
end;
guard_test2(G, Vt, St) ->
%% Everything else is a guard expression.