Merge branch 'bjorn/cuddle-with-tests' into maint

* bjorn/cuddle-with-tests: (23 commits)
  rand_SUITE: Speed up basic_stats/1
  base64_SUITE: Speed up roundtrip/1
  lists_SUITE: Test lists:concat/2
  lists_SUITE: Test lists:split/2
  lists_SUITE: Add a test case for lists:prefix/2
  lists_SUITE: Add hof/1 to test all high-order functions
  lists_SUITE: Add test for lists:takewhile/1
  lists_SUITE: Run test cases in each group in parallel
  lists_SUITE: Test lists:keyreplace/4
  lists_SUITE: Extend flatten/1 test to also test flatlength/1
  lists_SUITE: Correct test of lists:flatten/2
  id_transform_SUITE: Modernize test suite
  io_proto_SUITE: Speed up determination of default shell
  io_proto_SUITE: Refactor up rtnode() and friends
  gen_event_SUITE: Remove unnecessary sleep calls
  proc_lib: Improve coverage for crash/1
  proc_lib_SUITE: Eliminate compiler warnings
  io_SUITE: Add coverage/1 to completely cover io_lib_pretty
  io_SUITE: Extend coverage of code for testing printable chars
  io_SUITE: Speed up test for bad +pc option
  ...

1 files changed, 16 insertions, 37 deletions

diff --git a/lib/stdlib/test/id_transform_SUITE.erl b/lib/stdlib/test/id_transform_SUITE.erl
index 41de016f8d..1cff990697 100644
--- a/lib/stdlib/test/id_transform_SUITE.erl
+++ b/lib/stdlib/test/id_transform_SUITE.erl
@@ -56,47 +56,26 @@ end_per_group(_GroupName, Config) ->
 
 id_transform(doc) -> "Test erl_id_trans.";
 id_transform(Config) when is_list(Config) ->
-    ?line File=filename:join([code:lib_dir(stdlib),"examples",
-			      "erl_id_trans.erl"]),
-    ?line {ok,erl_id_trans,Bin}=compile:file(File,[binary]),
-    ?line {module,erl_id_trans}=code:load_binary(erl_id_trans,File,Bin),
-    ?line case test_server:purify_is_running() of
-	      false ->
-		  Dog = ct:timetrap(?t:hours(1)),
-		  ?line Res = run_in_test_suite(),
-		  ?t:timetrap_cancel(Dog),
-		  Res;
-	      true ->
-		  {skip,"Purify (too slow)"}
-	  end.
+    File = filename:join([code:lib_dir(stdlib),"examples",
+			"erl_id_trans.erl"]),
+    {ok,erl_id_trans,Bin} = compile:file(File,[binary]),
+    {module,erl_id_trans} = code:load_binary(erl_id_trans, File, Bin),
+    case test_server:purify_is_running() of
+	false ->
+	    Dog = ct:timetrap(?t:hours(1)),
+	    Res = run_in_test_suite(),
+	    ?t:timetrap_cancel(Dog),
+	    Res;
+	true ->
+	    {skip,"Valgrind (too slow)"}
+    end.
 
 run_in_test_suite() ->
-    LibDir = code:lib_dir(),
     SuperDir = filename:dirname(filename:dirname(code:which(?MODULE))),
     TestDirs = filelib:wildcard(filename:join([SuperDir,"*_test"])),
-    {All,Res} = case LibDir of
-		    "/clearcase/otp/erts/lib" ->
-			%% Only test_suites 'cause clearcase is too slow...
-			{false,run_list(TestDirs)};
-		    _ ->
-			{true,run_codepath_and(TestDirs)}
-		end,
-    Comment0 = case All of
-		   true -> [];
-		   false -> "Only testsuite directories traversed"
-	       end,
-    case Res of
-	{error,Reason} when Comment0 =/= [] ->
-	    {failed,Comment0++"; "++Reason};
-	{error,Reason} ->
-	    {failed,Reason};
-	ok ->
-	    {comment,Comment0}
-    end.
-
-run_codepath_and(DirList) ->
     AbsDirs = [filename:absname(X) || X <- code:get_path()],
-    run_list(ordsets:from_list([X || X <- AbsDirs] ++ DirList)).
+    Dirs = ordsets:from_list(AbsDirs ++ TestDirs),
+    run_list(Dirs).
 
 run_list(PathL) ->
     io:format("Where to search for beam files:\n~p\n", [PathL]),
@@ -123,7 +102,7 @@ run_list(PathL) ->
     end,
     case length(SevereFailures) of
 	0 -> ok;
-	Len -> {error,integer_to_list(Len)++" failures"}
+	Len -> {failed,integer_to_list(Len)++" failures"}
     end.