diff options
| author | Gustav Simonsson <[email protected]> | 2012-07-03 14:31:22 +0200 |
|---|---|---|
| committer | Gustav Simonsson <[email protected]> | 2012-07-03 14:31:22 +0200 |
| commit | 06067a490863cf2e7ff3323b639176b6200c9c41 (patch) | |
| tree | 18e1e78d4a2a8840d2aab7309c06113b58f08cb3 /lib/stdlib/test | |
| parent | 3b34580548d5060bae35a0f787e1c80b4a294123 (diff) | |
| download | otp-06067a490863cf2e7ff3323b639176b6200c9c41.tar.gz otp-06067a490863cf2e7ff3323b639176b6200c9c41.tar.bz2 otp-06067a490863cf2e7ff3323b639176b6200c9c41.zip | |
Correct guard matching in gen_server:enter_loop/4
to match global scope in ServerName without timeout.
OTP-10130
Diffstat (limited to 'lib/stdlib/test')
| -rw-r--r-- | lib/stdlib/test/gen_server_SUITE.erl | 28 |
1 files changed, 26 insertions, 2 deletions
diff --git a/lib/stdlib/test/gen_server_SUITE.erl b/lib/stdlib/test/gen_server_SUITE.erl index cdf15ba017..c38362d716 100644 --- a/lib/stdlib/test/gen_server_SUITE.erl +++ b/lib/stdlib/test/gen_server_SUITE.erl @@ -37,7 +37,8 @@ % spawn export -export([spec_init_local/2, spec_init_global/2, spec_init_via/2, - spec_init_default_timeout/2, spec_init_anonymous/1, + spec_init_default_timeout/2, spec_init_global_default_timeout/2, + spec_init_anonymous/1, spec_init_anonymous_default_timeout/1, spec_init_not_proc_lib/1, cast_fast_messup/0]). @@ -749,7 +750,7 @@ spec_init(suite) -> spec_init(Config) when is_list(Config) -> OldFlag = process_flag(trap_exit, true), - + ?line {ok, Pid0} = start_link(spec_init_local, [{ok, my_server}, []]), ?line ok = gen_server:call(Pid0, started_p), ?line ok = gen_server:call(Pid0, stop), @@ -819,6 +820,20 @@ spec_init(Config) when is_list(Config) -> test_server:fail(gen_server_did_not_die) end, + %% There is probably a better way to test this. + %% Before the OTP-10130 fix this failed because a timeout message + %% was generated as the spawned process crashed because a {global, Name} + %% was matched as a timeout value instead of matching on scope. + {ok, _PidHurra} = + start_link(spec_init_global_default_timeout, [{ok, hurra}, []]), + receive + _Anything -> + ct:log("OTP-10130, received: ~p~n", [_Anything]), + test_server:fail(init_of_global_default_timeout_failed) + after 5000 -> + ok + end, + ?line Pid5 = erlang:spawn_link(?MODULE, spec_init_not_proc_lib, [[]]), receive @@ -1125,6 +1140,15 @@ spec_init_default_timeout({ok, Name}, Options) -> %% Supervised init can occur here ... gen_server:enter_loop(?MODULE, Options, {}, {local, Name}). +%% OTP-10130, A bug was introduced where global scope was not matched when +%% enter_loop/4 was called (no timeout). +spec_init_global_default_timeout({ok, Name}, Options) -> + process_flag(trap_exit, true), + global:register_name(Name, self()), + proc_lib:init_ack({ok, self()}), + %% Supervised init can occur here ... + gen_server:enter_loop(?MODULE, Options, {}, {global, Name}). + spec_init_anonymous(Options) -> process_flag(trap_exit, true), proc_lib:init_ack({ok, self()}), |