OTP-8567 The word 'spec' is no longer reserved.

The function erl_scan:reserved_word/1 no longer returns true when given the
word spec. This bug was introduced in STDLIB-1.15.3 (R12B-3).

2 files changed, 193 insertions, 147 deletions

diff --git a/lib/stdlib/test/erl_pp_SUITE.erl b/lib/stdlib/test/erl_pp_SUITE.erl
index 92a54108aa..66730b7b94 100644
--- a/lib/stdlib/test/erl_pp_SUITE.erl
+++ b/lib/stdlib/test/erl_pp_SUITE.erl
@@ -46,7 +46,7 @@
          neg_indent/1,
          tickets/1,
             otp_6321/1, otp_6911/1, otp_6914/1, otp_8150/1, otp_8238/1,
-            otp_8473/1, otp_8522/1]).
+            otp_8473/1, otp_8522/1, otp_8567/1]).
 
 %% Internal export.
 -export([ehook/6]).
@@ -150,15 +150,15 @@ recs(Config) when is_list(Config) ->
                                         (A#r1.a)#r.a > 3 -> 3
                       end(#r1{a = #r{a = 4}}),
                   7 = fun(A) when record(A#r3.a, r1) -> 7 end(#r3{}),
-                  [#r1{a = 2,b = 1}] = 
+                  [#r1{a = 2,b = 1}] =
                       fun() ->
-                              [A || A <- [#r1{a = 1, b = 3}, 
-                                          #r2{a = 2,b = 1}, 
+                              [A || A <- [#r1{a = 1, b = 3},
+                                          #r2{a = 2,b = 1},
                                           #r1{a = 2, b = 1}],
-                                    A#r1.a > 
+                                    A#r1.a >
                                         A#r1.b]
                       end(),
-                  {[_],b} = 
+                  {[_],b} =
                       fun(L) ->
                               %% A is checked only once:
                               R1 = [{A,B} || A <- L, A#r1.a, B <- L, A#r1.b],
@@ -177,7 +177,7 @@ recs(Config) when is_list(Config) ->
                       end(#r1{a = 2}),
 
                   %% The test done twice (an effect of doing the test as soon as possible).
-                  3 = fun(A) when A#r1.a > 3, 
+                  3 = fun(A) when A#r1.a > 3,
                                   record(A, r1) -> 3
                       end(#r1{a = 5}),
 
@@ -251,18 +251,18 @@ recs(Config) when is_list(Config) ->
                                ok
                        end(),
 
-                  both = fun(A) when A#r.a, A#r.b -> both 
+                  both = fun(A) when A#r.a, A#r.b -> both
                          end(#r{a = true, b = true}),
 
                   ok = fun() ->
-                               F = fun(A, B) when ((A#r1.a) orelse (B#r2.a)) 
+                               F = fun(A, B) when ((A#r1.a) orelse (B#r2.a))
                                                   or (B#r2.b) or (A#r1.b) ->
                                          true;
                                       (_, _) -> false
                                    end,
-                               true = F(#r1{a = false, b = false}, 
+                               true = F(#r1{a = false, b = false},
                                         #r2{a = false, b = true}),
-                               false = F(#r1{a = true, b = true}, 
+                               false = F(#r1{a = true, b = true},
                                          #r1{a = false, b = true}),
                                ok
                        end(),
@@ -273,7 +273,7 @@ recs(Config) when is_list(Config) ->
            <<"-record(r1, {a, b = foo:bar(kljlfjsdlf, kjlksdjf)}).
               -record(r2, {c = #r1{}, d = #r1{a = bar:foo(kljklsjdf)}}).
 
-              t() -> 
+              t() ->
                   R = #r2{},
                   R#r2{c = R, d = #r1{}}.">>}
           ],
@@ -304,10 +304,10 @@ try_catch(Config) when is_list(Config) ->
           {try_6,
            <<"t() -> try 1=2 catch throw:{badmatch,2} -> 3 end.">>},
           {try_7,
-           <<"t() -> try 1=2 of 3 -> 4 
+           <<"t() -> try 1=2 of 3 -> 4
 		     catch error:{badmatch,2} -> 5 end.">>},
           {try_8,
-           <<"t() -> try 1=2 
+           <<"t() -> try 1=2
 		     catch error:{badmatch,2} -> 3
 		     after put(try_catch, 4) end.">>},
           {try_9,
@@ -371,7 +371,7 @@ receive_after(Config) when is_list(Config) ->
                              {X,Y};
                          Z ->
                              Z
-                     after 
+                     after
                          foo:bar() ->
                              {3,4}
                      end.">>}
@@ -429,7 +429,7 @@ head_tail(Config) when is_list(Config) ->
           {list_4,
            <<"t() -> [a].">>},
           {list_5,
-           <<"t() -> 
+           <<"t() ->
                [foo:bar(lkjljlskdfj, klsdajflds, sdafkljsdlfkjdas, kjlsdadjl),
                bar:foo(kljlkjsdf, lkjsdlfj, [kljsfj, sdfdsfsad])].">>}
           ],
@@ -462,7 +462,7 @@ cond1(Config) when is_list(Config) ->
           "    true ->\n"
           "        {x,y}\n"
           "end" = CChars,
-%     ?line ok = pp_expr(<<"cond 
+%     ?line ok = pp_expr(<<"cond
 %                               {foo,bar} ->
 %                                   [a,b];
 %                               true ->
@@ -544,7 +544,7 @@ old_mnemosyne_syntax(Config) when is_list(Config) ->
           "         X <- table(tab),\n"
           "         X.foo = bar\n"
           "    ]\n"
-          "end" = 
+          "end" =
         lists:flatten(erl_pp:expr(Q)),
 
     R = {rule,12,sales,2,
@@ -559,7 +559,7 @@ old_mnemosyne_syntax(Config) when is_list(Config) ->
              {atom,14,sales}}]}]},
     ?line "sales(E, employee) :-\n"
           "    E <- table(employee),\n"
-          "    E.salary = sales.\n" = 
+          "    E.salary = sales.\n" =
         lists:flatten(erl_pp:form(R)),
     ok.
 
@@ -660,7 +660,7 @@ hook(Config) when is_list(Config) ->
 
     ?line "INVALID-FORM:{foo,bar}:" = lists:flatten(erl_pp:expr({foo,bar})),
 
-    %% A list (as before R6), not a list of lists. 
+    %% A list (as before R6), not a list of lists.
     G = [{op,1,'>',{atom,1,a},{foo,{atom,1,b}}}], % not a proper guard
     GChars = lists:flatten(erl_pp:guard(G, H)),
     G2 = [{op,1,'>',{atom,1,a},
@@ -677,23 +677,23 @@ hook(Config) when is_list(Config) ->
     %% Note: no leading spaces before "begin".
     Block = {block,0,[{match,0,{var,0,'A'},{integer,0,3}},
                       {atom,0,true}]},
-    ?line "begin\n                     A =" ++ _ = 
+    ?line "begin\n                     A =" ++ _ =
                lists:flatten(erl_pp:expr(Block, 17, none)),
 
     %% Special...
-    ?line true = 
+    ?line true =
         "{some,value}" =:= lists:flatten(erl_pp:expr({value,0,{some,value}})),
 
     %% Silly...
     ?line true =
-        "if true -> 0 end" =:= 
+        "if true -> 0 end" =:=
               flat_expr({'if',0,[{clause,0,[],[],[{atom,0,0}]}]}),
 
     %% More compatibility: before R6
     OldIf = {'if',0,[{clause,0,[],[{atom,0,true}],[{atom,0,b}]}]},
     NewIf = {'if',0,[{clause,0,[],[[{atom,0,true}]],[{atom,0,b}]}]},
     OldIfChars = lists:flatten(erl_pp:expr(OldIf)),
-    NewIfChars = lists:flatten(erl_pp:expr(NewIf)),    
+    NewIfChars = lists:flatten(erl_pp:expr(NewIf)),
     ?line true = OldIfChars =:= NewIfChars,
 
     ok.
@@ -706,7 +706,7 @@ remove_indentation(S) ->
 ehook(HE, I, P, H, foo, bar) ->
     hook(HE, I, P, H).
 
-hook({foo,E}, I, P, H) -> 
+hook({foo,E}, I, P, H) ->
     erl_pp:expr({call,0,{atom,0,foo},[E]}, I, P, H).
 
 neg_indent(suite) ->
@@ -722,14 +722,14 @@ neg_indent(Config) when is_list(Config) ->
                               end">>),
     ?line ok = pp_expr(
             <<"fun() ->
-                  F = fun(A, B) when ((A#r1.a) orelse (B#r2.a)) 
+                  F = fun(A, B) when ((A#r1.a) orelse (B#r2.a))
                                      or (B#r2.b) or (A#r1.b) ->
                             true;
                          (_, _) -> false
                       end,
-                  true = F(#r1{a = false, b = false}, 
+                  true = F(#r1{a = false, b = false},
                            #r2{a = false, b = true}),
-                  false = F(#r1{a = true, b = true}, 
+                  false = F(#r1{a = true, b = true},
                             #r1{a = false, b = true}),
                   ok
                        end()">>),
@@ -764,7 +764,8 @@ neg_indent(Config) when is_list(Config) ->
     ok.
 
 tickets(suite) ->
-    [otp_6321, otp_6911, otp_6914, otp_8150, otp_8238, otp_8473, otp_8522].
+    [otp_6321, otp_6911, otp_6914, otp_8150, otp_8238, otp_8473, otp_8522,
+     otp_8567].
 
 otp_6321(doc) ->
     "OTP_6321. Bug fix of exprs().";
@@ -813,7 +814,7 @@ otp_8150(doc) ->
     "OTP_8150. Types.";
 otp_8150(suite) -> [];
 otp_8150(Config) when is_list(Config) ->
-    ?line _ = [{N,ok} = {N,pp_forms(B)} || 
+    ?line _ = [{N,ok} = {N,pp_forms(B)} ||
                   {N,B} <- type_examples()
                      ],
     ok.
@@ -918,7 +919,7 @@ otp_8473(suite) -> [];
 otp_8473(Config) when is_list(Config) ->
     Ex = [{ex1,<<"-type 'fun'(A) :: A.\n"
                  "-type funkar() :: 'fun'(fun((integer()) -> atom())).\n">>}],
-    ?line _ = [{N,ok} = {N,pp_forms(B)} || 
+    ?line _ = [{N,ok} = {N,pp_forms(B)} ||
                   {N,B} <- Ex],
     ok.
 
@@ -949,12 +950,57 @@ count_atom(L, A) when is_list(L) ->
 count_atom(_, _) ->
     0.
 
+otp_8567(doc) ->
+    "OTP_8567. Avoid duplicated 'undefined' in record field types.";
+otp_8567(suite) -> [];
+otp_8567(Config) when is_list(Config) ->
+    FileName = filename('otp_8567.erl', Config),
+    C = <<"-module otp_8567.\n"
+          "-compile export_all.\n"
+          "-spec(a).\n"
+          "-record r, {a}.\n"
+          "-record s, {a :: integer()}.\n"
+          "-type t() :: {#r{},#s{}}.\n">>,
+    ?line ok = file:write_file(FileName, C),
+    ?line {error,[{_,[{3,erl_parse,["syntax error before: ","')'"]}]}],_} =
+        compile:file(FileName, [return]),
+
+    F = <<"-module(otp_8567).\n"
+          "-compile(export_all).\n"
+          "-record(t, {a}).\n"
+          "-record(u, {a :: integer()}).\n"
+          "-opaque ot() :: {#t{}, #u{}}.\n"
+          "-opaque(ot1() :: atom()).\n"
+          "-type a() :: integer().\n"
+          "-spec t() -> a().\n"
+          "t() ->\n"
+          "    3.\n"
+          "\n"
+          "-spec(t1/1 :: (ot()) -> ot1()).\n"
+          "t1(A) ->\n"
+          "    A.\n"
+          "\n"
+          "-spec(t2 (ot()) -> ot1()).\n"
+          "t2(A) ->\n"
+          "    A.\n"
+          "\n"
+          "-spec(otp_8567:t3/1 :: (ot()) -> ot1()).\n"
+          "t3(A) ->\n"
+          "    A.\n"
+          "\n"
+          "-spec(otp_8567:t4 (ot()) -> ot1()).\n"
+          "t4(A) ->\n"
+          "    A.\n">>,
+    ?line ok = pp_forms(F),
+
+    ok.
+
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 
 compile(Config, Tests) ->
     F = fun({N,P}, BadL) ->
                 case catch compile_file(Config, P) of
-                    ok -> 
+                    ok ->
                         case pp_forms(P) of
                             ok ->
                                 BadL;
@@ -962,8 +1008,8 @@ compile(Config, Tests) ->
                                 ?t:format("~nTest ~p failed.~n", [N]),
                                 fail()
                         end;
-                    Bad -> 
-                        ?t:format("~nTest ~p failed. got~n  ~p~n", 
+                    Bad ->
+                        ?t:format("~nTest ~p failed. got~n  ~p~n",
                                   [N, Bad]),
                         fail()
                 end
@@ -993,7 +1039,7 @@ compile_file(Config, Test0) ->
         Error ->
             Error
     end.
-            
+
 compile_file(Config, Test0, Opts0) ->
     FileName = filename('erl_pp_test.erl', Config),
     Test = list_to_binary(["-module(erl_pp_test). "
@@ -1002,7 +1048,7 @@ compile_file(Config, Test0, Opts0) ->
     Opts = [export_all,return,nowarn_unused_record,{outdir,?privdir} | Opts0],
     ok = file:write_file(FileName, Test),
     case compile:file(FileName, Opts) of
-        {ok, _M, _Ws} -> 
+        {ok, _M, _Ws} ->
             {ok, filename:rootname(FileName)};
         Error -> Error
     end.
@@ -1029,7 +1075,7 @@ pp_forms(Bin, Hook) ->
     end.
 
 parse_and_pp_forms(String, Hook) ->
-    lists:append(lists:map(fun(AF) -> erl_pp:form(AF, Hook) 
+    lists:append(lists:map(fun(AF) -> erl_pp:form(AF, Hook)
                            end, parse_forms(String))).
 
 parse_forms(Chars) ->
@@ -1037,13 +1083,13 @@ parse_forms(Chars) ->
     parse_forms2(String, [], 1, []).
 
 parse_forms2([], _Cont, _Line, Forms) ->
-    lists:reverse(Forms);    
+    lists:reverse(Forms);
 parse_forms2(String, Cont0, Line, Forms) ->
     case erl_scan:tokens(Cont0, String, Line) of
         {done, {ok, Tokens, EndLine}, Chars} ->
             {ok, Form} = erl_parse:parse_form(Tokens),
             parse_forms2(Chars, [], EndLine, [Form | Forms]);
-        {more, Cont} when element(3, Cont) =:= [] -> 
+        {more, Cont} when element(3, Cont) =:= [] ->
             %% extra spaces after forms...
             parse_forms2([], Cont, Line, Forms);
         {more, Cont} ->
@@ -1061,10 +1107,10 @@ pp_expr(Bin, Hook) ->
     PP2 = (catch parse_and_pp_expr(PPneg, 0, Hook)),
     if
         PP1 =:= PP2 -> % same line numbers
-            case 
+            case
                 (test_max_line(PP1) =:= ok) and (test_new_line(PPneg) =:= ok)
             of
-                true -> 
+                true ->
                     ok;
                 false ->
                     not_ok
@@ -1097,7 +1143,7 @@ test_max_line(String) ->
     end.
 
 max_line(String) ->
-    lists:max([0 | [length(Sub) || 
+    lists:max([0 | [length(Sub) ||
                        Sub <- string:tokens(String, "\n"),
                        string:substr(Sub, 1, 5) =/= "-file"]]).
 
diff --git a/lib/stdlib/test/erl_scan_SUITE.erl b/lib/stdlib/test/erl_scan_SUITE.erl
index 32a06d15c7..afeb67eeb1 100644
--- a/lib/stdlib/test/erl_scan_SUITE.erl
+++ b/lib/stdlib/test/erl_scan_SUITE.erl
@@ -1,19 +1,19 @@
 %%
 %% %CopyrightBegin%
-%% 
-%% Copyright Ericsson AB 1998-2009. All Rights Reserved.
-%% 
+%%
+%% Copyright Ericsson AB 1998-2010. All Rights Reserved.
+%%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
 %% compliance with the License. You should have received a copy of the
 %% Erlang Public License along with this software. If not, it can be
 %% retrieved online at http://www.erlang.org/.
-%% 
+%%
 %% Software distributed under the License is distributed on an "AS IS"
 %% basis, WITHOUT WARRANTY OF ANY KIND, either express or implied. See
 %% the License for the specific language governing rights and limitations
 %% under the License.
-%% 
+%%
 %% %CopyrightEnd%
 
 -module(erl_scan_SUITE).
@@ -34,7 +34,7 @@
 -define(line, put(line, ?LINE), ).
 -define(config(A,B),config(A,B)).
 -define(t, test_server).
-%% config(priv_dir, _) ->    
+%% config(priv_dir, _) ->
 %%     ".";
 %% config(data_dir, _) ->
 %%     ".".
@@ -45,7 +45,7 @@
 init_per_testcase(_Case, Config) when is_list(Config) ->
     ?line Dog=test_server:timetrap(test_server:seconds(1200)),
     [{watchdog, Dog}|Config].
- 
+
 fin_per_testcase(_Case, Config) ->
     Dog=?config(watchdog, Config),
     test_server:timetrap_cancel(Dog),
@@ -97,7 +97,7 @@ assert_type(N, integer) when is_integer(N) ->
     ok;
 assert_type(N, atom) when is_atom(N) ->
     ok.
-    
+
 check(String) ->
     Error = erl_scan:string(String),
     check_error(Error, erl_scan).
@@ -146,7 +146,7 @@ iso88591(Config) when is_list(Config) ->
 	ok -> ok				%Aok
     end.
 
-otp_7810(doc) -> 
+otp_7810(doc) ->
     ["OTP-7810. White spaces, comments, and more.."];
 otp_7810(suite) ->
     [];
@@ -185,7 +185,7 @@ reserved_words() ->
          'andalso', 'orelse', 'end', 'fun', 'if', 'let', 'of',
          'query', 'receive', 'when', 'bnot', 'not', 'div',
          'rem', 'band', 'and', 'bor', 'bxor', 'bsl', 'bsr',
-         'or', 'xor', 'spec'] , % 'spec' shouldn't be there...
+         'or', 'xor'] ,
     [begin
          ?line {RW, true} = {RW, erl_scan:reserved_word(RW)},
          S = atom_to_list(RW),
@@ -203,7 +203,7 @@ atoms() ->
     ?line test_string("a@2", [{atom,1,a@2}]),
     ?line test_string([39,65,200,39], [{atom,1,'A�'}]),
     ?line test_string("�rlig �sten", [{atom,1,�rlig},{atom,1,�sten}]),
-    ?line {ok,[{atom,_,'$a'}],{1,6}} = 
+    ?line {ok,[{atom,_,'$a'}],{1,6}} =
         erl_scan:string("'$\\a'", {1,1}),
     ?line test("'$\\a'"),
     ok.
@@ -221,8 +221,8 @@ punctuations() ->
     Three = ["/=:=", "<=:=", "==:=", ">=:="], % three tokens...
     No = Three ++ L,
     SL0 = [{S1++S2,{-length(S1),S1,S2}} ||
-              S1 <- L, 
-              S2 <- L, 
+              S1 <- L,
+              S2 <- L,
               not lists:member(S1++S2, No)],
     SL = family_list(SL0),
     %% Two tokens. When there are several answers, the one with
@@ -250,15 +250,15 @@ comments() ->
     ?line test("a %%\n b"),
     ?line {ok,[],1} = erl_scan:string("%"),
     ?line test("a %%\n b"),
-    ?line {ok,[{atom,_,a},{atom,_,b}],{2,3}} = 
+    ?line {ok,[{atom,_,a},{atom,_,b}],{2,3}} =
         erl_scan:string("a %%\n b",{1,1}),
-    ?line {ok,[{atom,_,a},{comment,_,"%%"},{atom,_,b}],{2,3}} = 
+    ?line {ok,[{atom,_,a},{comment,_,"%%"},{atom,_,b}],{2,3}} =
         erl_scan:string("a %%\n b",{1,1}, [return_comments]),
     ?line {ok,[{atom,_,a},
                {white_space,_," "},
                {white_space,_,"\n "},
                {atom,_,b}],
-           {2,3}} = 
+           {2,3}} =
         erl_scan:string("a %%\n b",{1,1},[return_white_spaces]),
     ?line {ok,[{atom,_,a},
                {white_space,_," "},
@@ -275,14 +275,14 @@ errors() ->
     ?line {error,{1,erl_scan,char},1} = erl_scan:string("$"),
     ?line test_string([34,65,200,34], [{string,1,"A�"}]),
     ?line test_string("\\", [{'\\',1}]),
-    ?line {'EXIT',_} = 
+    ?line {'EXIT',_} =
         (catch {foo, erl_scan:string('$\\a', {1,1})}), % type error
-    ?line {'EXIT',_} = 
+    ?line {'EXIT',_} =
         (catch {foo, erl_scan:tokens([], '$\\a', {1,1})}), % type error
 
     ?line "{a,tuple}" = erl_scan:format_error({a,tuple}),
     ok.
-    
+
 integers() ->
     [begin
          I = list_to_integer(S),
@@ -299,14 +299,14 @@ base_integers() ->
          ?line test_string(BS++"#"++S, Ts)
      end || {BS,S} <- [{"2","11"}, {"5","23234"}, {"12","05a"},
                        {"16","abcdef"}, {"16","ABCDEF"}] ],
-    
+
     ?line {error,{1,erl_scan,{base,1}},1} = erl_scan:string("1#000"),
-    
+
     ?line test_string("12#bc", [{integer,1,11},{atom,1,c}]),
-    
+
     [begin
          Str = BS ++ "#" ++ S,
-         ?line {error,{1,erl_scan,{illegal,integer}},1} = 
+         ?line {error,{1,erl_scan,{illegal,integer}},1} =
              erl_scan:string(Str)
      end || {BS,S} <- [{"3","3"},{"15","f"}, {"12","c"}] ],
 
@@ -323,8 +323,8 @@ floats() ->
      end || FS <- ["1.0","001.17","3.31200","1.0e0","1.0E17",
                    "34.21E-18", "17.0E+14"]],
     ?line test_string("1.e2", [{integer,1,1},{'.',1},{atom,1,e2}]),
-    
-    ?line {error,{1,erl_scan,{illegal,float}},1} = 
+
+    ?line {error,{1,erl_scan,{illegal,float}},1} =
         erl_scan:string("1.0e400"),
     [begin
          ?line {error,{1,erl_scan,{illegal,float}},1} = erl_scan:string(S)
@@ -345,16 +345,16 @@ dots() ->
            {".a",   {ok,[{'.',1},{atom,1,a}],1}}
           ],
     ?line [R = erl_scan:string(S) || {S, R} <- Dot],
-    
+
     ?line {ok,[{dot,_}=T1],{1,2}} = erl_scan:string(".", {1,1}, text),
-    ?line [{column,1},{length,1},{line,1},{text,"."}] = 
+    ?line [{column,1},{length,1},{line,1},{text,"."}] =
         erl_scan:token_info(T1, [column, length, line, text]),
     ?line {ok,[{dot,_}=T2],{1,3}} = erl_scan:string(".%", {1,1}, text),
-    ?line [{column,1},{length,1},{line,1},{text,"."}] = 
+    ?line [{column,1},{length,1},{line,1},{text,"."}] =
         erl_scan:token_info(T2, [column, length, line, text]),
     ?line {ok,[{dot,_}=T3],{1,6}} =
         erl_scan:string(".% �h", {1,1}, text),
-    ?line [{column,1},{length,1},{line,1},{text,"."}] = 
+    ?line [{column,1},{length,1},{line,1},{text,"."}] =
         erl_scan:token_info(T3, [column, length, line, text]),
     ?line {error,{{1,2},erl_scan,char},{1,3}} =
         erl_scan:string(".$", {1,1}),
@@ -376,10 +376,10 @@ dots() ->
     ?line {done,{ok,[{comment,_,"%. "},
                      {white_space,_,"\n"},
                      {dot,_}],
-                 {2,3}}, ""} = 
+                 {2,3}}, ""} =
         erl_scan:tokens(C, "\n. ", {1,1}, return), % any loc, any options
 
-    ?line [test_string(S, R) || 
+    ?line [test_string(S, R) ||
               {S, R} <- [{".$\n",   [{'.',1},{char,1,$\n}]},
                          {"$\\\n",  [{char,1,$\n}]},
                          {"'\\\n'", [{atom,1,'\n'}]},
@@ -392,7 +392,7 @@ chars() ->
          Ts = [{char,1,C}],
          ?line test_string(L, Ts)
      end || C <- lists:seq(0, 255)],
-    
+
     %% Leading zeroes...
     [begin
          L = lists:flatten(io_lib:format("$\\~3.8.0b", [C])),
@@ -406,13 +406,13 @@ chars() ->
          Ts = [{char,1,C band 2#11111}],
          ?line test_string(L, Ts)
      end || C <- lists:seq(0, 255)],
-    
+
     [begin
          L = "$\\" ++ [C],
          Ts = [{char,1,V}],
          ?line test_string(L, Ts)
-     end || {C,V} <- [{$n,$\n}, {$r,$\r}, {$t,$\t}, {$v,$\v}, 
-                      {$b,$\b}, {$f,$\f}, {$e,$\e}, {$s,$\s}, 
+     end || {C,V} <- [{$n,$\n}, {$r,$\r}, {$t,$\t}, {$v,$\v},
+                      {$b,$\b}, {$f,$\f}, {$e,$\e}, {$s,$\s},
                       {$d,$\d}]],
 
     EC = [$\n,$\r,$\t,$\v,$\b,$\f,$\e,$\s,$\d],
@@ -445,7 +445,7 @@ chars() ->
      end || C <- lists:seq(0, 255) -- (No ++ [$\\])],
     ?line test_string("$\n", [{char,1,$\n}]),
 
-    ?line {error,{{1,1},erl_scan,char},{1,4}} = 
+    ?line {error,{{1,1},erl_scan,char},{1,4}} =
         erl_scan:string("$\\^",{1,1}),
     ?line test_string("$\\\n", [{char,1,$\n}]),
     %% Robert's scanner returns line 1:
@@ -453,7 +453,7 @@ chars() ->
     ?line test_string("$\n\n", [{char,1,$\n}]),
     ?line test("$\n\n"),
     ok.
-           
+
 
 variables() ->
     ?line test_string("     \237_Aou�eiy��", [{var,1,'_Aou�eiy��'}]),
@@ -469,8 +469,8 @@ eof() ->
     ?line {done,{eof,2},eof} = erl_scan:tokens(C1, eof, 1),
     {more, C2} = erl_scan:tokens([], "abra", 1),
     %% An error before R13A.
-    %% ?line {done,Err={error,{1,erl_scan,scan},1},eof} = 
-    ?line {done,{ok,[{atom,1,abra}],1},eof} = 
+    %% ?line {done,Err={error,{1,erl_scan,scan},1},eof} =
+    ?line {done,{ok,[{atom,1,abra}],1},eof} =
         erl_scan:tokens(C2, eof, 1),
 
     %% With column.
@@ -478,7 +478,7 @@ eof() ->
     ?line {done,{eof,{2,1}},eof} = erl_scan:tokens(C3, eof, 1),
     {more, C4} = erl_scan:tokens([], "abra", {1,1}),
     %% An error before R13A.
-    %% ?line {done,{error,{{1,1},erl_scan,scan},{1,5}},eof} = 
+    %% ?line {done,{error,{{1,1},erl_scan,scan},{1,5}},eof} =
     ?line {done,{ok,[{atom,_,abra}],{1,5}},eof} =
         erl_scan:tokens(C4, eof, 1),
 
@@ -486,7 +486,7 @@ eof() ->
     %% the R12B scanner returns eof as LeftoverChars: (eof is correct)
     ?line {more, C5} = erl_scan:tokens([], "a", 1),
     %% An error before R13A.
-    %% ?line {done,{error,{1,erl_scan,scan},1},eof} = 
+    %% ?line {done,{error,{1,erl_scan,scan},1},eof} =
     ?line {done,{ok,[{atom,1,a}],1},eof} =
         erl_scan:tokens(C5,eof,1),
 
@@ -528,7 +528,7 @@ illegal() ->
         erl_scan:tokens([], "foo "++Atom++". ", {1,1}),
     ?line {error,{{1,1},erl_scan,{illegal,atom}},{1,1003}} =
         erl_scan:string(QAtom, {1,1}),
-    ?line {done,{error,{{1,5},erl_scan,{illegal,atom}},{1,1007}},". "} = 
+    ?line {done,{error,{{1,5},erl_scan,{illegal,atom}},{1,1007}},". "} =
         erl_scan:tokens([], "foo "++QAtom++". ", {1,1}),
     ?line {error,{{1,1},erl_scan,{illegal,var}},{1,1001}} =
         erl_scan:string(Var, {1,1}),
@@ -553,7 +553,7 @@ crashes() ->
     ?line {'EXIT',_} = (catch {foo, erl_scan:string("\"\\v"++[-1,$"])}), %$"
     ?line {'EXIT',_} = (catch {foo, erl_scan:string([$",-1,$"])}),
     ?line {'EXIT',_} = (catch {foo, erl_scan:string("% foo"++[-1])}),
-    ?line {'EXIT',_} = 
+    ?line {'EXIT',_} =
          (catch {foo, erl_scan:string("% foo"++[-1],{1,1})}),
 
     ?line {'EXIT',_} = (catch {foo, erl_scan:string([a])}), % type error
@@ -564,7 +564,7 @@ crashes() ->
     ?line {'EXIT',_} = (catch {foo, erl_scan:string("\"\\v"++[a,$"])}), %$"
     ?line {'EXIT',_} = (catch {foo, erl_scan:string([$",a,$"])}),
     ?line {'EXIT',_} = (catch {foo, erl_scan:string("% foo"++[a])}),
-    ?line {'EXIT',_} = 
+    ?line {'EXIT',_} =
          (catch {foo, erl_scan:string("% foo"++[a],{1,1})}),
 
     ?line {'EXIT',_} = (catch {foo, erl_scan:string([3.0])}), % type error
@@ -573,26 +573,26 @@ crashes() ->
 
 options() ->
     %% line and column are not options, but tested here
-    ?line {ok,[{atom,1,foo},{white_space,1," "},{comment,1,"% bar"}], 1} = 
+    ?line {ok,[{atom,1,foo},{white_space,1," "},{comment,1,"% bar"}], 1} =
         erl_scan:string("foo % bar", 1, return),
-    ?line {ok,[{atom,1,foo},{white_space,1," "}],1} = 
+    ?line {ok,[{atom,1,foo},{white_space,1," "}],1} =
         erl_scan:string("foo % bar", 1, return_white_spaces),
-    ?line {ok,[{atom,1,foo},{comment,1,"% bar"}],1} = 
+    ?line {ok,[{atom,1,foo},{comment,1,"% bar"}],1} =
         erl_scan:string("foo % bar", 1, return_comments),
-    ?line {ok,[{atom,17,foo}],17} = 
+    ?line {ok,[{atom,17,foo}],17} =
         erl_scan:string("foo % bar", 17),
-    ?line {'EXIT',{function_clause,_}} = 
-        (catch {foo, 
+    ?line {'EXIT',{function_clause,_}} =
+        (catch {foo,
                 erl_scan:string("foo % bar", {a,1}, [])}), % type error
-    ?line {ok,[{atom,_,foo}],{17,18}} = 
+    ?line {ok,[{atom,_,foo}],{17,18}} =
         erl_scan:string("foo % bar", {17,9}, []),
-    ?line {'EXIT',{function_clause,_}} = 
+    ?line {'EXIT',{function_clause,_}} =
         (catch {foo,
                 erl_scan:string("foo % bar", {1,0}, [])}), % type error
-    ?line {ok,[{foo,1}],1} = 
+    ?line {ok,[{foo,1}],1} =
         erl_scan:string("foo % bar",1, [{reserved_word_fun,
                                          fun(W) -> W =:= foo end}]),
-    ?line {'EXIT',{badarg,_}} = 
+    ?line {'EXIT',{badarg,_}} =
         (catch {foo,
                 erl_scan:string("foo % bar",1, % type error
                                 [{reserved_word_fun,
@@ -618,14 +618,14 @@ more_options() ->
 
 token_info() ->
     ?line {ok,[T1],_} = erl_scan:string("foo", {1,18}, [text]),
-    {'EXIT',{badarg,_}} = 
+    {'EXIT',{badarg,_}} =
         (catch {foo, erl_scan:token_info(T1, foo)}), % type error
     ?line {line,1} = erl_scan:token_info(T1, line),
     ?line {column,18} = erl_scan:token_info(T1, column),
     ?line {length,3} = erl_scan:token_info(T1, length),
     ?line {text,"foo"} = erl_scan:token_info(T1, text),
     ?line [{category,atom},{column,18},{length,3},{line,1},
-           {symbol,foo},{text,"foo"}] = 
+           {symbol,foo},{text,"foo"}] =
         erl_scan:token_info(T1),
     ?line [{length,3},{column,18}] =
         erl_scan:token_info(T1, [length, column]),
@@ -648,9 +648,9 @@ token_info() ->
     ?line {category,'='} = erl_scan:token_info(T3, category),
     ?line [{symbol,'='}] = erl_scan:token_info(T3, [symbol]),
     ok.
-    
+
 attributes_info() ->
-    ?line {'EXIT',_} = 
+    ?line {'EXIT',_} =
         (catch {foo,erl_scan:attributes_info(foo)}), % type error
     ?line [{line,18}] = erl_scan:attributes_info(18),
     ?line {location,19} = erl_scan:attributes_info(19, location),
@@ -717,9 +717,9 @@ set_attribute() ->
     ?line [{line,{17,11}},{text,"foo"}] =
         erl_scan:attributes_info(A7, [line,column,text]),
 
-    ?line {'EXIT',_} = 
+    ?line {'EXIT',_} =
         (catch {foo, erl_scan:set_attribute(line, [], F2)}), % type error
-    ?line {'EXIT',{badarg,_}} = 
+    ?line {'EXIT',{badarg,_}} =
         (catch {foo, erl_scan:set_attribute(column, [], F2)}), % type error
     ok.
 
@@ -790,14 +790,14 @@ unicode() ->
     ?line {ok,[{char,1,83},{integer,1,45}],1} =
         erl_scan:string("$\\12345"), % not unicode
 
-    ?line {error,{1,erl_scan,{illegal,character}},1} = 
+    ?line {error,{1,erl_scan,{illegal,character}},1} =
         erl_scan:string([1089]),
-    ?line {error,{{1,1},erl_scan,{illegal,character}},{1,2}} = 
+    ?line {error,{{1,1},erl_scan,{illegal,character}},{1,2}} =
         erl_scan:string([1089], {1,1}),
     ?line {error,{1,erl_scan,{illegal,character}},1} =
-    %% ?line {error,{1,erl_scan,{illegal,atom}},1} = 
+    %% ?line {error,{1,erl_scan,{illegal,atom}},1} =
         erl_scan:string("'a"++[1089]++"b'"),
-    ?line {error,{{1,3},erl_scan,{illegal,character}},{1,4}} = 
+    ?line {error,{{1,3},erl_scan,{illegal,character}},{1,4}} =
         erl_scan:string("'a"++[1089]++"b'", {1,1}),
     ?line test("\"a"++[1089]++"b\""),
     ?line {ok,[{char,1,1}],1} = erl_scan:string([$$,$\\,$^,1089]),
@@ -822,7 +822,7 @@ unicode() ->
     ?line {ok,[{integer,1,16#aaa}],1} = erl_scan:string(Qs),
     ?line {ok,[Q2],{1,9}} = erl_scan:string("$\\x{aaa}", {1,1}, text),
     ?line [{category,integer},{column,1},{length,8},
-           {line,1},{symbol,16#aaa},{text,Qs}] = 
+           {line,1},{symbol,16#aaa},{text,Qs}] =
         erl_scan:token_info(Q2),
 
     U1 = "\"\\x{aaa}\"",
@@ -830,11 +830,11 @@ unicode() ->
     ?line [{category,'['},{column,1},{length,1},{line,1},
            {symbol,'['},{text,"\""}] = erl_scan:token_info(T1, Tags),
     ?line [{category,integer},{column,2},{length,7},
-           {line,1},{symbol,16#aaa},{text,"\\x{aaa}"}] = 
+           {line,1},{symbol,16#aaa},{text,"\\x{aaa}"}] =
         erl_scan:token_info(T2, Tags),
     ?line [{category,']'},{column,9},{length,1},{line,1},
            {symbol,']'},{text,"\""}] = erl_scan:token_info(T3, Tags),
-    ?line  {ok,[{'[',1},{integer,1,16#aaa},{']',1}],1} = 
+    ?line  {ok,[{'[',1},{integer,1,16#aaa},{']',1}],1} =
         erl_scan:string(U1, 1),
 
     U2 = "\"\\x41\\x{fff}\\x42\"",
@@ -844,7 +844,7 @@ unicode() ->
     U3 = "\"a\n\\x{fff}\n\"",
     ?line {ok,[{'[',1},{char,1,$a},{',',1},{char,1,$\n},
                {',',2},{integer,2,16#fff},{',',2},{char,2,$\n},
-               {']',3}],3} = 
+               {']',3}],3} =
         erl_scan:string(U3, 1),
 
     U4 = "\"\\^\n\\x{aaa}\\^\n\"",
@@ -867,10 +867,10 @@ unicode() ->
                {char,_,$d},{']',_}],{1,8}} = erl_scan:string(Str1, {1,1}),
     ?line test(Str1),
     Comment = "%% "++[1089],
-    ?line {ok,[{comment,1,[$%,$%,$\s,1089]}],1} = 
+    ?line {ok,[{comment,1,[$%,$%,$\s,1089]}],1} =
         erl_scan:string(Comment, 1, return),
-    ?line {ok,[{comment,_,[$%,$%,$\s,1089]}],{1,5}} = 
-        erl_scan:string(Comment, {1,1}, return),                           
+    ?line {ok,[{comment,_,[$%,$%,$\s,1089]}],{1,5}} =
+        erl_scan:string(Comment, {1,1}, return),
     ok.
 
 more_chars() ->
@@ -885,7 +885,7 @@ more_chars() ->
         erl_scan:tokens(C1, eof, 1),
     ?line {ok,[{char,1,123},{atom,1,a},{'}',1}],1} =
         erl_scan:string("$\\{a}"),
-    
+
     ?line {error,{{1,1},erl_scan,char},{1,4}} =
         erl_scan:string("$\\x", {1,1}),
     ?line {error,{{1,1},erl_scan,char},{1,5}} =
@@ -893,12 +893,12 @@ more_chars() ->
     ?line {more, C3} = erl_scan:tokens([], "$\\x", {1,1}),
     ?line {done,{error,{{1,1},erl_scan,char},{1,4}},eof} =
         erl_scan:tokens(C3, eof, 1),
-    ?line {error,{{1,1},erl_scan,char},{1,5}} = 
+    ?line {error,{{1,1},erl_scan,char},{1,5}} =
         erl_scan:string("$\\x{",{1,1}),
     ?line {more, C2} = erl_scan:tokens([], "$\\x{", {1,1}),
-    ?line {done,{error,{{1,1},erl_scan,char},{1,5}},eof} = 
+    ?line {done,{error,{{1,1},erl_scan,char},{1,5}},eof} =
         erl_scan:tokens(C2, eof, 1),
-    ?line {error,{1,erl_scan,{illegal,character}},1} = 
+    ?line {error,{1,erl_scan,{illegal,character}},1} =
         erl_scan:string("$\\x{g}"),
     ?line {error,{{1,1},erl_scan,{illegal,character}},{1,5}} =
         erl_scan:string("$\\x{g}", {1,1}),
@@ -924,12 +924,12 @@ more_chars() ->
     ?line test("$\\x{10FFFF}"),
     ?line test("$\\x{10ffff}"),
     ?line test("\"$\n \\{1}\""),
-    ?line {error,{1,erl_scan,{illegal,character}},1} = 
+    ?line {error,{1,erl_scan,{illegal,character}},1} =
         erl_scan:string("$\\x{110000}"),
-    ?line {error,{{1,1},erl_scan,{illegal,character}},{1,12}} = 
+    ?line {error,{{1,1},erl_scan,{illegal,character}},{1,12}} =
         erl_scan:string("$\\x{110000}", {1,1}),
 
-    ?line {error,{{1,1},erl_scan,{illegal,character}},{1,4}} = 
+    ?line {error,{{1,1},erl_scan,{illegal,character}},{1,4}} =
         erl_scan:string("$\\xfg", {1,1}),
 
     ?line test("$\\xffg"),
@@ -953,11 +953,11 @@ test(String) ->
      {Wtokens, Wend},
      {Ctokens, Cend},
      {CWtokens, CWend},
-     {CWtokens2, _}] = 
+     {CWtokens2, _}] =
         [scan_string_with_column(String, X) ||
-            X <- [[], 
-                  [return_white_spaces], 
-                  [return_comments], 
+            X <- [[],
+                  [return_white_spaces],
+                  [return_comments],
                   [return],
                   [return]]], % for white space compaction test
 
@@ -969,7 +969,7 @@ test(String) ->
     {none,Tokens} = {none, filter_tokens(CWtokens, [white_space,comment])},
     {comments,Ctokens} =
         {comments,filter_tokens(CWtokens, [white_space])},
-    {white_spaces,Wtokens} = 
+    {white_spaces,Wtokens} =
         {white_spaces,filter_tokens(CWtokens, [comment])},
 
     %% Use token attributes to extract parts from the original string,
@@ -991,9 +991,9 @@ test(String) ->
     %% Line attribute only:
     [Simple,Wsimple,Csimple,WCsimple] = Simples =
         [element(2, erl_scan:string(String, 1, Opts)) ||
-            Opts <- [[], 
-                     [return_white_spaces], 
-                     [return_comments], 
+            Opts <- [[],
+                     [return_white_spaces],
+                     [return_comments],
                      [return]]],
     {consistent,true} = {consistent,consistent_attributes(Simples)},
     {simple_wc,WCsimple} = {simple_wc,simplify(CWtokens)},
@@ -1004,19 +1004,19 @@ test(String) ->
     %% Line attribute only, with text:
     [SimpleTxt,WsimpleTxt,CsimpleTxt,WCsimpleTxt] = SimplesTxt =
         [element(2, erl_scan:string(String, 1, [text|Opts])) ||
-            Opts <- [[], 
-                     [return_white_spaces], 
-                     [return_comments], 
+            Opts <- [[],
+                     [return_white_spaces],
+                     [return_comments],
                      [return]]],
     TextTxt = get_text(WCsimpleTxt),
     {text_txt,TextTxt,String} = {text_txt,String,TextTxt},
-    {consistent_txt,true} = 
+    {consistent_txt,true} =
         {consistent_txt,consistent_attributes(SimplesTxt)},
-    {simple_txt,SimpleTxt} = 
+    {simple_txt,SimpleTxt} =
         {simple_txt,filter_tokens(WCsimpleTxt, [white_space,comment])},
-    {simple_c_txt,CsimpleTxt} = 
+    {simple_c_txt,CsimpleTxt} =
         {simple_c_txt,filter_tokens(WCsimpleTxt, [white_space])},
-    {simple_w_txt,WsimpleTxt} = 
+    {simple_w_txt,WsimpleTxt} =
         {simple_w_txt,filter_tokens(WCsimpleTxt, [comment])},
 
     ok.
@@ -1024,18 +1024,18 @@ test(String) ->
 test_white_space_compaction(Tokens, Tokens2) when Tokens =:= Tokens2 ->
     [WS, WS2] = [select_tokens(Ts, [white_space]) || Ts <- [Tokens, Tokens2]],
     test_wsc(WS, WS2).
-    
+
 test_wsc([], []) ->
     ok;
 test_wsc([Token|Tokens], [Token2|Tokens2]) ->
-    [Text, Text2] = [Text || 
-                        {text, Text} <- 
+    [Text, Text2] = [Text ||
+                        {text, Text} <-
                             [erl_scan:token_info(T, text) ||
                                 T <- [Token, Token2]]],
     Sz = erts_debug:size(Text),
     Sz2 = erts_debug:size({Text, Text2}),
     IsCompacted = Sz2 < 2*Sz+erts_debug:size({a,a}),
-    ToBeCompacted = is_compacted(Text),    
+    ToBeCompacted = is_compacted(Text),
     if
         IsCompacted =:= ToBeCompacted ->
             test_wsc(Tokens, Tokens2);
@@ -1050,14 +1050,14 @@ is_compacted("\n\r") ->
 is_compacted("\n\f") ->
     true;
 is_compacted([$\n|String]) ->
-      all_spaces(String) 
+      all_spaces(String)
     orelse
       all_tabs(String);
 is_compacted(String) ->
       all_spaces(String)
     orelse
       all_tabs(String).
-  
+
 all_spaces(L) ->
     all_same(L, $\s).
 
@@ -1078,7 +1078,7 @@ newlines_first([Token|Tokens]) ->
              _ ->
                  Nnls =:= 0
          end,
-    if 
+    if
         OK -> newlines_first(Tokens);
         true -> OK
     end.
@@ -1097,7 +1097,7 @@ simplify([]) ->
 
 get_text(Tokens) ->
     lists:flatten(
-      [T || 
+      [T ||
           Token <- Tokens,
           ({text,T} = erl_scan:token_info(Token, text)) =/= []]).
 
@@ -1108,7 +1108,7 @@ test_decorated_tokens(String, Tokens) ->
 token_attrs(Tokens) ->
     [{L,C,Len,T} ||
         Token <- Tokens,
-        ([{line,L},{column,C},{length,Len},{text,T}] = 
+        ([{line,L},{column,C},{length,Len},{text,T}] =
          erl_scan:token_info(Token, [line,column,length,text])) =/= []].
 
 test_strings([], _S, Line, Column) ->
@@ -1150,7 +1150,7 @@ scan_string_with_column(String, Options0) ->
     {ok, Ts1, End1} = erl_scan:string(String, StartLoc, Options),
     TString = String ++ ". ",
     {ok,Ts2,End2} = scan_tokens(TString, Options, [], StartLoc),
-    {ok, Ts3, End3} = 
+    {ok, Ts3, End3} =
         scan_tokens_1({more, []}, TString, Options, [], StartLoc),
     {end_2,End2,End3} = {end_2,End3,End2},
     {EndLine1,EndColumn1} = End1,
@@ -1190,8 +1190,8 @@ consistent_attributes([Ts | TsL]) ->
     L = [T || T <- Ts, is_integer(element(2, T))],
     case L of
         [] ->
-            TagsL = [[Tag || {Tag,_} <- 
-                                 erl_scan:attributes_info(element(2, T))] || 
+            TagsL = [[Tag || {Tag,_} <-
+                                 erl_scan:attributes_info(element(2, T))] ||
                         T <- Ts],
             case lists:usort(TagsL) of
                 [_] ->