Merge branch 'egil/stdlib/gen_event-start-2/OTP-14123'

* egil/stdlib/gen_event-start-2/OTP-14123:
  stdlib: Document gen_event start options
  stdlib: Test gen_event options
  stdlib: Refactor gen_event_SUITE
  stdlib: Remove whitespace error in gen_event_SUITE
  stdlib: Add start options to gen_event
  stdlib: Remove whitespace errors in gen_event

1 files changed, 101 insertions, 25 deletions

diff --git a/lib/stdlib/test/gen_event_SUITE.erl b/lib/stdlib/test/gen_event_SUITE.erl
index 4415c2d09d..9a7400c84e 100644
--- a/lib/stdlib/test/gen_event_SUITE.erl
+++ b/lib/stdlib/test/gen_event_SUITE.erl
@@ -21,22 +21,24 @@
 
 -include_lib("common_test/include/ct.hrl").
 
--export([all/0, suite/0,groups/0,init_per_suite/1, end_per_suite/1, 
+-export([all/0, suite/0,groups/0,init_per_suite/1, end_per_suite/1,
 	 init_per_group/2,end_per_group/2]).
 -export([start/1, add_handler/1, add_sup_handler/1,
 	 delete_handler/1, swap_handler/1, swap_sup_handler/1,
 	 notify/1, sync_notify/1, call/1, info/1, hibernate/1,
 	 call_format_status/1, call_format_status_anon/1,
-         error_format_status/1, get_state/1, replace_state/1]).
+         error_format_status/1, get_state/1, replace_state/1,
+         start_opt/1]).
 
 suite() -> [{ct_hooks,[ts_install_cth]}].
 
-all() -> 
+all() ->
     [start, {group, test_all}, hibernate,
      call_format_status, call_format_status_anon, error_format_status,
-     get_state, replace_state].
+     get_state, replace_state,
+     start_opt].
 
-groups() -> 
+groups() ->
     [{test_all, [],
       [add_handler, add_sup_handler, delete_handler,
        swap_handler, swap_sup_handler, notify, sync_notify,
@@ -59,6 +61,9 @@ end_per_group(_GroupName, Config) ->
 %% Start an event manager.
 %% --------------------------------------
 
+-define(LMGR, {local, my_dummy_name}).
+-define(GMGR, {global, my_dummy_name}).
+
 start(Config) when is_list(Config) ->
     OldFl = process_flag(trap_exit, true),
 
@@ -72,40 +77,36 @@ start(Config) when is_list(Config) ->
     [] = gen_event:which_handlers(Pid1),
     ok = gen_event:stop(Pid1),
 
-    {ok, Pid2} = gen_event:start({local, my_dummy_name}),
+    {ok, Pid2} = gen_event:start(?LMGR),
     [] = gen_event:which_handlers(my_dummy_name),
     [] = gen_event:which_handlers(Pid2),
     ok = gen_event:stop(my_dummy_name),
 
-    {ok, Pid3} = gen_event:start_link({local, my_dummy_name}),
+    {ok, Pid3} = gen_event:start_link(?LMGR),
     [] = gen_event:which_handlers(my_dummy_name),
     [] = gen_event:which_handlers(Pid3),
     ok = gen_event:stop(my_dummy_name),
 
-    {ok, Pid4} = gen_event:start_link({global, my_dummy_name}),
-    [] = gen_event:which_handlers({global, my_dummy_name}),
+    {ok, Pid4} = gen_event:start_link(?GMGR),
+    [] = gen_event:which_handlers(?GMGR),
     [] = gen_event:which_handlers(Pid4),
-    ok = gen_event:stop({global, my_dummy_name}),
+    ok = gen_event:stop(?GMGR),
 
     {ok, Pid5} = gen_event:start_link({via, dummy_via, my_dummy_name}),
     [] = gen_event:which_handlers({via, dummy_via, my_dummy_name}),
     [] = gen_event:which_handlers(Pid5),
     ok = gen_event:stop({via, dummy_via, my_dummy_name}),
 
-    {ok, _} = gen_event:start_link({local, my_dummy_name}),
-    {error, {already_started, _}} =
-	gen_event:start_link({local, my_dummy_name}),
-    {error, {already_started, _}} =
-	gen_event:start({local, my_dummy_name}),
+    {ok, _} = gen_event:start_link(?LMGR),
+    {error, {already_started, _}} = gen_event:start_link(?LMGR),
+    {error, {already_started, _}} = gen_event:start(?LMGR),
     ok = gen_event:stop(my_dummy_name),
 
-    {ok, Pid6} = gen_event:start_link({global, my_dummy_name}),
-    {error, {already_started, _}} =
-	gen_event:start_link({global, my_dummy_name}),
-    {error, {already_started, _}} =
-	gen_event:start({global, my_dummy_name}),
+    {ok, Pid6} = gen_event:start_link(?GMGR),
+    {error, {already_started, _}} = gen_event:start_link(?GMGR),
+    {error, {already_started, _}} = gen_event:start(?GMGR),
 
-    ok = gen_event:stop({global, my_dummy_name}, shutdown, 10000),
+    ok = gen_event:stop(?GMGR, shutdown, 10000),
     receive
 	{'EXIT', Pid6, shutdown} -> ok
     after 10000 ->
@@ -113,10 +114,8 @@ start(Config) when is_list(Config) ->
     end,
 
     {ok, Pid7} = gen_event:start_link({via, dummy_via, my_dummy_name}),
-    {error, {already_started, _}} =
-	gen_event:start_link({via, dummy_via, my_dummy_name}),
-    {error, {already_started, _}} =
-	gen_event:start({via, dummy_via, my_dummy_name}),
+    {error, {already_started, _}} = gen_event:start_link({via, dummy_via, my_dummy_name}),
+    {error, {already_started, _}} = gen_event:start({via, dummy_via, my_dummy_name}),
 
     exit(Pid7, shutdown),
     receive
@@ -128,6 +127,83 @@ start(Config) when is_list(Config) ->
     process_flag(trap_exit, OldFl),
     ok.
 
+start_opt(Config) when is_list(Config) ->
+    OldFl = process_flag(trap_exit, true),
+
+    dummy_via:reset(),
+
+    {ok, Pid0} = gen_event:start([]), %anonymous
+    [] = gen_event:which_handlers(Pid0),
+    ok = gen_event:stop(Pid0),
+
+    {ok, Pid1} = gen_event:start_link([]), %anonymous
+    [] = gen_event:which_handlers(Pid1),
+    ok = gen_event:stop(Pid1),
+
+    {ok, Pid2} = gen_event:start(?LMGR, []),
+    [] = gen_event:which_handlers(my_dummy_name),
+    [] = gen_event:which_handlers(Pid2),
+    ok = gen_event:stop(my_dummy_name),
+
+    {ok, Pid3} = gen_event:start_link(?LMGR, []),
+    [] = gen_event:which_handlers(my_dummy_name),
+    [] = gen_event:which_handlers(Pid3),
+    ok = gen_event:stop(my_dummy_name),
+
+    {ok, Pid4} = gen_event:start_link(?GMGR, []),
+    [] = gen_event:which_handlers(?GMGR),
+    [] = gen_event:which_handlers(Pid4),
+    ok = gen_event:stop(?GMGR),
+
+    {ok, Pid5} = gen_event:start_link({via, dummy_via, my_dummy_name}, []),
+    [] = gen_event:which_handlers({via, dummy_via, my_dummy_name}),
+    [] = gen_event:which_handlers(Pid5),
+    ok = gen_event:stop({via, dummy_via, my_dummy_name}),
+
+    {ok, _} = gen_event:start_link(?LMGR, []),
+    {error, {already_started, _}} = gen_event:start_link(?LMGR, []),
+    {error, {already_started, _}} = gen_event:start(?LMGR, []),
+    ok = gen_event:stop(my_dummy_name),
+
+    {ok, Pid7} = gen_event:start_link(?GMGR),
+    {error, {already_started, _}} = gen_event:start_link(?GMGR, []),
+    {error, {already_started, _}} = gen_event:start(?GMGR, []),
+
+    ok = gen_event:stop(?GMGR, shutdown, 10000),
+    receive
+	{'EXIT', Pid7, shutdown} -> ok
+    after 10000 ->
+	    ct:fail(exit_gen_event)
+    end,
+
+    {ok, Pid8} = gen_event:start_link({via, dummy_via, my_dummy_name}),
+    {error, {already_started, _}} = gen_event:start_link({via, dummy_via, my_dummy_name}, []),
+    {error, {already_started, _}} = gen_event:start({via, dummy_via, my_dummy_name}, []),
+
+    exit(Pid8, shutdown),
+    receive
+	{'EXIT', Pid8, shutdown} -> ok
+    after 10000 ->
+	    ct:fail(exit_gen_event)
+    end,
+
+    %% test spawn_opt
+    MinHeapSz = 10000,
+    {ok, Pid9} = gen_event:start_link(?LMGR, [{spawn_opt, [{min_heap_size, MinHeapSz}]}]),
+    {error, {already_started, _}} = gen_event:start_link(?LMGR, []),
+    {error, {already_started, _}} = gen_event:start(?LMGR, []),
+    {heap_size, HeapSz} = erlang:process_info(Pid9, heap_size),
+    true = HeapSz > MinHeapSz,
+    ok = gen_event:stop(my_dummy_name),
+
+    %% test debug opt
+    {ok, _} = gen_event:start_link(?LMGR, [{debug,[debug]}]),
+    {error, {already_started, _}} = gen_event:start_link(?LMGR, []),
+    {error, {already_started, _}} = gen_event:start(?LMGR, []),
+    ok = gen_event:stop(my_dummy_name),
+
+    process_flag(trap_exit, OldFl),
+    ok.
 
 hibernate(Config) when is_list(Config) ->
     {ok,Pid} = gen_event:start({local, my_dummy_handler}),