Remove support for mnemosyne-style record field access

(The support in erl_parse got removed when 'packages' were removed, since
the dot notation was overlaid on the existing mnemosyne access syntax.)

3 files changed, 29 insertions, 82 deletions

diff --git a/lib/syntax_tools/src/erl_prettypr.erl b/lib/syntax_tools/src/erl_prettypr.erl
index 877675772f..919df337d0 100644
--- a/lib/syntax_tools/src/erl_prettypr.erl
+++ b/lib/syntax_tools/src/erl_prettypr.erl
@@ -851,14 +851,10 @@ lay_2(Node, Ctxt) ->
 		   floating(text(".")),
 		   lay(erl_syntax:record_access_field(Node),
 		       set_prec(Ctxt, PrecR))),
-	    D3 = case erl_syntax:record_access_type(Node) of
-		     none ->
-			 D2;
-		     T ->
-			 beside(beside(floating(text("#")),
-				       lay(T, reset_prec(Ctxt))),
-				D2)
-		 end,
+	    T = erl_syntax:record_access_type(Node),
+	    D3 = beside(beside(floating(text("#")),
+                               lay(T, reset_prec(Ctxt))),
+                        D2),
 	    maybe_parentheses(beside(D1, D3), Prec, Ctxt);
 
 	record_expr ->
diff --git a/lib/syntax_tools/src/erl_syntax.erl b/lib/syntax_tools/src/erl_syntax.erl
index de271d7f2f..7ce9f231a1 100644
--- a/lib/syntax_tools/src/erl_syntax.erl
+++ b/lib/syntax_tools/src/erl_syntax.erl
@@ -254,7 +254,6 @@
 	 receive_expr_action/1,
 	 receive_expr_clauses/1,
 	 receive_expr_timeout/1,
-	 record_access/2,
 	 record_access/3,
 	 record_access_argument/1,
 	 record_access_field/1,
@@ -607,7 +606,6 @@ type(Node) ->
 	{record, _, _, _, _} -> record_expr;
 	{record, _, _, _} -> record_expr;
 	{record_field, _, _, _, _} -> record_access;
-	{record_field, _, _, _} -> record_access;
 	{record_index, _, _, _} -> record_index_expr;
 	{remote, _, _, _} -> module_qualifier;
 	{rule, _, _, _, _} -> rule;
@@ -4310,49 +4308,32 @@ record_index_expr_field(Node) ->
 
 
 %% =====================================================================
-%% @equiv record_access(Argument, none, Field)
-
--spec record_access(syntaxTree(), syntaxTree()) -> syntaxTree().
-
-record_access(Argument, Field) ->
-    record_access(Argument, none, Field).
-
-
-%% =====================================================================
-%% @doc Creates an abstract record field access expression. If
-%% `Type' is not `none', the result represents
-%% "<code><em>Argument</em>#<em>Type</em>.<em>Field</em></code>".
+%% @doc Creates an abstract record field access expression. The result
+%% represents "<code><em>Argument</em>#<em>Type</em>.<em>Field</em></code>".
 %%
-%% If `Type' is `none', the result represents
-%% "<code><em>Argument</em>.<em>Field</em></code>". This is a special
-%% form only allowed within Mnemosyne queries.
-%%
-%% @see record_access/2
 %% @see record_access_argument/1
 %% @see record_access_type/1
 %% @see record_access_field/1
 %% @see record_expr/3
 
 -record(record_access, {argument :: syntaxTree(),
-			type     :: 'none' | syntaxTree(),
+			type     :: syntaxTree(),
 			field    :: syntaxTree()}).
 
 %% type(Node) = record_access
 %% data(Node) = #record_access{argument :: Argument, type :: Type,
 %%			       field :: Field}
 %%
-%%	Argument = Field = syntaxTree()
-%%	Type = none | syntaxTree()
+%%	Argument = Type = Field = syntaxTree()
 %%
 %% `erl_parse' representation:
 %%
 %% {record_field, Pos, Argument, Type, Field}
-%% {record_field, Pos, Argument, Field}
 %%
 %%	Argument = Field = erl_parse()
 %%	Type = atom()
 
--spec record_access(syntaxTree(), 'none' | syntaxTree(), syntaxTree()) ->
+-spec record_access(syntaxTree(), syntaxTree(), syntaxTree()) ->
         syntaxTree().
 
 record_access(Argument, Type, Field) ->
@@ -4365,16 +4346,11 @@ revert_record_access(Node) ->
     Argument = record_access_argument(Node),
     Type = record_access_type(Node),
     Field = record_access_field(Node),
-    if Type =:= none ->
-	    {record_field, Pos, Argument, Field};
-       true ->
-	    case type(Type) of
-		atom ->
-		    {record_field, Pos,
-		     Argument, concrete(Type), Field};
-		_ ->
-		    Node
-	    end
+    case type(Type) of
+        atom ->
+            {record_field, Pos, Argument, concrete(Type), Field};
+        _ ->
+            Node
     end.
 
 
@@ -4387,8 +4363,6 @@ revert_record_access(Node) ->
 
 record_access_argument(Node) ->
     case unwrap(Node) of
-	{record_field, _, Argument, _} ->
-	    Argument;
 	{record_field, _, Argument, _, _} ->
 	    Argument;
 	Node1 ->
@@ -4397,21 +4371,14 @@ record_access_argument(Node) ->
 
 
 %% =====================================================================
-%% @doc Returns the type subtree of a `record_access' node,
-%% if any. If `Node' represents
-%% "<code><em>Argument</em>.<em>Field</em></code>", `none'
-%% is returned, otherwise if `Node' represents
-%% "<code><em>Argument</em>#<em>Type</em>.<em>Field</em></code>",
-%% `Type' is returned.
+%% @doc Returns the type subtree of a `record_access' node.
 %%
 %% @see record_access/3
 
--spec record_access_type(syntaxTree()) -> 'none' | syntaxTree().
+-spec record_access_type(syntaxTree()) -> syntaxTree().
 
 record_access_type(Node) ->
     case unwrap(Node) of
-	{record_field, _, _, _} ->
-	    none;
 	{record_field, Pos, _, Type, _} ->
 	    set_pos(atom(Type), Pos);
 	Node1 ->
@@ -4428,8 +4395,6 @@ record_access_type(Node) ->
 
 record_access_field(Node) ->
     case unwrap(Node) of
-	{record_field, _, _, Field} ->
-	    Field;
 	{record_field, _, _, _, Field} ->
 	    Field;
 	Node1 ->
@@ -6661,15 +6626,9 @@ subtrees(T) ->
 			     receive_expr_action(T)]
 		    end;
 		record_access ->
-		    case record_access_type(T) of
-			none ->
-			    [[record_access_argument(T)],
-			     [record_access_field(T)]];
-			R ->
-			    [[record_access_argument(T)],
-			     [R],
-			     [record_access_field(T)]]
-		    end;
+                    [[record_access_argument(T)],
+                     [record_access_type(T)],
+                     [record_access_field(T)]];
 		record_expr ->
 		    case record_expr_argument(T) of
 			none ->
@@ -6786,8 +6745,6 @@ make_tree(parentheses, [[E]]) -> parentheses(E);
 make_tree(prefix_expr, [[F], [A]]) -> prefix_expr(F, A);
 make_tree(receive_expr, [C]) -> receive_expr(C);
 make_tree(receive_expr, [C, [E], A]) -> receive_expr(C, E, A);
-make_tree(record_access, [[E], [F]]) ->
-    record_access(E, F);
 make_tree(record_access, [[E], [T], [F]]) ->
     record_access(E, T, F);
 make_tree(record_expr, [[T], F]) -> record_expr(T, F);
diff --git a/lib/syntax_tools/src/erl_syntax_lib.erl b/lib/syntax_tools/src/erl_syntax_lib.erl
index 2f0488abec..d5f80e15f4 100644
--- a/lib/syntax_tools/src/erl_syntax_lib.erl
+++ b/lib/syntax_tools/src/erl_syntax_lib.erl
@@ -1669,7 +1669,7 @@ analyze_record_attribute_tuple(Node) ->
 %%   <dt>`record_expr':</dt>
 %%     <dd>`{atom(), [{atom(), Value}]}'</dd>
 %%   <dt>`record_access':</dt>
-%%     <dd>`{atom(), atom()} | atom()'</dd>
+%%     <dd>`{atom(), atom()}'</dd>
 %%   <dt>`record_index_expr':</dt>
 %%     <dd>`{atom(), atom()}'</dd>
 %% </dl>
@@ -1679,9 +1679,7 @@ analyze_record_attribute_tuple(Node) ->
 %% listed in the order they appear. (See
 %% `analyze_record_field/1' for details on the field
 %% descriptors). For a `record_access' node,
-%% `Info' represents the record name and the field name (or
-%% if the record name is not included, only the field name; this is
-%% allowed only in Mnemosyne-query syntax). For a
+%% `Info' represents the record name and the field name. For a
 %% `record_index_expr' node, `Info' represents the
 %% record name and the name field name.
 %%
@@ -1713,18 +1711,14 @@ analyze_record_expr(Node) ->
 	    F = erl_syntax:record_access_field(Node),
 	    case erl_syntax:type(F) of
 		atom ->
-		    case erl_syntax:record_access_type(Node) of
-			none ->
-			    {record_access, erl_syntax:atom_value(F)};
-			A ->
-			    case erl_syntax:type(A) of
-				atom ->
-				    {record_access,
-				     {erl_syntax:atom_value(A),
-				      erl_syntax:atom_value(F)}};
-				_ ->
-				    throw(syntax_error)
-			    end
+		    A = erl_syntax:record_access_type(Node),
+                    case erl_syntax:type(A) of
+                        atom ->
+                            {record_access,
+                             {erl_syntax:atom_value(A),
+                              erl_syntax:atom_value(F)}};
+                        _ ->
+                            throw(syntax_error)
 		    end;
 		_ ->
 		    throw(syntax_error)