diff options
author | Björn Gustavsson <[email protected]> | 2012-10-18 16:30:47 +0200 |
---|---|---|
committer | Björn Gustavsson <[email protected]> | 2012-10-26 11:45:08 +0200 |
commit | a1bfc7b0abefe42aebd2616160b00c6bfdb9c4b6 (patch) | |
tree | 124b6342d76a0b3f44c9c3876d4126a7c811df93 /lib/test_server/src/test_server_sup.erl | |
parent | dafa6a1a7d478a61b220db811bc62f4b9b6d7de3 (diff) | |
download | otp-a1bfc7b0abefe42aebd2616160b00c6bfdb9c4b6.tar.gz otp-a1bfc7b0abefe42aebd2616160b00c6bfdb9c4b6.tar.bz2 otp-a1bfc7b0abefe42aebd2616160b00c6bfdb9c4b6.zip |
Simplify managment of test_server_loc
Before line numbers were included in exceptions (in R15), there were
parse transforms and macros that would keep the test_server_loc
process dictionary variable updated; therefore there is a mod_loc/1
function that will normalize the representation of locations.
Simplify the code as following:
* 'test_server_loc' should always contain a list with one or more
tuples. ({M,F} or {M,F,Line})
* At the beginning of each test case, set 'test_server_loc' to
[{Module,Func}] of the the currently executing test case.
* Stop updating 'test_server_loc', except when an exception occurs.
(It used to be updated when running 'init_per_testcase' and so on.)
* Remove the mod_loc/1 function.
Diffstat (limited to 'lib/test_server/src/test_server_sup.erl')
-rw-r--r-- | lib/test_server/src/test_server_sup.erl | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/lib/test_server/src/test_server_sup.erl b/lib/test_server/src/test_server_sup.erl index 9f0d1af3ef..3d00318b1b 100644 --- a/lib/test_server/src/test_server_sup.erl +++ b/lib/test_server/src/test_server_sup.erl @@ -512,7 +512,6 @@ framework_call(Callback,Func,Args,DefaultReturn) -> end, case erlang:function_exported(Mod,Func,length(Args)) of true -> - put(test_server_loc, {Mod,Func,framework}), EH = fun(Reason) -> exit({fw_error,{Mod,Func,Reason}}) end, SetTcState = case Func of end_tc -> true; @@ -555,18 +554,6 @@ format_loc([{Mod,LineOrFunc}]) -> format_loc({Mod,LineOrFunc}); format_loc({Mod,Func}) when is_atom(Func) -> io_lib:format("{~s,~w}",[package_str(Mod),Func]); -format_loc({Mod,Line}) when is_integer(Line) -> - %% ?line macro is used - ModStr = package_str(Mod), - case {lists:member(no_src, get(test_server_logopts)), - lists:reverse(ModStr)} of - {false,[$E,$T,$I,$U,$S,$_|_]} -> - io_lib:format("{~s,<a href=\"~s~s#~w\">~w</a>}", - [ModStr,downcase(ModStr),?src_listing_ext, - round_to_10(Line),Line]); - _ -> - io_lib:format("{~s,~w}",[ModStr,Line]) - end; format_loc(Loc) -> io_lib:format("~p",[Loc]). |