aboutsummaryrefslogtreecommitdiffstats
path: root/lib/tools/obj
diff options
context:
space:
mode:
authorMikael Pettersson <[email protected]>2015-04-28 19:22:12 +0200
committerMikael Pettersson <[email protected]>2015-04-28 19:22:12 +0200
commit2652fc4c4a5be4cf3849f18d5e97398ec38f9d99 (patch)
tree613d4209b251e1a13a4bbcb793855f002f419370 /lib/tools/obj
parent861145a503c77d8144033f38d288bdda31699edd (diff)
downloadotp-2652fc4c4a5be4cf3849f18d5e97398ec38f9d99.tar.gz
otp-2652fc4c4a5be4cf3849f18d5e97398ec38f9d99.tar.bz2
otp-2652fc4c4a5be4cf3849f18d5e97398ec38f9d99.zip
erl_child_setup.c: fix Android breakage
The Android support in erl_child_setup.c is broken: 1. The close fd loop compares an fd (integer i) with the address of the function __system_properties_fd rather than the value of calling that function. 2. This function is locally defined, but its name starts with two underscores which is reserved for the implementation. 3. This function is not used outside of this file, so should be static. 4. This function performs a fair amount of work (calls getenv and atoi), which would be repeated for each and every fd in the [from,to] range. 5. This function contains an unsed local variable 's'. Fixed by dropping the __ prefix, making the function static, dropping the unused local variable, and rewriting the close fd loop to call the function at most once.
Diffstat (limited to 'lib/tools/obj')
0 files changed, 0 insertions, 0 deletions