Merge branch 'egil/eprof' into dev

* egil/eprof:
  Fix eprof to handle error cases
  Dialyzer cleanup for eprof
  Fix fprof_SUITE to use new eprof API
  Switch pattern API for eprof profile with mfa
  Update eprof documentation
  Update eprof_SUITE with more basic tests
  Rename sorting choices for eprof
  Teach eprof to align text output
  Add dump functionality to eprof
  Add log functionality to eprof
  Update eprof tests to reflect new eprof
  Add start timestamp to eprof profiling
  Teach eprof to use the new breakpoints

OTP-8706 egil/eprof

eprof has been reimplemented with support in the Erlang virtual machine and
is now both faster (i.e. slows down the code being measured less) and
scales much better. In measurements we saw speed-ups compared to the old
eprof ranging from 6 times (for sequential code that only uses one
scheduler/core) up to 84 times (for parallel code that uses 8 cores).

3 files changed, 98 insertions, 10 deletions

diff --git a/lib/tools/test/eprof_SUITE.erl b/lib/tools/test/eprof_SUITE.erl
index 028fea8fe1..67607c6cf2 100644
--- a/lib/tools/test/eprof_SUITE.erl
+++ b/lib/tools/test/eprof_SUITE.erl
@@ -20,10 +20,89 @@
 
 -include("test_server.hrl").
 
--export([all/1,tiny/1,eed/1]).
+-export([all/1,tiny/1,eed/1,basic/1]).
 
-all(suite) -> [tiny,eed].
+all(suite) -> [basic,tiny,eed].
 
+basic(suite) -> [];
+basic(Config) when is_list(Config) ->
+
+    %% load eprof_test and change directory
+
+    ?line {ok, OldCurDir} = file:get_cwd(),
+    Datadir = ?config(data_dir, Config),
+    Privdir = ?config(priv_dir, Config),
+    ?line {ok,eprof_test} = compile:file(filename:join(Datadir, "eprof_test"),
+					       [trace,{outdir, Privdir}]),
+    ?line ok = file:set_cwd(Privdir),
+    ?line code:purge(eprof_test),
+    ?line {module,eprof_test} = code:load_file(eprof_test),
+
+    %% rootset profiling
+
+    ?line ensure_eprof_stopped(),
+    ?line profiling = eprof:profile([self()]),
+    ?line {error, already_profiling} = eprof:profile([self()]),
+    ?line profiling_stopped = eprof:stop_profiling(),
+    ?line profiling_already_stopped = eprof:stop_profiling(),
+    ?line profiling = eprof:start_profiling([self(),self(),self()]),
+    ?line profiling_stopped = eprof:stop_profiling(),
+
+    %% with patterns
+
+    ?line profiling = eprof:start_profiling([self()], {?MODULE, '_', '_'}),
+    ?line {error, already_profiling} = eprof:start_profiling([self()], {?MODULE, '_', '_'}),
+    ?line profiling_stopped = eprof:stop_profiling(),
+    ?line profiling = eprof:start_profiling([self()], {?MODULE, start_stop, '_'}),
+    ?line profiling_stopped = eprof:stop_profiling(),
+    ?line profiling = eprof:start_profiling([self()], {?MODULE, start_stop, 1}),
+    ?line profiling_stopped = eprof:stop_profiling(),
+
+    %% with fun
+
+    ?line {ok, _} = eprof:profile(fun() -> eprof_test:go(10) end),
+    ?line profiling = eprof:profile([self()]),
+    ?line {error, already_profiling} = eprof:profile(fun() -> eprof_test:go(10) end),
+    ?line profiling_stopped = eprof:stop_profiling(),
+    ?line {ok, _} = eprof:profile(fun() -> eprof_test:go(10) end),
+    ?line {ok, _} = eprof:profile([], fun() -> eprof_test:go(10) end),
+    ?line Pid     = whereis(eprof),
+    ?line {ok, _} = eprof:profile(erlang:processes() -- [Pid], fun() -> eprof_test:go(10) end),
+    ?line {ok, _} = eprof:profile([], fun() -> eprof_test:go(10) end, {eprof_test, '_', '_'}),
+    ?line {ok, _} = eprof:profile([], fun() -> eprof_test:go(10) end, {eprof_test, go, '_'}),
+    ?line {ok, _} = eprof:profile([], fun() -> eprof_test:go(10) end, {eprof_test, go, 1}),
+    ?line {ok, _} = eprof:profile([], fun() -> eprof_test:go(10) end, {eprof_test, dec, 1}),
+
+    %% error case
+
+    ?line error     = eprof:profile([Pid], fun() -> eprof_test:go(10) end),
+    ?line Pid       = whereis(eprof),
+    ?line error     = eprof:profile([Pid], fun() -> eprof_test:go(10) end),
+    ?line A         = spawn(fun() -> receive _ -> ok end end),
+    ?line profiling = eprof:profile([A]),
+    ?line true      = exit(A, kill_it),
+    ?line profiling_stopped = eprof:stop_profiling(),
+    ?line {error,_} = eprof:profile(fun() -> a = b end),
+
+    %% with mfa
+
+    ?line {ok, _} = eprof:profile([], eprof_test, go, [10]),
+    ?line {ok, _} = eprof:profile([], eprof_test, go, [10], {eprof_test, dec, 1}),
+
+    %% dump
+
+    ?line {ok, _} = eprof:profile([], fun() -> eprof_test:go(10) end, {eprof_test, '_', '_'}),
+    ?line [{_, Mfas}] = eprof:dump(),
+    ?line Dec_mfa = {eprof_test, dec, 1},
+    ?line Go_mfa  = {eprof_test, go,  1},
+    ?line {value, {Go_mfa,  { 1, _Time1}}} = lists:keysearch(Go_mfa,  1, Mfas),
+    ?line {value, {Dec_mfa, {11, _Time2}}} = lists:keysearch(Dec_mfa, 1, Mfas),
+
+    %% change current working directory
+
+    ?line ok = file:set_cwd(OldCurDir),
+    ?line stopped = eprof:stop(),
+    ok.
 
 tiny(suite) -> [];
 tiny(Config) when is_list(Config) -> 
@@ -40,11 +119,11 @@ tiny(Config) when is_list(Config) ->
     ?line code:purge(eprof_suite_test),
     ?line {module,eprof_suite_test} = code:load_file(eprof_suite_test),
     ?line {ok,_Pid} = eprof:start(),
-    ?line nothing_to_analyse = eprof:analyse(),
-    ?line nothing_to_analyse = eprof:total_analyse(),
+    ?line nothing_to_analyze = eprof:analyze(),
+    ?line nothing_to_analyze = eprof:analyze(total),
     ?line eprof:profile([], eprof_suite_test, test, [Config]),
-    ?line ok = eprof:analyse(),
-    ?line ok = eprof:total_analyse(),
+    ?line ok = eprof:analyze(),
+    ?line ok = eprof:analyze(total),
     ?line ok = eprof:log("eprof_SUITE_logfile"),
     ?line stopped = eprof:stop(),
     ?line ?t:timetrap_cancel(TTrap),
@@ -79,8 +158,8 @@ eed(Config) when is_list(Config) ->
     ?line {ok,ok} = eprof:profile([], eed, file, [Script]),
     ?line {T3,_} = statistics(runtime),
     ?line profiling_already_stopped = eprof:stop_profiling(),
-    ?line ok = eprof:analyse(),
-    ?line ok = eprof:total_analyse(),
+    ?line ok = eprof:analyze(),
+    ?line ok = eprof:analyze(total),
     ?line ok = eprof:log("eprof_SUITE_logfile"),
     ?line stopped = eprof:stop(),
     ?line ?t:timetrap_cancel(TTrap),
diff --git a/lib/tools/test/eprof_SUITE_data/eprof_test.erl b/lib/tools/test/eprof_SUITE_data/eprof_test.erl
new file mode 100644
index 0000000000..33c428e893
--- /dev/null
+++ b/lib/tools/test/eprof_SUITE_data/eprof_test.erl
@@ -0,0 +1,9 @@
+-module(eprof_test).
+-export([go/1]).
+
+go(N) ->
+    0 = dec(N),
+    ok.
+
+dec(0) -> 0;
+dec(N) -> dec(N - 1).
diff --git a/lib/tools/test/fprof_SUITE.erl b/lib/tools/test/fprof_SUITE.erl
index e437007e76..1cd9ac7824 100644
--- a/lib/tools/test/fprof_SUITE.erl
+++ b/lib/tools/test/fprof_SUITE.erl
@@ -356,7 +356,7 @@ imm_tail_seq(Config) when is_list(Config) ->
     ?line profiling_stopped = eprof:stop_profiling(),
     ?line R2 = R0,
     %%
-    ?line eprof:analyse(),
+    ?line eprof:analyze(),
     ?line stopped = eprof:stop(),
     %%
     ?line {ok, Tracer} = fprof:profile(start),
@@ -471,7 +471,7 @@ imm_compile(Config) when is_list(Config) ->
     ?line TS3 = erlang:now(),
     ?line profiling_stopped = eprof:stop_profiling(),
     %%
-    ?line eprof:analyse(),
+    ?line eprof:analyze(),
     ?line stopped = eprof:stop(),
     %%
     ?line {ok, Tracer} = fprof:profile(start),