Merge branch 'dgud/wx/additional-functionality/OTP-11986' into maint

* dgud/wx/additional-functionality/OTP-11986:
  wx: Fix destroy bug
  wx: Add wxPopup(Transient)Window
  wx: Fix non constant define (wxSL_LABELS)
  wx: Add wxActivateEvent
  wx: Add missing wxTextCtrl:changeValue

OTP-11985

1 files changed, 22 insertions, 10 deletions

diff --git a/lib/wx/api_gen/wx_gen_cpp.erl b/lib/wx/api_gen/wx_gen_cpp.erl
index 31ed1374c2..107d064f4a 100644
--- a/lib/wx/api_gen/wx_gen_cpp.erl
+++ b/lib/wx/api_gen/wx_gen_cpp.erl
@@ -71,7 +71,8 @@ gen_derived_dest_2(C=#class{name=Class, options=Opts}) ->
 
     if Derived andalso (TaylorMade =:= false) ->
 	    case lists:keysearch(ifdef,1,Opts) of
-		{value, {ifdef, What}} -> w("#if ~p~n",[What]);
+		{value, {ifdef, What}} when is_list(What)-> w("#if ~s~n",[What]);
+		{value, {ifdef, What}} when is_atom(What) -> w("#if ~p~n",[What]);
 		_ -> ok
 	    end,
 	    w("class E~s : public ~s {~n",[Class,Class]),
@@ -190,13 +191,14 @@ gen_funcs(Defs) ->
 %%     w("  case WXE_REMOVE_PORT:~n", []),
 %%     w("   { destroyMemEnv(Ecmd.port); } break;~n", []),
     w("  case DESTROY_OBJECT: {~n"),
-    w("     wxObject *This = (wxObject *) getPtr(bp,memenv);~n"),
-    w("     if(This) {~n"),
-    w("       if(recurse_level > 1) {~n"),
+    w("     void *This = getPtr(bp,memenv);~n"),
+    w("     wxeRefData *refd = getRefData(This);~n"),
+    w("     if(This && refd) {~n"),
+    w("       if(recurse_level > 1 && refd->type != 4) {~n"),
     w("          delayed_delete->Append(Ecmd.Save());~n"),
     w("       } else {~n"),
-    w("          ((WxeApp *) wxTheApp)->clearPtr((void *) This);~n"),
-    w("          delete This; }~n"),
+    w("          ((WxeApp *) wxTheApp)->clearPtr(This);~n"),
+    w("          delete_object(This, refd); }~n"),
     w("  } } break;~n"),
     w("  case WXE_REGISTER_OBJECT: {~n"
       "     registerPid(bp, Ecmd.caller, memenv);~n"
@@ -270,7 +272,8 @@ gen_class(C=#class{name=Name,methods=Ms,options=Opts}) ->
 	    false ->
 		case lists:keysearch(ifdef,1,Opts) of
 		    {value, {ifdef, What}} ->
-			w("#if ~p~n",[What]),
+			is_atom(What) andalso w("#if ~p~n",[What]),
+			is_list(What) andalso w("#if ~s~n",[What]),
 			Methods = lists:flatten(Ms),
 			MsR = [gen_method(Name,M) ||
 				  M <- lists:keysort(#method.id, Methods)],
@@ -735,9 +738,13 @@ call_wx(_N,{constructor,_},#type{base={class,RClass}},Ps) ->
 			false -> 0
 		    end;
 		false ->
-		    case hd(reverse(wx_gen_erl:parents(RClass))) of
-			root -> Id;
-			_ -> 1
+		    case is_dc(RClass) of
+			true -> 4;
+			false ->
+			    case hd(reverse(wx_gen_erl:parents(RClass))) of
+				root -> Id;
+				_ -> 1
+			    end
 		    end
 	    end,
     case virtual_dest(ClassDef) orelse (CType =/= 0) of
@@ -899,6 +906,10 @@ is_window(Class) ->
 is_dialog(Class) ->
     lists:member("wxDialog", wx_gen_erl:parents(Class)).
 
+is_dc(Class) ->
+    Parents = wx_gen_erl:parents(Class),
+    lists:member("wxDC", Parents) orelse lists:member("wxGraphicsContext", Parents).
+
 build_return_vals(Type,Ps) ->
     HaveType = case Type of  void -> 0; _ -> 1 end,
     NoOut = lists:sum([1 || #param{in=In} <- Ps, In =/= true]) + HaveType,
@@ -1097,6 +1108,7 @@ gen_macros() ->
     w("#include <wx/listbook.h>~n"),
     w("#include <wx/treebook.h>~n"),
     w("#include <wx/taskbar.h>~n"),
+    w("#include <wx/popupwin.h>~n"),
     w("#include <wx/html/htmlwin.h>~n"),
     w("#include <wx/html/htmlcell.h>~n"),
     w("#include <wx/filename.h>~n"),