wx: Optimize event and return value construction

Preallocated an rt array of 64 items (which covers 99%) of the calls
and thus avoids allocation and copying in most cases.

6 files changed, 89 insertions, 92 deletions

diff --git a/lib/wx/api_gen/wx_gen_cpp.erl b/lib/wx/api_gen/wx_gen_cpp.erl
index 7067b11465..8cbc448563 100644
--- a/lib/wx/api_gen/wx_gen_cpp.erl
+++ b/lib/wx/api_gen/wx_gen_cpp.erl
@@ -207,7 +207,7 @@ gen_funcs(Defs) ->
       " }~n"),
     w(" case WXE_BIN_INCR:~n   driver_binary_inc_refc(Ecmd.bin[0]->bin);~n   break;~n",[]),
     w(" case WXE_BIN_DECR:~n   driver_binary_dec_refc(Ecmd.bin[0]->bin);~n   break;~n",[]),
-    w(" case WXE_INIT_OPENGL:~n  wxe_initOpenGL(rt, bp);~n   break;~n",[]),
+    w(" case WXE_INIT_OPENGL:~n  wxe_initOpenGL(&rt, bp);~n   break;~n",[]),
 
     Res = [gen_class(Class) || Class <- Defs],
 
diff --git a/lib/wx/c_src/gen/wxe_funcs.cpp b/lib/wx/c_src/gen/wxe_funcs.cpp
index dca0f74dcd..2f52308f69 100644
--- a/lib/wx/c_src/gen/wxe_funcs.cpp
+++ b/lib/wx/c_src/gen/wxe_funcs.cpp
@@ -66,7 +66,7 @@ void WxeApp::wxe_dispatch(wxeCommand& Ecmd)
    driver_binary_dec_refc(Ecmd.bin[0]->bin);
    break;
  case WXE_INIT_OPENGL:
-  wxe_initOpenGL(rt, bp);
+  wxe_initOpenGL(&rt, bp);
    break;
 
 case 100: { // wxEvtHandler::Connect
diff --git a/lib/wx/c_src/wxe_gl.cpp b/lib/wx/c_src/wxe_gl.cpp
index 26b45d219e..7921c1d52a 100644
--- a/lib/wx/c_src/wxe_gl.cpp
+++ b/lib/wx/c_src/wxe_gl.cpp
@@ -67,7 +67,7 @@ void dlclose(HMODULE Lib) {
 typedef void * DL_LIB_P;
 #endif
 
-void wxe_initOpenGL(wxeReturn rt, char *bp) {
+void wxe_initOpenGL(wxeReturn *rt, char *bp) {
   DL_LIB_P LIBhandle;
   int (*init_opengl)(void *);
 #ifdef _WIN32
@@ -82,9 +82,9 @@ void wxe_initOpenGL(wxeReturn rt, char *bp) {
       wxe_gl_dispatch = (WXE_GL_DISPATCH) dlsym(LIBhandle, "egl_dispatch");
       if(init_opengl && wxe_gl_dispatch) {
 	(*init_opengl)(erlCallbacks);
-	rt.addAtom((char *) "ok");
-	rt.add(wxString::FromAscii("initiated"));
-	rt.addTupleCount(2);
+	rt->addAtom((char *) "ok");
+	rt->add(wxString::FromAscii("initiated"));
+	rt->addTupleCount(2);
 	erl_gl_initiated = TRUE;
       } else {
 	wxString msg;
@@ -95,24 +95,24 @@ void wxe_initOpenGL(wxeReturn rt, char *bp) {
 	  msg += wxT("egl_init_opengl ");
 	if(!wxe_gl_dispatch) 
 	  msg += wxT("egl_dispatch ");
-	rt.addAtom((char *) "error");
-	rt.add(msg);
-	rt.addTupleCount(2);
+	rt->addAtom((char *) "error");
+	rt->add(msg);
+	rt->addTupleCount(2);
       }
     } else {
       wxString msg;
       msg.Printf(wxT("Could not load dll: "));
       msg += wxString::FromAscii(bp);
-      rt.addAtom((char *) "error");
-      rt.add(msg);
-      rt.addTupleCount(2);
+      rt->addAtom((char *) "error");
+      rt->add(msg);
+      rt->addTupleCount(2);
     }
   } else {
-    rt.addAtom((char *) "ok");
-    rt.add(wxString::FromAscii("already initilized"));
-    rt.addTupleCount(2);
+    rt->addAtom((char *) "ok");
+    rt->add(wxString::FromAscii("already initilized"));
+    rt->addTupleCount(2);
   }
-  rt.send();
+  rt->send();
 }
 
 void setActiveGL(ErlDrvTermData caller, wxGLCanvas *canvas)
diff --git a/lib/wx/c_src/wxe_gl.h b/lib/wx/c_src/wxe_gl.h
index dc117bf610..f64c20f25a 100644
--- a/lib/wx/c_src/wxe_gl.h
+++ b/lib/wx/c_src/wxe_gl.h
@@ -26,7 +26,7 @@
 void activateGL(ErlDrvTermData caller);
 void setActiveGL(ErlDrvTermData caller, wxGLCanvas *canvas);
 void deleteActiveGL(wxGLCanvas *canvas);
-void wxe_initOpenGL(wxeReturn, char*);
+void wxe_initOpenGL(wxeReturn *, char*);
 void gl_dispatch(int op, char *bp, ErlDrvTermData caller, WXEBinRef *bins[]);
 
 WX_DECLARE_HASH_MAP(ErlDrvTermData, wxGLCanvas*, wxIntegerHash, wxIntegerEqual, wxeGLC);
diff --git a/lib/wx/c_src/wxe_return.cpp b/lib/wx/c_src/wxe_return.cpp
index accd818a14..f29c8eff4a 100644
--- a/lib/wx/c_src/wxe_return.cpp
+++ b/lib/wx/c_src/wxe_return.cpp
@@ -19,11 +19,6 @@
 
 #include "wxe_return.h"
 
-// see http://docs.wxwidgets.org/stable/wx_wxarray.html#arraymacros
-// this is a magic incantation which must be done!
-#include <wx/arrimpl.cpp> 
-WX_DEFINE_OBJARRAY(wxErlDrvTermDataArray);
-
 #define INLINE
 
 wxeReturn::wxeReturn (ErlDrvTermData   _port,
@@ -31,59 +26,51 @@ wxeReturn::wxeReturn (ErlDrvTermData   _port,
 		      bool             _isResult) {
     port    = _port;
     caller  = _caller;
-    
+
     isResult = _isResult;
-    
-     if (isResult) {
-         addAtom("_wxe_result_");
-     }
+    rtb = buff;
+    rt_max = RT_BUFF_SZ;
+    rt_n = 0;
+    if (isResult) {
+      addAtom("_wxe_result_");
+    }
+}
+
+//clear everything so we can re-use if we want
+void wxeReturn::reset() {
+  rt_n = 0;
+  temp_float.empty();
 }
 
 wxeReturn::~wxeReturn () {
-    //depending on which version of wxArray we use, we may have to clear it ourselves.
+  if(rtb != buff)
+    driver_free(rtb);
 }
 
-int wxeReturn::send() {      
-    if ((rt.GetCount() == 2 && isResult) || rt.GetCount() == 0)
-      return 1;  // not a call bail out
-    
-    if (isResult) {
-        addTupleCount(2);
-    }    
+int wxeReturn::send() {
+  if ((rt_n == 2 && isResult) || rt_n == 0)
+    return 1;  // not a call bail out
 
-    // rt to array
-    unsigned int rtLength = rt.GetCount(); //signed int
+  if (isResult) {
+    addTupleCount(2);
+  }
 
-    size_t size = sizeof(ErlDrvTermData)*(rtLength);
-    
-    ErlDrvTermData* rtData = (ErlDrvTermData *) driver_alloc(size);
-    for (unsigned int i=0; i < rtLength; i++) {
-        rtData[i] = rt[i];
-    }
- 
-    int res = erl_drv_send_term(port, caller, rtData, rtLength);
-    driver_free(rtData);
+  int res = erl_drv_send_term(port, caller, rtb, rt_n);
 
 #ifdef DEBUG
-    if(res == -1) {
-      fprintf(stderr, "Failed to send return or event msg\r\n");
-    }
+  if(res == -1) {
+    fprintf(stderr, "Failed to send return or event msg\r\n");
+  }
 #endif
 
-    reset();
-    return res;
-}
-
-//clear everything so we can re-use if we want
- void wxeReturn::reset() {
-     rt.empty();
-     temp_float.empty();
+  reset();
+  return res;
 }
 
 INLINE
 unsigned  int wxeReturn::size() {
-     return rt.GetCount();
- }
+  return rt_n;
+}
 
 
 INLINE
@@ -92,24 +79,34 @@ void wxeReturn::ensureFloatCount(size_t n) {
 }
 
 INLINE
-void wxeReturn::add(ErlDrvTermData type, ErlDrvTermData data) {
-    rt.Add(type);
-    rt.Add(data);
+void wxeReturn::do_add(ErlDrvTermData val) {
+  if(rt_n >= rt_max) {  // realloc
+    rt_max += RT_BUFF_SZ;
+    if(rtb == buff) {
+      rtb = (ErlDrvTermData *) driver_alloc(rt_max * sizeof(ErlDrvTermData));
+      for(int i = 0; i < RT_BUFF_SZ; i++)
+	rtb[i] = buff[i];
+    } else {
+      rtb = (ErlDrvTermData *) driver_realloc(rtb, rt_max * sizeof(ErlDrvTermData));
+    }
+  }
+  rtb[rt_n++] = val;
 }
 
 
-// INLINE 
-// void wxeReturn::addRef(const void *ptr, const char* className) {
-//    unsigned int ref_idx = wxe_app->getRef((void *)ptr, memEnv); 
-//    addRef(ref_idx, className);
-// }
+INLINE
+void wxeReturn::add(ErlDrvTermData type, ErlDrvTermData data) {
+  do_add(type);
+  do_add(data);
+}
+
 
 INLINE 
 void wxeReturn::addRef(const unsigned int ref, const char* className) {
    addAtom("wx_ref");
    addUint(ref);
    addAtom(className);
-   rt.Add(ERL_DRV_NIL);
+   do_add(ERL_DRV_NIL);
    addTupleCount(4);
 }
 
@@ -121,30 +118,30 @@ void wxeReturn::addAtom(const char* atomName) {
 
 INLINE 
 void wxeReturn::addBinary(const char* buf, const size_t size) {
-    rt.Add(ERL_DRV_BUF2BINARY);
-    rt.Add((ErlDrvTermData)buf);
-    rt.Add((ErlDrvTermData)size);
+    do_add(ERL_DRV_BUF2BINARY);
+    do_add((ErlDrvTermData)buf);
+    do_add((ErlDrvTermData)size);
 }
 
 INLINE 
 void wxeReturn::addExt2Term(wxeErlTerm *term) {
   if(term) {
-    rt.Add(ERL_DRV_EXT2TERM);
-    rt.Add((ErlDrvTermData)term->bin);
-    rt.Add((ErlDrvTermData)term->size);
+    do_add(ERL_DRV_EXT2TERM);
+    do_add((ErlDrvTermData)term->bin);
+    do_add((ErlDrvTermData)term->size);
   } else {
-    rt.Add(ERL_DRV_NIL);
+    do_add(ERL_DRV_NIL);
   }
 }
 
 INLINE
 void wxeReturn::addExt2Term(wxETreeItemData *val) {
   if(val) {
-    rt.Add(ERL_DRV_EXT2TERM);
-    rt.Add((ErlDrvTermData)(val->bin));
-    rt.Add((ErlDrvTermData)(val->size));
+    do_add(ERL_DRV_EXT2TERM);
+    do_add((ErlDrvTermData)(val->bin));
+    do_add((ErlDrvTermData)(val->size));
   } else
-    rt.Add(ERL_DRV_NIL);
+    do_add(ERL_DRV_NIL);
 }
 
 INLINE
@@ -174,8 +171,8 @@ void wxeReturn::addTupleCount(unsigned int n) {
 
 INLINE 
 void wxeReturn::endList(unsigned int n) {
-    rt.Add(ERL_DRV_NIL);
-    add(ERL_DRV_LIST, (ErlDrvTermData)(n+1));
+  do_add(ERL_DRV_NIL);
+  add(ERL_DRV_LIST, (ErlDrvTermData)(n+1));
 }
 
 INLINE 
diff --git a/lib/wx/c_src/wxe_return.h b/lib/wx/c_src/wxe_return.h
index a157348f1d..6729789116 100644
--- a/lib/wx/c_src/wxe_return.h
+++ b/lib/wx/c_src/wxe_return.h
@@ -40,10 +40,7 @@ extern "C" {
 #include <wx/html/htmlcell.h>
 
 
-// #define send() send_term(__FILE__, __LINE__)
-
-// see http://docs.wxwidgets.org/stable/wx_wxarray.html
-WX_DECLARE_OBJARRAY(ErlDrvTermData, wxErlDrvTermDataArray);
+#define RT_BUFF_SZ 64
 
 class wxeReturn {
 
@@ -57,7 +54,6 @@ public:
 
     void add(ErlDrvTermData type, ErlDrvTermData data);
 
-    //  void addRef(const void *ptr, const char* className);
     void addRef(const unsigned int ref, const char* className);
     void addAtom(const char* atomName);
     
@@ -65,8 +61,8 @@ public:
     void addExt2Term(wxeErlTerm * term);
     void addExt2Term(wxETreeItemData * term);
 
-    void addNil() { rt.Add(ERL_DRV_NIL); };
-    
+    void addNil() { do_add(ERL_DRV_NIL); };
+
     void addUint(unsigned int n);
     
     void addInt(int n);
@@ -116,6 +112,8 @@ public:
 
     void add(const wxHtmlLinkInfo &val);
 
+    void do_add(ErlDrvTermData val);
+
     void ensureFloatCount(size_t n);
 
     int  send();
@@ -129,15 +127,17 @@ private:
     inline void  addDate(wxDateTime dateTime);
 
     inline void  addTime(wxDateTime dateTime);
-    
-//    WxeApp*                 wxe_app;
+
     ErlDrvTermData          caller;
     ErlDrvTermData          port;
-//    wxeMemEnv               *memEnv;
-    wxErlDrvTermDataArray   rt;
     wxArrayDouble           temp_float;
     wxMBConvUTF32           utfConverter;
     bool                    isResult;
+
+    unsigned int            rt_max;
+    unsigned int            rt_n;
+    ErlDrvTermData          *rtb;
+    ErlDrvTermData          buff[RT_BUFF_SZ];
 };
 
 #endif	/* _WXE_RETURN_H */