Merge remote branch 'upstream/dev' into dev

6 files changed, 47 insertions, 19 deletions

diff --git a/lib/xmerl/include/xmerl_xsd.hrl b/lib/xmerl/include/xmerl_xsd.hrl
index b527accc8c..6dad7d8ff0 100644
--- a/lib/xmerl/include/xmerl_xsd.hrl
+++ b/lib/xmerl/include/xmerl_xsd.hrl
@@ -36,6 +36,7 @@
 	  schema_name,
 	  vsn,
 	  schema_preprocessed=false,
+	  external_xsd_base=false,
 	  xsd_base,
 	  xml_options=[],
 	  scope=[],
diff --git a/lib/xmerl/src/xmerl_scan.erl b/lib/xmerl/src/xmerl_scan.erl
index 059c8f21b6..e598c5f56d 100644
--- a/lib/xmerl/src/xmerl_scan.erl
+++ b/lib/xmerl/src/xmerl_scan.erl
@@ -2276,7 +2276,7 @@ scan_att_chars([H|T], S0, H, Acc, TmpAcc,AttType,IsNorm) -> % End quote
 	    true -> 
 		normalize(Acc,S,IsNorm)
 	end,
-    {lists:reverse(Acc2), T, S2,IsNorm2};
+    {lists:flatten(lists:reverse(Acc2)), T, S2,IsNorm2};
 scan_att_chars("&" ++ T, S0, Delim, Acc, TmpAcc,AT,IsNorm) -> % Reference
     ?bump_col(1),
     {ExpRef, T1, S1} = scan_reference(T, S),
diff --git a/lib/xmerl/src/xmerl_xsd.erl b/lib/xmerl/src/xmerl_xsd.erl
index e56f1470c0..f003cc74ba 100644
--- a/lib/xmerl/src/xmerl_xsd.erl
+++ b/lib/xmerl/src/xmerl_xsd.erl
@@ -287,10 +287,19 @@ process_schema(Schema) ->
 %% error reason. The error reason may be a list of several errors
 %% or a single error encountered during the processing.
 process_schema(Schema,Options) when is_list(Options) ->
-    S = initiate_state(Options,Schema),
-    process_schema2(xmerl_scan:file(filename:join(S#xsd_state.xsd_base, Schema)),S,Schema);
-process_schema(Schema,State) when is_record(State,xsd_state) ->
-    process_schema2(xmerl_scan:file(filename:join(State#xsd_state.xsd_base, Schema)),State,Schema).
+    State = initiate_state(Options,Schema),
+    process_schema(Schema, State);
+process_schema(Schema, State=#xsd_state{fetch_fun=Fetch})->
+    case Fetch(Schema, State) of
+	{ok,{file,File},_} ->
+	    process_schema2(xmerl_scan:file(File), State, Schema);
+	{ok,{string,Str},_} ->
+	    process_schema2(xmerl_scan:string(Str), State, Schema);
+	{ok,[],_} ->
+	    {error,enoent};
+	Err ->
+	    Err
+    end.
 
 process_schema2(Err={error,_},_,_) ->
     Err;
@@ -319,12 +328,9 @@ process_schemas(Schemas) ->
 %% error reason. The error reason may be a list of several errors
 %% or a single error encountered during the processing.
 process_schemas(Schemas=[{_,Schema}|_],Options) when is_list(Options) ->
-    process_schemas(Schemas,initiate_state(Options,Schema));
+    State = initiate_state(Options,Schema),
+    process_schemas(Schemas, State);
 process_schemas([{_NS,Schema}|Rest],State=#xsd_state{fetch_fun=Fetch}) ->
-%%      case process_external_schema_once(Schema,if_list_to_atom(NS),State) of
-%%   	S when is_record(S,xsd_state) ->
-%%     case process_schema(filename:join([State#xsd_state.xsd_base,Schema]),State) of
-%% 	{ok,S} ->
     Res=
     case Fetch(Schema,State) of
 	{ok,{file,File},_} ->
@@ -345,20 +351,20 @@ process_schemas([{_NS,Schema}|Rest],State=#xsd_state{fetch_fun=Fetch}) ->
 process_schemas([],S) when is_record(S,xsd_state) ->
     {ok,S}.
 
-
 initiate_state(Opts,Schema) ->
     XSDBase = filename:dirname(Schema),
     {{state,S},RestOpts}=new_state(Opts),
     S2 = create_tables(S),
-    initiate_state2(S2#xsd_state{schema_name = Schema,
-				xsd_base = XSDBase,
-				fetch_fun = fun fetch/2},RestOpts).
+    S3 = initiate_state2(S2#xsd_state{schema_name = Schema, xsd_base=XSDBase,
+				      fetch_fun = fun fetch/2}, 
+			 RestOpts).
+
 initiate_state2(S,[]) ->
     S;
 initiate_state2(S,[{tab2file,Bool}|T]) ->
     initiate_state2(S#xsd_state{tab2file=Bool},T);
-initiate_state2(S,[{xsdbase,XSDBase}|T]) ->
-    initiate_state2(S#xsd_state{xsd_base=XSDBase},T);
+initiate_state2(S,[{xsdbase, XSDBase}|T]) ->
+    initiate_state2(S#xsd_state{xsd_base=XSDBase, external_xsd_base=true},T);
 initiate_state2(S,[{fetch_fun,FetchFun}|T]) ->
     initiate_state2(S#xsd_state{fetch_fun=FetchFun},T);
 initiate_state2(S,[{fetch_path,FetchPath}|T]) ->
@@ -5232,7 +5238,12 @@ fetch(URI,S) ->
 	    [] -> %% empty systemliteral
 		[];
 	    _ ->
-		filename:join(S#xsd_state.xsd_base, URI)
+		case S#xsd_state.external_xsd_base of
+		    true ->
+			filename:join(S#xsd_state.xsd_base, URI);
+		    false ->
+			filename:join(S#xsd_state.xsd_base, filename:basename(URI))
+		end
 	end,
     Path = path_locate(S#xsd_state.fetch_path, Filename, Fullname),
     ?dbg("fetch(~p) -> {file, ~p}.~n", [URI, Path]),
diff --git a/lib/xmerl/test/xmerl_SUITE.erl b/lib/xmerl/test/xmerl_SUITE.erl
index 392b2522e8..0c809dbcb6 100644
--- a/lib/xmerl/test/xmerl_SUITE.erl
+++ b/lib/xmerl/test/xmerl_SUITE.erl
@@ -57,7 +57,8 @@ groups() ->
      {eventp_tests, [], [sax_parse_and_export]},
      {ticket_tests, [],
       [ticket_5998, ticket_7211, ticket_7214, ticket_7430,
-       ticket_6873, ticket_7496, ticket_8156, ticket_8697]},
+       ticket_6873, ticket_7496, ticket_8156, ticket_8697,
+       ticket_9411]},
      {app_test, [], [{xmerl_app_test, all}]},
      {appup_test, [], [{xmerl_appup_test, all}]}].
 
@@ -575,7 +576,17 @@ ticket_8697(Config) ->
     ?line [16#545C] = HexEntityText,
     ok.
 
+ticket_9411(suite) -> [];
+ticket_9411(doc) -> 
+    ["Test that xmerl_scan handles attribute that contains for example &quot"];
+ticket_9411(Config) ->
+    DataDir = ?config(data_dir,Config),
 
+    ?line {ok, Schema} = xmerl_xsd:process_schema(filename:join([DataDir,"misc/ticket_9411.xsd"])),
+    ?line {ok, Bin} = file:read_file(filename:join([DataDir,"misc/ticket_9411.xml"])),
+    ?line Xml = erlang:binary_to_list(Bin),
+    ?line {E, _} = xmerl_scan:string(Xml),
+    ?line {E, _} = xmerl_xsd:validate(E, Schema).
 
 
 
diff --git a/lib/xmerl/test/xmerl_SUITE_data/misc.tar.gz b/lib/xmerl/test/xmerl_SUITE_data/misc.tar.gz
index c48a6f897b..fef7431845 100644
--- a/lib/xmerl/test/xmerl_SUITE_data/misc.tar.gz
+++ b/lib/xmerl/test/xmerl_SUITE_data/misc.tar.gz
diff --git a/lib/xmerl/test/xmerl_xsd_SUITE.erl b/lib/xmerl/test/xmerl_xsd_SUITE.erl
index a0d3b1e667..421fa48054 100644
--- a/lib/xmerl/test/xmerl_xsd_SUITE.erl
+++ b/lib/xmerl/test/xmerl_xsd_SUITE.erl
@@ -62,7 +62,7 @@ groups() ->
        sis2, state2file_file2state, union]},
      {ticket_tests, [],
       [ticket_6910, ticket_7165, ticket_7190, ticket_7288,
-       ticket_7736, ticket_8599]},
+       ticket_7736, ticket_8599, ticket_9410]},
      {facets, [],
       [length, minLength, maxLength, pattern, enumeration,
        whiteSpace, maxInclusive, maxExclusive, minExclusive,
@@ -1146,3 +1146,8 @@ ticket_8599(Config) ->
     
     ?line {{xmlElement,persons,persons,_,_,_,_,_,_,_,_,_},_GlobalState} = xmerl_xsd:validate(E, S).
 
+
+ticket_9410(suite) -> [];
+ticket_9410(Config) ->
+    file:set_cwd(filename:join([?config(data_dir,Config),".."])),
+    ?line {ok, _S} = xmerl_xsd:process_schema("xmerl_xsd_SUITE_data/small.xsd").