diff options
author | Siri Hansen <[email protected]> | 2013-04-11 15:53:06 +0200 |
---|---|---|
committer | Siri Hansen <[email protected]> | 2013-04-19 10:57:12 +0200 |
commit | 02e6d017104cdbd5cc8c4cf542b727ab621dad96 (patch) | |
tree | c96d6610a1fabaf940b4da025580e9a9475b3fa1 /lib | |
parent | b31b467e902c978284eaeca6a23e336d2301f42a (diff) | |
download | otp-02e6d017104cdbd5cc8c4cf542b727ab621dad96.tar.gz otp-02e6d017104cdbd5cc8c4cf542b727ab621dad96.tar.bz2 otp-02e6d017104cdbd5cc8c4cf542b727ab621dad96.zip |
[reltool] Remove erlang:port_close/1 for node port
Test nodes are started with erlang:open_port/2, using the -detached
option to erl. -detached causes the port returned from open_port/2 to
be closed automatically. Some test cases failed occasionally with a
badarg when attempting to close the port with erlang:port_close/1. To
avoid this the call to port_close/1 is now removed.
Diffstat (limited to 'lib')
-rw-r--r-- | lib/reltool/test/reltool_server_SUITE.erl | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/reltool/test/reltool_server_SUITE.erl b/lib/reltool/test/reltool_server_SUITE.erl index b1e1787f18..752037042d 100644 --- a/lib/reltool/test/reltool_server_SUITE.erl +++ b/lib/reltool/test/reltool_server_SUITE.erl @@ -2595,8 +2595,8 @@ start_node(Name, ErlPath, Args0) -> %io:format("open_port({spawn_executable, ~p}, [{args,~p}])~n",[ErlPath,Args]), case open_port({spawn_executable, ErlPath}, [{args,Args}]) of Port when is_port(Port) -> - unlink(Port), - erlang:port_close(Port), + %% no need to close port since node is detached (see + %% mk_node_args) so port will be closed anyway. case ping_node(FullName, 50) of ok -> {ok, FullName}; Other -> exit({failed_to_start_node, FullName, Other}) @@ -2629,7 +2629,7 @@ mk_node_args(Name, Args) -> end, {ok, Pwd} = file:get_cwd(), NameStr = atom_to_list(Name), - ["-detached", "-noinput", + ["-detached", NameSw, NameStr, "-pa", Pa, "-env", "ERL_CRASH_DUMP", Pwd ++ "/erl_crash_dump." ++ NameStr, |