Merge branch 'maint'

6 files changed, 54 insertions, 21 deletions

diff --git a/lib/common_test/src/ct_run.erl b/lib/common_test/src/ct_run.erl
index 00d0aab507..3605385689 100644
--- a/lib/common_test/src/ct_run.erl
+++ b/lib/common_test/src/ct_run.erl
@@ -293,10 +293,10 @@ script_start1(Parent, Args) ->
 		application:set_env(common_test, auto_compile, true),
 		InclDirs =
 		    case proplists:get_value(include, Args) of
-			Incl when is_list(hd(Incl)) ->
-			    Incl;
+			Incls when is_list(hd(Incls)) ->
+			    [filename:absname(IDir) || IDir <- Incls];
 			Incl when is_list(Incl) ->
-			    [Incl];
+			    [filename:absname(Incl)];
 			undefined ->
 			    []
 		    end,
@@ -1023,10 +1023,10 @@ run_test2(StartOpts) ->
 		    case proplists:get_value(include, StartOpts) of
 			undefined ->
 			    [];
-			Incl when is_list(hd(Incl)) ->
-			    Incl;
+			Incls when is_list(hd(Incls)) ->
+			    [filename:absname(IDir) || IDir <- Incls];
 			Incl when is_list(Incl) ->
-			    [Incl]
+			    [filename:absname(Incl)]
 		    end,
 		case os:getenv("CT_INCLUDE_PATH") of
 		    false ->
@@ -1393,6 +1393,7 @@ run_testspec2(TestSpec) ->
 			EnvInclude++Opts#opts.include
 		end,
 	    application:set_env(common_test, include, AllInclude),
+
 	    LogDir1 = which(logdir,Opts#opts.logdir),
 	    case check_and_install_configfiles(
 		   Opts#opts.config, LogDir1, Opts) of
@@ -2134,6 +2135,14 @@ do_run_test(Tests, Skip, Opts0) ->
     case check_and_add(Tests, [], []) of
 	{ok,AddedToPath} ->
 	    ct_util:set_testdata({stats,{0,0,{0,0}}}),
+
+	    %% test_server needs to know the include path too
+	    InclPath = case application:get_env(common_test, include) of
+			   {ok,Incls} -> Incls;
+			   _ -> []
+		       end,
+	    application:set_env(test_server, include, InclPath),
+
 	    test_server_ctrl:start_link(local),
 
 	    %% let test_server expand the test tuples and count no of cases
diff --git a/lib/kernel/src/inet.erl b/lib/kernel/src/inet.erl
index 43bab8bcf0..ec2c350931 100644
--- a/lib/kernel/src/inet.erl
+++ b/lib/kernel/src/inet.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1997-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1997-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -1070,7 +1070,7 @@ gethostbyname_tm(Name, Type, Timer, [wins|_]=Opts) ->
     gethostbyname_tm_native(Name, Type, Timer, Opts);
 gethostbyname_tm(Name, Type, Timer, [native|_]=Opts) ->
     gethostbyname_tm_native(Name, Type, Timer, Opts);
-gethostbyname_tm(Name, Type, Timer, [_|_]=Opts) ->
+gethostbyname_tm(Name, Type, Timer, [_|Opts]) ->
     gethostbyname_tm(Name, Type, Timer, Opts);
 %% Make sure we always can look up our own hostname.
 gethostbyname_tm(Name, Type, Timer, []) ->
diff --git a/lib/kernel/test/inet_SUITE.erl b/lib/kernel/test/inet_SUITE.erl
index d45dfc2173..849013ac79 100644
--- a/lib/kernel/test/inet_SUITE.erl
+++ b/lib/kernel/test/inet_SUITE.erl
@@ -1,7 +1,7 @@
 %%
 %% %CopyrightBegin%
 %%
-%% Copyright Ericsson AB 1997-2014. All Rights Reserved.
+%% Copyright Ericsson AB 1997-2015. All Rights Reserved.
 %%
 %% The contents of this file are subject to the Erlang Public License,
 %% Version 1.1, (the "License"); you may not use this file except in
@@ -36,6 +36,7 @@
 	 gethostnative_parallell/1, cname_loop/1, 
          gethostnative_soft_restart/0, gethostnative_soft_restart/1,
 	 gethostnative_debug_level/0, gethostnative_debug_level/1,
+	 lookup_bad_search_option/1,
 	 getif/1,
 	 getif_ifr_name_overflow/1,getservbyname_overflow/1, getifaddrs/1,
 	 parse_strict_address/1, simple_netns/1, simple_netns_open/1]).
@@ -52,6 +53,7 @@ all() ->
      ipv4_to_ipv6, host_and_addr, {group, parse},
      t_gethostnative, gethostnative_parallell, cname_loop,
      gethostnative_debug_level, gethostnative_soft_restart,
+     lookup_bad_search_option,
      getif, getif_ifr_name_overflow, getservbyname_overflow,
      getifaddrs, parse_strict_address, simple_netns, simple_netns_open].
 
@@ -908,6 +910,21 @@ lookup_loop([H|Hs], Delay, Tag, Parent, Cnt, Hosts) ->
 
 
 
+lookup_bad_search_option(suite) ->
+    [];
+lookup_bad_search_option(doc) ->
+    ["Test lookup with erroneously configured lookup option (OTP-12133)"];
+lookup_bad_search_option(Config) when is_list(Config) ->
+    Db = inet_db,
+    %% The bad option can not enter through inet_db:set_lookup/1,
+    %% but through e.g .inetrc.
+    ets:insert(Db, {res_lookup,[lookup_bad_search_option]}),
+    {ok,Hostname} = inet:gethostname(),
+    {ok,_Hent} = inet:gethostbyname(Hostname), % Will hang loop for this bug
+    ok.
+
+
+
 getif(suite) ->
     [];
 getif(doc) ->
diff --git a/lib/test_server/src/erl2html2.erl b/lib/test_server/src/erl2html2.erl
index b9b45cda25..7cfaa2c325 100644
--- a/lib/test_server/src/erl2html2.erl
+++ b/lib/test_server/src/erl2html2.erl
@@ -22,11 +22,11 @@
 %%%------------------------------------------------------------------
 
 -module(erl2html2).
--export([convert/2, convert/3]).
+-export([convert/3, convert/4]).
 
-convert([], _Dest) ->   % Fake clause.
+convert([], _Dest, _InclPath) ->   % Fake clause.
     ok;
-convert(File, Dest) ->
+convert(File, Dest, InclPath) ->
     %% The generated code uses the BGCOLOR attribute in the
     %% BODY tag, which wasn't valid until HTML 3.2.  Also,
     %% good HTML should either override all colour attributes
@@ -48,12 +48,12 @@ convert(File, Dest) ->
               "</head>\n\n"
 	      "<body bgcolor=\"white\" text=\"black\""
 	      " link=\"blue\" vlink=\"purple\" alink=\"red\">\n"],
-    convert(File, Dest, Header).
+    convert(File, Dest, InclPath, Header).
 
 
-convert(File, Dest, Header) ->
+convert(File, Dest, InclPath, Header) ->
     %% statistics(runtime),
-    case parse_file(File) of
+    case parse_file(File, InclPath) of
 	{ok,Functions} ->
 	    %% {_, Time1} = statistics(runtime),
 	    %% io:format("Parsed file in ~.2f Seconds.~n",[Time1/1000]),
@@ -92,8 +92,8 @@ convert(File, Dest, Header) ->
 %%% Use expanded preprocessor directives if possible (epp). Only if
 %%% this fails, fall back on using non-expanded code (epp_dodger).
 
-parse_file(File) ->
-    case epp:open(File, [], []) of
+parse_file(File, InclPath) ->
+    case epp:open(File, InclPath, []) of
 	{ok,Epp} ->
 	    try parse_preprocessed_file(Epp,File,false) of
 		Forms ->
@@ -145,13 +145,15 @@ parse_non_preprocessed_file(File) ->
 parse_non_preprocessed_file(Epp, File, Location) ->
     case epp_dodger:parse_form(Epp, Location) of
 	{ok,Tree,Location1} ->
-	    case erl_syntax:revert(Tree) of
+	    try erl_syntax:revert(Tree) of
 		{function,L,F,A,[_|C]} ->
 		    Clauses = [{clause,CL} || {clause,CL,_,_,_} <- C],
 		    [{atom_to_list(F),A,L} | Clauses] ++
 			parse_non_preprocessed_file(Epp, File, Location1);
 		_ ->
 		    parse_non_preprocessed_file(Epp, File, Location1)
+	    catch
+		_:_ -> parse_non_preprocessed_file(Epp, File, Location1)
 	    end;
 	{error,_E,Location1} ->
 	    parse_non_preprocessed_file(Epp, File, Location1);
diff --git a/lib/test_server/src/test_server_ctrl.erl b/lib/test_server/src/test_server_ctrl.erl
index af8921fe75..488f38d05d 100644
--- a/lib/test_server/src/test_server_ctrl.erl
+++ b/lib/test_server/src/test_server_ctrl.erl
@@ -1927,15 +1927,20 @@ html_possibly_convert(Src, SrcInfo, Dest) ->
 	{ok,DestInfo} when DestInfo#file_info.mtime >= SrcInfo#file_info.mtime ->
 	    ok;					% dest file up to date
 	_ ->
+	    InclPath = case application:get_env(test_server, include) of
+			   {ok,Incls} -> Incls;
+			   _ -> []
+		       end,
+
 	    OutDir = get(test_server_log_dir_base),
 	    case test_server_sup:framework_call(get_html_wrapper,
 						["Module "++Src,false,
 						 OutDir,undefined,
 						 encoding(Src)], "") of
 		Empty when (Empty == "") ; (element(2,Empty) == "")  ->
-		    erl2html2:convert(Src, Dest);
+		    erl2html2:convert(Src, Dest, InclPath);
 		{_,Header,_} ->
-		    erl2html2:convert(Src, Dest, Header)
+		    erl2html2:convert(Src, Dest, InclPath, Header)
 	    end
     end.
 
diff --git a/lib/test_server/test/erl2html2_SUITE.erl b/lib/test_server/test/erl2html2_SUITE.erl
index 37c2b74d8e..908985c879 100644
--- a/lib/test_server/test/erl2html2_SUITE.erl
+++ b/lib/test_server/test/erl2html2_SUITE.erl
@@ -161,7 +161,7 @@ convert_module(Mod,Config) ->
     Src = filename:join(DataDir,Mod++".erl"),
     Dst = filename:join(PrivDir,Mod++".erl.html"),
     io:format("<a href=\"~s\">~s</a>\n",[Src,filename:basename(Src)]),
-    ok = erl2html2:convert(Src, Dst, "<html><body>"),
+    ok = erl2html2:convert(Src, Dst, [], "<html><body>"),
     io:format("<a href=\"~s\">~s</a>\n",[Dst,filename:basename(Dst)]),
     {Src,Dst}.