Merge pull request #1773 from bjorng/bjorn/compiler/beam_validator-receive

Check that messages outside of the heap are not corrupted

4 files changed, 651 insertions, 28 deletions

diff --git a/lib/compiler/src/beam_validator.erl b/lib/compiler/src/beam_validator.erl
index c30ab34ac7..ee0011d397 100644
--- a/lib/compiler/src/beam_validator.erl
+++ b/lib/compiler/src/beam_validator.erl
@@ -29,7 +29,7 @@
 
 -include("beam_disasm.hrl").
 
--import(lists, [reverse/1,foldl/3,foreach/2,dropwhile/2]).
+-import(lists, [any/2,dropwhile/2,foldl/3,foreach/2,reverse/1]).
 
 %% To be called by the compiler.
 
@@ -365,7 +365,9 @@ valfun_1({recv_set,{f,Fail}}, Vst) when is_integer(Fail) ->
     Vst;
 %% Misc.
 valfun_1(remove_message, Vst) ->
-    Vst;
+    %% The message term is no longer fragile. It can be used
+    %% without restrictions.
+    remove_fragility(Vst);
 valfun_1({'%',_}, Vst) ->
     Vst;
 valfun_1({line,_}, Vst) ->
@@ -533,7 +535,7 @@ valfun_4({bif,element,{f,Fail},[Pos,Tuple],Dst}, Vst0) ->
     Vst1 = branch_state(Fail, Vst0),
     TupleType = upgrade_tuple_type({tuple,[get_tuple_size(PosType)]}, TupleType0),
     Vst = set_type(TupleType, Tuple, Vst1),
-    set_type_reg(term, Dst, Vst);
+    set_type_reg(term, Tuple, Dst, Vst);
 valfun_4({bif,raise,{f,0},Src,_Dst}, Vst) ->
     validate_src(Src, Vst),
     kill_state(Vst);
@@ -542,7 +544,8 @@ valfun_4(raw_raise=I, Vst) ->
 valfun_4({bif,Op,{f,Fail},Src,Dst}, Vst0) ->
     validate_src(Src, Vst0),
     Vst = branch_state(Fail, Vst0),
-    Type = bif_type(Op, Src, Vst),
+    Type0 = bif_type(Op, Src, Vst),
+    Type = propagate_fragility(Type0, Src, Vst),
     set_type_reg(Type, Dst, Vst);
 valfun_4({gc_bif,Op,{f,Fail},Live,Src,Dst}, #vst{current=St0}=Vst0) ->
     verify_live(Live, Vst0),
@@ -552,7 +555,8 @@ valfun_4({gc_bif,Op,{f,Fail},Live,Src,Dst}, #vst{current=St0}=Vst0) ->
     Vst2 = branch_state(Fail, Vst1),
     Vst = prune_x_regs(Live, Vst2),
     validate_src(Src, Vst),
-    Type = bif_type(Op, Src, Vst),
+    Type0 = bif_type(Op, Src, Vst),
+    Type = propagate_fragility(Type0, Src, Vst),
     set_type_reg(Type, Dst, Vst);
 valfun_4(return, #vst{current=#st{numy=none}}=Vst) ->
     assert_term({x,0}, Vst),
@@ -563,13 +567,20 @@ valfun_4({jump,{f,Lbl}}, Vst) ->
     kill_state(branch_state(Lbl, Vst));
 valfun_4({loop_rec,{f,Fail},Dst}, Vst0) ->
     Vst = branch_state(Fail, Vst0),
-    set_type_reg(term, Dst, Vst);
+    %% This term may not be part of the root set until
+    %% remove_message/0 is executed. If control transfers
+    %% to the loop_rec_end/1 instruction, no part of this
+    %% this term must be stored in a Y register.
+    set_type_reg({fragile,term}, Dst, Vst);
 valfun_4({wait,_}, Vst) ->
+    verify_y_init(Vst),
     kill_state(Vst);
 valfun_4({wait_timeout,_,Src}, Vst) ->
     assert_term(Src, Vst),
+    verify_y_init(Vst),
     Vst;
 valfun_4({loop_rec_end,_}, Vst) ->
+    verify_y_init(Vst),
     kill_state(Vst);
 valfun_4(timeout, #vst{current=St}=Vst) ->
     Vst#vst{current=St#st{x=init_regs(0, term)}};
@@ -589,17 +600,17 @@ valfun_4({select_tuple_arity,Tuple,{f,Fail},{list,Choices}}, Vst) ->
     kill_state(branch_arities(Choices, Tuple, branch_state(Fail, Vst)));
 valfun_4({get_list,Src,D1,D2}, Vst0) ->
     assert_type(cons, Src, Vst0),
-    Vst = set_type_reg(term, D1, Vst0),
-    set_type_reg(term, D2, Vst);
+    Vst = set_type_reg(term, Src, D1, Vst0),
+    set_type_reg(term, Src, D2, Vst);
 valfun_4({get_hd,Src,Dst}, Vst) ->
     assert_type(cons, Src, Vst),
-    set_type_reg(term, Dst, Vst);
+    set_type_reg(term, Src, Dst, Vst);
 valfun_4({get_tl,Src,Dst}, Vst) ->
     assert_type(cons, Src, Vst),
-    set_type_reg(term, Dst, Vst);
+    set_type_reg(term, Src, Dst, Vst);
 valfun_4({get_tuple_element,Src,I,Dst}, Vst) ->
     assert_type({tuple_element,I+1}, Src, Vst),
-    set_type_reg(term, Dst, Vst);
+    set_type_reg(term, Src, Dst, Vst);
 
 %% New bit syntax matching instructions.
 valfun_4({test,bs_start_match2,{f,Fail},Live,[Ctx,NeedSlots],Ctx}, Vst0) ->
@@ -625,7 +636,7 @@ valfun_4({test,bs_start_match2,{f,Fail},Live,[Src,Slots],Dst}, Vst0) ->
     verify_live(Live, Vst0),
     Vst1 = prune_x_regs(Live, Vst0),
     Vst = branch_state(Fail, Vst1),
-    set_type_reg(bsm_match_state(Slots), Dst, Vst);
+    set_type_reg(bsm_match_state(Slots), Src, Dst, Vst);
 valfun_4({test,bs_match_string,{f,Fail},[Ctx,_,_]}, Vst) ->
     bsm_validate_context(Ctx, Vst),
     branch_state(Fail, Vst);
@@ -650,7 +661,8 @@ valfun_4({test,bs_get_integer2,{f,Fail},Live,[Ctx,_,_,_],Dst}, Vst) ->
 valfun_4({test,bs_get_float2,{f,Fail},Live,[Ctx,_,_,_],Dst}, Vst) ->
     validate_bs_get(Fail, Ctx, Live, {float, []}, Dst, Vst);
 valfun_4({test,bs_get_binary2,{f,Fail},Live,[Ctx,_,_,_],Dst}, Vst) ->
-    validate_bs_get(Fail, Ctx, Live, term, Dst, Vst);
+    Type = propagate_fragility(term, [Ctx], Vst),
+    validate_bs_get(Fail, Ctx, Live, Type, Dst, Vst);
 valfun_4({test,bs_get_utf8,{f,Fail},Live,[Ctx,_],Dst}, Vst) ->
     validate_bs_get(Fail, Ctx, Live, {integer, []}, Dst, Vst);
 valfun_4({test,bs_get_utf16,{f,Fail},Live,[Ctx,_],Dst}, Vst) ->
@@ -790,7 +802,7 @@ verify_get_map(Fail, Src, List, Vst0) ->
     Vst2 = branch_state(Fail, Vst1),
     Keys = extract_map_keys(List),
     assert_unique_map_keys(Keys),
-    verify_get_map_pair(List,Vst0,Vst2).
+    verify_get_map_pair(List, Src, Vst0, Vst2).
 
 extract_map_vals([_Key,Val|T]) ->
     [Val|extract_map_vals(T)];
@@ -800,10 +812,11 @@ extract_map_keys([Key,_Val|T]) ->
     [Key|extract_map_keys(T)];
 extract_map_keys([]) -> [].
 
-verify_get_map_pair([],_,Vst) -> Vst;
-verify_get_map_pair([Src,Dst|Vs],Vst0,Vsti) ->
+verify_get_map_pair([Src,Dst|Vs], Map, Vst0, Vsti0) ->
     assert_term(Src, Vst0),
-    verify_get_map_pair(Vs,Vst0,set_type_reg(term,Dst,Vsti)).
+    Vsti = set_type_reg(term, Map, Dst, Vsti0),
+    verify_get_map_pair(Vs, Map, Vst0, Vsti);
+verify_get_map_pair([], _Map, _Vst0, Vst) -> Vst.
 
 verify_put_map(Fail, Src, Dst, Live, List, Vst0) ->
     assert_type(map, Src, Vst0),
@@ -1093,10 +1106,11 @@ bsm_validate_context(Reg, Vst) ->
 bsm_get_context({x,X}=Reg, #vst{current=#st{x=Xs}}=_Vst) when is_integer(X) ->
     case gb_trees:lookup(X, Xs) of
 	{value,#ms{}=Ctx} -> Ctx;
+	{value,{fragile,#ms{}=Ctx}} -> Ctx;
 	_ -> error({no_bsm_context,Reg})
     end;
 bsm_get_context(Reg, _) -> error({bad_source,Reg}).
-    
+
 bsm_save(Reg, {atom,start}, Vst) ->
     %% Save point refering to where the match started.
     %% It is always valid. But don't forget to validate the context register.
@@ -1133,13 +1147,34 @@ set_type(Type, {x,_}=Reg, Vst) -> set_type_reg(Type, Reg, Vst);
 set_type(Type, {y,_}=Reg, Vst) -> set_type_y(Type, Reg, Vst);
 set_type(_, _, #vst{}=Vst) -> Vst.
 
-set_type_reg(Type, {x,X}=Reg, #vst{current=#st{x=Xs}=St}=Vst)
-  when is_integer(X), 0 =< X ->
-    check_limit(Reg),
-    Vst#vst{current=St#st{x=gb_trees:enter(X, Type, Xs)}};
+set_type_reg(Type, Src, Dst, Vst) ->
+    case get_term_type_1(Src, Vst) of
+        {fragile,_} ->
+            set_type_reg(make_fragile(Type), Dst, Vst);
+        _ ->
+            set_type_reg(Type, Dst, Vst)
+    end.
+
+set_type_reg(Type, {x,_}=Reg, Vst) ->
+    set_type_x(Type, Reg, Vst);
 set_type_reg(Type, Reg, Vst) ->
     set_type_y(Type, Reg, Vst).
 
+set_type_x(Type, {x,X}=Reg, #vst{current=#st{x=Xs0}=St}=Vst)
+  when is_integer(X), 0 =< X ->
+    check_limit(Reg),
+    Xs = case gb_trees:lookup(X, Xs0) of
+             none ->
+                 gb_trees:insert(X, Type, Xs0);
+             {value,{fragile,_}} ->
+                 gb_trees:update(X, make_fragile(Type), Xs0);
+             {value,_} ->
+                 gb_trees:update(X, Type, Xs0)
+         end,
+    Vst#vst{current=St#st{x=Xs}};
+set_type_x(Type, Reg, #vst{}) ->
+    error({invalid_store,Reg,Type}).
+
 set_type_y(Type, {y,Y}=Reg, #vst{current=#st{y=Ys0}=St}=Vst)
   when is_integer(Y), 0 =< Y ->
     check_limit(Reg),
@@ -1157,6 +1192,9 @@ set_type_y(Type, {y,Y}=Reg, #vst{current=#st{y=Ys0}=St}=Vst)
     Vst#vst{current=St#st{y=Ys}};
 set_type_y(Type, Reg, #vst{}) -> error({invalid_store,Reg,Type}).
 
+make_fragile({fragile,_}=Type) -> Type;
+make_fragile(Type) -> {fragile,Type}.
+
 set_catch_end({y,Y}, #vst{current=#st{y=Ys0}=St}=Vst) ->
     Ys = gb_trees:update(Y, initialized, Ys0),
     Vst#vst{current=St#st{y=Ys}}.
@@ -1257,9 +1295,26 @@ assert_term(Src, Vst) ->
 %%
 %% map			Map.
 %%
+%%
+%%
+%% FRAGILITY
+%% ---------
+%%
+%% The loop_rec/2 instruction may return a reference to a term that is
+%% not part of the root set. That term or any part of it must not be
+%% included in a garbage collection. Therefore, the term (or any part
+%% of it) must not be stored in an Y register.
+%%
+%% Such terms are wrapped in a {fragile,Type} tuple, where Type is one
+%% of the types described above.
 
 assert_type(WantedType, Term, Vst) ->
-    assert_type(WantedType, get_term_type(Term, Vst)).
+    case get_term_type(Term, Vst) of
+        {fragile,Type} ->
+            assert_type(WantedType, Type);
+        Type ->
+            assert_type(WantedType, Type)
+    end.
 
 assert_type(Correct, Correct) -> ok;
 assert_type(float, {float,_}) -> ok;
@@ -1285,14 +1340,19 @@ assert_type(Needed, Actual) ->
 %%  is inconsistent, and we know that some instructions will never
 %%  be executed at run-time.
 
-upgrade_tuple_type({tuple,[Sz]}, {tuple,[OldSz]}=T) when Sz < OldSz ->
+upgrade_tuple_type(NewType, {fragile,OldType}) ->
+    make_fragile(upgrade_tuple_type_1(NewType, OldType));
+upgrade_tuple_type(NewType, OldType) ->
+    upgrade_tuple_type_1(NewType, OldType).
+
+upgrade_tuple_type_1({tuple,[Sz]}, {tuple,[OldSz]}=T) when Sz < OldSz ->
     %% The old type has a higher value for the least tuple size.
     T;
-upgrade_tuple_type({tuple,[Sz]}, {tuple,OldSz}=T) 
+upgrade_tuple_type_1({tuple,[Sz]}, {tuple,OldSz}=T)
   when is_integer(Sz), is_integer(OldSz), Sz =< OldSz ->
     %% The old size is exact, and the new size is smaller than the old size.
     T;
-upgrade_tuple_type({tuple,_}=T, _) ->
+upgrade_tuple_type_1({tuple,_}=T, _) ->
     %% The new type information is exact or has a higher value for
     %% the least tuple size.
     %%     Note that inconsistencies are also handled in this
@@ -1459,6 +1519,14 @@ merge_y_regs_1(_, _, Regs) -> Regs.
 %% merge_types(Type1, Type2) -> Type
 %%  Return the most specific type possible.
 %%  Note: Type1 must NOT be the same as Type2.
+merge_types({fragile,Same}=Type, Same) ->
+    Type;
+merge_types({fragile,T1}, T2) ->
+    make_fragile(merge_types(T1, T2));
+merge_types(Same, {fragile,Same}=Type) ->
+    Type;
+merge_types(T1, {fragile,T2}) ->
+    make_fragile(merge_types(T1, T2));
 merge_types(uninitialized=I, _) -> I;
 merge_types(_, uninitialized=I) -> I;
 merge_types(initialized=I, _) -> I;
@@ -1509,6 +1577,10 @@ verify_y_init(#vst{current=#st{y=Ys}}) ->
 verify_y_init_1([]) -> ok;
 verify_y_init_1([{Y,uninitialized}|_]) ->
     error({uninitialized_reg,{y,Y}});
+verify_y_init_1([{Y,{fragile,_}}|_]) ->
+    %% Unsafe. This term may be outside any heap belonging
+    %% to the process and would be corrupted by a GC.
+    error({fragile_message_reference,{y,Y}});
 verify_y_init_1([{_,_}|Ys]) ->
     verify_y_init_1(Ys).
 
@@ -1554,6 +1626,27 @@ eat_heap_float(#vst{current=#st{hf=HeapFloats0}=St}=Vst) ->
 	    Vst#vst{current=St#st{hf=HeapFloats}}
     end.
 
+remove_fragility(#vst{current=#st{x=Xs0,y=Ys0}=St0}=Vst) ->
+    F = fun(_, {fragile,Type}) -> Type;
+           (_, Type) -> Type
+        end,
+    Xs = gb_trees:map(F, Xs0),
+    Ys = gb_trees:map(F, Ys0),
+    St = St0#st{x=Xs,y=Ys},
+    Vst#vst{current=St}.
+
+propagate_fragility(Type, Ss, Vst) ->
+    F = fun(S) ->
+                case get_term_type_1(S, Vst) of
+                    {fragile,_} -> true;
+                    _ -> false
+                end
+        end,
+    case any(F, Ss) of
+        true -> make_fragile(Type);
+        false -> Type
+    end.
+
 bif_type('-', Src, Vst) ->
     arith_type(Src, Vst);
 bif_type('+', Src, Vst) ->
diff --git a/lib/compiler/test/beam_validator_SUITE.erl b/lib/compiler/test/beam_validator_SUITE.erl
index b8fff7b100..3af71559ae 100644
--- a/lib/compiler/test/beam_validator_SUITE.erl
+++ b/lib/compiler/test/beam_validator_SUITE.erl
@@ -33,7 +33,8 @@
 	 state_after_fault_in_catch/1,no_exception_in_catch/1,
 	 undef_label/1,illegal_instruction/1,failing_gc_guard_bif/1,
 	 map_field_lists/1,cover_bin_opt/1,
-	 val_dsetel/1,bad_tuples/1,bad_try_catch_nesting/1]).
+	 val_dsetel/1,bad_tuples/1,bad_try_catch_nesting/1,
+         receive_stacked/1]).
 
 -include_lib("common_test/include/ct.hrl").
 
@@ -62,7 +63,8 @@ groups() ->
        state_after_fault_in_catch,no_exception_in_catch,
        undef_label,illegal_instruction,failing_gc_guard_bif,
        map_field_lists,cover_bin_opt,val_dsetel,
-       bad_tuples,bad_try_catch_nesting]}].
+       bad_tuples,bad_try_catch_nesting,
+       receive_stacked]}].
 
 init_per_suite(Config) ->
     Config.
@@ -531,6 +533,52 @@ bad_try_catch_nesting(Config) ->
        {bad_try_catch_nesting,{y,2},[{{y,1},{trytag,[5]}}]}}}] = Errors,
     ok.
 
+receive_stacked(Config) ->
+    Mod = ?FUNCTION_NAME,
+    Errors = do_val(Mod, Config),
+    [{{receive_stacked,f1,0},
+      {{loop_rec_end,{f,3}},
+       17,
+       {fragile_message_reference,{y,0}}}},
+     {{receive_stacked,f2,0},
+      {{test_heap,3,0},10,{fragile_message_reference,{y,1}}}},
+     {{receive_stacked,f3,0},
+      {{test_heap,3,0},10,{fragile_message_reference,{y,1}}}},
+     {{receive_stacked,f4,0},
+      {{test_heap,3,0},10,{fragile_message_reference,{y,1}}}},
+     {{receive_stacked,f5,0},
+      {{loop_rec_end,{f,23}},
+       23,
+       {fragile_message_reference,{y,1}}}},
+     {{receive_stacked,f6,0},
+      {{gc_bif,byte_size,{f,29},0,[{y,0}],{x,0}},
+       12,
+       {fragile_message_reference,{y,0}}}},
+     {{receive_stacked,f7,0},
+      {{loop_rec_end,{f,33}},
+       20,
+       {fragile_message_reference,{y,0}}}},
+     {{receive_stacked,f8,0},
+      {{loop_rec_end,{f,38}},
+       20,
+       {fragile_message_reference,{y,0}}}},
+     {{receive_stacked,m1,0},
+      {{loop_rec_end,{f,43}},
+       19,
+       {fragile_message_reference,{y,0}}}},
+     {{receive_stacked,m2,0},
+      {{loop_rec_end,{f,48}},
+       33,
+       {fragile_message_reference,{y,0}}}}] = Errors,
+
+    %% Compile the original source code as a smoke test.
+    Data = proplists:get_value(data_dir, Config),
+    Base = atom_to_list(Mod),
+    File = filename:join(Data, Base),
+    {ok,Mod,_} = compile:file(File, [binary]),
+
+    ok.
+
 %%%-------------------------------------------------------------------------
 
 transform_remove(Remove, Module) ->
diff --git a/lib/compiler/test/beam_validator_SUITE_data/receive_stacked.S b/lib/compiler/test/beam_validator_SUITE_data/receive_stacked.S
new file mode 100644
index 0000000000..cca052a9c4
--- /dev/null
+++ b/lib/compiler/test/beam_validator_SUITE_data/receive_stacked.S
@@ -0,0 +1,390 @@
+{module, receive_stacked}.  %% version = 0
+
+{exports, [{f1,0},
+           {f2,0},
+           {f3,0},
+           {f4,0},
+           {f5,0},
+           {f6,0},
+           {f7,0},
+           {f8,0},
+           {id,1},
+           {m1,0},
+           {m2,0},
+           {module_info,0},
+           {module_info,1}]}.
+
+{attributes, []}.
+
+{labels, 57}.
+
+
+{function, f1, 0, 2}.
+  {label,1}.
+    {line,[{location,"receive_stacked.erl",15}]}.
+    {func_info,{atom,receive_stacked},{atom,f1},0}.
+  {label,2}.
+    {allocate_zero,1,0}.
+  {label,3}.
+    {loop_rec,{f,5},{x,0}}.
+    {move,{x,0},{y,0}}.
+    {test,is_integer,{f,4},[{y,0}]}.
+    remove_message.
+    {move,{integer,42},{x,0}}.
+    {line,[{location,"receive_stacked.erl",18}]}.
+    {call,1,{f,52}}.
+    {move,{y,0},{x,0}}.
+    {deallocate,1}.
+    return.
+  {label,4}.
+    {loop_rec_end,{f,3}}.
+  {label,5}.
+    {wait,{f,3}}.
+
+
+{function, f2, 0, 7}.
+  {label,6}.
+    {line,[{location,"receive_stacked.erl",22}]}.
+    {func_info,{atom,receive_stacked},{atom,f2},0}.
+  {label,7}.
+    {allocate_zero,2,0}.
+  {label,8}.
+    {loop_rec,{f,10},{x,0}}.
+    {test,is_nonempty_list,{f,9},[{x,0}]}.
+    {get_list,{x,0},{y,1},{x,0}}.
+    {test,is_nil,{f,9},[{x,0}]}.
+    {test_heap,3,0}.
+    remove_message.
+    {put_tuple,2,{y,0}}.
+    {put,{atom,ok}}.
+    {put,{y,1}}.
+    {move,{integer,42},{x,0}}.
+    {line,[{location,"receive_stacked.erl",26}]}.
+    {call,1,{f,52}}.
+    {test_heap,3,0}.
+    {put_tuple,2,{x,0}}.
+    {put,{y,0}}.
+    {put,{y,1}}.
+    {deallocate,2}.
+    return.
+  {label,9}.
+    {loop_rec_end,{f,8}}.
+  {label,10}.
+    {wait,{f,8}}.
+
+
+{function, f3, 0, 12}.
+  {label,11}.
+    {line,[{location,"receive_stacked.erl",30}]}.
+    {func_info,{atom,receive_stacked},{atom,f3},0}.
+  {label,12}.
+    {allocate_zero,2,0}.
+  {label,13}.
+    {loop_rec,{f,15},{x,0}}.
+    {test,is_nonempty_list,{f,14},[{x,0}]}.
+    {get_hd,{x,0},{y,1}}.
+    {test,is_integer,{f,14},[{y,1}]}.
+    {test_heap,3,0}.
+    remove_message.
+    {put_tuple,2,{y,0}}.
+    {put,{atom,ok}}.
+    {put,{y,1}}.
+    {move,{integer,42},{x,0}}.
+    {line,[{location,"receive_stacked.erl",34}]}.
+    {call,1,{f,52}}.
+    {test_heap,3,0}.
+    {put_tuple,2,{x,0}}.
+    {put,{y,0}}.
+    {put,{y,1}}.
+    {deallocate,2}.
+    return.
+  {label,14}.
+    {loop_rec_end,{f,13}}.
+  {label,15}.
+    {wait,{f,13}}.
+
+
+{function, f4, 0, 17}.
+  {label,16}.
+    {line,[{location,"receive_stacked.erl",38}]}.
+    {func_info,{atom,receive_stacked},{atom,f4},0}.
+  {label,17}.
+    {allocate_zero,2,0}.
+  {label,18}.
+    {loop_rec,{f,20},{x,0}}.
+    {test,is_nonempty_list,{f,19},[{x,0}]}.
+    {get_tl,{x,0},{y,1}}.
+    {test,is_list,{f,19},[{y,1}]}.
+    {test_heap,3,0}.
+    remove_message.
+    {put_tuple,2,{y,0}}.
+    {put,{atom,ok}}.
+    {put,{y,1}}.
+    {move,{integer,42},{x,0}}.
+    {line,[{location,"receive_stacked.erl",42}]}.
+    {call,1,{f,52}}.
+    {test_heap,3,0}.
+    {put_tuple,2,{x,0}}.
+    {put,{y,0}}.
+    {put,{y,1}}.
+    {deallocate,2}.
+    return.
+  {label,19}.
+    {loop_rec_end,{f,18}}.
+  {label,20}.
+    {wait,{f,18}}.
+
+
+{function, f5, 0, 22}.
+  {label,21}.
+    {line,[{location,"receive_stacked.erl",46}]}.
+    {func_info,{atom,receive_stacked},{atom,f5},0}.
+  {label,22}.
+    {allocate_zero,2,0}.
+  {label,23}.
+    {loop_rec,{f,25},{x,0}}.
+    {test,is_tuple,{f,24},[{x,0}]}.
+    {test,test_arity,{f,24},[{x,0},1]}.
+    {get_tuple_element,{x,0},0,{y,1}}.
+    {test,is_integer,{f,24},[{y,1}]}.
+    remove_message.
+    {put_map_assoc,{f,0},{literal,#{}},{y,0},0,{list,[{atom,key},{y,1}]}}.
+    {move,{integer,42},{x,0}}.
+    {line,[{location,"receive_stacked.erl",50}]}.
+    {call,1,{f,52}}.
+    {test_heap,3,0}.
+    {put_tuple,2,{x,0}}.
+    {put,{y,0}}.
+    {put,{y,1}}.
+    {deallocate,2}.
+    return.
+  {label,24}.
+    {loop_rec_end,{f,23}}.
+  {label,25}.
+    {wait,{f,23}}.
+
+
+{function, f6, 0, 27}.
+  {label,26}.
+    {line,[{location,"receive_stacked.erl",54}]}.
+    {func_info,{atom,receive_stacked},{atom,f6},0}.
+  {label,27}.
+    {allocate_zero,1,0}.
+  {label,28}.
+    {loop_rec,{f,30},{x,0}}.
+    {test,bs_start_match2,{f,29},1,[{x,0},0],{x,0}}.
+    {test,bs_get_integer2,
+          {f,29},
+          1,
+          [{x,0},
+           {integer,8},
+           1,
+           {field_flags,[{anno,[56,{file,"receive_stacked.erl"}]},
+                         unsigned,big]}],
+          {x,1}}.
+    {test,bs_get_binary2,
+          {f,29},
+          1,
+          [{x,0},
+           {atom,all},
+           8,
+           {field_flags,[{anno,[56,{file,"receive_stacked.erl"}]},
+                         unsigned,big]}],
+          {y,0}}.
+    {'%',
+        {no_bin_opt,
+            {binary_used_in,{gc_bif,byte_size,{f,29},0,[{y,0}],{x,0}}},
+            [56,{file,"receive_stacked.erl"}]}}.
+    {line,[{location,"receive_stacked.erl",56}]}.
+    {gc_bif,byte_size,{f,29},0,[{y,0}],{x,0}}.
+    {test,is_lt,{f,29},[{integer,8},{x,0}]}.
+    remove_message.
+    {move,{integer,42},{x,0}}.
+    {line,[{location,"receive_stacked.erl",57}]}.
+    {call,1,{f,52}}.
+    {move,{y,0},{x,0}}.
+    {deallocate,1}.
+    return.
+  {label,29}.
+    {loop_rec_end,{f,28}}.
+  {label,30}.
+    {wait,{f,28}}.
+
+
+{function, f7, 0, 32}.
+  {label,31}.
+    {line,[{location,"receive_stacked.erl",61}]}.
+    {func_info,{atom,receive_stacked},{atom,f7},0}.
+  {label,32}.
+    {allocate_zero,1,0}.
+  {label,33}.
+    {loop_rec,{f,35},{x,0}}.
+    {test,bs_start_match2,{f,34},1,[{x,0},0],{x,0}}.
+    {test,bs_get_integer2,
+          {f,34},
+          1,
+          [{x,0},
+           {integer,8},
+           1,
+           {field_flags,[{anno,[63,{file,"receive_stacked.erl"}]},
+                         unsigned,big]}],
+          {x,1}}.
+    {test,bs_get_binary2,
+          {f,34},
+          1,
+          [{x,0},
+           {atom,all},
+           8,
+           {field_flags,[{anno,[63,{file,"receive_stacked.erl"}]},
+                         unsigned,big]}],
+          {y,0}}.
+    {'%',{no_bin_opt,{binary_used_in,{test,is_binary,{f,34},[{y,0}]}},
+                     [63,{file,"receive_stacked.erl"}]}}.
+    {test,is_binary,{f,34},[{y,0}]}.
+    remove_message.
+    {move,{integer,42},{x,0}}.
+    {line,[{location,"receive_stacked.erl",64}]}.
+    {call,1,{f,52}}.
+    {move,{y,0},{x,0}}.
+    {deallocate,1}.
+    return.
+  {label,34}.
+    {loop_rec_end,{f,33}}.
+  {label,35}.
+    {wait,{f,33}}.
+
+
+{function, f8, 0, 37}.
+  {label,36}.
+    {line,[{location,"receive_stacked.erl",68}]}.
+    {func_info,{atom,receive_stacked},{atom,f8},0}.
+  {label,37}.
+    {allocate_zero,1,0}.
+  {label,38}.
+    {loop_rec,{f,40},{x,0}}.
+    {test,bs_start_match2,{f,39},1,[{x,0},0],{x,1}}.
+    {test,bs_get_integer2,
+          {f,39},
+          2,
+          [{x,1},
+           {integer,8},
+           1,
+           {field_flags,[{anno,[70,{file,"receive_stacked.erl"}]},
+                         unsigned,big]}],
+          {x,2}}.
+    {test,bs_get_binary2,
+          {f,39},
+          2,
+          [{x,1},
+           {atom,all},
+           8,
+           {field_flags,[{anno,[70,{file,"receive_stacked.erl"}]},
+                         unsigned,big]}],
+          {y,0}}.
+    {'%',{no_bin_opt,{[{x,1},{y,0}],{loop_rec_end,{f,38}},not_handled},
+                     [70,{file,"receive_stacked.erl"}]}}.
+    {test,is_binary,{f,39},[{x,0}]}.
+    remove_message.
+    {move,{integer,42},{x,0}}.
+    {line,[{location,"receive_stacked.erl",71}]}.
+    {call,1,{f,52}}.
+    {move,{y,0},{x,0}}.
+    {deallocate,1}.
+    return.
+  {label,39}.
+    {loop_rec_end,{f,38}}.
+  {label,40}.
+    {wait,{f,38}}.
+
+
+{function, m1, 0, 42}.
+  {label,41}.
+    {line,[{location,"receive_stacked.erl",75}]}.
+    {func_info,{atom,receive_stacked},{atom,m1},0}.
+  {label,42}.
+    {allocate_zero,1,0}.
+  {label,43}.
+    {loop_rec,{f,45},{x,0}}.
+    {test,is_map,{f,44},[{x,0}]}.
+    {get_map_elements,{f,44},{x,0},{list,[{atom,key},{y,0}]}}.
+    {test,is_integer,{f,44},[{y,0}]}.
+    remove_message.
+    {move,{integer,42},{x,0}}.
+    {line,[{location,"receive_stacked.erl",78}]}.
+    {call,1,{f,52}}.
+    {test_heap,2,0}.
+    {put_list,{y,0},nil,{x,0}}.
+    {deallocate,1}.
+    return.
+  {label,44}.
+    {loop_rec_end,{f,43}}.
+  {label,45}.
+    {wait,{f,43}}.
+
+
+{function, m2, 0, 47}.
+  {label,46}.
+    {line,[{location,"receive_stacked.erl",82}]}.
+    {func_info,{atom,receive_stacked},{atom,m2},0}.
+  {label,47}.
+    {allocate_zero,4,0}.
+    {move,{atom,key1},{x,0}}.
+    {line,[{location,"receive_stacked.erl",83}]}.
+    {call,1,{f,52}}.
+    {move,{x,0},{y,3}}.
+    {move,{atom,key2},{x,0}}.
+    {line,[{location,"receive_stacked.erl",84}]}.
+    {call,1,{f,52}}.
+    {move,{x,0},{y,2}}.
+  {label,48}.
+    {loop_rec,{f,50},{x,0}}.
+    {test,is_map,{f,49},[{x,0}]}.
+    {get_map_elements,{f,49},{x,0},{list,[{y,3},{y,1}]}}.
+    {get_map_elements,{f,49},{x,0},{list,[{y,2},{y,0}]}}.
+    {test,is_integer,{f,49},[{y,1}]}.
+    {test,is_integer,{f,49},[{y,0}]}.
+    remove_message.
+    {kill,{y,2}}.
+    {kill,{y,3}}.
+    {move,{integer,42},{x,0}}.
+    {line,[{location,"receive_stacked.erl",87}]}.
+    {call,1,{f,52}}.
+    {test_heap,3,0}.
+    {put_tuple,2,{x,0}}.
+    {put,{y,1}}.
+    {put,{y,0}}.
+    {deallocate,4}.
+    return.
+  {label,49}.
+    {loop_rec_end,{f,48}}.
+  {label,50}.
+    {wait,{f,48}}.
+
+
+{function, id, 1, 52}.
+  {label,51}.
+    {line,[{location,"receive_stacked.erl",91}]}.
+    {func_info,{atom,receive_stacked},{atom,id},1}.
+  {label,52}.
+    return.
+
+
+{function, module_info, 0, 54}.
+  {label,53}.
+    {line,[]}.
+    {func_info,{atom,receive_stacked},{atom,module_info},0}.
+  {label,54}.
+    {move,{atom,receive_stacked},{x,0}}.
+    {line,[]}.
+    {call_ext_only,1,{extfunc,erlang,get_module_info,1}}.
+
+
+{function, module_info, 1, 56}.
+  {label,55}.
+    {line,[]}.
+    {func_info,{atom,receive_stacked},{atom,module_info},1}.
+  {label,56}.
+    {move,{x,0},{x,1}}.
+    {move,{atom,receive_stacked},{x,0}}.
+    {line,[]}.
+    {call_ext_only,2,{extfunc,erlang,get_module_info,2}}.
diff --git a/lib/compiler/test/beam_validator_SUITE_data/receive_stacked.erl b/lib/compiler/test/beam_validator_SUITE_data/receive_stacked.erl
new file mode 100644
index 0000000000..b95fa9ca62
--- /dev/null
+++ b/lib/compiler/test/beam_validator_SUITE_data/receive_stacked.erl
@@ -0,0 +1,92 @@
+-module(receive_stacked).
+-compile([export_all,nowarn_export_all]).
+
+%% Messages may be stored outside any process heap until they
+%% have been accepted by the 'remove_message' instruction.
+%% When matching of a message fails, it is not allowed to
+%% leave references to the message or any part of it in
+%% the Y registers. An experimental code generator could
+%% do that, causing an emulator crash if there happenened to
+%% be a garbage collection.
+%%
+%% The 'S' file corresponding to this file was compiled with
+%% that experimental code generator.
+
+f1() ->
+    receive
+        X when is_integer(X) ->
+            id(42),
+            X
+    end.
+
+f2() ->
+    receive
+        [X] ->
+            Res = {ok,X},
+            id(42),
+            {Res,X}
+    end.
+
+f3() ->
+    receive
+        [H|_] when is_integer(H) ->
+            Res = {ok,H},
+            id(42),
+            {Res,H}
+    end.
+
+f4() ->
+    receive
+        [_|T] when is_list(T) ->
+            Res = {ok,T},
+            id(42),
+            {Res,T}
+    end.
+
+f5() ->
+    receive
+        {X} when is_integer(X) ->
+            Res = #{key=>X},
+            id(42),
+            {Res,X}
+    end.
+
+f6() ->
+    receive
+        <<_:8,T/binary>> when byte_size(T) > 8 ->
+            id(42),
+            T
+    end.
+
+f7() ->
+    receive
+        <<_:8,T/binary>> when is_binary(T) ->
+            id(42),
+            T
+    end.
+
+f8() ->
+    receive
+        <<_:8,T/binary>> = Bin when is_binary(Bin) ->
+            id(42),
+            T
+    end.
+
+m1() ->
+    receive
+        #{key:=V} when is_integer(V) ->
+            id(42),
+            [V]
+    end.
+
+m2() ->
+    K1 = id(key1),
+    K2 = id(key2),
+    receive
+        #{K1:=V1,K2:=V2} when is_integer(V1), is_integer(V2) ->
+            id(42),
+            {V1,V2}
+    end.
+
+id(I) ->
+    I.