inets: Ctify inets_SUITE

Also remove all form of io:formats that can easily be achieved
by tracing.

1 files changed, 25 insertions, 142 deletions

diff --git a/lib/inets/test/inets_SUITE.erl b/lib/inets/test/inets_SUITE.erl
index c3586f09e3..928d9dc391 100644
--- a/lib/inets/test/inets_SUITE.erl
+++ b/lib/inets/test/inets_SUITE.erl
@@ -21,7 +21,6 @@
 -module(inets_SUITE).
 
 -include_lib("common_test/include/ct.hrl").
--include("test_server_line.hrl").
 -include("inets_test_lib.hrl").
 
 %% Note: This directive should only be used in test suites.
@@ -37,8 +36,12 @@ all() ->
 
 groups() -> 
     [{services_test, [],
-      [start_inets, start_httpc, start_httpd, start_ftpc,
-       start_tftpd]},
+      [start_inets, 
+       start_httpc, 
+       start_httpd, 
+       start_ftpc,
+       start_tftpd
+      ]},
      {app_test, [], [{inets_app_test, all}]},
      {appup_test, [], [{inets_appup_test, all}]}].
 
@@ -48,9 +51,6 @@ init_per_group(_GroupName, Config) ->
 end_per_group(_GroupName, Config) ->
     Config.
 
-
-
-
 %%--------------------------------------------------------------------
 %% Function: init_per_suite(Config) -> Config
 %% Config - [tuple()]
@@ -103,14 +103,8 @@ end_per_testcase(_, Config) ->
 %% Test cases starts here.
 %%-------------------------------------------------------------------------
 
-
-
-%%-------------------------------------------------------------------------
-
-start_inets(doc) ->
-    ["Test inets API functions"];
-start_inets(suite) ->
-    [];
+start_inets() ->
+    [{doc, "Test inets API functions"}].
 start_inets(Config) when is_list(Config) ->
     [_|_] = inets:service_names(),
 
@@ -134,134 +128,85 @@ start_inets(Config) when is_list(Config) ->
     ok = inets:start(permanent),
     ok = inets:stop().
 
-
 %%-------------------------------------------------------------------------
 
-start_httpc(doc) ->
-    ["Start/stop of httpc service"];
-start_httpc(suite) ->
-    [];
+start_httpc() ->
+    [{doc, "Start/stop of httpc service"}].
 start_httpc(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
-    tsp("start_httpc -> entry with"
-	"~n   Config: ~p", [Config]),
-
     PrivDir = ?config(priv_dir, Config),
 
-    tsp("start_httpc -> start (empty) inets"),
     ok = inets:start(),
-
-    tsp("start_httpc -> start httpc (as inets service) with profile foo"),
     {ok, Pid0} = inets:start(httpc, [{profile, foo}]),
 
-    tsp("start_httpc -> check running services"),
     Pids0 =  [ServicePid || {_, ServicePid} <- inets:services()],  
     true = lists:member(Pid0, Pids0),
     [_|_] = inets:services_info(),	
 
-    tsp("start_httpc -> stop httpc"),
     inets:stop(httpc, Pid0),
 
-    tsp("start_httpc -> sleep some"),
     test_server:sleep(100),
 
-    tsp("start_httpc -> check running services"),
     Pids1 =  [ServicePid || {_, ServicePid} <- inets:services()], 
     false = lists:member(Pid0, Pids1),        
 
-    tsp("start_httpc -> start httpc (stand-alone) with profile bar"),
     {ok, Pid1} = inets:start(httpc, [{profile, bar}], stand_alone),
 
-    tsp("start_httpc -> check running services"),
     Pids2 =  [ServicePid || {_, ServicePid} <- inets:services()], 
     false = lists:member(Pid1, Pids2),   
 
-    tsp("start_httpc -> stop httpc"),
     ok = inets:stop(stand_alone, Pid1),
     receive 
 	{'EXIT', Pid1, shutdown} ->
 	    ok
     after 100 ->
-	    tsf(stand_alone_not_shutdown)
+	    ct:fail(stand_alone_not_shutdown)
     end,
 
-    tsp("start_httpc -> stop inets"),
     ok = inets:stop(),
 
-    tsp("start_httpc -> unload inets"),
     application:load(inets),
-
-    tsp("start_httpc -> set inets environment (httpc profile foo)"),
     application:set_env(inets, services, [{httpc,[{profile, foo}, 
 						  {data_dir, PrivDir}]}]),
-
-    tsp("start_httpc -> start inets"),
     ok = inets:start(),
 
-    tsp("start_httpc -> check running services"),
     (?NUM_DEFAULT_SERVICES + 1) = length(inets:services()),
 
-    tsp("start_httpc -> unset inets env"),
     application:unset_env(inets, services),
-
-    tsp("start_httpc -> stop inets"),
     ok = inets:stop(),
-
-    tsp("start_httpc -> start (empty) inets"),
     ok = inets:start(),
 
-    tsp("start_httpc -> start inets httpc service with profile foo"),
     {ok, Pid3} = inets:start(httpc, [{profile, foo}]),
-
-    tsp("start_httpc -> stop inets service httpc with profile foo"),
     ok = inets:stop(httpc, foo),
-
-    tsp("start_httpc -> check running services"),
     Pids3 =  [ServicePid || {_, ServicePid} <- inets:services()], 
     false = lists:member(Pid3, Pids3),      
-
-    tsp("start_httpc -> stop inets"),
-    ok = inets:stop(),
-
-    tsp("start_httpc -> done"),    
-    ok.
-
+    ok = inets:stop().
 
 %%-------------------------------------------------------------------------
 
-start_httpd(doc) ->
-    ["Start/stop of httpd service"];
-start_httpd(suite) ->
-    [];
+start_httpd() ->
+    [{doc, "Start/stop of httpd service"}].
 start_httpd(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
-    i("start_httpd -> entry with"
-      "~n   Config: ~p", [Config]),
     PrivDir = ?config(priv_dir, Config),
     HttpdConf = [{server_name, "httpd_test"}, {server_root, PrivDir},
-		 {document_root, PrivDir}, {bind_address, "localhost"}],
+		 {document_root, PrivDir}, {bind_address, any}],
     
-    i("start_httpd -> start inets"),
     ok = inets:start(),
-
-    i("start_httpd -> start httpd service"),
     {ok, Pid0} = inets:start(httpd, [{port, 0}, {ipfamily, inet} | HttpdConf]),
     Pids0 =  [ServicePid || {_, ServicePid} <- inets:services()],  
     true = lists:member(Pid0, Pids0),
     [_|_] = inets:services_info(),	
 
-    i("start_httpd -> stop httpd service"),
     inets:stop(httpd, Pid0),
     test_server:sleep(500),
     Pids1 =  [ServicePid || {_, ServicePid} <- inets:services()], 
     false = lists:member(Pid0, Pids1),        
-    i("start_httpd -> start (stand-alone) httpd service"),
     {ok, Pid1} = 
 	inets:start(httpd, [{port, 0}, {ipfamily, inet} | HttpdConf], 
 		    stand_alone),
     Pids2 =  [ServicePid || {_, ServicePid} <- inets:services()], 
     false = lists:member(Pid1, Pids2),   
-    i("start_httpd -> stop (stand-alone) httpd service"),
     ok = inets:stop(stand_alone, Pid1),
     receive 
 	{'EXIT', Pid1, shutdown} ->
@@ -269,7 +214,6 @@ start_httpd(Config) when is_list(Config) ->
     after 100 ->
 	    test_server:fail(stand_alone_not_shutdown)
     end,
-    i("start_httpd -> stop inets"),
     ok = inets:stop(),
     File0 = filename:join(PrivDir, "httpd.conf"),
     {ok, Fd0} =  file:open(File0, [write]),
@@ -277,17 +221,12 @@ start_httpd(Config) when is_list(Config) ->
     ok = file:write(Fd0, Str),
     file:close(Fd0),
 
-    i("start_httpd -> [application] load inets"),
     application:load(inets),
-    i("start_httpd -> [application] set httpd services env with proplist-file"),
     application:set_env(inets, 
 			services, [{httpd, [{proplist_file, File0}]}]),
-    i("start_httpd -> start inets"),
     ok = inets:start(),
     (?NUM_DEFAULT_SERVICES + 1) = length(inets:services()),
-    i("start_httpd -> [application] unset services env"),
     application:unset_env(inets, services),
-    i("start_httpd -> stop inets"),
     ok = inets:stop(),
     
     File1 = filename:join(PrivDir, "httpd_apache.conf"),
@@ -300,68 +239,46 @@ start_httpd(Config) when is_list(Config) ->
     file:write(Fd1, "Port 0\r\n"),
     file:close(Fd1),
 
-    i("start_httpd -> [application] load inets"),
     application:load(inets),
-    i("start_httpd -> [application] set httpd services env with file"),
     application:set_env(inets, 
 			services, [{httpd, [{file, File1}]}]),
-    i("start_httpd -> start inets"),
     ok = inets:start(),
     (?NUM_DEFAULT_SERVICES + 1) = length(inets:services()),
-    i("start_httpd -> [application] unset services env"),
     application:unset_env(inets, services),
-    i("start_httpd -> stop inets"),
     ok = inets:stop(),
     
     %% OLD format
-    i("start_httpd -> [application] load inets"),
     application:load(inets),
-    i("start_httpd -> [application] set httpd services OLD env"),
     application:set_env(inets, 
 			services, [{httpd, File1}]),
-    i("start_httpd -> start inets"),
     ok = inets:start(),
     (?NUM_DEFAULT_SERVICES + 1) = length(inets:services()),
-    i("start_httpd -> [application] unset services enc"),
     application:unset_env(inets, services),
-    i("start_httpd -> stop inets"),
     ok = inets:stop(),
-
-    i("start_httpd -> start inets"),
     ok = inets:start(),
-    i("start_httpd -> try (and fail) start httpd service - server_name"),
     {error, {missing_property, server_name}} = 
 	inets:start(httpd, [{port, 0},
 			    {server_root, PrivDir},
 			    {document_root, PrivDir}, 
 			    {bind_address, "localhost"}]),
-    i("start_httpd -> try (and fail) start httpd service - missing document_root"),
     {error, {missing_property, document_root}} = 
 	inets:start(httpd, [{port, 0},
 			    {server_name, "httpd_test"}, 
 			    {server_root, PrivDir},
 			    {bind_address, "localhost"}]),
-    i("start_httpd -> try (and fail) start httpd service - missing server_root"),
     {error, {missing_property, server_root}} = 
 	inets:start(httpd, [{port, 0},
 			    {server_name, "httpd_test"}, 
 			    {document_root, PrivDir},
 			    {bind_address, "localhost"}]),
-    i("start_httpd -> try (and fail) start httpd service - missing port"),
     {error, {missing_property, port}} = 
 	inets:start(httpd, HttpdConf),
-    i("start_httpd -> stop inets"),
-    ok = inets:stop(),
-    i("start_httpd -> done"),
-    ok.
-    
+    ok = inets:stop().
 
 %%-------------------------------------------------------------------------
 
 start_ftpc(doc) ->
-    ["Start/stop of ftpc service"];
-start_ftpc(suite) ->
-    [];
+    [{doc, "Start/stop of ftpc service"}];
 start_ftpc(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
     ok = inets:start(),
@@ -389,7 +306,7 @@ start_ftpc(Config) when is_list(Config) ->
 			{'EXIT', Pid1, shutdown} ->
 			    ok
 		    after 100 ->
-			    tsf(stand_alone_not_shutdown)
+			    ct:fail(stand_alone_not_shutdown)
 		    end,
 		    ok = inets:stop(),
 		    ok;
@@ -401,15 +318,11 @@ start_ftpc(Config) when is_list(Config) ->
 	throw:{error, not_found} ->
 	    {skip, "No available FTP servers"}
     end.
-	    
-
 
 %%-------------------------------------------------------------------------
 
-start_tftpd(doc) ->
-    ["Start/stop of tfpd service"];
-start_tftpd(suite) ->
-    [];
+start_tftpd() ->
+    [{doc, "Start/stop of tfpd service"}].
 start_tftpd(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
     ok = inets:start(),
@@ -441,16 +354,12 @@ start_tftpd(Config) when is_list(Config) ->
     application:unset_env(inets, services),
     ok = inets:stop().
 
-
 %%-------------------------------------------------------------------------
 
-httpd_reload(doc) ->
-    ["Reload httpd configuration without restarting service"];
-httpd_reload(suite) ->
-    [];
+httpd_reload() ->
+    [{doc, "Reload httpd configuration without restarting service"}].
 httpd_reload(Config) when is_list(Config) ->
     process_flag(trap_exit, true),
-    i("httpd_reload -> starting"),
     PrivDir = ?config(priv_dir, Config),
     DataDir =  ?config(data_dir, Config),
     HttpdConf = [{server_name,   "httpd_test"}, 
@@ -458,23 +367,18 @@ httpd_reload(Config) when is_list(Config) ->
 		 {document_root, PrivDir}, 
 		 {bind_address,  "localhost"}],
 
-    i("httpd_reload -> start inets"),
-
     ok = inets:start(),
     test_server:sleep(5000),
-    i("httpd_reload -> inets started - start httpd service"),
 
-    {ok, Pid0} = inets:start(httpd, [{port, 0}, {ipfamily, inet} | HttpdConf]),
+    {ok, Pid0} = inets:start(httpd, [{port, 0}, 
+				     {ipfamily, inet} | HttpdConf]),
     test_server:sleep(5000),
-    i("httpd_reload -> httpd service started (~p) - get port", [Pid0]),
 
     [{port, Port0}] = httpd:info(Pid0, [port]),         
     test_server:sleep(5000),
-    i("httpd_reload -> Port: ~p - get document root", [Port0]),
 
     [{document_root, PrivDir}] =  httpd:info(Pid0, [document_root]),
     test_server:sleep(5000),
-    i("httpd_reload -> document root: ~p - reload config", [PrivDir]),
 
     ok = httpd:reload_config([{port, Port0}, {ipfamily, inet},
 			      {server_name, "httpd_test"}, 
@@ -482,11 +386,8 @@ httpd_reload(Config) when is_list(Config) ->
 			      {document_root, DataDir}, 
 			      {bind_address, "localhost"}], non_disturbing),
     test_server:sleep(5000),    
-    io:format("~w:~w:httpd_reload - reloaded - get document root~n", [?MODULE, ?LINE]),
-
     [{document_root, DataDir}] =  httpd:info(Pid0, [document_root]),
     test_server:sleep(5000),    
-    i("httpd_reload -> document root: ~p - reload config", [DataDir]),
 
     ok = httpd:reload_config([{port, Port0}, {ipfamily, inet},
 			      {server_name, "httpd_test"}, 
@@ -539,23 +440,5 @@ httpd_reload(Config) when is_list(Config) ->
     
     ok = inets:stop(httpd, Pid1),
     application:unset_env(inets, services),
-    ok = inets:stop(),
-    i("httpd_reload -> starting"),
-    ok.
-    
-
-tsf(Reason) ->
-    test_server:fail(Reason).
-
-tsp(F) ->
-    tsp(F, []).
-tsp(F, A) ->
-    Timestamp = inets_lib:formated_timestamp(),
-    test_server:format("** ~s ** ~p ~p:" ++ F ++ "~n", [Timestamp, self(), ?MODULE | A]).
-
-i(F) ->
-    i(F, []).
+    ok = inets:stop().
 
-i(F, A) ->
-    Timestamp = inets_lib:formated_timestamp(),
-    io:format("*** ~s ~w:" ++ F ++ "~n", [Timestamp, ?MODULE | A]).