Fix testcases after removal of non-smp emulator

7 files changed, 38 insertions, 173 deletions

diff --git a/lib/common_test/test_server/ts_install.erl b/lib/common_test/test_server/ts_install.erl
index c4e0223ac7..c5631fb9c3 100644
--- a/lib/common_test/test_server/ts_install.erl
+++ b/lib/common_test/test_server/ts_install.erl
@@ -408,17 +408,13 @@ off_heap_msgq() ->
     end.
 
 schedulers() ->
-    case catch erlang:system_info(smp_support) of
-	true ->
-	    case {erlang:system_info(schedulers),
-		  erlang:system_info(schedulers_online)} of
-		{S,S} ->
-		    "/S"++integer_to_list(S);
-		{S,O} ->
-		    "/S"++integer_to_list(S) ++ ":" ++
-			integer_to_list(O)
-	    end;
-	_ -> ""
+    case {erlang:system_info(schedulers),
+          erlang:system_info(schedulers_online)} of
+        {S,S} ->
+            "/S"++integer_to_list(S);
+        {S,O} ->
+            "/S"++integer_to_list(S) ++ ":" ++
+                integer_to_list(O)
     end.
 
 bind_type() ->
diff --git a/lib/common_test/test_server/ts_run.erl b/lib/common_test/test_server/ts_run.erl
index 82ae44ec06..ec4a54b249 100644
--- a/lib/common_test/test_server/ts_run.erl
+++ b/lib/common_test/test_server/ts_run.erl
@@ -204,11 +204,7 @@ make_command(Vars, Spec, State) ->
 		      _ ->
 			  ok
 		  end,
-		  "cerl -valgrind" ++
-		      case erlang:system_info(smp_support) of
-			  true -> " -smp";
-			  false -> ""
-		      end
+		  "cerl -valgrind"
 	  end,
     Naming =
 	case ts_lib:var(longnames, Vars) of
diff --git a/lib/kernel/test/gen_udp_SUITE.erl b/lib/kernel/test/gen_udp_SUITE.erl
index aa616d43d6..8364fe7cdc 100644
--- a/lib/kernel/test/gen_udp_SUITE.erl
+++ b/lib/kernel/test/gen_udp_SUITE.erl
@@ -295,21 +295,9 @@ bad_address(Config) when is_list(Config) ->
 %% are received per in/out scheduling, which should be
 %% the same as the read_packets parameter.
 %% 
-%% What happens on the SMP emulator remains to be seen...
-%%
 
 %% OTP-6249 UDP option for number of packet reads.
 read_packets(Config) when is_list(Config) ->
-    case erlang:system_info(smp_support) of
-	false ->
-	    read_packets_1();
-	true ->
-	    %% We would need some new sort of tracing to test this
-	    %% option reliably in an SMP emulator.
-	    {skip,"SMP emulator"}
-    end.
-
-read_packets_1() ->
     N1 = 5,
     N2 = 7,
     {ok,R} = gen_udp:open(0, [{read_packets,N1}]),
diff --git a/lib/kernel/test/zlib_SUITE.erl b/lib/kernel/test/zlib_SUITE.erl
index 4b67fce9a8..a44ef106d3 100644
--- a/lib/kernel/test/zlib_SUITE.erl
+++ b/lib/kernel/test/zlib_SUITE.erl
@@ -885,29 +885,23 @@ split_bin(Last,Acc) ->
 
 %% Check concurrent access to zlib driver.
 smp(Config) ->
-    case erlang:system_info(smp_support) of
-	true ->
-	    NumOfProcs = lists:min([8,erlang:system_info(schedulers)]),
-	    io:format("smp starting ~p workers\n",[NumOfProcs]),
-
-	    %% Tests to run in parallel.
-	    Funcs = [zip_usage, gz_usage, compress_usage, dictionary_usage,
-		     crc, adler],
-
-	    %% We get all function arguments here to avoid repeated parallel
-	    %% file read access.
-	    FnAList = lists:map(fun(F) -> {F,?MODULE:F({get_arg,Config})}
-				end, Funcs),	    
-
-	    Pids = [spawn_link(?MODULE, worker, [rand:uniform(9999),
-						 list_to_tuple(FnAList),
-						 self()])
-		    || _ <- lists:seq(1,NumOfProcs)],
-	    wait_pids(Pids);
-
-	false ->
-	    {skipped,"No smp support"}
-    end.
+    NumOfProcs = lists:min([8,erlang:system_info(schedulers)]),
+    io:format("smp starting ~p workers\n",[NumOfProcs]),
+
+    %% Tests to run in parallel.
+    Funcs = [zip_usage, gz_usage, compress_usage, dictionary_usage,
+             crc, adler],
+
+    %% We get all function arguments here to avoid repeated parallel
+    %% file read access.
+    FnAList = lists:map(fun(F) -> {F,?MODULE:F({get_arg,Config})}
+                        end, Funcs),
+
+    Pids = [spawn_link(?MODULE, worker, [rand:uniform(9999),
+                                         list_to_tuple(FnAList),
+                                         self()])
+            || _ <- lists:seq(1,NumOfProcs)],
+    wait_pids(Pids).
 
 
 worker(Seed, FnATpl, Parent) ->
diff --git a/lib/runtime_tools/test/dbg_SUITE.erl b/lib/runtime_tools/test/dbg_SUITE.erl
index 4b0864858c..cfe8412e33 100644
--- a/lib/runtime_tools/test/dbg_SUITE.erl
+++ b/lib/runtime_tools/test/dbg_SUITE.erl
@@ -23,7 +23,7 @@
 -export([all/0, suite/0,
          big/1, tiny/1, simple/1, message/1, distributed/1, port/1,
 	 send/1, recv/1,
-         ip_port/1, file_port/1, file_port2/1, file_port_schedfix/1,
+         ip_port/1, file_port/1, file_port2/1,
          ip_port_busy/1, wrap_port/1, wrap_port_time/1,
          with_seq_trace/1, dead_suspend/1, local_trace/1,
          saved_patterns/1, tracer_exit_on_stop/1,
@@ -41,7 +41,7 @@ suite() ->
 all() -> 
     [big, tiny, simple, message, distributed, port, ip_port,
      send, recv,
-     file_port, file_port2, file_port_schedfix, ip_port_busy,
+     file_port, file_port2, ip_port_busy,
      wrap_port, wrap_port_time, with_seq_trace, dead_suspend,
      local_trace, saved_patterns, tracer_exit_on_stop,
      erl_tracer, distributed_erl_tracer].
@@ -623,99 +623,6 @@ file_port2(Config) when is_list(Config) ->
     end,
     ok.
 
-%% Test that the scheduling timestamp fix for trace flag 'running' works.
-file_port_schedfix(Config) when is_list(Config) ->
-    case (catch erlang:system_info(smp_support)) of
-        true ->
-            {skip, "No schedule fix on SMP"};
-        _ ->
-            try
-                file_port_schedfix1(Config)
-            after
-                dbg:stop()
-            end
-    end.
-file_port_schedfix1(Config) when is_list(Config) ->
-    stop(),
-    {A,B,C} = erlang:now(),
-    FTMP =  atom_to_list(?MODULE) ++ integer_to_list(A) ++
-    "-" ++ integer_to_list(B) ++ "-" ++ integer_to_list(C),
-    FName = filename:join([proplists:get_value(data_dir, Config), FTMP]),
-    %%
-    Port = dbg:trace_port(file, {FName, wrap, ".wraplog", 8*1024, 4}),
-    {ok, _} = dbg:tracer(port, Port),
-    {ok,[{matched,_node,0}]} = dbg:p(new,[running,procs,send,timestamp]),
-    %%
-    %% Generate the trace data
-    %%
-    %% This starts 3 processes that sends a message to each other in a ring,
-    %% 4 laps. Prior to sending the message to the next in the ring, each
-    %% process send 8 messages to itself, just to generate some trace data,
-    %% and to lower the possibility that the trace log wraps just after
-    %% a schedule out message (which would not burden any process and hence
-    %% not show up in the result)
-    %%
-    %% The wrap file trace is used because it burns a lot of time when the
-    %% driver swaps files, a lot more than the regular file trace. The test
-    %% case is dimensioned so that the log fills two files and just starts
-    %% on the third (out of four wrap files). This gives two file swaps,
-    %% and there are three processes, so one process will NOT be burdened.
-    %% The criterion for trace success is then that the max process
-    %% execution time must not be more than twice the min process
-    %% execution time. Wallclock. A normal result is about 10 times more
-    %% without schedule in - schedule out compensation (OTP-3938).
-    %%
-    ok = token_volleyball(3, 4, 8),
-    %%
-    {ok,[{matched,_,_}]} = dbg:p(all, [clear]),
-    stop(),
-    %%
-    %% Get the trace result
-    %%
-    Tag = make_ref(),
-    dbg:trace_client(file, {FName, wrap, ".wraplog"},
-                     {fun schedstat_handler/2, {self(), Tag, []}}),
-    Result =
-    receive
-        {Tag, D} ->
-            lists:map(
-              fun({Pid, {A1, B1, C1}}) ->
-                      {Pid, C1/1000000 + B1 + A1*1000000}
-              end,
-              D)
-    end,
-    ok = io:format("Result=~p", [Result]),
-    %    erlang:display({?MODULE, ?LINE, Result}),
-    %%
-    %% Analyze the result
-    %%
-    {Min, Max} = lists:foldl(fun({_Pid, M}, {Mi, Ma}) ->
-                                     {if M < Mi -> M; true -> Mi end,
-                                      if M > Ma -> M; true -> Ma end}
-                             end,
-                             {void, 0},
-                             Result),
-    % More PaN debug
-    io:format("Min = ~f, Max = ~f~n",[Min,Max]),
-    %%
-    %% Cleanup
-    %%
-    ToBeDeleted = filelib:wildcard(FName++"*"++".wraplog"),
-    lists:map(fun file:delete/1, ToBeDeleted),
-    %    io:format("ToBeDeleted=~p", [ToBeDeleted]),
-    %%
-    %% Present the result
-    %%
-    P = (Max / Min - 1) * 100,
-    BottomLine = lists:flatten(io_lib:format("~.2f %", [P])),
-    if P > 100 ->
-           Reason = {BottomLine, '>', "100%"},
-           erlang:display({file_port_schedfix, fail, Reason}),
-           ct:fail(Reason);
-       true ->
-           {comment, BottomLine}
-    end.
-
 %% Test tracing to wrapping file port
 wrap_port(Config) when is_list(Config) ->
     Self = self(),
diff --git a/lib/runtime_tools/test/dyntrace_SUITE.erl b/lib/runtime_tools/test/dyntrace_SUITE.erl
index 7be2f49a8b..7ffbe54446 100644
--- a/lib/runtime_tools/test/dyntrace_SUITE.erl
+++ b/lib/runtime_tools/test/dyntrace_SUITE.erl
@@ -51,11 +51,7 @@ init_per_suite(Config) ->
 	case erlang:system_info(debug_compiled) of
 	    false -> "";
 	    true -> ".debug"
-	end ++
-	case erlang:system_info(smp_support) of
-	    false -> "";
-	    true -> ".smp"
-	end,
+	end ++ ".smp",
     [{emu_name,N}|Config].
 
 end_per_suite(_Config) ->
diff --git a/lib/stdlib/test/ets_SUITE.erl b/lib/stdlib/test/ets_SUITE.erl
index 05451a83fb..5a5e282998 100644
--- a/lib/stdlib/test/ets_SUITE.erl
+++ b/lib/stdlib/test/ets_SUITE.erl
@@ -2283,13 +2283,8 @@ write_concurrency(Config) when is_list(Config) ->
     NoHashMem = ets:info(No7,memory),
     NoHashMem = ets:info(No8,memory),
 
-    case erlang:system_info(smp_support) of
-	true ->
-	    true = YesMem > NoHashMem,
-	    true = YesMem > NoTreeMem;
-	false ->
-	    true = YesMem =:= NoHashMem
-    end,
+    true = YesMem > NoHashMem,
+    true = YesMem > NoTreeMem,
 
     {'EXIT',{badarg,_}} = (catch ets_new(foo,[public,{write_concurrency,foo}])),
     {'EXIT',{badarg,_}} = (catch ets_new(foo,[public,{write_concurrency}])),
@@ -5912,16 +5907,11 @@ add_lists([E1|T1], [E2|T2], Acc) ->
 run_smp_workers(InitF,ExecF,FiniF,Laps) ->
     run_smp_workers(InitF,ExecF,FiniF,Laps, 0).
 run_smp_workers(InitF,ExecF,FiniF,Laps, Exclude) ->
-    case erlang:system_info(smp_support) of
-	true ->
-            case erlang:system_info(schedulers_online) of
-                N when N > Exclude ->
-                    run_workers_do(InitF,ExecF,FiniF,Laps, N - Exclude);
-                _ ->
-                    {skipped, "Too few schedulers online"}
-            end;
-	false ->
-	    {skipped,"No smp support"}
+    case erlang:system_info(schedulers_online) of
+        N when N > Exclude ->
+            run_workers_do(InitF,ExecF,FiniF,Laps, N - Exclude);
+        _ ->
+            {skipped, "Too few schedulers online"}
     end.
 
 run_sched_workers(InitF,ExecF,FiniF,Laps) ->
@@ -6231,11 +6221,9 @@ spawn_monitor_with_pid(Pid, Fun, N) ->
 only_if_smp(Func) ->
     only_if_smp(2, Func).
 only_if_smp(Schedulers, Func) ->
-    case {erlang:system_info(smp_support),
-	  erlang:system_info(schedulers_online)} of
-	{false,_} -> {skip,"No smp support"};
-	{true,N} when N < Schedulers -> {skip,"Too few schedulers online"};
-	{true,_} -> Func()
+    case erlang:system_info(schedulers_online) of
+	N when N < Schedulers -> {skip,"Too few schedulers online"};
+	_ -> Func()
     end.
 
 %% Copy-paste from emulator/test/binary_SUITE.erl