Merge branch 'lukas/common_test/ct_parse_table/OTP-8907' into dev

* lukas/common_test/ct_parse_table/OTP-8907:
  Update parse_table to take multiline sql rows Add test cases for ct:parse_table

2 files changed, 90 insertions, 3 deletions

diff --git a/lib/common_test/src/ct_util.erl b/lib/common_test/src/ct_util.erl
index 0a434666fa..b5ab4cbb6e 100644
--- a/lib/common_test/src/ct_util.erl
+++ b/lib/common_test/src/ct_util.erl
@@ -556,10 +556,37 @@ listenv(Telnet) ->
 %%% @hidden
 %%% @equiv ct:parse_table/1
 parse_table(Data) ->
-    [Heading|Lines]=
-	[remove_space(string:tokens(L, "|"),[]) || L <- Data, hd(L)==$|],
+    {Heading, Rest} = get_headings(Data),
+    Lines = parse_row(Rest,[],size(Heading)),
     {Heading,Lines}.
 
+get_headings(["|" ++ Headings | Rest]) ->
+    {remove_space(string:tokens(Headings, "|"),[]), Rest};
+get_headings([_ | Rest]) ->
+    get_headings(Rest);
+get_headings([]) ->
+    {{},[]}.
+
+parse_row(["|" ++ _ = Row | T], Rows, NumCols) when NumCols > 1 ->
+    case string:tokens(Row, "|") of
+	Values when length(Values) =:= NumCols ->
+	    parse_row(T,[remove_space(Values,[])|Rows], NumCols);
+	Values when length(Values) < NumCols ->
+	    parse_row([Row ++"\n"++ hd(T) | tl(T)], Rows, NumCols)
+    end;
+parse_row(["|" ++ _ = Row | T], Rows, 1 = NumCols) ->
+    case string:rchr(Row, $|) of
+	1 ->
+	    parse_row([Row ++"\n"++hd(T) | tl(T)], Rows, NumCols);
+	_Else ->
+	    parse_row(T, [remove_space(string:tokens(Row,"|"),[])|Rows],
+		      NumCols)
+    end;
+parse_row([_Skip | T], Rows, NumCols) ->
+    parse_row(T, Rows, NumCols);
+parse_row([], Rows, _NumCols) ->
+    lists:reverse(Rows).
+
 remove_space([Str|Rest],Acc) ->
     remove_space(Rest,[string:strip(string:strip(Str),both,$')|Acc]);
 remove_space([],Acc) ->
diff --git a/lib/common_test/test/ct_misc_1_SUITE.erl b/lib/common_test/test/ct_misc_1_SUITE.erl
index eb6c6aa101..8c8b2d0d41 100644
--- a/lib/common_test/test/ct_misc_1_SUITE.erl
+++ b/lib/common_test/test/ct_misc_1_SUITE.erl
@@ -62,7 +62,7 @@ all(doc) ->
 
 all(suite) ->
     [
-     beam_me_up
+     beam_me_up, parse_table
     ].
 
 %%--------------------------------------------------------------------
@@ -106,6 +106,66 @@ beam_me_up(Config) when is_list(Config) ->
     TestEvents = events_to_check(beam_me_up, 1),
     ok = ct_test_support:verify_events(TestEvents, Events, Config).
 
+
+parse_table(suite) ->
+    [parse_table_empty, parse_table_single,
+     parse_table_multiline_row,
+     parse_table_one_column_multiline,
+     parse_table_one_column_simple].
+
+parse_table_empty(Config) when is_list(Config) ->
+
+    String = ["+----+-------+---------+---------+----------+------+--------+",
+	      "| id | col11 | col2222 | col3333 | col4     | col5 | col6666 |",
+	      "+----+-------+---------+---------+----------+------+--------+",
+	      "+----+-------+---------+---------+----------+------+--------+",
+	      "Query Done: 0 records selected"],
+
+    {{"id","col11","col2222","col3333","col4","col5","col6666"},[]} =
+	ct:parse_table(String).
+
+
+parse_table_single(Config) when is_list(Config) ->
+
+    String = ["+------+--------+--------------+------------+------------------+---------+--------+---------+-----------+",
+	      "| id | col1 | col2 | col3 | col4 | col5 | col6 | col7 | col8 |",
+"+------+--------+--------------+------------+------------------+---------+--------+---------+-----------+",
+	      "| 0 | 0 | -1407231560 | -256 | -1407231489 | 1500 | 1 | 1 | 1 |",
+	      "+------+--------+--------------+------------+------------------+---------+--------+---------+-----------+"
+	      "Query Done: 1 record selected"],
+
+    {{"id","col1","col2","col3","col4","col5","col6","col7","col8"},
+     [{"0","0","-1407231560","-256","-1407231489", "1500","1","1","1"}]} =
+	ct:parse_table(String).
+
+parse_table_multiline_row(Config) when is_list(Config) ->
+    
+    String = ["+------+--------+--------------+------------+------------------+---------+--------+---------+-----------+",
+	      "| id | col1 | col2 | col3 | col4 | col5 | col6 | col7 | col8 |",
+"+------+--------+--------------+------------+------------------+---------+--------+---------+-----------+",
+	      "| 0 | 0 | Free test string",
+	      " on more lines",
+	      "than one",
+	      "| -256 | -1407231489 | 1500 | 1 | 1 | 1 |",
+	      "+------+--------+--------------+------------+------------------+---------+--------+---------+-----------+"
+	      "Query Done: 1 record selected"],
+
+    {{"id","col1","col2","col3","col4","col5","col6","col7","col8"},
+     [{"0","0","Free test string\n on more lines\nthan one\n",
+       "-256","-1407231489", "1500","1","1","1"}]} =
+	ct:parse_table(String).
+
+parse_table_one_column_simple(Config) when is_list(Config) ->
+
+    String = ["|test|","|test value|"],
+
+    {{"test"},[{"test value"}]} = ct:parse_table(String).
+
+parse_table_one_column_multiline(Config) when is_list(Config) ->
+    String = ["|test|","|test","value|"],
+
+    {{"test"},[{"test\nvalue"}]} = ct:parse_table(String).
+	
 %%%-----------------------------------------------------------------
 %%% HELP FUNCTIONS
 %%%-----------------------------------------------------------------