Merge branch 'maint'

* maint:
  Increase max number of node name characters to 256

2 files changed, 13 insertions, 5 deletions

diff --git a/lib/erl_interface/include/ei.h b/lib/erl_interface/include/ei.h
index ed0420300d..b138118f04 100644
--- a/lib/erl_interface/include/ei.h
+++ b/lib/erl_interface/include/ei.h
@@ -213,12 +213,12 @@ extern volatile int __erl_errno;
  * library and when using the library we set a value that we use
  */
 
-#define EI_MAXHOSTNAMELEN 64
-#define EI_MAXALIVELEN 63
 #define EI_MAX_COOKIE_SIZE 512
 #define MAXATOMLEN (255 + 1)
 #define MAXATOMLEN_UTF8 (255*4 + 1)
-#define MAXNODELEN EI_MAXALIVELEN+1+EI_MAXHOSTNAMELEN
+#define EI_MAXHOSTNAMELEN (MAXATOMLEN - 2)
+#define EI_MAXALIVELEN (MAXATOMLEN - 2)
+#define MAXNODELEN MAXATOMLEN
 
 typedef enum { 
     ERLANG_ASCII = 1,
diff --git a/lib/erl_interface/src/connect/ei_connect.c b/lib/erl_interface/src/connect/ei_connect.c
index 0cbad235cc..1b1479d2e9 100644
--- a/lib/erl_interface/src/connect/ei_connect.c
+++ b/lib/erl_interface/src/connect/ei_connect.c
@@ -791,14 +791,17 @@ int ei_connect_init_ussi(ei_cnode* ec, const char* this_node_name,
 	if (strcmp(hp->h_name, "localhost") == 0) {
 	    /* We use a short node name */    
 	    if ((ct = strchr(thishostname, '.')) != NULL) *ct = '\0';
-	    sprintf(thisnodename, "%s@%s", this_node_name, thishostname);
 	} else {
 	    /* We use a short node name */    
 	    if ((ct = strchr(hp->h_name, '.')) != NULL) *ct = '\0';
 	    strcpy(thishostname, hp->h_name);
-	    sprintf(thisnodename, "%s@%s", this_node_name, hp->h_name);
 	}
     }
+    if (strlen(this_node_name) + 1 + strlen(thishostname) > MAXNODELEN) {
+        EI_TRACE_ERR0("ei_connect_init_ussi","this node name is too long");
+        return ERL_ERROR;
+    }
+    sprintf(thisnodename, "%s@%s", this_node_name, thishostname);
     res = ei_connect_xinit_ussi(ec, thishostname, thisalivename, thisnodename,
                                 (struct in_addr *)*hp->h_addr_list, cookie, creation,
                                 cbs, cbs_sz, setup_context);
@@ -889,6 +892,11 @@ int ei_connect_tmo(ei_cnode* ec, char *nodename, unsigned ms)
     int ei_h_errno;
 #endif /* !win32 */
     int res;
+
+    if (strlen(nodename) > MAXNODELEN) {
+	EI_TRACE_ERR0("ei_connect","Too long nodename");
+	return ERL_ERROR;
+    }
     
     /* extract the host and alive parts from nodename */
     if (!(hostname = strchr(nodename,'@'))) {