aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorJohn Högberg <[email protected]>2019-08-06 09:16:48 +0200
committerJohn Högberg <[email protected]>2019-08-06 10:01:54 +0200
commitf84acd6e090c052c8a70a611eafbf7959464937b (patch)
treef3938ff28ea1d18b5117f17118dc3c773f6e0274 /lib
parent64731f3bb753f2b534ada36a4713370aecc8b4b1 (diff)
downloadotp-f84acd6e090c052c8a70a611eafbf7959464937b.tar.gz
otp-f84acd6e090c052c8a70a611eafbf7959464937b.tar.bz2
otp-f84acd6e090c052c8a70a611eafbf7959464937b.zip
erts_debug: Turn off unsafe optimizations in test case
The test case alters the return value of a function that the compiler expects will never return, resulting in undefined behavior. Note that the debugger (which may change variables/return values) is unaffected since the affected module is purged and "replaced" with an interpreted variant.
Diffstat (limited to 'lib')
-rw-r--r--lib/kernel/src/erts_debug.erl9
1 files changed, 9 insertions, 0 deletions
diff --git a/lib/kernel/src/erts_debug.erl b/lib/kernel/src/erts_debug.erl
index 42261d371d..7b9067d079 100644
--- a/lib/kernel/src/erts_debug.erl
+++ b/lib/kernel/src/erts_debug.erl
@@ -40,6 +40,15 @@
lc_graph/0, lc_graph_to_dot/2, lc_graph_merge/2,
alloc_blocks_size/1]).
+%% Reroutes calls to the given MFA to error_handler:breakpoint/3
+%%
+%% Note that this is potentially unsafe as compiled code may assume that the
+%% targeted function returns a specific type, triggering undefined behavior if
+%% this function were to return something else.
+%%
+%% For reference, the debugger avoids the issue by purging the affected module
+%% and interpreting all functions in the module, ensuring that no assumptions
+%% are made with regard to return or argument types.
-spec breakpoint(MFA, Flag) -> non_neg_integer() when
MFA :: {Module :: module(),
Function :: atom(),