1 files changed, 31 insertions, 25 deletions

diff --git a/lib/docbuilder/src/docb_main.erl b/lib/docbuilder/src/docb_main.erl
index ef21f65557..4f5f035a65 100644
--- a/lib/docbuilder/src/docb_main.erl
+++ b/lib/docbuilder/src/docb_main.erl
@@ -34,14 +34,23 @@
 %% Parses the source file File and transforms the result to html,
 %% latex and/or man page format.
 process(File, Opts) ->
-
-    File1 = File ++ ".tmpconv",
-    os:cmd("sed -e 's/xi:include[ \t]*href/include file/g' -e 's/xmlns:xi=\"http:\\/\\/www.w3.org\\/2001\\/XInclude\"//g' < " ++ 
-	   File ++ ".xml > " ++ File1 ++ ".xml"), %LATH
+    
+    SrcType = docb_util:lookup_option(src_type, Opts),
+
+    File1 = 
+	case SrcType of
+	    ".xml" ->
+		FileTmp = File ++ ".tmpconv",
+		os:cmd("sed -e 's/xi:include[ \t]*href/include file/g' -e 's/xmlns:xi=\"http:\\/\\/www.w3.org\\/2001\\/XInclude\"//g' < " ++ 
+		       File ++ ".xml > " ++ FileTmp ++ ".xml"),
+		FileTmp;
+	    ".sgml"  ->
+		File
+	end,		
     
     case parse1(File1, Opts) of
 	errors ->
-	    file:delete(File1 ++ ".xml"),
+	    delete_tmp_file(SrcType, File1),
 	    errors;
 	{ok, Tree} ->
 	    From = element(1, Tree),
@@ -55,22 +64,28 @@ process(File, Opts) ->
 
 	    %% If no target format is specified, assume HTML:
 	    Tos = if
-		      Tos0==[] -> [html];
+		      Tos0 =:= [] -> [html];
 		      true -> Tos0
 		  end,
 
 	    Result = [transform(From, To, Opts, File, Tree)||To <- Tos], 
 	    case lists:member(transformation_error,Result) of 
 		true -> 	
-		    file:delete(File1 ++ ".xml"),
+		    delete_tmp_file(SrcType, File1),
 		    errors;
 		_ -> 
-		    file:delete(File1 ++ ".xml"),
+		    delete_tmp_file(SrcType, File1),
 		    ok
 	    end
     
     end.
 
+
+delete_tmp_file(".xml", File) ->
+    file:delete(File ++ ".xml");
+delete_tmp_file(_, _) ->
+    ok.
+
 %%----------------------------------------------------------------------
 
 %% parse(File, Opts) -> {ok, Tree} | errors
@@ -327,12 +342,8 @@ verify(Tree) -> verify(Tree, [], 1).
 verify({pcdata, Optional, _}, Path, Level) ->
     verify_optional(Optional, Path, Level);
 verify({Tag, Optional, Args}, Path, Level) when is_list(Args) ->
-    case verify_optional(Optional, Path, Level) of
-	true ->
-	    verify_list(Args, [Tag|Path], Level);
-	false ->
-	    false
-    end;
+    verify_optional(Optional, Path, Level)
+	andalso verify_list(Args, [Tag|Path], Level);
 verify(Other, Path, Level) ->
     verify_error(Other, Path, Level).
 
@@ -342,12 +353,7 @@ verify_error(X, Path, Level) ->
     false.
 
 verify_list([H|T], Path, Level) ->
-    case verify(H, Path, Level) of
-	true ->
-	    verify_list(T, Path, Level +1);
-	false ->
-	    false
-    end;
+    verify(H, Path, Level) andalso verify_list(T, Path, Level + 1);
 verify_list([], _, _) ->
     true.
 
@@ -419,7 +425,7 @@ edit1_list(_Tag, [], _Op) ->
 %% Actual transformation of tree structure to desired format.
 transform(From, To, Opts, File, Tree) ->
     Filter = if
-		 To==html; To==kwic ->
+		 To =:= html; To =:= kwic ->
 		     list_to_atom("docb_tr_" ++ atom_to_list(From) ++
 				  [$2|atom_to_list(To)]);
 		 true ->
@@ -427,7 +433,7 @@ transform(From, To, Opts, File, Tree) ->
 				  [$2|atom_to_list(To)])
 	     end,
 
-    case catch apply(Filter, transform, [File, Tree, Opts]) of
+    case catch Filter:transform(File, Tree, Opts) of
 
 	%% R5C
 	{'EXIT', {undef, [{Filter, transform, [File, Tree, Opts]}|_]}}->
@@ -459,9 +465,9 @@ transform(From, To, Opts, File, Tree) ->
 finish_transform(Tree, File, Opts, Filter) ->
     {Str, NewOpts} = pp(Tree, [], 1, Filter, Opts),
     Extension =
-	case catch apply(Filter, extension, [NewOpts]) of
+	case catch Filter:extension(NewOpts) of
 	    {'EXIT', _} ->
-		apply(Filter, extension, []);
+		Filter:extension();
 	    Others ->
 		Others
 	end,
@@ -606,7 +612,7 @@ include_all(Fd) ->
 	eof ->
 	    [];
 	ListOfChars ->
-	    lists:append(ListOfChars, include_all(Fd))
+	    ListOfChars ++ include_all(Fd)
     end.
 
 extract(File, Fd, StartTag, StopTag, State) ->