3 files changed, 24 insertions, 89 deletions

diff --git a/lib/runtime_tools/c_src/dtrace_user.d b/lib/runtime_tools/c_src/dtrace_user.d
index 3a80d0f7a3..9e180a3cb2 100644
--- a/lib/runtime_tools/c_src/dtrace_user.d
+++ b/lib/runtime_tools/c_src/dtrace_user.d
@@ -19,31 +19,11 @@
  */
 
 provider erlang {
-    /**
-     * Send a single string to a probe.
-     *
-     * @param NUL-terminated string
+    /*
+     * The set of probes for use by Erlang code ... moved from here to
+     * erts/emulator/beam/erlang_dtrace.d until a more portable solution is
+     * found; see erlang_dtrace.d for details.
      */
-    probe user_trace__s1(char* message);
-
-    /**
-     * Multi-purpose probe: up to 4 NUL-terminated strings and 4
-     * 64-bit integer arguments.
-     *
-     * @param proc, the PID (string form) of the sending process
-     * @param user_tag, the user tag of the sender
-     * @param i1, integer
-     * @param i2, integer
-     * @param i3, integer
-     * @param i4, integer
-     * @param s1, string/iolist. D's arg6 is NULL if not given by Erlang
-     * @param s2, string/iolist. D's arg7 is NULL if not given by Erlang
-     * @param s3, string/iolist. D's arg8 is NULL if not given by Erlang
-     * @param s4, string/iolist. D's arg9 is NULL if not given by Erlang
-     */
-    probe user_trace__i4s4(char *proc, char *user_tag,
-                           int i1, int i2, int i3, int i4,
-                           char *s1, char *s2, char *s3, char *s4);
 };
 
 #pragma D attributes Evolving/Evolving/Common provider erlang provider
diff --git a/lib/runtime_tools/c_src/dyntrace.c b/lib/runtime_tools/c_src/dyntrace.c
index 96dbebbdfa..eef03afd1c 100644
--- a/lib/runtime_tools/c_src/dyntrace.c
+++ b/lib/runtime_tools/c_src/dyntrace.c
@@ -36,6 +36,10 @@
 
 void dtrace_nifenv_str(ErlNifEnv *env, char *process_buf);
 void get_string_maybe(ErlNifEnv *env, const ERL_NIF_TERM term, char **ptr, char *buf, int bufsiz);
+#ifdef HAVE_USE_DTRACE
+ERL_NIF_TERM erl_nif_user_trace_s1(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[]);
+ERL_NIF_TERM erl_nif_user_trace_i4s4(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[]);
+#endif
 
 #ifdef VALGRIND
     #  include <valgrind/memcheck.h>
@@ -56,11 +60,13 @@ static int load(ErlNifEnv* env, void** priv_data, ERL_NIF_TERM load_info);
 static ERL_NIF_TERM available(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[]);
 static ERL_NIF_TERM user_trace_s1(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[]);
 static ERL_NIF_TERM user_trace_i4s4(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[]);
+static ERL_NIF_TERM user_trace_n(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[]);
 
 static ErlNifFunc nif_funcs[] = {
     {"available", 0, available},
     {"user_trace_s1", 1, user_trace_s1},
-    {"user_trace_i4s4", 9, user_trace_i4s4}
+    {"user_trace_i4s4", 9, user_trace_i4s4},
+    {"user_trace_n", 10, user_trace_n}
 };
 
 ERL_NIF_INIT(dyntrace, nif_funcs, load, NULL, NULL, NULL)
@@ -96,76 +102,25 @@ static ERL_NIF_TERM available(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[
 static ERL_NIF_TERM user_trace_s1(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
 {
 #ifdef	HAVE_USE_DTRACE
-    ErlNifBinary message_bin;
-    DTRACE_CHARBUF(messagebuf, MESSAGE_BUFSIZ + 1);
-
-    if (DTRACE_ENABLED(user_trace_s1)) {
-	if (!enif_inspect_iolist_as_binary(env, argv[0], &message_bin) ||
-	    message_bin.size > MESSAGE_BUFSIZ) {
-	    return atom_badarg;
-	}
-	memcpy(messagebuf, (char *) message_bin.data, message_bin.size);
-        messagebuf[message_bin.size] = '\0';
-	DTRACE1(user_trace_s1, messagebuf);
-	return atom_true;
-    } else {
-	return atom_false;
-    }
+    return erl_nif_user_trace_s1(env, argc, argv);
 #else
     return atom_error;
 #endif
 }
 
-void
-get_string_maybe(ErlNifEnv *env,
-                 const ERL_NIF_TERM term, char **ptr, char *buf, int bufsiz)
+static ERL_NIF_TERM user_trace_i4s4(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
 {
-    ErlNifBinary str_bin;
-
-    if (!enif_inspect_iolist_as_binary(env, term, &str_bin) ||
-        str_bin.size > bufsiz) {
-        *ptr = NULL;
-    } else {
-        memcpy(buf, (char *) str_bin.data, str_bin.size);
-        buf[str_bin.size] = '\0';
-        *ptr = buf;
-    }
+#ifdef	HAVE_USE_DTRACE
+    return erl_nif_user_trace_i4s4(env, argc, argv);
+#else
+    return atom_error;
+#endif
 }
 
-static ERL_NIF_TERM user_trace_i4s4(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
+static ERL_NIF_TERM user_trace_n(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
 {
 #ifdef	HAVE_USE_DTRACE
-    DTRACE_CHARBUF(procbuf, 32 + 1);
-    DTRACE_CHARBUF(user_tagbuf, MESSAGE_BUFSIZ + 1);
-    char *utbuf = NULL;
-    ErlNifSInt64 i1, i2, i3, i4;
-    DTRACE_CHARBUF(messagebuf1, MESSAGE_BUFSIZ + 1);
-    DTRACE_CHARBUF(messagebuf2, MESSAGE_BUFSIZ + 1);
-    DTRACE_CHARBUF(messagebuf3, MESSAGE_BUFSIZ + 1);
-    DTRACE_CHARBUF(messagebuf4, MESSAGE_BUFSIZ + 1);
-    char *mbuf1 = NULL, *mbuf2 = NULL, *mbuf3 = NULL, *mbuf4 = NULL;
-
-    if (DTRACE_ENABLED(user_trace_i4s4)) {
-	dtrace_nifenv_str(env, procbuf);
-        get_string_maybe(env, argv[0], &utbuf, user_tagbuf, MESSAGE_BUFSIZ);
-        if (! enif_get_int64(env, argv[1], &i1))
-            i1 = 0;
-        if (! enif_get_int64(env, argv[2], &i2))
-            i2 = 0;
-        if (! enif_get_int64(env, argv[3], &i3))
-            i3 = 0;
-        if (! enif_get_int64(env, argv[4], &i4))
-            i4 = 0;
-        get_string_maybe(env, argv[5], &mbuf1, messagebuf1, MESSAGE_BUFSIZ);
-        get_string_maybe(env, argv[6], &mbuf2, messagebuf2, MESSAGE_BUFSIZ);
-        get_string_maybe(env, argv[7], &mbuf3, messagebuf3, MESSAGE_BUFSIZ);
-        get_string_maybe(env, argv[8], &mbuf4, messagebuf4, MESSAGE_BUFSIZ);
-	DTRACE10(user_trace_i4s4, procbuf, utbuf,
-		 i1, i2, i3, i4, mbuf1, mbuf2, mbuf3, mbuf4);
-	return atom_true;
-    } else {
-	return atom_false;
-    }
+    return erl_nif_user_trace_n(env, argc, argv);
 #else
     return atom_error;
 #endif
diff --git a/lib/runtime_tools/c_src/trace_ip_drv.c b/lib/runtime_tools/c_src/trace_ip_drv.c
index 7f7ab8dd9d..6b77128761 100644
--- a/lib/runtime_tools/c_src/trace_ip_drv.c
+++ b/lib/runtime_tools/c_src/trace_ip_drv.c
@@ -590,8 +590,8 @@ static void *my_alloc(size_t size)
     void *ret;
     if ((ret = driver_alloc(size)) == NULL) {
 	/* May or may not work... */
-	fprintf(stderr, "Could not allocate %d bytes of memory in %s.",
-		(int) size, __FILE__);
+	fprintf(stderr, "Could not allocate %lu bytes of memory in %s.",
+		(unsigned long) size, __FILE__);
 	exit(1);
     }
     return ret;
@@ -605,8 +605,8 @@ static ErlDrvBinary *my_alloc_binary(int size)
     ErlDrvBinary *ret;
     if ((ret = driver_alloc_binary(size)) == NULL) {
 	/* May or may not work... */
-	fprintf(stderr, "Could not allocate a binary of %d bytes in %s.",
-		(int) size, __FILE__);
+	fprintf(stderr, "Could not allocate a binary of %lu bytes in %s.",
+		(unsigned long) size, __FILE__);
 	exit(1);
     }
     return ret;