| Age | Commit message (Collapse) | Author |
|---|
|
efile_drv is gone and so is the need for file-specific DTrace. The
new implementation works fine with the normal tracing mechanism so
there's nothing preventing anyone from making an erl_tracer nif
that forward these events to DTrace.
|
|
The option no longer does anything at all.
|
|
|
|
There doesn't seem to be any science behind the long delays, and
the (newly introduced) dry run forces us to eat them twice, so
they've been shortened to more reasonable values.
|
|
Code loading is done through dirty IO now, causing the
dirty_scheduler_exit tests to fail as they block their own progress
by invoking erts_debug:dirty_io(wait, _); the spawned processes
will exit normally before we have a chance to kill them.
To get around this, we perform a dry run to ensure that all required
code is loaded. It isn't particularly pretty (or fast) but it saves
us the hassle of maintaining a module list (cf. embedded mode).
|
|
The old driver didn't fall back to using write(2) if writev(2) failed
due to the combined length of the iov overflowing a ssize_t, but the
new one doesn't have any problems with it so we failed this test with
a case_clause error on 32-bit machines.
|
|
Files opened with the file module are not guaranteed to work with
prim_file, even when opened in raw mode.
|
|
|
|
|
|
The tests assume that the most active process will be the current
one, which is no longer true since the delayed_write option now
uses a wrapper process for much of its work.
The timeout for this test has been increased to account for the
lack of delayed_write; 60s was enough for everything except the
debug build on some machines.
|
|
|
|
|
|
|
|
This subtest revolves around the possibility that the underlying
port can be killed, which is nonsense now that the file suite no
longer uses ports for anything.
|
|
This test revolves around the possibility that the underlying port
can be killed, which is nonsense now that the file suite no longer
uses ports for anything.
|
|
This test is irrelevant as the new implementation doesn't use async
threads.
|
|
|
|
|
|
The cumulative wait time was as long as the delay itself in the
flush-on-size test, causing the test to pass because the write
managed to time out.
|
|
|
|
|
|
|
|
This also hides the module behind ?PRIM_FILE to make testing new
implementations less painful.
|
|
This improves the latency of file operations as dirty schedulers
are a bit more eager to run jobs than async threads, and use a
single global queue rather than per-thread queues, eliminating the
risk of a job stalling behind a long-running job on the same thread
while other async threads sit idle.
There's no such thing as a free lunch though; the lowered latency
comes at the cost of increased busy-waiting which may have an
adverse effect on some applications. This behavior can be tweaked
with the +sbwt flag, but unfortunately it affects all types of
schedulers and not just dirty ones. We plan to add type-specific
flags at a later stage.
sendfile has been moved to inet_drv to lessen the effect of a nasty
race; the cooperation between inet_drv and efile has never been
airtight and the socket dying at the wrong time (Regardless of
reason) could result in fd aliasing. Moving it to the inet driver
makes it impossible to trigger this by closing the socket in the
middle of a sendfile operation, while still allowing it to be
aborted -- something that can't be done if it stays in the file
driver.
The race still occurs if the controlling process dies in the short
window between dispatching the sendfile operation and the dup(2)
call in the driver, but it's much less likely to happen now.
A proper fix is in the works.
--
Notable functional differences:
* The use_threads option for file:sendfile/5 no longer has any
effect.
* The file-specific DTrace probes have been removed. The same
effect can be achieved with normal tracing together with the
nif__entry/nif__return probes to track scheduling.
--
OTP-14256
|
|
|
|
If a NIF monitor fired while the resource was present in an ETS
table, the lock checker would erroneously report a lock order
violation.
This has no effect outside of debug builds.
|
|
This introduces a way to retrieve erlang terms from NIF IO queues
without having to resort to copying.
OTP-14797
|
|
|
|
Document enif_realloc and pointer alignment guarantees
|
|
|
|
|
|
|
|
This commit adds a new syntax for retrieving the stacktrace
without calling erlang:get_stacktrace/0. That allow us to
deprecate erlang:get_stacktrace/0 and ultimately remove it.
The problem with erlang:get_stacktrace/0 is that it can keep huge
terms in a process for an indefinite time after an exception. The
stacktrace can be huge after a 'function_clause' exception or a failed
call to a BIF or operator, because the arguments for the call will be
included in the stacktrace. For example:
1> catch abs(lists:seq(1, 1000)).
{'EXIT',{badarg,[{erlang,abs,
[[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20|...]],
[]},
{erl_eval,do_apply,6,[{file,"erl_eval.erl"},{line,674}]},
{erl_eval,expr,5,[{file,"erl_eval.erl"},{line,431}]},
{shell,exprs,7,[{file,"shell.erl"},{line,687}]},
{shell,eval_exprs,7,[{file,"shell.erl"},{line,642}]},
{shell,eval_loop,3,[{file,"shell.erl"},{line,627}]}]}}
2> erlang:get_stacktrace().
[{erlang,abs,
[[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,
23,24|...]],
[]},
{erl_eval,do_apply,6,[{file,"erl_eval.erl"},{line,674}]},
{erl_eval,expr,5,[{file,"erl_eval.erl"},{line,431}]},
{shell,exprs,7,[{file,"shell.erl"},{line,687}]},
{shell,eval_exprs,7,[{file,"shell.erl"},{line,642}]},
{shell,eval_loop,3,[{file,"shell.erl"},{line,627}]}]
3>
We can extend the syntax for clauses in try/catch to optionally bind
the stacktrace to a variable.
Here is an example using the current syntax:
try
Expr
catch C:E ->
Stk = erlang:get_stacktrace(),
.
.
.
In the new syntax, it would look like:
try
Expr
catch
C:E:Stk ->
.
.
.
Only a variable (not a pattern) is allowed in the stacktrace position,
to discourage matching of the stacktrace. (Matching would also be
expensive, because the raw format of the stacktrace would have to be
converted to the cooked form before matching.)
Note that:
try
Expr
catch E ->
.
.
.
is a shorthand for:
try
Expr
catch throw:E ->
.
.
.
If the stacktrace is to be retrieved for a throw, the 'throw:'
prefix must be explicitly included:
try
Expr
catch throw:E:Stk ->
.
.
.
|
|
In the grammar file for the Erlang language, patterns are parsed
as expressions. erl_lint will then weed out expressions that are
not legal patterns.
The rule sharing causes problems if we were to introduce new
syntax, for example a pattern followed by a ':'. There would
be a shift/reduce conflict, and a pattern followed by a ':'
would be parsed as a remote call.
Introduce a new pat_expr rule to express exactly the subset
of expressions that is allowed in pattern.
Note: For the moment, we must allow full expressions in
case clauses to keep 'merl' working.
|
|
X register 0 used to be mapped to a hardware register, and therefore
faster than the other registers. Because of that, the compiler
tried to use x(0) as much as possible as a temporary register.
That was changed a few releases ago. X register 0 is now placed
in the array of all X registers and has no special speed
advantage compared to the other registers.
Remove the code in the compiler that attempts to use x(0) as
much as possible. As a result, the following type of instruction
will be much less frequent:
{put_list,Src,{x,0},{x,0}}
Instead, the following type of instruction will be more frequent:
{put_list,Src,{x,X},{x,X}}
(Where X is an arbitrary X register.)
Update the runtime system to specialize that kind of put_list
instruction.
|
|
* maint:
Fix type create_option() in mnesia
|
|
Fix type create_option() in mnesia
|
|
* maint:
Fix max atom size overflow on 64-bits Erlang by lowering the MAX_ATOM_TABLE_SIZE
Fix integer overflow when set a large maximum value for atom table
|
|
Fix integer overflow when set a large maximum value for atom table
OTP-14796
|
|
|
|
* bjorn/compiler/coverage:
v3_codegen: Remove check of operand for bs_context_to_binary
beam_jump: Eliminate a repeated clause
beam_asm: No longer allow iolists as contents in chunk/2
beam_utils_SUITE: Cover more lines in beam_utils
guard_SUITE: Add a test case to cover beam_dead:turn_op/1
Recognize 'nil' as a literal in beam_utils:bif_to_test/3
Cover more code in beam_bsm:btb_opt_1/3
Add test to cover a line in v3_kernel:opt_single_valued/3
|
|
* maint:
Avoid falling measurements testcases on slow machines
stdlib: string optimize special case for ASCII
stdlib: Minor unicode_util opts
|
|
* dgud/stdlib/optimize-string-lists:
Avoid falling measurements testcases on slow machines
stdlib: string optimize special case for ASCII
stdlib: Minor unicode_util opts
OTP-14670
|
|
Minor grammar tweak in ETS documentation
|
|
|
|
=== OTP-19.2.3.1 ===
Changed Applications:
- erts-8.2.2.1
Unchanged Applications:
- asn1-4.0.4
- common_test-1.13
- compiler-7.0.3
- cosEvent-2.2.1
- cosEventDomain-1.2.1
- cosFileTransfer-1.2.1
- cosNotification-1.2.2
- cosProperty-1.2.1
- cosTime-1.2.2
- cosTransactions-1.3.2
- crypto-3.7.2
- debugger-4.2.1
- dialyzer-3.0.3
- diameter-1.12.1
- edoc-0.8.1
- eldap-1.2.2
- erl_docgen-0.6.1
- erl_interface-3.9.2
- et-1.6
- eunit-2.3.2
- gs-1.6.2
- hipe-3.15.3
- ic-4.4.2
- inets-6.3.5
- jinterface-1.7.1
- kernel-5.1.1
- megaco-3.18.1
- mnesia-4.14.3
- observer-2.3
- odbc-2.12
- orber-3.8.2
- os_mon-2.4.1
- otp_mibs-1.1.1
- parsetools-2.1.4
- percept-0.9
- public_key-1.3
- reltool-0.7.2
- runtime_tools-1.11
- sasl-3.0.2
- snmp-5.2.4
- ssh-4.4
- ssl-8.1
- stdlib-3.2
- syntax_tools-2.1.1
- tools-2.9
- typer-0.9.11
- wx-1.8
- xmerl-1.3.12
|
|
|
|
|
|
* sverker/mbcs-pool-stats/ERL-88/OTP-14795:
Fix erlang:memory
Remove duplicate stats for 'fetch'
Do not include new stats for 'allocator_sizes'
Add more cpool stats
erts: Add statistics for cpoll fetch attempts
|
|
|
