aboutsummaryrefslogtreecommitdiffstats
path: root/erts
AgeCommit message (Collapse)Author
2019-03-29Fix out of memory bug in the implementation of mapsKjell Winblad
This commit fixes a bug that could cause a crash or memory usage to grow until the machine ran out of memory when adding a key-value pair to a map. This could happen when inserting a new key-value pair with a key K1 containing a binary B1 into a map M having a key K2 with a binary B2 if the following conditions were met: * size(B1) >= 4294967296 * size(B2) >= 4294967296 * size(M) >= 32 * (size(B1) rem 4294967296) == (size(B2) rem 4294967296) * the first (size(B1) rem 4294967296) bytes are the same both in B1 and B2 * substituting B1 in K1 with B2 would result in a term with the same value as K2 The root cause of the bug is that the map implementation only hashed the first (X modulo 4294967296) bytes of binaries so that different binaries could get hashed to the same hash value independently of the hash seed.
2019-03-29Merge pull request #2169 from llelf/shell-ctrl+rbracketBjörn Gustavsson
tty: document ^] keystroke
2019-03-28Merge branch 'john/erts/remove-destructive-bs_get_binary2/ERL-901'John Högberg
* john/erts/remove-destructive-bs_get_binary2/ERL-901: erts: Remove unsafe bs_get_binary2 optimization from loader
2019-03-27erts: Remove unsafe bs_get_binary2 optimization from loaderJohn Högberg
A load-time optimization assumed that match contexts had no further uses when a bs_get_binary2 overwrote the match context's register, and figured it would be safe to reuse the match context's memory for the resulting binary. This is no longer safe as of OTP 22, as a match context may be reused after being passed to another function.
2019-03-27Merge branch 'john/erts/seq_trace-sigq-clearing/OTP-15704'John Högberg
* john/erts/seq_trace-sigq-clearing/OTP-15704: erts: Handle all signal types when clearing seq_trace token
2019-03-27erts: Handle all signal types when clearing seq_trace tokenJohn Högberg
We walk through all signal queues in the system when clearing seq_trace, so we must be prepared to encounter all kinds of signals.
2019-03-27Fix unsafe optimization made by the loaderBjörn Gustavsson
Fix the unsafe load-time optimization introduced in 07bdbb3a1edc. https://bugs.erlang.org/browse/ERL-899
2019-03-26Merge branch 'john/erts/explain-empty-stack-check-in-next_catch'John Högberg
* john/erts/explain-empty-stack-check-in-next_catch: erts: Add an explanation for the empty stack check in next_catch
2019-03-26Revert "Prepare release"Henrik Nord
This reverts commit 0118046f9bda8dcf3594184fa439b79267db8017.
2019-03-25Prepare releaseErlang/OTP
2019-03-25Merge branch 'sverker/bug-fixing'Sverker Eriksson
* sverker/bug-fixing: erts: Fix erts_debug:set_internal_state(reds_left) erts: Fix binary_SUITE:cmp_old_impl
2019-03-25erts: Fix erts_debug:set_internal_state(reds_left)Sverker Eriksson
to avoid failed ERTS_DBG_CHK_REDS by clearing virtual_reds.
2019-03-25erts: Fix binary_SUITE:cmp_old_implSverker Eriksson
since DFLAG_BIG_CREATION became mandatory in 321dc6ee0241f802c940def174c0a77262e11f21.
2019-03-25Merge branch ↵Lukas Larsson
'lukas/erts/fragment-dist-messages/OTP-13397/OTP-15610/OTP-15611/OTP-15612/OTP-15613/OTP-15703' * lukas/erts/fragment-dist-messages/OTP-13397/OTP-15610/OTP-15611/OTP-15612/OTP-15613/OTP-15703: (26 commits) erts: Yield when exiting/free process is suspended by de doc: Fix Design Princ, statem incorrect anchor erts: Include external msg in need of GC erts: Include dist header in return from dist_ctrl_get_data erts: Fix so that exit/down terms stay alive erts: Pending signals can be for free processes erts: Fix faulty assert in reference_table_term etp: Don't crash etp-stack* when c_p->i is null erts: Adjust dist obuf size correctly after hdr fin erts: Fix non-payload dist exit signals erts: Always do trylock on proc locks when crash dumping Fix tests to work better in debug emulator erts: erts_factory_proc_init should not set hole marker erts: Skip heavy process tab tests in debug emu ts: Use same dynlinking logic for all bsd Revert "erts: Always run fds check after each testcase" erts: Always run fds check after each testcase erts: Always stop any testnodes before testcase exits erts: Add crash dumping of EXITING and FREE processes wx: Remove ERL_FLAGS from Makefile erlc command ...
2019-03-25erts: Yield when exiting/free process is suspended by deLukas Larsson
2019-03-25erts: Add an explanation for the empty stack check in next_catchJohn Högberg
2019-03-25erts: Include external msg in need of GCLukas Larsson
When many external messages suddenly appear in the mailbox the young gen size is adjusted accordingly but it was immediately shrunk as the data was not counted towards the shrink size. This commit includes the ext dist size in the shrink calculation which means that the decode of the external messages will not trigger as many GCs which means much better performance.
2019-03-25erts: Include dist header in return from dist_ctrl_get_dataLukas Larsson
2019-03-25erts: Fix so that exit/down terms stay aliveLukas Larsson
When the GC is run or the link/monitor node is deleted, the terms associated with it will also be deallocated so we have to make sure that we don't do any GCs and that all link/monitor nodes are copied onto the heap before the node is deallocated.
2019-03-25erts: Pending signals can be for free processesLukas Larsson
Since we no schedule free processes multiple times, pending signals can be from free as well as current processes.
2019-03-25erts: Fix faulty assert in reference_table_termLukas Larsson
2019-03-25etp: Don't crash etp-stack* when c_p->i is nullLukas Larsson
2019-03-25erts: Adjust dist obuf size correctly after hdr finLukas Larsson
2019-03-25erts: Fix non-payload dist exit signalsLukas Larsson
When interacting with jinterface and erl_interface the old dist messages are used and they incorrectly used the external data.
2019-03-25erts: Always do trylock on proc locks when crash dumpingLukas Larsson
2019-03-25Fix tests to work better in debug emulatorLukas Larsson
2019-03-25erts: erts_factory_proc_init should not set hole markerLukas Larsson
Setting the hole marker in debug on the entire heap is very slow so instead we do it in erts_produce_heap.
2019-03-25erts: Skip heavy process tab tests in debug emuLukas Larsson
2019-03-25Revert "erts: Always run fds check after each testcase"Lukas Larsson
This reverts commit 1eb0a2c47edd036731ee1e4e4f7b5bdfc7d576fa.
2019-03-25erts: Always run fds check after each testcaseLukas Larsson
2019-03-25erts: Always stop any testnodes before testcase exitsLukas Larsson
This needs to be done in order for automatic fd leak checking to work properly.
2019-03-25erts: Add crash dumping of EXITING and FREE processesLukas Larsson
2019-03-25erts: Fix incorrect ticket example in commentJohn Högberg
2019-03-25erts: Fix file desc leak in poll debug get_evtsLukas Larsson
2019-03-25erts: Fix verify_nc in distribution suiteLukas Larsson
When the calling process is trapping exits a stray message will end up in the mailbox which is problematic. This change uses a monitor instead.
2019-03-25erts: Fix atom16 testcase after dist frag implLukas Larsson
2019-03-25erts: Fix make system to pass TYPE from top levelLukas Larsson
This makes it possible to do: make release TYPE=debug from ERL_TOP and it will build the correct things.
2019-03-25Revert "erts: Add debug dist obuf memory leak check"Lukas Larsson
This reverts commit f4c121b1d98bf3db7e6eecbb9fb5b292f2bc3bb0.
2019-03-25erts: Fix version error in erl_nif.hJohn Högberg
2019-03-22Merge branch 'sverker/enable-big-creation/OTP-15603'Sverker Eriksson
* sverker/enable-big-creation/OTP-15603: epmd: Support 32-bit creation values in local node erts: Robustify epmd reply function erts: Reject decoded local refs with too large first word erts: Fix bug in list_to_ref erl_interface: Remove old encoding of pid,port,refs erts: Remove old encoding of pids, ports and refs erts: Make DFLAG_BIG_CREATION mandatory
2019-03-22epmd: Support 32-bit creation values in local nodeSverker Eriksson
* Increase distribution version from 5 to 6 * Introduce new ALIVE2_X_RESP with 32-bit creation as reply to ALIVE2_REQ when sender dist version >= 6 * Still reply old ALIVE2_RESP with tiny creation 1..3 if sender dist version < 6.
2019-03-22erts: Robustify epmd reply functionSverker Eriksson
2019-03-22erts: Reject decoded local refs with too large first wordSverker Eriksson
2019-03-22erts: Fix bug in list_to_refSverker Eriksson
First word must be less than (1 bsl 18) for local refs.
2019-03-22Suppress false positive warning in gcc 4.8.2Kjell Winblad
This commit suppresses the following warning in gcc 4.8.2: In file included from beam/bif.c:33:0: beam/bif.c: In function ‘iolist_size_1’: beam/bif.h:332:14: warning: ‘state_mref’ may be used uninitialized in this function [-Wmaybe-uninitialized] reg[0] = (A0); \ ^ beam/bif.c:2464:11: note: ‘state_mref’ was declared here Eterm state_mref;
2019-03-22beam_emu.c: Avoid triggering an assertion for the wrong reasonBjörn Gustavsson
Before 2d2e78ad6e66 that introduced tail-recursive calls of BIFs, the stack was guaranteed not to be empty when `erlang:raise/3` was called from the `catch` block of a `try` (because the `try` had set up a stack frame that would be deallocated after the `raise` call). Now the stack can be empty, so the ASSERT() call in next_catch() that checks that there is a continuation pointer at the top of the stack may fail. Move the ASSERT() call to after check for empty stack. While at it, also add a comment of the reason for the assertion.
2019-03-22Merge branch 'john/erts/fix-badarg-fixed_apply'John Högberg
* john/erts/fix-badarg-fixed_apply: erts: Include argument list on badarg in fixed_apply
2019-03-22Merge branch 'john/erts/unc-path-size-fix/OTP-15693'John Högberg
* john/erts/unc-path-size-fix/OTP-15693: erts: Fix incorrect UNC path length calculation
2019-03-22erts: Fix incorrect UNC path length calculationJohn Högberg
This didn't cause any issues for the most part since the path was still properly formed, but it broke down when appending the wildcards in file:list_dir/1. The ASSERT_PATH_FORMAT macro would have caught this in no time, but it went unnoticed because we don't run debug builds on Windows.
2019-03-21Merge 'sverker/master/enif_whereis_pid-dirty-dtor/OTP-15694'Sverker Eriksson
* sverker/master/enif_whereis_pid-dirty-dtor: erts: Add test of enif_whereis* from resource destructor erts: Simplify nif_SUITE:nif_whereis* tests erts: Schedule resource destructors always