aboutsummaryrefslogtreecommitdiffstats
path: root/lib/erl_interface/src
AgeCommit message (Collapse)Author
2011-09-29Merge branch 'dev' into majorBjörn-Egil Dahlberg
* dev: Update copyright years
2011-09-29Update copyright yearsBjörn-Egil Dahlberg
2011-09-20Merge branch 'dev' into majorHenrik Nord
Conflicts: erts/aclocal.m4 erts/include/internal/ethread_header_config.h.in
2011-09-20Merge branch 'ac/fix-erl_interface-docs' into devHenrik Nord
* ac/fix-erl_interface-docs: Make comment reflect code in erl_interface/src/misc/ei_decode_term.c ei_decode_ei_term() returns 1 if index is incremented OTP-9559
2011-09-20Merge branch 'cr/cppcheck' into devHenrik Nord
* cr/cppcheck: Changes inspired by running cppcheck(1) OTP-9557
2011-09-08Merge branch 'dev' into majorHenrik Nord
2011-09-08Merge branch 'ms/ei-int-overflow-in-string-atom-enc' into devHenrik Nord
* ms/ei-int-overflow-in-string-atom-enc: ei: integer overflow in string/atom encoding OTP-9530
2011-09-07Make comment reflect code in erl_interface/src/misc/ei_decode_term.cAnneli Cuss
Note that ei_decode_term.h has the correct behaviour described! Also removed extraneous '/* return 0; */' comments.
2011-09-06Changes inspired by running cppcheck(1)Christian von Roques
2011-08-08erl_interface: Support parallel makeBjörn Gustavsson
2011-06-29Align ei buffer according to size of pointersBjörn-Egil Dahlberg
2011-06-07ei: integer overflow in string/atom encodingMichael Santos
ei_encode_atom() and ei_encode_string() use strlen() to get the length of the buffer. As strlen() returns an unsigned long long and both ei functions take a signed integer, the length fields may overflow. Check the results of strlen can be held in a signed integer.
2011-05-20Update copyright yearsBjörn-Egil Dahlberg
2011-05-17Remove unused variable in epmd_portBjörn-Egil Dahlberg
2011-05-11Merge branch 'gl/erl_do_receive_msg/OTP-9241' into devBjörn-Egil Dahlberg
* gl/erl_do_receive_msg/OTP-9241: The function 'erl_xreceive_msg' returned garbage in the 'to' and 'to_name' members of the message. The reason for that was found in the 'erl_do_receive_msg' function. When no 'pid' is provided by the sender, like when doing rpc calls as those uses registered name sends, it doesn't initialize the 'to' member and also the 'to_name' member is copied by the function.
2011-04-26The function 'erl_xreceive_msg' returned garbage in the 'to' and 'to_name' ↵Goran Larsson
members of the message. The reason for that was found in the 'erl_do_receive_msg' function. When no 'pid' is provided by the sender, like when doing rpc calls as those uses registered name sends, it doesn't initialize the 'to' member and also the 'to_name' member is copied by the function.
2011-04-13erl_interface: fix compile errorMichael Santos
2011-03-24Merge branch 'cg/fix-sizeof-array-arg' into devHenrik Nord
* cg/fix-sizeof-array-arg: Fix using sizeof() for array given as function argument OTP-9151
2011-03-11Update copyright yearsBjörn-Egil Dahlberg
2011-02-25Fix using sizeof() for array given as function argumentCristian Greco
When using the sizeof() operator for an array given as function argument it returns the size of the pointer. In this case, the affected function hex(char digest[16], char buff[33]) will just print 4 or 8 byte instead of the full length of 16 bytes, on 32bit and 64bit systems respectively.
2011-02-22ei: buffer overflow when decoding atomsMichael Santos
2011-02-22erl_interface: fix buffer overflowsMichael Santos
2011-01-03Merge branch 'vb/ei-exts' into devBjörn-Egil Dahlberg
* vb/ei-exts: Fix testcases erl_global_whereis, erl_global_names Fix wrong erl_compare_ext result comparing lists Correct erl_global{register, unregister} functions Add PID (~p) type parameters to ei_format Add char (~c) type parameters to ei_format OTP-9015 Conflicts: lib/erl_interface/include/ei.h
2010-12-15Remove ancient distribution message DOP_NODE_LINK from all codePatrik Nyblom
2010-12-10Fix wrong erl_compare_ext result comparing listsVitaliy Batichko
Function erl_compare_ext of erl_interface library returns 1 instead -1 when comparing lists like [0] and [0, 1000]. Credits to: Evgeny Khirin <evgeny.khirin <at> erlios.com>
2010-12-10Correct erl_global{register, unregister} functionsVitaliy Batichko
C node needs DFLAG_DIST_MONITOR flag set when connecting, and support for processing monitoring start/end messages received from counterpart, to make global registration actually work.
2010-12-08Add PID (~p) type parameters to ei_formatVitaliy Batichko
2010-12-08Add char (~c) type parameters to ei_formatVitaliy Batichko
2010-11-25erl_interface: Fix erl_term_len for integers and refsSverker Eriksson
From R14B integers use all 32 bits of external format INTEGER_EXT. erl_term_len still had the 28-bit check and therefor returned a too large values (7 instead of 5) for integers of 29-32 bits. erl_term_len also returned a 2 bytes too small value for references.
2010-11-22Merge branch 'ms/ei-fixes' into devBjörn-Egil Dahlberg
* ms/ei-fixes: ei: check memory was allocated ei: error if return value of ei_alloc_big is NULL OTP-8943
2010-11-22Merge branch 'ms/ei-fix-node-name-overflow' into devBjörn-Egil Dahlberg
* ms/ei-fix-node-name-overflow: ei: check the length of the node name OTP-8943
2010-11-11Merge branch 'maint-r14' into devBjörn-Egil Dahlberg
2010-11-08Fix faulty tracelevel in erl_interfaceBjörn-Egil Dahlberg
2010-10-29ei: check memory was allocatedMichael Santos
2010-10-29ei: error if return value of ei_alloc_big is NULLMichael Santos
2010-10-26ei: check the length of the node nameMichael Santos
Check the length of the node name to prevent an overflow.
2010-10-14Merge branch 'ms/fix-zero-byte-allocation' into devBjörn-Egil Dahlberg
* ms/fix-zero-byte-allocation: registry: fix zero byte allocation OTP-8893
2010-10-14Merge branch 'sv/ei-number-parsing' into devBjörn-Egil Dahlberg
* sv/ei-number-parsing: teach ei_x_format to handle unary - and + OTP-8891
2010-10-06teach ei_x_format to handle unary - and +Steve Vinoski
Teach the format string parser used for ei_x_format() and ei_x_format_wo_ver() about unary negative and positive operators on numbers. Previously, passing a negative numeric constant or a positive numeric constant with an explicit leading plus sign within the format string would cause these functions to fail. Augment the format_wo_ver unit test in the ei_format suite with a regression test for these cases. An easy way to reproduce the problem is to use erl_call: erl_call -s foo@bar -a 'erlang list_to_integer [-1]' Without this change, erl_call fails with a -1 exit status. With this change, it properly prints "-1".
2010-10-06registry: fix zero byte allocationMichael Santos
Pasto in code results in 0 bytes (instead of length bytes) being allocated when the length of the key exceeds the static buffer.
2010-10-06erl_call: remove get_hostentMichael Santos
get_hostent does not properly handle IPv4 addresses on little endian platforms and fails with hostnames beginning with a number. Remove get_hostent and use ei_gethostbyname directly since gethostbyname supports IPv4 addresses. Reported-By: Julien Barbot
2010-09-13Merge branch 'pan/epmd-vulnerabilities/OTP-8780' into devPatrik Nyblom
* pan/epmd-vulnerabilities/OTP-8780: Teach testcases to survive TIME_WAIT overload Update erl_interface doc and testsuite for epmd changes Restore null termination of input buffer Teach testcase epmd_SUITE:too_large to accept econnaborted Teach epmd_cli.c to not respond 'Killed' when killing denied Calculate minimal packet size for ALIVE2 requests correctly Document epmd and it's options properly and fixup help text Fix anomalies in epmd not yet reported as security issues Remove two buffer overflow vulnerabilities in EPMD Remove all support for ancient EPMD protocol Remove very old protocol from EPMD Conflicts: lib/erl_interface/src/epmd/epmd_port.c
2010-09-13Merge branch 'sv/ei-writev' into devBjörn-Egil Dahlberg
* sv/ei-writev: fix incorrect writev iovec buffer handling in ei OTP-8837
2010-09-13Teach Winsock initialization to be thread safePatrik Nyblom
2010-09-11fix incorrect writev iovec buffer handling in eiSteve Vinoski
For platforms that support writev, ei uses iovec structures to be able to easily send noncontiguous data buffers. When sending large messages, the socket can of course block, in which case ei adjusts its iovecs to pick up where it left off when the socket becomes writeable again. Unfortunately the code that handled the case when the number of bytes written are less than the current iovec size adjusted only the iovec byte count but not the iovec data pointer, resulting in the same data being sent multiple times. The fix is trivial: in addition to subtracting the count of bytes already written from the current iovec's size, also increment the current iovec's data pointer by the number of bytes already written. Tested manually on Linux and verified to fix a problem detected in production with writing large binaries from a cnode to a regular node. No unit tests were added, however, because they use the local loopback which acts more like a pipe than an inter-host TCP connection. The closing of the TCP window on the receiving side and the resultant write blocking on the socket, which in turn caused the code that mishandled the iovecs to be exercised, could unfortunately not be readily duplicated in the erl_interface test suite.
2010-09-08erl_call: fix multiple buffer overflowsMichael Santos
Check operations that can overflow, e.g., erl_call -sname $(perl -e 'print "x"x5000') perl -e 'print "-module(", "x"x10000, ");"' | erl_call -m -r -sname foo
2010-09-07Merge branch 'mk/net-dragonfly-bsd-patches' into devBjörn Gustavsson
* mk/net-dragonfly-bsd-patches: Remove unused variables Use proper install method Add support for DragonFly BSD Add support for NetBSD
2010-08-31Remove all support for ancient EPMD protocolPatrik Nyblom
2010-08-23ei: prevent overflow in ei_connect_init/ei_xconnectMichael Santos
Check the length of the buffer before copying. ei_cnode ec; struct in_addr addr; char *node = (char *)calloc(5001, 1); (void)memset(node, 'x', 5000); ei_connect_init(&ec, node, "", 0); addr.s_addr = inet_addr("192.168.1.1"); ei_xconnect(&ec, &addr, node);
2010-08-13Add support for DragonFly BSDMartti Kuparinen
These are the current NetBSD pkgsrc patches.