Age | Commit message (Collapse) | Author |
|
Changes to satisfy dialyzer. Including changing the definition
of some of the behaviours (use the '-callback' attribute instead
of an explicit behaviour_info/1 function).
Also found and corrected some (apparently minor) bugs.
OTP-15932
|
|
Changes to satisfy dialyzer. Including changing the definition
of the snmpm_network_interface behaviour (use the '-callback'
attribute instead of an explicit behaviour_info/1 function).
OTP-15932
|
|
Make target (for running dialyzer on snmp), os usage
and a minor snmp_log ("future proofing").
OTP-15932
|
|
Use of the deprecated module random has been replaced
by the module rand.
OTP-15331
|
|
Removed the use of the deprecated erlang:stacktrace() function.
Instead make use of the 'catch Class:Error:Stacktrace' feature.
OTP-15332
|
|
There no timestamp type in os (but there is in erlang).
|
|
|
|
Added common (formated) timestamp function(s). Made use of
these in the verbosity module (for debug printouts) and in
the test suite(s).
I also *think* I found the cause for some if the test case
failures (timeouts).
For v3 (agent) test cases the test manager makes use of parts
of the agent code: snmp_framework_mib and snmp_user_based_sm_mib.
And since they store their data in snmpa_local_db, that also
needs to be running.
And this was the problem (I think). On some (slow) machines,
the snmpa_local_db process from the *previous* test case
might still be running when the we tried to start it. That meant
that no new snmpa_local_db was started. Instead the old one,
still running but terminating, was retain. For a while. Until
it actually finally stopped. So the next operation towards
snmpa_local_db, insert, simply hanged until the process
terminated.
This in combination with the fact that the packet server process,
which was started using proc_lib, previously called init_ack
before this init was actually done, could actually start and then
at a much later time hang because some operation timed out
(the packet server was hanging).
Yuckety yuck-yuck.
|
|
Improved test printouts (more with timestamps), also
fixed the printouts of the (fake) local-db start
result printout.
Also updated the copyright end-dates.
|
|
The agent test manager had a bug during start that could
potentially cause deadlock, but atleast could cause test
cases to fail because of timeouts. The test manager
(actually the "packet server") used proc_lib to start the
process but it called the init_ack function before the init
was actually complete. This was only a problem for v3 cases
(where it did a bunch of further inits, including starting
the local-db process).
Also did debug/verbosity tweaking. Added a bunch of debug
(verbosity) printouts for the agent test manager "packet server"
during v3 init. Also made sure we could distinguish the
"normal" local-db from the one used by the test manager
(this is done by using a new short-name).
|
|
Improve debug (verbose) printouts when a get/get-next/get-bulk/set
request fails (first by printing at level log instead of trace
and secondly by also printing the original operation result
when the operation fails).
|
|
|
|
|
|
Added VMODULE for the two new modules.
Also, improved some verbose printouts.
OTP-15691
|
|
Added the Extra (net-if data) argument to all the get-
mechanism callback functions.
OTP-15691
|
|
Added the snmpa_get module as the default get-mechanism
for the agent.
This has been done by simply moving the do_get, do_get_next
and do_get_bulk functions from the snmpa_agent module.
Some functions where also moved into the lib module (with
the idea of beeing more generally useful).
OTP-15691
|
|
Added preliminary version of the get-mechanism behaviour.
OTP-15691
|
|
Add/update and export some useful types.
OTP-15691
|
|
Fixed the build order. Some of the mib modules export types
used by other modules, so build them (the mib-modules) first
(after snmpa).
OTP-15691
|
|
Also streamlined the config storage. And corrected
the store of the set_mechanism (in the snmp_agent_table).
This is only used for debugging, but just the same.
OTP-15691
|
|
|
|
|
|
|
|
The snmp mib compiler printed an spurious version message
if the 'version' option was provided.
OTP-15290
|
|
Also fixed case clause.
OTP-15287 (ERIERL-206)
|
|
OTP-15287 (ERIERL-206)
|
|
For some outgoing messages (not response) the following
error(s) has been corrected:
* encrypted: logged incorrectly, should have written the v3-header
and the scoped pdu, but was actually logged as-is (encrypted),
making conversion impossible.
* un-encrypted: messages was not logged at all.
OTP-15287 (ERIERL-206)
|
|
If conversion of an Audit Trail Log (ATL) entry failed,
this could result in an abort of the entire conversion,
not just the one entry. This has now been improved so
that the failure now results in a "error message" into
the "stream". Furthermore, we now keep track of the number
of entries we succeede and fail to convert.
OTP-15287 (ERIERL-206)
|
|
I did not find any legitimate use of "can not", however skipped
changing e.g RFCs archived in the source tree.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
In the future, erlang:get_stacktrace/0 will probably only work
inside a the 'catch' block of a 'try' expression.
Future-proof the code by rewriting the old-style catch to
a try...catch.
|
|
|
|
|
|
|
|
|
|
The files are not used in runtime of the snmp app, but they are still
part of the application and beam files are generated. Not including them
will make the general app test fail.
|
|
|
|
|
|
|
|
As long as it is not prioritized to make an snmp_upgrade_SUITE it is
not worth trying to do anything but restart_application
|
|
Adresses problems desciribed in
http://erlang.org/pipermail/erlang-bugs/2015-April/004891.html
http://erlang.org/pipermail/erlang-patches/2015-April/004766.html
The original patch also suggested the following fix.
However we need more information to be able to understand if
this is correct or not, and it does not have priority at the moment
for us to investigate.
@@ -816,7 +816,7 @@ next_node(D, {tree, Tree, {table_entry, _MibName}},
"~n RevOidSoFar: ~p"
"~n MibView: ~p", [size(Tree), Oid, RevOidSoFar, MibView]),
OidSoFar = lists:reverse(RevOidSoFar),
- case snmpa_acm:is_definitely_not_in_mib_view(OidSoFar, MibView) of
+ case snmpa_acm:is_definitely_not_in_mib_view(OidSoFar ++ Oid, MibView) of
true ->
?vdebug("next_node(tree,table_entry) -> not in mib view",[]),
false;
|
|
|
|
* zandra/snmp-appup:
add a soft upgrade instruction to the snmp appup
|
|
* zhird/johnheizenberg/snmp_config_check_imask_bugfix:
fix snmp_conf check imask bug
OTP-13101
|
|
|