| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
Dear all,
it's almost a year since I sent the patch attached to this e-mail, and I
just found out that I have not yet gotten a response to it.
I would consider this patch important because it fixes an issue with the
interpretation of data that might be critical for SNMPv3 operation. I
confirmed at that time that erlangs interpretation of
vacmViewTreeFamilyMask is indeed not interoperable with other SNMP
stacks.
Kind regards,
> > > the implementation of SNMP-VIEW-BASED-ACM.mib assumes that the input for
> > > vacmViewTreeFamilyMask is an OID consisting of 1's and 0's only to form
> > > the mask. However, the MIB states that the input should be a bitstring.
> > >
> > > The OID representation of the mask is useful in the code as it speeds up
> > > time-critical code paths when checking access permissions for EACH SNMP
> > > access. Reading/writing the view mask objects is less time-critical.
> > >
> > > Therefore, to fix the issue, convert between OID representation and
> > > bitstring when the vacmViewTreeFamilyMask objects are accessed. This is
> > > done by the patch attached to this e-mail.
>
>
> I'm very sorry for the troubles that I am causing but it seems that the
> previous version of the patch did more than it should: the OID-bitstring
> conversion was also applied to other tables in the same MIB on
> get/get-next requests.
>
> The version of the patch that is attached to this e-mail restricts the
> OID-bitstring conversion to vacmViewTreeFamilyMask alone.
--
Dr. Stefan Zegenhagen
arcutronix GmbH
Garbsener Landstr. 10
30419 Hannover
Germany
Tel: +49 511 277-2734
Fax: +49 511 277-2709
Email: [email protected]
Web: www.arcutronix.com
*Synchronize the Ethernet*
General Managers: Dipl. Ing. Juergen Schroeder, Dr. Josef Gfrerer -
Legal Form: GmbH, Registered office: Hannover, HRB 202442, Amtsgericht
Hannover; Ust-Id: DE257551767.
Please consider the environment before printing this message.
>From aa2acfb8a0b5ae05fc5ba982d78ee5607384a2be Mon Sep 17 00:00:00 2001
From: Stefan Zegenhagen <[email protected]>
Date: Wed, 1 Aug 2012 09:56:15 +0200
Subject: [PATCH] bugfix for vacmViewTreeFamilyMask
The vacmViewTreeFamilyMask is defined to be a bit string in the MIB, not
an OID. However, the MIB implementation assumed the latter, effectively
rendering all attempts to read/set masks via SNMP unsuccessful.
Since the mask is used in hot paths (e.g. access permission checks for
each SNMP operation, the OID representation of the mask has benefits
(e.g. faster processing). Therefore, convert the bitstring to/from its
OID representation when reading/setting any mask object.
|
|
Removed use of the "-compile(export_all)" attribute and
instead explicitly export functions. This together with
some renaming of internal functions avoids unpredictable
ct side effects. Previously some test cases had "internal"
(since the export_all made all functions exported, not so
much) functions, with the same name but with arity 0,
which did the actual test case. This made for confusing
logs and possible unpredictable test behaviour.
|
|
|
|
There was an id as the first agument to each expect call.
Ufortunatly, this id was often 1 and since the same test
function(s) was called in many test cases, there was many
"Expect 1", and therefor no way of knowing which expect
actually was performed.
The expect functions has been changed to instead take module
and line number.
|
|
|
|
|
|
|
|
bmk/snmp/snmp424_integration/r16
Conflicts:
lib/snmp/doc/src/notes.xml
|
|
bmk/snmp/snmp424_integration/r16
Conflicts:
lib/snmp/doc/src/notes.xml
|
|
OTP-11009
|
|
Test suite utility function for verifying crypto support
updated to use new crypto interface.
OTP-11009
|
|
OTP-11009
|
|
Added a common utility function (in the snmp_misc module)
for testing for crypto support (sed both by the manager
and agent code).
OTP-11009
|
|
|
|
|
|
|
|
Also fixed some of the debug printouts.
|
|
|
|
Make sure snmpa_mib_storage_ets can handle a non-ex file
whe n openning a table (it should simply create it).
|
|
There is a set of default agent config environment values used
when starting an agent. For specififc group of test cases, other
values is used. These two groups of environment is now merged
in a more controlled way.
Also test case grouping make use of more test cases functions
(in order to make the groups() function more readable).
|
|
Updated the snmpa_mib_storage_mnesia module to handle alias
atoms for the nodes option.
Also, (git) added mib-storage behaviour ref-man.
|
|
The agent test (sub-) suite updated according to the
new mib-storage format. Also changed config of started
agent to the "new" format.
|
|
|
|
|
|
|
|
|
|
Add a new function/2 to behaviour. Also changed returnj type for
info/1. Also make sure even ets and dets implementation(s)
check that the correct type is written.
|
|
The new mib-storage is now used by both the mib-server and
the symbolic-store.
|
|
|
|
When starting a sub-agent we previously did not provide
a value for mib_storage, which was alright because ets
was assumed as a default in every place where it was used.
Now we expect the value to be defined and therefor we
must explicitly add the default value for sub-agents when
staring them.
|
|
|
|
The module snmpa_general_db is no longer used (replaced
by the behaviour snmpa_mib_storage and the modules
implementing this behaviour).
|
|
|
|
|
|
|
|
Add (make) depend rule for the new mib-server data module,
snmpa_mib_datas_tttn. Also corrected the depend rule for
the mib-server data module behaviour module (snmpa_mib_data).
|
|
The main snmp agent api module contains some basic type defs
and therefor it must be compiled first.
|
|
|
|
Defines some basic snmp types in the main snmp api module.
Also define some basic snmp agent types in the main snmp
agent api module.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Finalized snmpa_mib_data behaviour. Updated mib-server and
tttn module accordingly. Also assigned proper version, updated
app and appup files.
|
|
|
|
|
