aboutsummaryrefslogtreecommitdiffstats
path: root/lib/snmp
AgeCommit message (Collapse)Author
2013-07-22Merge branch 'maint'Björn-Egil Dahlberg
2013-07-16snmp: Silence debug in testsBjörn-Egil Dahlberg
2013-07-15Merge branch 'maint'Micael Karlberg
2013-07-04Merge branch 'bmk/snmp/agent/ldb_counter_wrap/OTP-11192' into ↵Micael Karlberg
bmk/snmp/snmp4241_integration/r16 Conflicts: lib/snmp/doc/src/notes.xml lib/snmp/src/app/snmp.appup.src
2013-07-04[snmp/agent] Cleanup, renaming, appup, proper version and release notesMicael Karlberg
Add utility functions for checking view masks. Code cleanup, function renaming and comment fix (%% instead of %). Also updated the mask check in the vacm config file check function. Finally, release notes and some cosmetic changes to the agent config-file(s) user guide chapter.
2013-07-03[snmp/agent] Local DB counter increment wrap errorMicael Karlberg
The counter increment function in the local-db was incorrect. It did not handle counter wrap correctly. OTP-11192
2013-06-24Merge branch 'sze/fix-vacm' into bmk/snmp/agent/fix_vacm_mask/OTP-11177Micael Karlberg
2013-06-12Merge branch 'maint'Björn-Egil Dahlberg
2013-06-12Update copyright yearsBjörn-Egil Dahlberg
2013-06-10SNMP/VACM: bugfix for vacmViewTreeFamilyMaskStefan Zegenhagen
Dear all, it's almost a year since I sent the patch attached to this e-mail, and I just found out that I have not yet gotten a response to it. I would consider this patch important because it fixes an issue with the interpretation of data that might be critical for SNMPv3 operation. I confirmed at that time that erlangs interpretation of vacmViewTreeFamilyMask is indeed not interoperable with other SNMP stacks. Kind regards, > > > the implementation of SNMP-VIEW-BASED-ACM.mib assumes that the input for > > > vacmViewTreeFamilyMask is an OID consisting of 1's and 0's only to form > > > the mask. However, the MIB states that the input should be a bitstring. > > > > > > The OID representation of the mask is useful in the code as it speeds up > > > time-critical code paths when checking access permissions for EACH SNMP > > > access. Reading/writing the view mask objects is less time-critical. > > > > > > Therefore, to fix the issue, convert between OID representation and > > > bitstring when the vacmViewTreeFamilyMask objects are accessed. This is > > > done by the patch attached to this e-mail. > > > I'm very sorry for the troubles that I am causing but it seems that the > previous version of the patch did more than it should: the OID-bitstring > conversion was also applied to other tables in the same MIB on > get/get-next requests. > > The version of the patch that is attached to this e-mail restricts the > OID-bitstring conversion to vacmViewTreeFamilyMask alone. -- Dr. Stefan Zegenhagen arcutronix GmbH Garbsener Landstr. 10 30419 Hannover Germany Tel: +49 511 277-2734 Fax: +49 511 277-2709 Email: [email protected] Web: www.arcutronix.com *Synchronize the Ethernet* General Managers: Dipl. Ing. Juergen Schroeder, Dr. Josef Gfrerer - Legal Form: GmbH, Registered office: Hannover, HRB 202442, Amtsgericht Hannover; Ust-Id: DE257551767. Please consider the environment before printing this message. >From aa2acfb8a0b5ae05fc5ba982d78ee5607384a2be Mon Sep 17 00:00:00 2001 From: Stefan Zegenhagen <[email protected]> Date: Wed, 1 Aug 2012 09:56:15 +0200 Subject: [PATCH] bugfix for vacmViewTreeFamilyMask The vacmViewTreeFamilyMask is defined to be a bit string in the MIB, not an OID. However, the MIB implementation assumed the latter, effectively rendering all attempts to read/set masks via SNMP unsuccessful. Since the mask is used in hot paths (e.g. access permission checks for each SNMP operation, the OID representation of the mask has benefits (e.g. faster processing). Therefore, convert the bitstring to/from its OID representation when reading/setting any mask object.
2013-06-04Merge branch 'maint'Björn Gustavsson
* maint: (128 commits) beam_lib: Correct wrong type specification testSeqOf: Test constrained, extensible sizes [snmp/agent] Some restructuring of test suite Clean up testSeqOf Extend tests cases for BIT STRING Improve tests of ENUMERATED asn1ct_check: Eliminate useless Per argument from complist_as_tuple() asn1ct_check: Don't pass on #'ObjectClassFieldType'{} with fixed type asn1ct_gen_per: Remove useless renewal of 'enumval' Fix encoding of semi-constrained, extensible INTEGERs PER/UPER: Fix decoding of semi-constrained INTEGERs testPrim: Simplify test cases using a roundtrip function BER: Fix handling of a constructed default value for a class PER: Generate code for deep table constraints at compile-time Normalize data representation for table constraints asn1ct: Simplify check_value/2 Extend tests to cover more code in asn1ct_check Clean up checking of values for ENUMERATEDs Introduce a new mechanism for structured error handling asn1_db: Make dbput/3 and dbsave/2 asynchronous ...
2013-05-31[snmp/agent] Some restructuring of test suiteMicael Karlberg
Removed use of the "-compile(export_all)" attribute and instead explicitly export functions. This together with some renaming of internal functions avoids unpredictable ct side effects. Previously some test cases had "internal" (since the export_all made all functions exported, not so much) functions, with the same name but with arity 0, which did the actual test case. This made for confusing logs and possible unpredictable test behaviour.
2013-05-30[snmp/agent] Fixed expect macroMicael Karlberg
2013-05-30[snmp/agent] Changed the test suite expect functionMicael Karlberg
There was an id as the first agument to each expect call. Ufortunatly, this id was often 1 and since the same test function(s) was called in many test cases, there was many "Expect 1", and therefor no way of knowing which expect actually was performed. The expect functions has been changed to instead take module and line number.
2013-05-29[snmp/agent] Mib data tttn commentsMicael Karlberg
2013-05-29[snmp/agent] Moved agent config type definition to main agent interface moduleMicael Karlberg
2013-05-28[snmp/agent] Corrected the mib_storage typeMicael Karlberg
2013-05-28Merge branch 'bmk/snmp/agent/mib_storage_behaviour/OTP-11107' into ↵Micael Karlberg
bmk/snmp/snmp424_integration/r16 Conflicts: lib/snmp/doc/src/notes.xml
2013-05-28Merge branch 'bmk/snmp/agent/mib_server_data_callback/OTP-11101' into ↵Micael Karlberg
bmk/snmp/snmp424_integration/r16 Conflicts: lib/snmp/doc/src/notes.xml
2013-05-28[snmp] Updated version and release notesMicael Karlberg
OTP-11009
2013-05-28[snmp] Updated (all) test code to support new crypto interfaceMicael Karlberg
Test suite utility function for verifying crypto support updated to use new crypto interface. OTP-11009
2013-05-28[snmp] Some cosmetic cleanup (tmp verbosity printouts commented)Micael Karlberg
OTP-11009
2013-05-28[snmp] Use of new crypto interface correctd in managerMicael Karlberg
Added a common utility function (in the snmp_misc module) for testing for crypto support (sed both by the manager and agent code). OTP-11009
2013-05-28[snmp/agent] Updated deprecated attributeMicael Karlberg
2013-05-28Merge remote-tracking branch 'upstream/maint'Ingela Anderton Andin
Conflicts: bootstrap/lib/stdlib/ebin/beam_lib.beam lib/public_key/test/erl_make_certs.erl
2013-05-24snmp: Remove use of deprecated crypto functionsIngela Anderton Andin
2013-05-24[snmp/agent] Some restructuring and some new test cases of mib-server suiteMicael Karlberg
2013-05-24[snmp/agent] Improved mib-storage ets module error handlingMicael Karlberg
Also fixed some of the debug printouts.
2013-05-23[snmp/agent] Make the mib-server test (sub-) suite use new mib-storageMicael Karlberg
2013-05-23[snmp/agent] Handle mib-storage ets module non-ex fileMicael Karlberg
Make sure snmpa_mib_storage_ets can handle a non-ex file whe n openning a table (it should simply create it).
2013-05-23[snmp/agent] Merging test case specific and common config envMicael Karlberg
There is a set of default agent config environment values used when starting an agent. For specififc group of test cases, other values is used. These two groups of environment is now merged in a more controlled way. Also test case grouping make use of more test cases functions (in order to make the groups() function more readable).
2013-05-23[snmp/agent] Updated open options for the mnesia mib-storage moduleMicael Karlberg
Updated the snmpa_mib_storage_mnesia module to handle alias atoms for the nodes option. Also, (git) added mib-storage behaviour ref-man.
2013-05-23[snmp/agent] Update agent test (sub-) suiteMicael Karlberg
The agent test (sub-) suite updated according to the new mib-storage format. Also changed config of started agent to the "new" format.
2013-05-23[snmp/agent] Updated the config tool with new mib-storage formatMicael Karlberg
2013-05-23[snmp/agent] Add more verbosity printouts to the mnesia mib-storage moduleMicael Karlberg
2013-05-22[snmp/agent] CosmeticMicael Karlberg
2013-05-22[snmp/agent] No default value for mib_storage and some cleanupMicael Karlberg
2013-05-22[snmp/agent] Add info/2 and some record checksMicael Karlberg
Add a new function/2 to behaviour. Also changed returnj type for info/1. Also make sure even ets and dets implementation(s) check that the correct type is written.
2013-05-22[snmp/agent] Make use of new mib_storageMicael Karlberg
The new mib-storage is now used by both the mib-server and the symbolic-store.
2013-05-22[snmp/agent] Mib server assumes no default value for mib_storageMicael Karlberg
2013-05-22[snmp/agent] Add default value for mib_storage for sub-agentMicael Karlberg
When starting a sub-agent we previously did not provide a value for mib_storage, which was alright because ets was assumed as a default in every place where it was used. Now we expect the value to be defined and therefor we must explicitly add the default value for sub-agents when staring them.
2013-05-22[snmp/agent] Deprecate *old* info conversion functionMicael Karlberg
2013-05-22[snmp/agent] Removed module from app-file and make file(s)Micael Karlberg
The module snmpa_general_db is no longer used (replaced by the behaviour snmpa_mib_storage and the modules implementing this behaviour).
2013-05-21[snmp/agent] Add mib-storage behaviour ref-man documentationMicael Karlberg
2013-05-21[snmp/agent] backupMicael Karlberg
2013-05-21[snmp/agent] Some mib-server options rewordingMicael Karlberg
2013-05-21[snmp/agent] Add (make) deepend for the new mib-server data moduleMicael Karlberg
Add (make) depend rule for the new mib-server data module, snmpa_mib_datas_tttn. Also corrected the depend rule for the mib-server data module behaviour module (snmpa_mib_data).
2013-05-21[snmp/agent] Make sure main api module is compiled firstMicael Karlberg
The main snmp agent api module contains some basic type defs and therefor it must be compiled first.
2013-05-21[snmp/agent] Fixed copyright end dateMicael Karlberg
2013-05-21[snmp/agent] Fixed basic type issuesMicael Karlberg
Defines some basic snmp types in the main snmp api module. Also define some basic snmp agent types in the main snmp agent api module.