Age | Commit message (Collapse) | Author | |
---|---|---|---|
2016-01-20 | stdlib: Update erl_parse(3) | Hans Bolinder | |
Calls to map_anno(), fold_anno(), and mapfold_anno() with lists of erl_parse trees have been replaced. Those functions accept lists of erl_parse trees, but it was not the intention when the functions were introduced, and it is not documented. | |||
2016-01-20 | stdlib: Refine the types of the abstract format | Hans Bolinder | |
2016-01-20 | compiler: Improve type and specs | Hans Bolinder | |
2016-01-20 | hipe: Improve types | Hans Bolinder | |
2016-01-20 | dialyzer: Improve a type | Hans Bolinder | |
2016-01-20 | syntax_tools: Correct a type | Hans Bolinder | |
2016-01-20 | stdlib: Correct a type | Hans Bolinder | |
2016-01-19 | Merge branch 'sverk/safe-purging/OTP-13122' | Sverker Eriksson | |
* sverk/safe-purging/OTP-13122: erts: Ignore unexpected messages to erts_code_purger erts: Optimize erlang:check_process_code erts: Refactor check_process_code/3 erts: Make copy_literals more fail safe erts: Move copy_literals/2 from erlang to erts_internal erts: Make erlang:purge_module/1 safe erts: Refactor code:purge/1 and code:soft_purge/1 erts: Introduce erts_code_purger | |||
2016-01-18 | Merge branch 'maint' | Hans Nilsson | |
2016-01-18 | ssh: encode/decode benchmark suites | Hans Nilsson | |
2016-01-18 | ssh: added cipher name to transfer speed report | Hans Nilsson | |
2016-01-18 | ssh: added sftp server benchmark | Hans Nilsson | |
2016-01-18 | Merge branch 'maint' | Björn-Egil Dahlberg | |
2016-01-18 | Merge branch 'egil/improve-map-cerl-prettypr/OTP-13238' into maint | Björn-Egil Dahlberg | |
* egil/improve-map-cerl-prettypr/OTP-13238: compiler, hipe: Fix pretty printing of Core Maps hipe: Fix map pretty printing of pairs dialyzer: Update Maps tests | |||
2016-01-18 | Merge branch 'maint' | Hans Bolinder | |
* maint: edoc: Assign correct names to list arguments | |||
2016-01-18 | edoc: Assign correct names to list arguments | Hans Bolinder | |
Bug reported by Josemic. See also ERL-63. | |||
2016-01-15 | Merge branch 'maint' | Hans Bolinder | |
* maint: dialyzer: Correct handling of parameters of opaque types | |||
2016-01-15 | dialyzer: Correct handling of parameters of opaque types | Hans Bolinder | |
Correction of commit d57f5e. | |||
2016-01-14 | compiler, hipe: Fix pretty printing of Core Maps | Björn-Egil Dahlberg | |
Literal maps could cause dialyzer to crash when pretty printing the results. Reported-by: Chris McGrath <[email protected]> | |||
2016-01-14 | hipe: Fix map pretty printing of pairs | Björn-Egil Dahlberg | |
In commit f667931e2905797ffab63e224e56eaf07f77178a the core format changed for map pairs. Let dialyzer and hipe pretty printing of maps also adhere to those changes. An Erlang map update, M#{foo := 1, bar => 2} will now be printed as: ~{ 'foo' := 1, 'bar' => 2 | M }~ | |||
2016-01-14 | dialyzer: Update Maps tests | Björn-Egil Dahlberg | |
2016-01-13 | erts: Make erlang:purge_module/1 safe | Sverker Eriksson | |
Problem: erlang:purge_module/1 is not safe in the sense that very bad things may happen if the code to be purged is still referred to by live processes. Introduce erts_internal:purge_module which is the same as the old erlang:purge_module BIF (except it returns false if no such old module). Implement erlang:purge_module in Erlang and let it invoke erts_code_purger for safe purging where all clogging processes first are killed. | |||
2016-01-13 | Merge branch 'sverk/fvisibility-hidden/OTP-13227' | Sverker Eriksson | |
* sverk/fvisibility-hidden/OTP-13227: erts: Allow -fvisibility=hidden for NIFs and drivers erts: Cleanup erl_driver.h for windows erts: Refactor ERL_NIF_INIT macro | |||
2016-01-13 | erts: Refactor code:purge/1 and code:soft_purge/1 | Sverker Eriksson | |
by moving code from code_server to erts_code_purger. This is more or less a copy-paste from code_server.erl to erts_code_purger.erl. All the inner mechanics of code:purge/1 and code:soft_purge/1 are unchanged. | |||
2016-01-13 | erts: Introduce erts_code_purger | Sverker Eriksson | |
as a system process with preloaded code. | |||
2016-01-13 | Merge branch 'maint' | Björn Gustavsson | |
* maint: Fix crash when attempting to update a fun as if it were a map | |||
2016-01-13 | Merge branch 'bjorn/compiler/map-bug/OTP-13231' into maint | Björn Gustavsson | |
* bjorn/compiler/map-bug/OTP-13231: Fix crash when attempting to update a fun as if it were a map | |||
2016-01-13 | stdlib: Let dets:open_file() crash when given raw file name | Hans Bolinder | |
See also ERL-55. | |||
2016-01-13 | Merge branch 'maint' | Hans Bolinder | |
* maint: stdlib: Fix linter crash due to missing -module declaration Conflicts: lib/stdlib/test/erl_lint_SUITE.erl | |||
2016-01-13 | stdlib: Fix linter crash due to missing -module declaration | Hans Bolinder | |
The Erlang Code Linter no longer crashes if there is a -deprecated() attribute but no -module() declaration. See also ERL-62 at bugs.erlang.org. | |||
2016-01-13 | Merge branch 'maint' | Hans Bolinder | |
* maint: stdlib: fix erl_eval not using non-local function handler | |||
2016-01-13 | stdlib: fix erl_eval not using non-local function handler | Hans Bolinder | |
See also ERL-32 at bugs.erlang.org. Thanks to Ben Paxton. | |||
2016-01-12 | Fix crash when attempting to update a fun as if it were a map | Björn Gustavsson | |
The following example would cause an internal consistency failure in the compiler: f() -> ok. update() -> (fun f/0)#{u => 42}. The reason is that internally, v3_core will (incorrectly) rewrite update/0 to code similar to this: update() -> if is_map(fun f/0) -> maps:update(u, 42, fun f/0) end. Since funs are not allowed to be created in guards, incorrect and unsafe code would be generated. It is easy to fix the bug. There already is a is_valid_map_src/1 function in v3_core that tests whether the argument for the map update operation can possibly be a valid map. A fun is represented as a variable with a special name in Core Erlang, so it would not be recognized as unsafe. All we'll need to do to fix the bug is to look closer at variables to ensure they don't represent funs. That will ensure that the code is rewritten in the correct way: update() -> error({badmap,fun f/0}) end. Reported-by: Thomas Arts | |||
2016-01-11 | Merge branch 'maint' | Henrik Nord | |
Conflicts: OTP_VERSION | |||
2016-01-11 | Merge branch 'maint-18' into maint | Henrik Nord | |
2016-01-11 | Merge branch 'maint' | Björn Gustavsson | |
* maint: Eliminate crash in v3_codegen | |||
2016-01-11 | Eliminate crash in v3_codegen | Björn Gustavsson | |
The following code would crash v3_codegen: order(From) -> catch if From#{[] => sufficient} -> saint end. Before explaining the crash, first some background on the stack frame and the Y registers. Certain instructions, most notably the 'call' instructions, clobber all X registers. Before any such instruction, all X registers that have values that will be used after the call must be saved to Y registers (i.e. to the stack frame). adjust_stack/4 will be called when X registers must be saved. There is also another situation when X registers must be saved, namely within a 'catch' if we are about to execute any instruction that may cause an exception. Examples of such instructions are some guard BIFs (such as length/1) and construction of binaries or maps. Within a 'catch', X registers must be be saved because if an exception is thrown and catched all X registers will be destroyed. The same adjust_stack/4 function will be called for those instructions, but only if they occur within a 'catch'. There is actually one more complication. If there is code in a guard within a catch, the X registers should not be saved, because the code in a guard never clobbers any X registers that were alive before the guard code was entered. v3_codegen is written with the implicit assumption that code in guards never cause anything to be saved to Y registers. The code for building maps and binaries would incorrectly save X registers within a guard inside a 'catch'. For construction of binaries, that would mean that a useless but harmelss 'move' instruction was generated. But for construction of maps, the saving of the Y register would not be harmless. There would be a crash when attempting to merge #sr{} records. #sr{} records keeps track of the contents of X and Y registers. When two separate code paths are joined (e.g. at the end of 'case' statement), the register descriptors must be reconciled. Basically, the register descriptors for both paths must be identical. The #sr{} record for one path must not claim that {y,0} contains a certain value, while another path claims that {y,0} is dead. Thus, the crash occurs in sr_merge/2 when failing to reconcile the Y registers. To fix this bug this bug we will introduce a new function called maybe_adjust_stack/5. It will save X registers on the stack only if the code is inside a catch but not inside a guard. We will change all existing code to use this new function when appropriate. Reported-by: Thomas Arts | |||
2016-01-08 | erts: Allow -fvisibility=hidden for NIFs and drivers | Sverker Eriksson | |
as is strongly recommended by gcc man page. We use __attribute__ ((visibility("default"))) to make sure the init functions are properly exported. | |||
2016-01-08 | Update release notes | Erlang/OTP | |
2016-01-08 | ssh: update vsn.mk to 4.2.1 | Hans Nilsson | |
2016-01-08 | ssh: handle secondary ssh_msg_userauth_info_request message | Hans Nilsson | |
2016-01-08 | ssh: testcase for abnormal keyboard-interactive authentication | Hans Nilsson | |
2016-01-08 | Merge branch 'maint' | Björn Gustavsson | |
* maint: beam_bool: Fix unsafe optimization | |||
2016-01-07 | Merge branch 'sverk/proc-dict-opt' | Sverker Eriksson | |
OTP-13167 * sverk/proc-dict-opt: erts: Add new test case pdict_SUITE:mixed erts: Add 'fill_heap' to erts_debug:state_internal_state erts: Rename proc dict size to arraySize erts: Refactor proc dict with 'usedSlots' erts: Add sizeMask for faster proc dict indexing erts: Remove ProcDict.used erts: Add proc dict macros ERTS_PD_START/SIZE erts: Optimize away function "array_put" in proc dict erts: Optimize hashing in process dictionary | |||
2016-01-07 | Merge branch 'bjorn/compiler/beam_bool/OTP-13208' into maint | Björn Gustavsson | |
* bjorn/compiler/beam_bool/OTP-13208: beam_bool: Fix unsafe optimization | |||
2016-01-07 | beam_bool: Fix unsafe optimization | Björn Gustavsson | |
beam_bool would make the following code unsafe (which would be reported by beam_validator): scotland(Echo) -> found(case Echo of Echo when true; Echo, Echo, Echo -> Echo; echo -> [] end, Echo = placed). found(_, _) -> million. Basically, beam_bool would see that the 'case' would always return the value of Echo. Thus: scotland(Echo) -> found(Echo, Echo = placed). The only problem is that beam_bool would also remove a 'move' instruction that would save Echo to the stack. Here is the assembly code for part of the function: {allocate_zero,1,1}. {move,{x,0},{y,0}}. %% Save Echo on stack. {bif,'=:=',{f,7},[{x,0},{atom,true}],{x,1}}. {bif,'=:=',{f,7},[{x,0},{atom,true}],{x,2}}. {bif,'=:=',{f,7},[{x,0},{atom,true}],{x,3}}. {bif,'and',{f,7},[{x,2},{x,3}],{x,2}}. {bif,'and',{f,7},[{x,1},{x,2}],{x,1}}. {jump,{f,8}}. {label,7}. {move,{atom,false},{x,1}}. {label,8}. {bif,'or',{f,6},[{atom,true},{x,1}],{x,1}}. {test,is_eq_exact,{f,6},[{x,1},{atom,true}]}. %% Jump never taken. {jump,{f,5}}. {label,6}. {test,is_eq_exact,{f,9},[{x,0},{atom,echo}]}. {move,nil,{x,0}}. {jump,{f,5}}. {label,9}. {test_heap,3,0}. {put_tuple,2,{x,0}}. {put,{atom,case_clause}}. {put,{y,0}}. {line,[{location,"t.erl",5}]}. {call_ext,1,{extfunc,erlang,error,1}}. {jump,{f,5}}. {label,5}. {test,is_eq_exact,{f,12},[{atom,placed},{y,0}]}. beam_bool would see that the is_eq_exact test at label 8 would always succeed. It could therefore remove most of the code before the jump to label 5. Unfortunately it also removed the essential move of Echo to the stack: {allocate_zero,1,1}. %% Instruction incorrectly removed: {move,{x,0},{y,0}}. {jump,{f,5}}. {label,5}. {test,is_eq_exact,{f,12},[{atom,placed},{y,0}]}. The root cause of the problem is that the 'move' instruction is included in the block of 'bif' instructions before label 8. Normally the 'move' instruction would not have been discarded, but because the left operand to the 'or' BIF is 'true', the entire block with 'bif' instructions are dropped. As far as I can see, there is no gain by including 'move' instructions in the first place. There is no way that better code will be produced. In fact, the entire optimization can be given up if 'move' instructions are found in the block. Thus we can fix this bug by never including any 'move' instructions in the block of 'bif' instructions. We can also remove all the code that deals with 'move' instructions within blocks. Reported-by: Thomas Arts | |||
2015-12-28 | Merge branch 'maint' | Zandra | |
2015-12-28 | Merge branch 'legoscia/tls_dist_error_reporting' into maint | Zandra | |
* legoscia/tls_dist_error_reporting: Report bad options for outgoing TLS distribution Save error reasons for TLS distribution connections Report bad options for TLS distribution connections OTP-13219 | |||
2015-12-28 | Merge branch 'maint' | Zandra | |
2015-12-28 | Merge branch 'josevalim/jv-map-fun-eval-maint' into maint | Zandra | |
* josevalim/jv-map-fun-eval-maint: Use full list of bindings when matching on map keys OTP-13218 |