Age | Commit message (Collapse) | Author |
|
In the v3_life pass, it is assumed that a 'match_fail' primop
only occur at the top-level and at the end of a function.
But this code:
do_split_cases(A) ->
case A of
x ->
Z = dummy1;
_ ->
Z = dummy2,
a=b
end,
Z.
will be optimized by sys_core_fold to the following code:
'split_cases'/1 =
fun (_cor0) ->
let <_cor7,Z> =
case _cor0 of
<'x'> when 'true' ->
< 'dummy1','dummy1' >
<_cor6> when 'true' ->
%% Here follows a 'match_fail' primop inside
%% multiple return values:
< primop 'match_fail'({'badmatch','b'}),'dummy2' >
end
in
Z
moving the 'match_fail' primop into a "values" construction.
In the future, we would like to get rid of the v3_life pass (it is
there for historical reasons), so in the mean-time we prefer to not
add more code to it by generalizing the handling of 'match_fail'.
Since the 'match_fail' primop can be simulated by erlang:error/{1,2},
the simplest solution is to translate 'match_fail' to a call to
erlang:error/{1,2} in v3_kernel and remove the handling of
'match_fail' in v3_life and v3_codegen.
It is tempting to get rid of 'match_fail' also in the Core Erlang
format, but there are two issues:
- Removing the support for 'match_fail' completely may break tools
that generate Core Erlang code. We should not do that in a minor
release.
- There is no easy way to generate a 'function_clause' exception
that will remain correct if it will be inlined into another
function. (Calling "erlang:error(function_clause, Args)" is
fine only if it is not inlined into another function.) A good
solution probably involves introducing new instructions, which
is better done in a major release.
Noticed-by: Håkan Matsson
Minimized-test-case-by: Erik Søe Sørensen
|
|
* raimo/opu-fixes:
inet_res_SUITE: Go back to old way to kill test name server
|
|
* hb/erl_docgen/fix_links/OTP-9832:
Generate links in C libraries correctly
|
|
* siri/sasl/check-config-in-tar/OTP-9539:
Check that sys.config and relup have valid content when added to tar
|
|
* siri/sasl/require-kernel-start/OTP-9652:
Reject systools:make_script if kernel and stdlib are not permanent in .rel
|
|
systools:make_tar now does a minor check of the content of sys.config
and relup before adding them to the tar file. If the content is not
readable or in expected format, the function fails.
|
|
It should not be possible to create a .boot file unless kernel and
stdlib are stated as permanent applications in the .rel file. Note
that 'permanent' is the default start type, so not specifying a start
type for kernel and stdlib is, as always, ok.
|
|
Supervisor should never keep child specs for dead temporary children.
|
|
* anders/diameter/testsuites/OTP-9829: (21 commits)
Install example dictionaries
Move example code to examples/code
Move example dictionaries to examples/dict
Set name/prefix at compilation, not in dictionaries
Add RFC 4004 (MIP) dictionary
Add RFC 4740 (SIP) dictionary
Add RFC 4072 (EAP) dictionary
Add RFC 4006 (CC) dictionary
Add RFC 4005 (NAS) dictionary
Add standards testcase to compiler suite
Remove {init,end}_per_group workaround
Use new syntax for specifying ct group properties
Increase timetrap in compiler suite
Minor capx suite tweaks
Minor makefile tweak
Remove trailing whitespace
Update skip condition in gen_sctp suite
Reintroduce gen_sctp suite
Remove delay from connect in transport suite
Add codec testcase for decode of unknown AVPs
...
|
|
* anders/diameter/compilation_options/OTP-9826:
Allow module name mapping at dictionary compilation
Fix blunder that broke name/prefix compilation options
|
|
* anders/diameter/missed_events/OTP-9824:
Update watchdog suite
Ensure capabilities exchange can't fail too early
|
|
|
|
|
|
|
|
|
|
To avoid inappropriate defaults if the dictionaries are reused.
|
|
|
|
|
|
|
|
|
|
|
|
To test compilation of example dictionaries from various standards.
|
|
This undoes commit 162c0d3ee30790ec5a75e20b0e2e8bc61ed92375.
|
|
No longer have to duplicate groups for sequential and parallel runs.
|
|
Compilation is slow on Solaris for one.
|
|
|
|
|
|
|
|
To the R15 behaviour, with a return value instead of badarg.
|
|
Commit e05868f49b442c10cedbded390c110473cda6f00 was the original,
this commit is the result of splitting that one in two.
Resurrect this suite to make SCTP faults more visible: the transport
suite has sporadic failures because of them, despite having jacked
up timeouts to unreasonable values.
|
|
There should be no need for it, previous introduction was misguided.
|
|
|
|
That is, remove the catch for the pre-R15 behaviour.
|
|
This is to make the 'inherits' option usable with dictionaries
that inherit specific AVPs. Something like "diameterc -inherts from/to"
effectively replaces "@inherits from" in the source dictionary with
"@inherits to".
|
|
|
|
|
|
|
|
In particular, not before the service process has a monitor on
the watchdog since the watchdog's exit reason is meaningful.
|
|
|
|
|
|
OTP-9821
|
|
The uniqueness check of attributes failed when the namespace_conformant
flag was set to true.
|
|
|
|
* origin/peppe/common_test/r15b_docs:
Update basics chapter and introduce getting started chapter
Document the tc_logfile data
Document new CSS look and the basic_html flag
Document info functions for init/end_per_suite/group
Document the group info function
Document changes in test specifications (groups) and style sheets
Document group specifications in all/0 and the group info function
OTP-9156
|
|
|
|
|
|
|
|
|
|
|
|
|