| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2016-01-28 | code: Correct the types for error returns | Björn Gustavsson | |
| The specifications for functions that load code in the 'code' module (e.g. code:load_file/1) have some problems: * The specs claim that the functions can return {error,on_load}, but they never do. However, they can return {error,on_load_failure} if the -on_load function in a module fails. * The specs claim that the functions can return {error,native_code}, but they never do. While we are it, also extend the on_load_errors/1 test case to test that the load functions return {error,on_load_failure} when an -on_load function fails. | |||
| 2016-01-25 | Eliminate run-time system crash in code:load_abs/1 | Björn Gustavsson | |
| The run-time system would terminate if code:load_abs/1 was called with a filename containing any non-latin1 characters. The reason is that code_server would attempt to construct a module name from the filename using list_to_atom/1 and that atoms currently are limited to the latin1 character set. But how should the error be reported? I have decided to that the simplest and least confusing way is to move the call to list_to_atom/1 to 'code' module and let it crash the calling process. The resulting stack back trace will make it clear what the reason for the crash was. | |||
| 2016-01-25 | Merge branch 'ia/ssl/test-alpn-cuddle' into maint | Ingela Anderton Andin | |
| * ia/ssl/test-alpn-cuddle: ssl: Fix typos that broke alpn tests | |||
| 2016-01-25 | Merge branch 'ia/ssl/hs-timing/OTP-13253' into maint | Ingela Anderton Andin | |
| * ia/ssl/hs-timing/OTP-13253: ssl: Prepare for release ssl: Fix timing releated bug | |||
| 2016-01-22 | Merge branch 'siri/cover/nofile/OTP-13200' into maint | Siri Hansen | |
| * siri/cover/nofile/OTP-13200: [cover] Don't crash when compiling beam without 'file' attribute [cover] Simplify module cc in cover test to avoid confusion | |||
| 2016-01-21 | ssl: Fix typos that broke alpn tests | Ingela Anderton Andin | |
| 2016-01-21 | PER: Correct compilation of named INTEGERs | Björn Gustavsson | |
| When a constrained INTEGER has more than 16536 values and named values, the compiler would crash when compiling to the PER format. Example: Longitude ::= INTEGER { oneMicrodegreeEast(10), oneMicrodegreeWest(-10), unavailable(1800000001) } (-1799999999..1800000001) Reported-by: Ingars | |||
| 2016-01-21 | ssl: Prepare for release | Ingela Anderton Andin | |
| 2016-01-21 | ssl: Fix timing releated bug | Ingela Anderton Andin | |
| 2016-01-21 | Merge branch 'ia/ssl/version_support_check' into maint | Ingela Anderton Andin | |
| * ia/ssl/version_support_check: ssl: In interop tests always check if SSL/TLS version is supported by OpenSSL | |||
| 2016-01-21 | ssl: In interop tests always check if SSL/TLS version is supported by OpenSSL | Ingela Anderton Andin | |
| As sslv3 is being faced out we need to test for old version support as well as newer versions. | |||
| 2016-01-19 | Merge branch 'sverk/crypto-aec-ecb-multiblock' into maint | Sverker Eriksson | |
| OTP-13249 * sverk/crypto-aec-ecb-multiblock: crypto: Fix bug for multiple blocks for AES-ECB | |||
| 2016-01-18 | ssh: encode/decode benchmark suites | Hans Nilsson | |
| 2016-01-18 | ssh: added cipher name to transfer speed report | Hans Nilsson | |
| 2016-01-18 | ssh: added sftp server benchmark | Hans Nilsson | |
| 2016-01-18 | Merge branch 'egil/improve-map-cerl-prettypr/OTP-13238' into maint | Björn-Egil Dahlberg | |
| * egil/improve-map-cerl-prettypr/OTP-13238: compiler, hipe: Fix pretty printing of Core Maps hipe: Fix map pretty printing of pairs dialyzer: Update Maps tests | |||
| 2016-01-18 | edoc: Assign correct names to list arguments | Hans Bolinder | |
| Bug reported by Josemic. See also ERL-63. | |||
| 2016-01-15 | dialyzer: Correct handling of parameters of opaque types | Hans Bolinder | |
| Correction of commit d57f5e. | |||
| 2016-01-14 | crypto: Fix bug for multiple blocks for AES-ECB | Andrew Bennett | |
| 2016-01-14 | compiler, hipe: Fix pretty printing of Core Maps | Björn-Egil Dahlberg | |
| Literal maps could cause dialyzer to crash when pretty printing the results. Reported-by: Chris McGrath <[email protected]> | |||
| 2016-01-14 | hipe: Fix map pretty printing of pairs | Björn-Egil Dahlberg | |
| In commit f667931e2905797ffab63e224e56eaf07f77178a the core format changed for map pairs. Let dialyzer and hipe pretty printing of maps also adhere to those changes. An Erlang map update, M#{foo := 1, bar => 2} will now be printed as: ~{ 'foo' := 1, 'bar' => 2 | M }~ | |||
| 2016-01-14 | dialyzer: Update Maps tests | Björn-Egil Dahlberg | |
| 2016-01-13 | Merge branch 'bjorn/compiler/map-bug/OTP-13231' into maint | Björn Gustavsson | |
| * bjorn/compiler/map-bug/OTP-13231: Fix crash when attempting to update a fun as if it were a map | |||
| 2016-01-13 | stdlib: Fix linter crash due to missing -module declaration | Hans Bolinder | |
| The Erlang Code Linter no longer crashes if there is a -deprecated() attribute but no -module() declaration. See also ERL-62 at bugs.erlang.org. | |||
| 2016-01-13 | stdlib: fix erl_eval not using non-local function handler | Hans Bolinder | |
| See also ERL-32 at bugs.erlang.org. Thanks to Ben Paxton. | |||
| 2016-01-12 | Fix crash when attempting to update a fun as if it were a map | Björn Gustavsson | |
| The following example would cause an internal consistency failure in the compiler: f() -> ok. update() -> (fun f/0)#{u => 42}. The reason is that internally, v3_core will (incorrectly) rewrite update/0 to code similar to this: update() -> if is_map(fun f/0) -> maps:update(u, 42, fun f/0) end. Since funs are not allowed to be created in guards, incorrect and unsafe code would be generated. It is easy to fix the bug. There already is a is_valid_map_src/1 function in v3_core that tests whether the argument for the map update operation can possibly be a valid map. A fun is represented as a variable with a special name in Core Erlang, so it would not be recognized as unsafe. All we'll need to do to fix the bug is to look closer at variables to ensure they don't represent funs. That will ensure that the code is rewritten in the correct way: update() -> error({badmap,fun f/0}) end. Reported-by: Thomas Arts | |||
| 2016-01-11 | Merge branch 'maint-18' into maint | Henrik Nord | |
| 2016-01-11 | Eliminate crash in v3_codegen | Björn Gustavsson | |
| The following code would crash v3_codegen: order(From) -> catch if From#{[] => sufficient} -> saint end. Before explaining the crash, first some background on the stack frame and the Y registers. Certain instructions, most notably the 'call' instructions, clobber all X registers. Before any such instruction, all X registers that have values that will be used after the call must be saved to Y registers (i.e. to the stack frame). adjust_stack/4 will be called when X registers must be saved. There is also another situation when X registers must be saved, namely within a 'catch' if we are about to execute any instruction that may cause an exception. Examples of such instructions are some guard BIFs (such as length/1) and construction of binaries or maps. Within a 'catch', X registers must be be saved because if an exception is thrown and catched all X registers will be destroyed. The same adjust_stack/4 function will be called for those instructions, but only if they occur within a 'catch'. There is actually one more complication. If there is code in a guard within a catch, the X registers should not be saved, because the code in a guard never clobbers any X registers that were alive before the guard code was entered. v3_codegen is written with the implicit assumption that code in guards never cause anything to be saved to Y registers. The code for building maps and binaries would incorrectly save X registers within a guard inside a 'catch'. For construction of binaries, that would mean that a useless but harmelss 'move' instruction was generated. But for construction of maps, the saving of the Y register would not be harmless. There would be a crash when attempting to merge #sr{} records. #sr{} records keeps track of the contents of X and Y registers. When two separate code paths are joined (e.g. at the end of 'case' statement), the register descriptors must be reconciled. Basically, the register descriptors for both paths must be identical. The #sr{} record for one path must not claim that {y,0} contains a certain value, while another path claims that {y,0} is dead. Thus, the crash occurs in sr_merge/2 when failing to reconcile the Y registers. To fix this bug this bug we will introduce a new function called maybe_adjust_stack/5. It will save X registers on the stack only if the code is inside a catch but not inside a guard. We will change all existing code to use this new function when appropriate. Reported-by: Thomas Arts | |||
| 2016-01-08 | Update release notes | Erlang/OTP | |
| 2016-01-08 | ssh: update vsn.mk to 4.2.1 | Hans Nilsson | |
| 2016-01-08 | ssh: handle secondary ssh_msg_userauth_info_request message | Hans Nilsson | |
| 2016-01-08 | ssh: testcase for abnormal keyboard-interactive authentication | Hans Nilsson | |
| 2016-01-07 | Merge branch 'bjorn/compiler/beam_bool/OTP-13208' into maint | Björn Gustavsson | |
| * bjorn/compiler/beam_bool/OTP-13208: beam_bool: Fix unsafe optimization | |||
| 2016-01-07 | beam_bool: Fix unsafe optimization | Björn Gustavsson | |
| beam_bool would make the following code unsafe (which would be reported by beam_validator): scotland(Echo) -> found(case Echo of Echo when true; Echo, Echo, Echo -> Echo; echo -> [] end, Echo = placed). found(_, _) -> million. Basically, beam_bool would see that the 'case' would always return the value of Echo. Thus: scotland(Echo) -> found(Echo, Echo = placed). The only problem is that beam_bool would also remove a 'move' instruction that would save Echo to the stack. Here is the assembly code for part of the function: {allocate_zero,1,1}. {move,{x,0},{y,0}}. %% Save Echo on stack. {bif,'=:=',{f,7},[{x,0},{atom,true}],{x,1}}. {bif,'=:=',{f,7},[{x,0},{atom,true}],{x,2}}. {bif,'=:=',{f,7},[{x,0},{atom,true}],{x,3}}. {bif,'and',{f,7},[{x,2},{x,3}],{x,2}}. {bif,'and',{f,7},[{x,1},{x,2}],{x,1}}. {jump,{f,8}}. {label,7}. {move,{atom,false},{x,1}}. {label,8}. {bif,'or',{f,6},[{atom,true},{x,1}],{x,1}}. {test,is_eq_exact,{f,6},[{x,1},{atom,true}]}. %% Jump never taken. {jump,{f,5}}. {label,6}. {test,is_eq_exact,{f,9},[{x,0},{atom,echo}]}. {move,nil,{x,0}}. {jump,{f,5}}. {label,9}. {test_heap,3,0}. {put_tuple,2,{x,0}}. {put,{atom,case_clause}}. {put,{y,0}}. {line,[{location,"t.erl",5}]}. {call_ext,1,{extfunc,erlang,error,1}}. {jump,{f,5}}. {label,5}. {test,is_eq_exact,{f,12},[{atom,placed},{y,0}]}. beam_bool would see that the is_eq_exact test at label 8 would always succeed. It could therefore remove most of the code before the jump to label 5. Unfortunately it also removed the essential move of Echo to the stack: {allocate_zero,1,1}. %% Instruction incorrectly removed: {move,{x,0},{y,0}}. {jump,{f,5}}. {label,5}. {test,is_eq_exact,{f,12},[{atom,placed},{y,0}]}. The root cause of the problem is that the 'move' instruction is included in the block of 'bif' instructions before label 8. Normally the 'move' instruction would not have been discarded, but because the left operand to the 'or' BIF is 'true', the entire block with 'bif' instructions are dropped. As far as I can see, there is no gain by including 'move' instructions in the first place. There is no way that better code will be produced. In fact, the entire optimization can be given up if 'move' instructions are found in the block. Thus we can fix this bug by never including any 'move' instructions in the block of 'bif' instructions. We can also remove all the code that deals with 'move' instructions within blocks. Reported-by: Thomas Arts | |||
| 2015-12-28 | Merge branch 'legoscia/tls_dist_error_reporting' into maint | Zandra | |
| * legoscia/tls_dist_error_reporting: Report bad options for outgoing TLS distribution Save error reasons for TLS distribution connections Report bad options for TLS distribution connections OTP-13219 | |||
| 2015-12-28 | Merge branch 'josevalim/jv-map-fun-eval-maint' into maint | Zandra | |
| * josevalim/jv-map-fun-eval-maint: Use full list of bindings when matching on map keys OTP-13218 | |||
| 2015-12-28 | Merge branch 'lucafavatella/dialyzer-fun-call' into maint | Zandra | |
| * lucafavatella/dialyzer-fun-call: Teach Dialyzer call to funs `M:F/A` (literal M, F, A) OTP-13217 | |||
| 2015-12-22 | Merge branch 'maint-17' into maint | Anders Svensson | |
| 2015-12-22 | ssh: clean test specs | Hans Nilsson | |
| 2015-12-22 | Merge branch 'hans/ssh/cuddle_tests' into maint | Hans Nilsson | |
| * hans/ssh/cuddle_tests: ssh: add econnaborted to disconnect msgs in test suite ssh: fix the check that open-ssh supports certain pubkeys in a test suite | |||
| 2015-12-22 | ssh: fix error (wrong suite) in test/ssh.spec | Hans Nilsson | |
| 2015-12-21 | ssh: benchmark all common kex and cipher algorithms | Hans Nilsson | |
| 2015-12-21 | New structure of the report | Hans Nilsson | |
| 2015-12-21 | ssh: ssh_benchmark_SUITE re-organized | Hans Nilsson | |
| 2015-12-21 | ssh: Add first version of ssh_benchmark_SUITE | Hans Nilsson | |
| 2015-12-20 | Update release notes | Erlang/OTP | |
| 2015-12-20 | Merge branch 'anders/diameter/17.5.6.7/OTP-13211' into maint-17 | Erlang/OTP | |
| * anders/diameter/17.5.6.7/OTP-13211: vsn -> 1.9.2.2 Update/fix appup for 17.5.6.7 Be resilient to diameter_service state upgrades | |||
| 2015-12-20 | Merge branch 'anders/diameter/request_leak/OTP-13137' into maint-17 | Erlang/OTP | |
| * anders/diameter/request_leak/OTP-13137: Fix request table leak at retransmission Fix request table leak at exit signal | |||
| 2015-12-20 | Merge branch 'anders/diameter/17/watchdog/OTP-12969' into maint-17 | Erlang/OTP | |
| * anders/diameter/17/watchdog/OTP-12969: Fix watchdog function_clause | |||
| 2015-12-20 | Merge branch 'anders/diameter/M-bit/OTP-12947' into maint-17 | Erlang/OTP | |
| * anders/diameter/M-bit/OTP-12947: Add service_opt() strict_mbit | |||
 |
index : otp.git | |
| Mirror of Erlang/OTP repository. | OTP Team |
| aboutsummaryrefslogtreecommitdiffstats |