aboutsummaryrefslogtreecommitdiffstats
path: root/src/cow_http_hd.erl
diff options
context:
space:
mode:
authorLoïc Hoguin <[email protected]>2014-12-17 23:54:37 +0200
committerLoïc Hoguin <[email protected]>2014-12-18 00:08:14 +0200
commit8ebb992434c89e191389503cbc705d7f30706772 (patch)
treeb07bbe35102f2b867b5f5d2f53a212c48b37fc67 /src/cow_http_hd.erl
parent95b4a3924d2a8ac1bf0d114248f1a45e58c25cbf (diff)
downloadcowlib-8ebb992434c89e191389503cbc705d7f30706772.tar.gz
cowlib-8ebb992434c89e191389503cbc705d7f30706772.tar.bz2
cowlib-8ebb992434c89e191389503cbc705d7f30706772.zip
Add cow_http_hd:parse_if_match/1
From RFC7232. Nearly twice as fast as current Cowboy code.
Diffstat (limited to 'src/cow_http_hd.erl')
-rw-r--r--src/cow_http_hd.erl76
1 files changed, 76 insertions, 0 deletions
diff --git a/src/cow_http_hd.erl b/src/cow_http_hd.erl
index 8427cc7..2c08486 100644
--- a/src/cow_http_hd.erl
+++ b/src/cow_http_hd.erl
@@ -23,6 +23,7 @@
-export([parse_content_type/1]).
-export([parse_date/1]).
-export([parse_expect/1]).
+-export([parse_if_match/1]).
-export([parse_if_modified_since/1]).
-export([parse_if_unmodified_since/1]).
-export([parse_last_modified/1]).
@@ -30,6 +31,9 @@
-export([parse_transfer_encoding/1]).
-export([parse_upgrade/1]).
+-type etag() :: {weak | strong, binary()}.
+-export_type([etag/0]).
+
-type media_type() :: {binary(), binary(), [{binary(), binary()}]}.
-export_type([media_type/0]).
@@ -1013,6 +1017,78 @@ horse_parse_expect() ->
).
-endif.
+%% @doc Parse the If-Match header.
+
+-spec parse_if_match(binary()) -> '*' | [etag()].
+parse_if_match(<<"*">>) ->
+ '*';
+parse_if_match(IfMatch) ->
+ nonempty(etag_list(IfMatch, [])).
+
+etag_list(<<>>, Acc) -> lists:reverse(Acc);
+etag_list(<< $\s, R/bits >>, Acc) -> etag_list(R, Acc);
+etag_list(<< $\t, R/bits >>, Acc) -> etag_list(R, Acc);
+etag_list(<< $,, R/bits >>, Acc) -> etag_list(R, Acc);
+etag_list(<< $W, $/, $", R/bits >>, Acc) -> etagc(R, Acc, weak, <<>>);
+etag_list(<< $", R/bits >>, Acc) -> etagc(R, Acc, strong, <<>>).
+
+etagc(<< $", R/bits >>, Acc, Strength, Tag) -> etag_list_sep(R, [{Strength, Tag}|Acc]);
+etagc(<< C, R/bits >>, Acc, Strength, Tag) when ?IS_ETAGC(C) -> etagc(R, Acc, Strength, << Tag/binary, C >>).
+
+etag_list_sep(<<>>, Acc) -> lists:reverse(Acc);
+etag_list_sep(<< $\s, R/bits >>, Acc) -> etag_list_sep(R, Acc);
+etag_list_sep(<< $\t, R/bits >>, Acc) -> etag_list_sep(R, Acc);
+etag_list_sep(<< $,, R/bits >>, Acc) -> etag_list(R, Acc).
+
+-ifdef(TEST).
+etagc() ->
+ ?SUCHTHAT(C, int(16#21, 16#ff), C =/= 16#22 andalso C =/= 16#7f).
+
+etag() ->
+ ?LET({Strength, Tag},
+ {oneof([weak, strong]), list(etagc())},
+ begin
+ TagBin = list_to_binary(Tag),
+ {{Strength, TagBin},
+ case Strength of
+ weak -> << $W, $/, $", TagBin/binary, $" >>;
+ strong -> << $", TagBin/binary, $" >>
+ end}
+ end).
+
+prop_parse_if_match() ->
+ ?FORALL(L,
+ non_empty(list(etag())),
+ begin
+ << _, IfMatch/binary >> = iolist_to_binary([[$,, T] || {_, T} <- L]),
+ ResL = parse_if_match(IfMatch),
+ CheckedL = [T =:= ResT || {{T, _}, ResT} <- lists:zip(L, ResL)],
+ [true] =:= lists:usort(CheckedL)
+ end).
+
+parse_if_match_test_() ->
+ Tests = [
+ {<<"\"xyzzy\"">>, [{strong, <<"xyzzy">>}]},
+ {<<"\"xyzzy\", \"r2d2xxxx\", \"c3piozzzz\"">>,
+ [{strong, <<"xyzzy">>}, {strong, <<"r2d2xxxx">>}, {strong, <<"c3piozzzz">>}]},
+ {<<"*">>, '*'}
+ ],
+ [{V, fun() -> R = parse_if_match(V) end} || {V, R} <- Tests].
+
+parse_if_match_error_test_() ->
+ Tests = [
+ <<>>
+ ],
+ [{V, fun() -> {'EXIT', _} = (catch parse_if_match(V)) end} || V <- Tests].
+-endif.
+
+-ifdef(PERF).
+horse_parse_if_match() ->
+ horse:repeat(200000,
+ parse_if_match(<<"\"xyzzy\", \"r2d2xxxx\", \"c3piozzzz\"">>)
+ ).
+-endif.
+
%% @doc Parse the If-Modified-Since header.
-spec parse_if_modified_since(binary()) -> calendar:datetime().