blob: 2df89a6eb4bcd401e2a2b0b2a0406ba8cfce052e (
plain) (
blame)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<HTML>
<HEAD>
<TITLE> [99s-extend] Using cowboy_req:body more than once per request
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:extend%40lists.ninenines.eu?Subject=Re%3A%20%5B99s-extend%5D%20Using%20cowboy_req%3Abody%20more%20than%20once%20per%20request&In-Reply-To=%3C54176B4C.1060101%40ninenines.eu%3E">
<META NAME="robots" CONTENT="index,nofollow">
<style type="text/css">
pre {
white-space: pre-wrap; /* css-2.1, curent FF, Opera, Safari */
}
</style>
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="000463.html">
<LINK REL="Next" HREF="000459.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[99s-extend] Using cowboy_req:body more than once per request</H1>
<B>Loïc Hoguin</B>
<A HREF="mailto:extend%40lists.ninenines.eu?Subject=Re%3A%20%5B99s-extend%5D%20Using%20cowboy_req%3Abody%20more%20than%20once%20per%20request&In-Reply-To=%3C54176B4C.1060101%40ninenines.eu%3E"
TITLE="[99s-extend] Using cowboy_req:body more than once per request">essen at ninenines.eu
</A><BR>
<I>Tue Sep 16 00:42:20 CEST 2014</I>
<P><UL>
<LI>Previous message: <A HREF="000463.html">[99s-extend] Using cowboy_req:body more than once per request
</A></li>
<LI>Next message: <A HREF="000459.html">[99s-extend] :binding doc
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#464">[ date ]</a>
<a href="thread.html#464">[ thread ]</a>
<a href="subject.html#464">[ subject ]</a>
<a href="author.html#464">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On 09/16/2014 12:35 AM, Paulo F. Oliveira wrote:
><i> Hi.
</I>><i>
</I>>><i> It seems a bit weird to me to read the body and validate it before validating the request itself.
</I>><i>
</I>><i> It certainly seems like it, but I had no immediate solution and
</I>><i> instead of changing a dozen handlers, this seemed faster to implement
</I>><i> :D. I don't understand what you mean by "validating the request
</I>><i> itself". I read the header (I mentioned previously) and the body and
</I>><i> check one against the other. They are present and enough for the
</I>><i> _validator_ to make a decision, but I might be missing something here.
</I>
Like, is it the right method? Are the bindings/qs parameters/headers
present and valid? And so on. The body should be the last thing you
check, due to how expensive it can be, not the first.
>><i> I would explicitly put these checks in the handler directly. This of course means that there is no need to read it twice anymore.
</I>><i>
</I>><i> I've been trying to find a way to easily share code between handlers
</I>><i> without having to rewrite a lot of code (even if I do decide to put
</I>><i> things in a library function - or several). I recently came across
</I>><i> <A HREF="https://github.com/opscode/mixer.">https://github.com/opscode/mixer.</A> Have you ever used it?
</I>
I usually share code by writing functions. Then I call these functions
where needed.
--
Loïc Hoguin
<A HREF="http://ninenines.eu">http://ninenines.eu</A>
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="000463.html">[99s-extend] Using cowboy_req:body more than once per request
</A></li>
<LI>Next message: <A HREF="000459.html">[99s-extend] :binding doc
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#464">[ date ]</a>
<a href="thread.html#464">[ thread ]</a>
<a href="subject.html#464">[ subject ]</a>
<a href="author.html#464">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://lists.ninenines.eu/listinfo/extend">More information about the Extend
mailing list</a><br>
</body></html>
|
