1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<HTML>
<HEAD>
<TITLE> [99s-extend] Proposal for Cowboy Routing
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:extend%40lists.ninenines.eu?Subject=Re%3A%20%5B99s-extend%5D%20Proposal%20for%20Cowboy%20Routing&In-Reply-To=%3C20121113161004.GF17626%40members.linode.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<style type="text/css">
pre {
white-space: pre-wrap; /* css-2.1, curent FF, Opera, Safari */
}
</style>
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="000013.html">
<LINK REL="Next" HREF="000014.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[99s-extend] Proposal for Cowboy Routing</H1>
<B>Thomas Allen</B>
<A HREF="mailto:extend%40lists.ninenines.eu?Subject=Re%3A%20%5B99s-extend%5D%20Proposal%20for%20Cowboy%20Routing&In-Reply-To=%3C20121113161004.GF17626%40members.linode.com%3E"
TITLE="[99s-extend] Proposal for Cowboy Routing">thomas at oinksoft.com
</A><BR>
<I>Tue Nov 13 17:10:04 CET 2012</I>
<P><UL>
<LI>Previous message: <A HREF="000013.html">[99s-extend] Proposal for Cowboy Routing
</A></li>
<LI>Next message: <A HREF="000014.html">[99s-extend] Proposal for Cowboy Routing
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#16">[ date ]</a>
<a href="thread.html#16">[ thread ]</a>
<a href="subject.html#16">[ subject ]</a>
<a href="author.html#16">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On Tue, Nov 13, 2012 at 04:22:48PM +0100, Loïc Hoguin wrote:
><i> No, just check that cowboy_req:path/1 ends with $/, and if it
</I>><i> doesn't then redirect.
</I>
OK, so what I'm going for is to actually check for a valid URL with the
slash. I got it to work in current cowboy, but shield your eyes ...
I do this "middleware" thing often ... this might be a misnomer as I
think some definitions of middleware specify that it be able to wrap the
request *and* the response. I digress ...
%%% foo_app.erl:
{ok, _} = cowboy:start_http(http, ?ACCEPTORS,
[{port, ?PORT}],
[{dispatch, Dispatch},
{onrequest, fun(Req) ->
foo_middleware:all(Dispatch, Req)
end}]
),
%% foo_middleware.erl:
-define(MIDDLEWARE, [
fun foo_middleware:slash/2,
fun foo_middleware:session/2,
fun foo_middleware:user/2
]).
all(Dispatch, Req) ->
lists:foldl(fun(F, CurReq) -> F(Dispatch, CurReq) end, Req,
?MIDDLEWARE).
%% ...
slash(Dispatch, Req) ->
{Path, _} = cowboy_req:path(Req),
case binary:last(Path) of
$/ -> Req;
_ ->
SlashPath = <<Path/bitstring, "/">>,
{Host, _} = cowboy_req:host(Req),
Match = cowboy_dispatcher:match(Dispatch, Host,
SlashPath),
case element(1, Match) of
ok ->
cowboy_req:reply(301,
[{<<"Location">>, SlashPath}], <<>>, Req);
error -> Req
end
end.
So, I assume that any path not ending in "/" won't match. Another
version of this could toss that assumption, but then you're performing
an extra match on every request ... much better to use a '_' rule in
that case.
One thing that is icky about using a fallback '_' handler, and the
reason I've elected to use onrequest for this example, is that I do not
see a way to access cowboy_protocol's state.dispatch to access these
rules. So, I enclose them in my `onrequest` fun. Would it be possible to
expose Dispatch? This has many applications, particularly for URL
reversing.
Perhaps I am missing several things ;^)
Thomas
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="000013.html">[99s-extend] Proposal for Cowboy Routing
</A></li>
<LI>Next message: <A HREF="000014.html">[99s-extend] Proposal for Cowboy Routing
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#16">[ date ]</a>
<a href="thread.html#16">[ thread ]</a>
<a href="subject.html#16">[ subject ]</a>
<a href="author.html#16">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://lists.ninenines.eu/listinfo/extend">More information about the Extend
mailing list</a><br>
</body></html>
|
