archives/extend/2014-February/000330.html


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<HTML>
 <HEAD>
   <TITLE> [99s-extend] Accept header in POST request
   </TITLE>
   <LINK REL="Index" HREF="index.html" >
   <LINK REL="made" HREF="mailto:extend%40lists.ninenines.eu?Subject=Re%3A%20%5B99s-extend%5D%20Accept%20header%20in%20POST%20request&In-Reply-To=%3CCAKfrUsjrQxO_6CB0Hw85aqcWe%2BC5j0Dv%2BcNbK7ffSzv7npMvMA%40mail.gmail.com%3E">
   <META NAME="robots" CONTENT="index,nofollow">
   <style type="text/css">
       pre {
           white-space: pre-wrap;       /* css-2.1, curent FF, Opera, Safari */
           }
   </style>
   <META http-equiv="Content-Type" content="text/html; charset=us-ascii">
   <LINK REL="Previous"  HREF="000329.html">
   <LINK REL="Next"  HREF="000331.html">
 </HEAD>
 <BODY BGCOLOR="#ffffff">
   <H1>[99s-extend] Accept header in POST request</H1>
    <B>&#321;ukasz Biedrycki</B> 
    <A HREF="mailto:extend%40lists.ninenines.eu?Subject=Re%3A%20%5B99s-extend%5D%20Accept%20header%20in%20POST%20request&In-Reply-To=%3CCAKfrUsjrQxO_6CB0Hw85aqcWe%2BC5j0Dv%2BcNbK7ffSzv7npMvMA%40mail.gmail.com%3E"
       TITLE="[99s-extend] Accept header in POST request">lukasz.biedrycki at gmail.com
       </A><BR>
    <I>Mon Feb  3 20:16:29 CET 2014</I>
    <P><UL>
        <LI>Previous message: <A HREF="000329.html">[99s-extend] Accept header in POST request
</A></li>
        <LI>Next message: <A HREF="000331.html">[99s-extend] Metrics per request and handler
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#330">[ date ]</a>
              <a href="thread.html#330">[ thread ]</a>
              <a href="subject.html#330">[ subject ]</a>
              <a href="author.html#330">[ author ]</a>
         </LI>
       </UL>
    <HR>  
<!--beginarticle-->
<PRE>Perfect, thanks a lot!
Cheers,
&#321;.


On Mon, Feb 3, 2014 at 8:15 PM, Lo&#239;c Hoguin &lt;<A HREF="https://lists.ninenines.eu/listinfo/extend">essen at ninenines.eu</A>&gt; wrote:

&gt;<i> Sure. It won't be called if not a GET or HEAD request so that's probably
</I>&gt;<i> the best value you can return in your case.
</I>&gt;<i>
</I>&gt;<i>
</I>&gt;<i> On 02/03/2014 08:08 PM, &#321;ukasz Biedrycki wrote:
</I>&gt;<i>
</I>&gt;&gt;<i> Ok,
</I>&gt;&gt;<i> it is more clear for me.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i> Last question I have is about content_types_provided function.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i> Is it safe to define it like this?
</I>&gt;&gt;<i>
</I>&gt;&gt;<i> content_types_provided(R, S) -&gt;
</I>&gt;&gt;<i> ContentTypes = [{{&lt;&lt;&quot;application&quot;&gt;&gt;, &lt;&lt;&quot;json&quot;&gt;&gt;, '*'}, *undefined*}],
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>     {ContentTypes, Req, State}.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i> Callback in content_types_provided is useless for POST requests, as it
</I>&gt;&gt;<i> won&#8217;t be called.
</I>&gt;&gt;<i> Is it safe to use *undefined *atom, to have a source code clearer?
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i> On Mon, Feb 3, 2014 at 7:37 PM, Lo&#239;c Hoguin &lt;<A HREF="https://lists.ninenines.eu/listinfo/extend">essen at ninenines.eu</A>
</I>&gt;&gt;<i> &lt;mailto:<A HREF="https://lists.ninenines.eu/listinfo/extend">essen at ninenines.eu</A>&gt;&gt; wrote:
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>     If Accept is sent and is different than text/html, yes.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>     This is how HTTP is defined. If the client says it speaks only
</I>&gt;&gt;<i>     content-type X but you can only reply with content-type Y, you error
</I>&gt;&gt;<i>     out early and stop processing the request. On the other hand if the
</I>&gt;&gt;<i>     client doesn't say what content-type it speaks then the server can
</I>&gt;&gt;<i>     choose whichever one it wants.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>     On 02/03/2014 07:26 PM, &#321;ukasz Biedrycki wrote:
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>         My application sends both headers: &#8220;Content-type&#8221; and &#8220;Accept&#8221;
</I>&gt;&gt;<i>         header
</I>&gt;&gt;<i>         using POST method.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>         For POST rest handler do I have to specify both:
</I>&gt;&gt;<i>         content_types_accepted
</I>&gt;&gt;<i>         and content_types_provided to manage this kind of request?
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>         On Mon, Feb 3, 2014 at 7:23 PM, Lo&#239;c Hoguin &lt;<A HREF="https://lists.ninenines.eu/listinfo/extend">essen at ninenines.eu</A>
</I>&gt;&gt;<i>         &lt;mailto:<A HREF="https://lists.ninenines.eu/listinfo/extend">essen at ninenines.eu</A>&gt;
</I>&gt;&gt;<i>         &lt;mailto:<A HREF="https://lists.ninenines.eu/listinfo/extend">essen at ninenines.eu</A> &lt;mailto:<A HREF="https://lists.ninenines.eu/listinfo/extend">essen at ninenines.eu</A>&gt;&gt;&gt; wrote:
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>              The content-type provided is relevant for any response, not
</I>&gt;&gt;<i>         just
</I>&gt;&gt;<i>              responses to GET requests. It defaults to text/html. If
</I>&gt;&gt;<i>         your client
</I>&gt;&gt;<i>              doesn't send that content-type, you have to define the
</I>&gt;&gt;<i>         callback.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>              I notice that the documentation is incorrect about the
</I>&gt;&gt;<i> relevant
</I>&gt;&gt;<i>              methods for this callback, I will open a ticket to fix it
</I>&gt;&gt;<i> soon.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>              On 02/03/2014 07:13 PM, &#321;ukasz Biedrycki wrote:
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  Hi,
</I>&gt;&gt;<i>                  I have a rest handler that accepts POST and PUT
</I>&gt;&gt;<i>         requests with
</I>&gt;&gt;<i>                  &#8220;application/json&#8221; content type.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  I have content_types_accepted function defined as
</I>&gt;&gt;<i> follows:
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  content_types_accepted(Req, State) -&gt;
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  {[{&#8216;application/json', from_json}], Req, State}.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  The problem I have is within a request that has two
</I>&gt;&gt;<i>         headers:
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  *Content-type*: application/json
</I>&gt;&gt;<i>                  *Accept*: application/json
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  With this combination I receive *406*.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  You can repeat it with test:
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  http_SUITE.erl:
</I>&gt;&gt;<i>                  1072 rest_postonly(Config) -&gt;
</I>&gt;&gt;<i>                  1073     Client = ?config(client, Config),
</I>&gt;&gt;<i>                  1074     Headers = [
</I>&gt;&gt;<i>                  1075         {&lt;&lt;&quot;content-type&quot;&gt;&gt;, &lt;&lt;&quot;text/plain&quot;&gt;&gt;},
</I>&gt;&gt;<i>                  1076         {&lt;&lt;&quot;accept&quot;&gt;&gt;, &lt;&lt;&quot;text/plain&quot;&gt;&gt;}
</I>&gt;&gt;<i>                  1077     ],
</I>&gt;&gt;<i>                  1078     {ok, Client2} =
</I>&gt;&gt;<i>         cowboy_client:request(&lt;&lt;&quot;POST&quot;____&gt;&gt;,
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  1079         build_url(&quot;/postonly&quot;, Config), Headers,
</I>&gt;&gt;<i>         &quot;12345&quot;,
</I>&gt;&gt;<i>                  Client),
</I>&gt;&gt;<i>                  1080     {ok, 204, _, _} =
</I>&gt;&gt;<i>         cowboy_client:response(____Client2).
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  My solution to that was to add a content_types_provided
</I>&gt;&gt;<i>         function:
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  content_types_provided(Req, State) -&gt;
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  ContentTypes = [{{&lt;&lt;&quot;application&quot;&gt;&gt;, &lt;&lt;&quot;json&quot;&gt;&gt;, '*'},
</I>&gt;&gt;<i>         to_json}],
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  {ContentTypes, Req, State}.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  But it is useless as *to_json* callback registered is
</I>&gt;&gt;<i>         not called
</I>&gt;&gt;<i>                  anyhow.
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  Adding *content_types_provided* function is a correct
</I>&gt;&gt;<i>         solution
</I>&gt;&gt;<i>                  in this case?
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  Or I am missing something here?
</I>&gt;&gt;<i>                  &#8220;Accept&#8221; header is not relevant only in case of GET
</I>&gt;&gt;<i>         requests?
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  Thank for help,
</I>&gt;&gt;<i>                  &#321;ukasz Biedrycki
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  ___________________________________________________
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  Extend mailing list
</I>&gt;&gt;<i>         <A HREF="https://lists.ninenines.eu/listinfo/extend">Extend at lists.ninenines.eu</A> &lt;mailto:<A HREF="https://lists.ninenines.eu/listinfo/extend">Extend at lists.ninenines.eu</A>&gt;
</I>&gt;&gt;<i>         &lt;mailto:<A HREF="https://lists.ninenines.eu/listinfo/extend">Extend at lists.__ninenines.eu</A>
</I>&gt;&gt;<i>         &lt;mailto:<A HREF="https://lists.ninenines.eu/listinfo/extend">Extend at lists.ninenines.eu</A>&gt;&gt;
</I>&gt;&gt;<i>         <A HREF="https://lists.ninenines.eu/____listinfo/extend">https://lists.ninenines.eu/____listinfo/extend</A>
</I>&gt;&gt;<i>         &lt;<A HREF="https://lists.ninenines.eu/__listinfo/extend">https://lists.ninenines.eu/__listinfo/extend</A>&gt;
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>                  &lt;<A HREF="https://lists.ninenines.eu/__listinfo/extend">https://lists.ninenines.eu/__listinfo/extend</A>
</I>&gt;&gt;<i>         &lt;<A HREF="https://lists.ninenines.eu/listinfo/extend">https://lists.ninenines.eu/listinfo/extend</A>&gt;&gt;
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>              --
</I>&gt;&gt;<i>              Lo&#239;c Hoguin
</I>&gt;&gt;<i>         <A HREF="http://ninenines.eu">http://ninenines.eu</A>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>     --
</I>&gt;&gt;<i>     Lo&#239;c Hoguin
</I>&gt;&gt;<i>     <A HREF="http://ninenines.eu">http://ninenines.eu</A>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;&gt;<i>
</I>&gt;<i> --
</I>&gt;<i> Lo&#239;c Hoguin
</I>&gt;<i> <A HREF="http://ninenines.eu">http://ninenines.eu</A>
</I>&gt;<i>
</I>-------------- next part --------------
An HTML attachment was scrubbed...
URL: &lt;<A HREF="http://lists.ninenines.eu/archives/extend/attachments/20140203/e84f6223/attachment.html">http://lists.ninenines.eu/archives/extend/attachments/20140203/e84f6223/attachment.html</A>&gt;
</PRE>

<!--endarticle-->
    <HR>
    <P><UL>
        <!--threads-->
	<LI>Previous message: <A HREF="000329.html">[99s-extend] Accept header in POST request
</A></li>
	<LI>Next message: <A HREF="000331.html">[99s-extend] Metrics per request and handler
</A></li>
         <LI> <B>Messages sorted by:</B> 
              <a href="date.html#330">[ date ]</a>
              <a href="thread.html#330">[ thread ]</a>
              <a href="subject.html#330">[ subject ]</a>
              <a href="author.html#330">[ author ]</a>
         </LI>
       </UL>

<hr>
<a href="https://lists.ninenines.eu/listinfo/extend">More information about the Extend
mailing list</a><br>
</body></html>