1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<HTML>
<HEAD>
<TITLE> [99s-extend] [cowboy REST] returning {true, URL} to PUT
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:extend%40lists.ninenines.eu?Subject=Re%3A%20%5B99s-extend%5D%20%5Bcowboy%20REST%5D%20returning%20%7Btrue%2C%20URL%7D%20to%20PUT&In-Reply-To=%3C53BBD908.6020909%40ninenines.eu%3E">
<META NAME="robots" CONTENT="index,nofollow">
<style type="text/css">
pre {
white-space: pre-wrap; /* css-2.1, curent FF, Opera, Safari */
}
</style>
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="000409.html">
<LINK REL="Next" HREF="000411.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[99s-extend] [cowboy REST] returning {true, URL} to PUT</H1>
<B>Loïc Hoguin</B>
<A HREF="mailto:extend%40lists.ninenines.eu?Subject=Re%3A%20%5B99s-extend%5D%20%5Bcowboy%20REST%5D%20returning%20%7Btrue%2C%20URL%7D%20to%20PUT&In-Reply-To=%3C53BBD908.6020909%40ninenines.eu%3E"
TITLE="[99s-extend] [cowboy REST] returning {true, URL} to PUT">essen at ninenines.eu
</A><BR>
<I>Tue Jul 8 13:42:00 CEST 2014</I>
<P><UL>
<LI>Previous message: <A HREF="000409.html">[99s-extend] [cowboy REST] returning {true, URL} to PUT
</A></li>
<LI>Next message: <A HREF="000411.html">[99s-extend] [cowboy REST] returning {true, URL} to PUT
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#410">[ date ]</a>
<a href="thread.html#410">[ thread ]</a>
<a href="subject.html#410">[ subject ]</a>
<a href="author.html#410">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>That's what POST should do.
Compare:
PUT /some/resource/1234 -> no redirect needed
POST /some/resource -> creates /some/resource/1234, redirects
If /some/resource is a collection then PUT on that collection is
supposed to replace it entirely.
Again it's possible for PUT to create a resource elsewhere, but
typically the redirect would be from something like
<A HREF="http://api.yourservice.com/resource/1234">http://api.yourservice.com/resource/1234</A> to
<A HREF="http://cloudthingy.server137.yourservice.com/whatever/resource/1234">http://cloudthingy.server137.yourservice.com/whatever/resource/1234</A> and
not to do what POST is intended for.
On 07/08/2014 01:32 PM, Samuel wrote:
><i> Ok, thanks. That should probably be mentioned in the documentation of
</I>><i> content_types_accepted, as it says {true, URI} is a valid output for
</I>><i> the provided function.
</I>><i>
</I>><i> Just out of curiosity from a non-so-expert in REST. The API spec
</I>><i> (which I am not the author of) says the PUT call should create a
</I>><i> resource with a unique id and return the URI of the created resource
</I>><i> in the Location header. That is something like PUT /some/resource
</I>><i> should return /some/resource/1234 in the Location. some/resource is
</I>><i> fixed but 1234 would be generated for each instance of /some/resource.
</I>><i> Is that considered nonsensical?
</I>><i>
</I>><i> On 8 July 2014 11:57, Loïc Hoguin <<A HREF="https://lists.ninenines.eu/listinfo/extend">essen at ninenines.eu</A>> wrote:
</I>>><i> It's not enabled for PATCH or PUT because it makes little sense for them.
</I>>><i> PATCH and PUT are typically used directly on the URI of the resource, even
</I>>><i> when creating it. While you can return a "better URI" for the created
</I>>><i> resource for them, this should be seen as a special case rather than the
</I>>><i> norm. You can still do it by setting the location header manually and Cowboy
</I>>><i> will react accordingly.
</I>>><i>
</I>>><i>
</I>>><i> On 07/08/2014 09:12 AM, Samuel wrote:
</I>>>><i>
</I>>>><i> Hi,
</I>>>><i>
</I>>>><i> According to the documentation I should be able to return a new
</I>>>><i> location when handling a PUT request when using cowboy_rest protocol:
</I>>>><i>
</I>>>><i> The AcceptResource value is the name of the callback that will be
</I>>>><i> called if the
</I>>>><i> content-type matches. It is defined as follow.
</I>>>><i>
</I>>>><i> Value type: true | {true, URL} | false
</I>>>><i>
</I>>>><i> That works for "true" and "false" but not for "{true, URL}", in that
</I>>>><i> case the Ranch listener crashes badly[1].
</I>>>><i>
</I>>>><i> Looking into cowboy_rest.erl I see that the {true, URL} form is
</I>>>><i> restricted to POST requests:
</I>>>><i> <A HREF="https://github.com/extend/cowboy/blob/master/src/cowboy_rest.erl#L784">https://github.com/extend/cowboy/blob/master/src/cowboy_rest.erl#L784</A>
</I>>>><i>
</I>>>><i> Is that intentional or should I submit a patch to add at least PUT and
</I>>>><i> PATCH to that condition (or remove all of them if that is not guarding
</I>>>><i> against something horrible)?
</I>>>><i>
</I>>>><i> Regards
</I>>>><i>
</I>>>><i> [1] Ranch crash log:
</I>>>><i> Ranch listener http_acceptor had connection process started with
</I>>>><i> cowboy_protocol:start_link/4 at <0.2660.0> exit with reason:
</I>>>><i>
</I>>>><i> {{case_clause,{{true,"/url"},{http_req,#Port<0.15864>,ranch_tcp,keepalive,<0.2660.0>,<<"PUT">>,'HTTP/1.1',{{127,0,0,1},56983},<<"localhost">>,undefined,8080,<<"/order">>,undefined,<<>>,undefined,[],[{<<"user-agent">>,<<"curl/7.22.0
</I>>>><i> (x86_64-pc-linux-gnu) libcurl/7.22.0 OpenSSL/1.0.1 zlib/1.2.3.4
</I>>>><i> libidn/1.23
</I>>>><i> librtmp/2.3">>},{<<"host">>,<<"localhost:8080">>},{<<"accept">>,<<"*/*">>},{<<"content-type">>,<<"application/json">>}],[{<<"content-type">>,{<<"application">>,<<"json">>,[]}},{<<"if-modified-since">>,undefined},{<<"if-none-match">>,undefined},{<<"if-unmodified-since">>,undefined},{<<"if-match">>,undefined},{<<"accept">>,[{{<<"*">>,<<"*">>,[]},1000,[]}]}],undefined,[{charset,undefined},{media_type,{<<"text">>,<<"html">>,[]}}],waiting,undefined,<<>>,false,waiting,[{<<"content-type">>,[<<"text">>,<<"/">>,<<"html">>,<<>>]}],<<>>,undefined},{state}}},[{cowboy_rest,process_content_type,3,[{file,"src/cowboy_rest.erl"},{line,780}]},{cowboy_protocol,execute,4,[{file,"src/cowboy_protocol.erl"},{line,529}]}]}
</I>>>><i>
</I>>><i>
</I>>><i> --
</I>>><i> Loïc Hoguin
</I>>><i> <A HREF="http://ninenines.eu">http://ninenines.eu</A>
</I>><i>
</I>><i>
</I>><i>
</I>
--
Loïc Hoguin
<A HREF="http://ninenines.eu">http://ninenines.eu</A>
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="000409.html">[99s-extend] [cowboy REST] returning {true, URL} to PUT
</A></li>
<LI>Next message: <A HREF="000411.html">[99s-extend] [cowboy REST] returning {true, URL} to PUT
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#410">[ date ]</a>
<a href="thread.html#410">[ thread ]</a>
<a href="subject.html#410">[ subject ]</a>
<a href="author.html#410">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://lists.ninenines.eu/listinfo/extend">More information about the Extend
mailing list</a><br>
</body></html>
|
