aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHans Bolinder <[email protected]>2016-06-13 15:49:05 +0200
committerHans Bolinder <[email protected]>2016-08-31 15:09:46 +0200
commit2a69eaaf4aaf8f7744e09e1e60b08ebaecde151a (patch)
treec26be4a3c69ee02a45baceb09094e9d2375e4a95
parent0ca1c088b5cf03357154c0b9178d99893f0eaf5c (diff)
downloadotp-2a69eaaf4aaf8f7744e09e1e60b08ebaecde151a.tar.gz
otp-2a69eaaf4aaf8f7744e09e1e60b08ebaecde151a.tar.bz2
otp-2a69eaaf4aaf8f7744e09e1e60b08ebaecde151a.zip
dialyzer: Remove a check that always fails
-rw-r--r--lib/dialyzer/src/dialyzer_contracts.erl12
1 files changed, 1 insertions, 11 deletions
diff --git a/lib/dialyzer/src/dialyzer_contracts.erl b/lib/dialyzer/src/dialyzer_contracts.erl
index 976a2b8955..a72368f9f8 100644
--- a/lib/dialyzer/src/dialyzer_contracts.erl
+++ b/lib/dialyzer/src/dialyzer_contracts.erl
@@ -768,19 +768,9 @@ picky_contract_check(CSig0, Sig0, MFA, WarningInfo, Contract, RecDict, Acc) ->
end.
extra_contract_warning(MFA, WarningInfo, Contract, CSig, Sig, RecDict) ->
- %% We do not want to depend upon erl_types:t_to_string() possibly
- %% hiding the contents of opaque types.
- SigUnopaque = erl_types:t_unopaque(Sig),
- CSigUnopaque = erl_types:t_unopaque(CSig),
- SigString0 =
- lists:flatten(dialyzer_utils:format_sig(SigUnopaque, RecDict)),
- ContractString0 =
- lists:flatten(dialyzer_utils:format_sig(CSigUnopaque, RecDict)),
- %% The only difference is in record fields containing 'undefined' or not.
- IsUndefRecordFieldsRelated = SigString0 =:= ContractString0,
{IsRemoteTypesRelated, SubtypeRelation} =
is_remote_types_related(Contract, CSig, Sig, MFA, RecDict),
- case IsUndefRecordFieldsRelated orelse IsRemoteTypesRelated of
+ case IsRemoteTypesRelated of
true ->
no_warning;
false ->