Revamp engine_free_nif()

* Add error handling for all OpenSSL calls.

1 files changed, 10 insertions, 5 deletions

diff --git a/lib/crypto/c_src/engine.c b/lib/crypto/c_src/engine.c
index 1398e315aa..9a3793180d 100644
--- a/lib/crypto/c_src/engine.c
+++ b/lib/crypto/c_src/engine.c
@@ -194,13 +194,18 @@ ERL_NIF_TERM engine_free_nif(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[]
     struct engine_ctx *ctx;
 
     // Get Engine
-    if (!enif_get_resource(env, argv[0], engine_ctx_rtype, (void**)&ctx)) {
-        PRINTF_ERR0("engine_free_nif Leaved: Parameter not an engine resource object");
-        return enif_make_badarg(env);
-    }
+    if (argc != 1)
+        goto bad_arg;
+    if (!enif_get_resource(env, argv[0], engine_ctx_rtype, (void**)&ctx))
+        goto bad_arg;
 
-    ENGINE_free(ctx->engine);
+    if (!ENGINE_free(ctx->engine))
+        goto err;
     return atom_ok;
+
+ bad_arg:
+ err:
+    return enif_make_badarg(env);
 #else
     return atom_notsup;
 #endif